Re: [PATCH 12/15] ide: remove -dma_master field from ide_hwif_t

2007-10-24 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 18 October 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: Index: b/drivers/ide/pci/hpt366.c === --- a/drivers/ide/pci/hpt366.c +++ b/drivers/ide/pci/hpt366.c @@ -845,32 +845,33 @@

Re: [PATCH 12/15] ide: remove -dma_master field from ide_hwif_t

2007-10-08 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 04 October 2007, Sergei Shtylyov wrote: [...] Index: b/drivers/ide/pci/hpt366.c === --- a/drivers/ide/pci/hpt366.c +++ b/drivers/ide/pci/hpt366.c @@ -845,32 +845,33 @@ static int

Re: [PATCH 12/15] ide: remove -dma_master field from ide_hwif_t

2007-10-04 Thread Sergei Shtylyov
Hello, I wrote: * Convert cmd64x, hpt366 and pdc202xx_old host drivers to use pci_resource_start(hwif-pci_dev, 4) instead of hwif-dma_master. Before using pci_resource_start(), the code should check pci_resource_len() to ensure it is the appropriate size. It would be very wise to ensure

Re: [PATCH 12/15] ide: remove -dma_master field from ide_hwif_t

2007-10-03 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: * Convert cmd64x, hpt366 and pdc202xx_old host drivers to use pci_resource_start(hwif-pci_dev, 4) instead of hwif-dma_master. Before using pci_resource_start(), the code should check pci_resource_len() to ensure it is the appropriate size. It would

Re: [PATCH 12/15] ide: remove -dma_master field from ide_hwif_t

2007-10-02 Thread Bartlomiej Zolnierkiewicz
On Tuesday 02 October 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: On Monday 01 October 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: * Convert cmd64x, hpt366 and pdc202xx_old host drivers to use pci_resource_start(hwif-pci_dev, 4) instead of hwif-dma_master.

[PATCH 12/15] ide: remove -dma_master field from ide_hwif_t

2007-10-01 Thread Bartlomiej Zolnierkiewicz
* Convert cmd64x, hpt366 and pdc202xx_old host drivers to use pci_resource_start(hwif-pci_dev, 4) instead of hwif-dma_master. * Remove no longer needed -dma_master field from ide_hwif_t. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c |7

Re: [PATCH 12/15] ide: remove -dma_master field from ide_hwif_t

2007-10-01 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: * Convert cmd64x, hpt366 and pdc202xx_old host drivers to use pci_resource_start(hwif-pci_dev, 4) instead of hwif-dma_master. Before using pci_resource_start(), the code should check pci_resource_len() to ensure it is the appropriate size. It would be very

Re: [PATCH 12/15] ide: remove -dma_master field from ide_hwif_t

2007-10-01 Thread Bartlomiej Zolnierkiewicz
On Monday 01 October 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: * Convert cmd64x, hpt366 and pdc202xx_old host drivers to use pci_resource_start(hwif-pci_dev, 4) instead of hwif-dma_master. Before using pci_resource_start(), the code should check pci_resource_len() to