Re: [PATCH 2/5] ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc()

2008-02-07 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Same BUG_ON() is present inside ide_set_handler(). There is no BUG_ON there -- __ide_set_handler() has a check for the same condition and a printk(KERN_CRIT)... myabe it should be replaced with BUG_ON()... Yeah, you're right - care to make a patch?

Re: [PATCH 2/5] ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc()

2008-02-06 Thread Bartlomiej Zolnierkiewicz
On Wednesday 06 February 2008, Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > > Same BUG_ON() is present inside ide_set_handler(). > > There is no BUG_ON there -- __ide_set_handler() has a check for the same > condition and a printk(KERN_CRIT)... myabe it should be replaced wi

Re: [PATCH 2/5] ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc()

2008-02-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Same BUG_ON() is present inside ide_set_handler(). There is no BUG_ON there -- __ide_set_handler() has a check for the same condition and a printk(KERN_CRIT)... myabe it should be replaced with BUG_ON()... Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL

[PATCH 2/5] ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc()

2008-02-01 Thread Bartlomiej Zolnierkiewicz
Same BUG_ON() is present inside ide_set_handler(). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-iops.c |2 -- 1 file changed, 2 deletions(-) Index: b/drivers/ide/ide-iops.c === --- a/drivers/