Re: [PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-02-11 Thread Russell King
On Sat, Feb 02, 2008 at 12:35:30AM +0100, Bartlomiej Zolnierkiewicz wrote: > > > Index: b/drivers/ide/arm/icside.c > > > === > > > --- a/drivers/ide/arm/icside.c > > > +++ b/drivers/ide/arm/icside.c > > > @@ -459,11 +456,19 @@ icside_r

Re: [PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-02-11 Thread Atsushi Nemoto
On Mon, 11 Feb 2008 00:16:07 +0100, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > > It is too late for -git but not too late for 2.6.25-rc1. ;-) > > > > Could you make a patch please? > > I went ahead and made a patch (sorry, I needed it for git pull request :). > > From: Bartlomiej Zo

Re: [PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 February 2008, Bartlomiej Zolnierkiewicz wrote: > On Sunday 10 February 2008, Atsushi Nemoto wrote: > > On Sun, 06 Jan 2008 18:03:10 +0100, Bartlomiej Zolnierkiewicz <[EMAIL > > PROTECTED]> wrote: > > > + /* reset DMA masks only for SFF-style DMA controllers */ > > > + if ((d->host_fl

Re: [PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 February 2008, Atsushi Nemoto wrote: > On Sun, 06 Jan 2008 18:03:10 +0100, Bartlomiej Zolnierkiewicz <[EMAIL > PROTECTED]> wrote: > > + /* reset DMA masks only for SFF-style DMA controllers */ > > + if ((d->host_flags && IDE_HFLAG_NO_DMA) == 0 && hwif->dma_base == 0) > > +

Re: [PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-02-10 Thread Atsushi Nemoto
On Sun, 06 Jan 2008 18:03:10 +0100, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > + /* reset DMA masks only for SFF-style DMA controllers */ > + if ((d->host_flags && IDE_HFLAG_NO_DMA) == 0 && hwif->dma_base == 0) > + hwif->swdma_mask = hwif->mwdma_mask = hwif->ultra_m

Re: [PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-02-01 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday 28 January 2008, Sergei Shtylyov wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > > * Remove 'struct pci_dev *dev' argument from ide_hwif_setup_dma(). > > > * Un-static ide_hwif_setup_dma() and add CONFIG_BLK_DEV_IDEDMA_PCI=n > > version. > > > * Add 'const struct ide_p

Re: [PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-01-28 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: * Remove 'struct pci_dev *dev' argument from ide_hwif_setup_dma(). * Un-static ide_hwif_setup_dma() and add CONFIG_BLK_DEV_IDEDMA_PCI=n version. * Add 'const struct ide_port_info *d' argument to ide_device_add[_all](). * Factor out generic ports

[PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-01-06 Thread Bartlomiej Zolnierkiewicz
* Remove 'struct pci_dev *dev' argument from ide_hwif_setup_dma(). * Un-static ide_hwif_setup_dma() and add CONFIG_BLK_DEV_IDEDMA_PCI=n version. * Add 'const struct ide_port_info *d' argument to ide_device_add[_all](). * Factor out generic ports init from ide_pci_setup_ports() to ide_init_port()