Re: [PATCH libata-dev-2.6 1/3] Add CHS support

2005-02-14 Thread Albert Lee
Dear all: Comments: 1) Patches #1 and #2 look OK. 2) Patch #3 needs to be split up into three patches: a) rename variables (s/sector/block/), b) reorganize read/write translation c) add CHS support Happy lunar new year. Attached pls find the split patch #3 for your review. Patch

Re: [PATCH libata-dev-2.6 1/3] Add CHS support

2005-02-06 Thread Jeff Garzik
Mark Lord wrote: Jeff Garzik wrote: 3) In Promise's GPL'd driver for their SATA (w/ PATA) cards, they unconditionally execute the INITIALIZE DEVICE PARAMETERS command. I wonder if we should do the same. That command was *necessary* for certain drives at one time, which refused all other