Re: [RFC PATCH] ide-floppy: use rq-cmd for preparing and sending packet cmds to the drive

2008-02-13 Thread Borislav Petkov
On Tue, Feb 12, 2008 at 10:39:22PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi Bart, I think that this _really_ should be done _after_ unifying ATAPI handling [*]. Otherwise you will be making some of the same changes to the _three_ copies of (more or less) identical code and more importantly

Re: [RFC PATCH] ide-floppy: use rq-cmd for preparing and sending packet cmds to the drive

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 13 February 2008, Borislav Petkov wrote: On Tue, Feb 12, 2008 at 10:39:22PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi Bart, I think that this _really_ should be done _after_ unifying ATAPI handling [*]. Otherwise you will be making some of the same changes to the

Re: [RFC PATCH] ide-floppy: use rq-cmd for preparing and sending packet cmds to the drive

2008-02-12 Thread Bartlomiej Zolnierkiewicz
Hi Borislav, On Tuesday 12 February 2008, Borislav Petkov wrote: Hi Bart, here's a first go at converting ide-floppy to using rq-cmd for packet commands. The code below is pretty rough and from what i can tell needs to be hammered a lot more, for it raises a lot of issues: I think that

[RFC PATCH] ide-floppy: use rq-cmd for preparing and sending packet cmds to the drive

2008-02-12 Thread Borislav Petkov
Hi Bart, here's a first go at converting ide-floppy to using rq-cmd for packet commands. The code below is pretty rough and from what i can tell needs to be hammered a lot more, for it raises a lot of issues: 1. The command control (pc-callback, request type, etc) is still done using the pc