Tejun Heo wrote:
Andrew Morton wrote:
So, I guess it's NACK w/o suggested alternatives, right?
I wouldn't nack without good reasons, and I have none here. I don't have
very strong opinions either way.
I was just wondering whether I should just go with snprintf dancing in
eh_link_report,
Tejun Heo wrote:
..
* For timeouts, result TF isn't available and thus res printout is
misleading. res shouldn't be printed after timeouts. This would
require allocating yest another temp buf and separating out res printing
into separate snprintf.
..
And snprintf() is buggy, by the way. It
Tejun Heo wrote:
Hello,
Andrew Morton wrote:
On Thu, 14 Feb 2008 09:40:51 +0900
Tejun Heo [EMAIL PROTECTED] wrote:
Can you please take a look at ata_eh_link_report() in
drivers/ata/libata-eh.c?
I did. Punishment?
Heh.. :-)
Currently, it has some problems.
Yes, and the patches do
On Fri, 15 Feb 2008 10:49:31 +0900 Tejun Heo [EMAIL PROTECTED] wrote:
printk is a special case, I think. It's the primary logging/debugging
method which can't fail and as it's mostly interpreted by human beings
(and developers in problematic cases), it has different maneuvering room
on
On Fri, 15 Feb 2008 11:36:12 +0900 Tejun Heo [EMAIL PROTECTED] wrote:
Andrew Morton wrote:
printk is a special case, I think. It's the primary logging/debugging
method which can't fail and as it's mostly interpreted by human beings
(and developers in problematic cases), it has different
On Wed, 13 Feb 2008 18:09:28 +0900
Tejun Heo [EMAIL PROTECTED] wrote:
This is the third take of implement-printk_header-and-mprintk
patchset.
Changes from the last take[L] are...
* Now header is printed on every line of a multiline message. If the
header ends with ':' followed by
Andrew Morton wrote:
And mprintk the following.
code:
DEFINE_MPRINTK(mp, 2 * 80);
mprintk_set_header(mp, KERN_INFO ata%u.%2u: , 1, 0);
mprintk_push(mp, ATA %d, 7);
mprintk_push(mp, , %u sectors\n, 1024);
mprintk(mp, everything seems dandy\n);
output:
6ata1.00: ATA 7, 1024
On Thu, 14 Feb 2008 09:40:51 +0900
Tejun Heo [EMAIL PROTECTED] wrote:
Can you please take a look at ata_eh_link_report() in
drivers/ata/libata-eh.c?
I did. Punishment?
Currently, it has some problems.
Yes, and the patches do clean that up.
ho hum. What tends to happen with this sort of
Hello,
Andrew Morton wrote:
On Thu, 14 Feb 2008 09:40:51 +0900
Tejun Heo [EMAIL PROTECTED] wrote:
Can you please take a look at ata_eh_link_report() in
drivers/ata/libata-eh.c?
I did. Punishment?
Heh.. :-)
Currently, it has some problems.
Yes, and the patches do clean that up.
