Re: Need help with libata error handling in libsas

2008-02-25 Thread Brian King
James Bottomley wrote: I keep hearing that we need to convert libsas to use libata's new error handling. Unfortunately, I have very little conception of what that means. Right at the moment, libsas doesn't use any error handling functions of libata at all. I've looked through the

Re: Need help with libata error handling in libsas

2008-02-25 Thread James Bottomley
On Mon, 2008-02-25 at 10:34 -0600, Brian King wrote: The new libata-eh is used for more than just EH. It is used for device probing, device revalidation, and power management. It is also woken for all command failures and is where the request sense for ATAPI devices is issued. Device

Re: Need help with libata error handling in libsas

2008-02-25 Thread Jeff Garzik
James Bottomley wrote: On Mon, 2008-02-25 at 10:34 -0600, Brian King wrote: The new libata-eh is used for more than just EH. It is used for device probing, device revalidation, and power management. It is also woken for all command failures and is where the request sense for ATAPI devices is

Need help with libata error handling in libsas

2008-02-24 Thread James Bottomley
I keep hearing that we need to convert libsas to use libata's new error handling. Unfortunately, I have very little conception of what that means. Right at the moment, libsas doesn't use any error handling functions of libata at all. I've looked through the libata-eh functions, and I find them

Re: Change Libata Error Handling for Drive Testing

2007-03-22 Thread Fajun Chen
Hi Tejun, JFYI, it turns out that spurious interrupts was caused by User Scan before drive is ready. I wait for 2 seconds after drive is powered on which is not sufficient for some drives. Alt status should be checked first but there's no good way to check it in user space. Does User Scan

Re: Change Libata Error Handling for Drive Testing

2007-03-19 Thread Fajun Chen
Another error we're analyzing is disabled IRQ due to screaming unhandled interrupts from ata_interrupt(). Since this happened on different drives, it doesn't seem to be a drive issue. Any known problem on this one? Could long ISR locking by some rogue application cause this problem? To

Re: Change Libata Error Handling for Drive Testing

2007-03-19 Thread Fajun Chen
On 3/19/07, Fajun Chen [EMAIL PROTECTED] wrote: Another error we're analyzing is disabled IRQ due to screaming unhandled interrupts from ata_interrupt(). Since this happened on different drives, it doesn't seem to be a drive issue. Any known problem on this one? Could long ISR

Re: Change Libata Error Handling for Drive Testing

2007-03-19 Thread Tejun Heo
Fajun Chen wrote: Please ignore the changes to pata_sil680.c. The same failure happened to standard sil680 driver without my change as well. Does it also happen when the second port is empty? -- tejun - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a

Re: Change Libata Error Handling for Drive Testing

2007-03-19 Thread Fajun Chen
On 3/19/07, Tejun Heo [EMAIL PROTECTED] wrote: Fajun Chen wrote: Please ignore the changes to pata_sil680.c. The same failure happened to standard sil680 driver without my change as well. Does it also happen when the second port is empty? Yes, it happens even when one of the port (either

Re: libata error handling

2005-08-19 Thread Luben Tuikov
On 08/19/05 01:40, Tejun Heo wrote: I genearally agree that the events are somewhat standard for block devices but IMHO SCSI EH also has fair amount SCSI-specific assumptions and ATA is a bit too different from SCSI to fit cleanly into it. For example, when handling NCQ errors, the whole

Re: libata error handling

2005-08-19 Thread Patrick Mansfield
On Fri, Aug 19, 2005 at 02:46:35PM -0400, Luben Tuikov wrote: Using the command time out hook and the strategy routine, gives _complete_ control over host recovery, and I really do mean _complete_. I assume you mean hostt-eh_timed_out. Is anyone implmenting (or has implemented) a

Re: libata error handling

2005-08-19 Thread Mike Anderson
Luben Tuikov [EMAIL PROTECTED] wrote: On 08/19/05 15:38, Patrick Mansfield wrote: The eh_timed_out + eh_strategy_handler is actually pretty perfect, and _complete_, for any application and purpose in recovering a LU/device/host (in that order ;-) ). The two problems I see with the hook

Re: libata error handling

2005-08-19 Thread Luben Tuikov
On 08/19/05 16:11, Patrick Mansfield wrote: On Fri, Aug 19, 2005 at 04:03:15PM -0400, Luben Tuikov wrote: The eh_timed_out + eh_strategy_handler is actually pretty perfect, and _complete_, for any application and purpose in recovering a One other point: Another problems is that we quiesce

Re: libata error handling

2005-08-19 Thread Luben Tuikov
On 08/19/05 17:10, Patrick Mansfield wrote: Luben - On Fri, Aug 19, 2005 at 04:43:41PM -0400, Luben Tuikov wrote: On 08/19/05 16:11, Patrick Mansfield wrote: I was changing it to wakeup the eh even while other IO is outstanding, so the eh can wakeup and cancel individual commands while

Re: libata error handling

2005-08-18 Thread Tejun Heo
Hi, Jeff. Jeff Garzik wrote: Tejun, In an email I cannot find anymore, you asked why I was interested in converting libata to use the fine-grained EH hooks in the SCSI layer, rather than continued with the current -eh_strategy_handler() method. Several reasons: 1) The fine-grained