Re: [PATCH 02/63] ide-cd: fix ACER/AOpen 24X CDROM speed reporting on big-endian machines

Bartlomiej Zolnierkiewicz wrote: * Fix ACER/AOpen 24X CDROM speed reporting on big-endian machines by adding missing le16_to_cpu() calls. While at it: * Replace ntohs() by be16_to_cpu(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL

Re: [PATCH 01/63] ide-cd: fix SAMSUNG CD-ROM SCR-3231 quirk

Bartlomiej Zolnierkiewicz wrote: cdi-mask is cleared by ide_cdrom_register() which is called after the quirk. Fix it by adding new -no_speed_select flag to struct ide_cd_config_flags and using it in ide_cdrom_register() to set CDC_SELECT_SPEED flag. Signed-off-by: Bartlomiej

Re: [PATCH 04/63] ide-cd: fix error messages in cdrom_{read,write}_check_ireason()

Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 05/63] ide-cd: add missing 'ireason' masking to cdrom_write_intr()

Bartlomiej Zolnierkiewicz wrote: Mask 'ireason' variable with 0x3 so the valid interrupt reason value is passed to cdrom_write_check_ireason() for checking. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe

Re: [PATCH 08/63] ide-cd: fix error message in cdrom_pc_intr()

Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 09/63] ide-cd: fix 'ireason' reporting in cdrom_pc_intr()

Bartlomiej Zolnierkiewicz wrote: Mask 'ireason' variable so only the valid interrupt reason bits will be reported on drive appears confused error. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this

Re: [PATCH 13/63] ide-cd: fix DMA error handling in cdrom_newpc_intr()

Bartlomiej Zolnierkiewicz wrote: Make cdrom_newpc_intr() match cdrom_{read,write}_intr() w.r.t. handling DMA errors: * disable DMA before cdrom_decode_status() call * log the device name and the type of the request (read/write) Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]

Re: [PATCH 16/63] ide-cd: remove stale cdrom_transfer_packet_command() comment

Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 63/63] ide-cd: update driver version, comments and copyrights

Bartlomiej Zolnierkiewicz wrote: * Bump driver version. * Remove filename and stale TODO from comments. * Add my copyrights. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the

Re: [PATCH 21/63] ide-cd: remove unused and write-only struct ide_cd_config_flags fields

Bartlomiej Zolnierkiewicz wrote: unused fields: * -writing * -reserved write-only fields: * -playmsf_as_bcd * -subchan_as_bcd * -test_write * -supp_disc_present Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To

Re: [PATCH 06/63] ide-cd: fix error messages in cdrom_write_intr()

Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

pata_via question.

Running 2.6.24-rc6 here. I just installed a combo card, 3 sata ports, one pata port, VIA VT6421 chip on it. I do not have an ide drive attached to it, and my bios does not acknowledge the presence of the card or the sata drive attached, meaning I have to keep a ide drive for use as the /boot

Re: [PATCH 07/63] ide-cd: add error message for DMA error to cdrom_read_intr()

Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 59/63] ide-cd: call blk_dump_rq_flags() on missing data in cdrom_rw_intr()

Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 30/63] ide-cd: remove NO_DOOR_LOCKING define

Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 34/63] ide-cd: remove duplicate sense keys definitions from ide-cd.h

Bartlomiej Zolnierkiewicz wrote: ide-cd.c already uses sense keys definitions from scsi/scsi.h. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the

Re: [PATCH 23/63] ide-cd: cleanup ide_cdrom_update_speed()

Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 12/63] ide-cd: fix missing data handling in cdrom_pc_intr()

Bartlomiej Zolnierkiewicz wrote: If drive still wants to transfer the data we need to pad the transfer instead of just finishing the request. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list:

Re: [PATCH 18/63] ide-cd: remove dead code from cdrom_pc_intr()

Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 42/63] ide-cd: coding style fixes for cdrom_get_toc_entry()

Bartlomiej Zolnierkiewicz wrote: This is a preparation to move code handling cdrom.c IOCTLs out of ide-cd.c. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 17/63] ide-cd: remove unused defines from ide-cd.h

Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 20/63] ide-cd: remove needless zeroing of 'info' fields from ide_cdrom_setup()

Bartlomiej Zolnierkiewicz wrote: ide_cd_probe() zeroes 'info' prior to calling ide_cdrom_setup() so there is no need to explicitly zero 'info' fields in the latter function. Ditto for fields of CDROM_STATE_FLAGS(), CDROM_CONFIG_FLAGS() and 'cdi' (all are embedded in 'info').

Re: [PATCH 22/63] ide-cd: remove struct atapi_{mechstat_header,changer_info,slot}

Bartlomiej Zolnierkiewicz wrote: * Remove -changer_info from struct cdrom_info (it is never allocated). * Remove unused struct atapi_{mechstat_header,changer_info,slot}. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei

Re: [PATCH 19/63] ide-cd: remove unused struct atapi_cdrom_subchnl

Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 14/63] ide-cd: fix trailing whitespaces in changelog

Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: pata_via question.

Or is it all covered by this: from lspci, with or without pata_via loaded 01:0a.0 RAID bus controller: VIA Technologies, Inc. VT6421 IDE RAID Controller (rev 50) sata_via handles the extra pata_port on this controller - To unsubscribe from this list: send the line unsubscribe linux-ide

Re: [PATCH 00/63] ide-cd: redux

On Thursday 20 December 2007, Borislav Petkov wrote: On Thu, Dec 20, 2007 at 01:48:49AM +0100, Bartlomiej Zolnierkiewicz wrote: Hi Bart, Hi all, PS ide-cd Maintainer position is still open... i'd like to take that position if nobody objects. I've done some work around the kernel here

Re: [PATCH 00/63] ide-cd: redux

On Thursday 20 December 2007, Phillip Susi wrote: Bartlomiej Zolnierkiewicz wrote: Hi, This patch series is a major rework of the ide-cd driver. Hi, in the future could you please post big patchbombs like this as replies to the first one so they fold nicely into one thread? IIRC,