On Mon, 31 Dec 2007 15:56:08 -0600
James Bottomley [EMAIL PROTECTED] wrote:
ATA requires that all DMA transfers begin and end on word boundaries.
Because of this, a large amount of machinery grew up in ide to adjust
scatterlists on this basis. However, as of 2.5, the block layer has a
Linda Walsh writes:
Robert Hancock wrote:
Linda Walsh wrote:
Alan Cox wrote:
rate began falling; at 128k block-reads-at-a-time or larger, it
drops below
20MB/s (only on buffered SATA).
Try disabling NCQ - see if you've got a drive with the 'NCQ = no
readahead' flaw.
Hi Bart,
here's the unfinished redux of ide-floppy which i'm REsending now so that we
could
sinchronize trees. The original send got busted in vger's filters due to syntax
error in the Message-ID tag.
Documentation/ide/ChangeLog.ide-floppy.1996-2002 | 64 ++
drivers/ide/ide-floppy.c
There should be no functional change resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 90 +-
1 files changed, 57 insertions(+), 33 deletions(-)
diff --git a/drivers/ide/ide-floppy.c
Replace the ide-floppy packet commands opcode defines with the generic ones.
Add a missing GPCMD_WRITE_12 (opcode 0xaa) to the generic ones in cdrom.h. The
last one can be found in the current version of INF-8090, p.905.
CC: Jens Axboe [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
Documentation/ide/ChangeLog.ide-floppy.1996-2002 | 64
drivers/ide/ide-floppy.c | 69 +-
2 files changed, 67 insertions(+), 66 deletions(-)
diff --git
- do a white-space cleanup
- remove old crufty code untouched since at least 2005
- shorten lines longer than 80ish columns
- shorten some LAAARGE typenames.
There should be no functional changes resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
This BUG_ON is unneeded since the -handler != NULL check is performed in
ide_set_handler().
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/ide/ide-floppy.c
also, fix header comments and remove superfluous ones. There should be no
functionality change resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 45 -
drivers/ide/ide-floppy.h | 127
There should be no functional change resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 58 +
drivers/ide/ide-floppy.h |3 +-
2 files changed, 29 insertions(+), 32 deletions(-)
diff --git
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 2c139e7..fd5fe7b 100644
--- a/drivers/ide/ide-floppy.c
+++
while at it:
-cleanup small issues raised by scripts/checkpatch.pl
-remove redundant and shorten some comments
There should be no functionality change resulting from this patch
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 195
Robert Hancock wrote:
Mark Lord wrote:
Robert Hancock wrote:
..
From some of the traces I took previously (posted on LKML as
sata_nv ADMA controller lockup investigation way back in Feb 07),
what seems to occur is that when the second command is issued very
rapidly (within less than 20
Mark Lord wrote:
Robert Hancock wrote:
Mark Lord wrote:
Robert Hancock wrote:
..
From some of the traces I took previously (posted on LKML as sata_nv ADMA
controller lockup investigation way back in Feb 07), what seems to occur is that
when the second command is issued very rapidly (within
As requested by Jeff
Update the legacy driver so it can handle VLB ports nicely, and has an
internal structure for nailing new ISA/VLB forms in. Anyone got an
ALI14xx and a spare day ;)
Also adds an all parameter so you can load this driver after all the PCI ones
in a boot time kernel and tell
Alan Cox wrote:
Signed-off-by: Alan Cox [EMAIL PROTECTED]
The comment is misleading at best...
It doesn't matter if NO_IRQ is zero or not here, because ata_irq
is not a static/global variable, but a local one. By removing the
initializer, here, the semantics changes.
But in this very case,
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.24-rc6-mm1/drivers/ata/pata_mpc52xx.c
linux-2.6.24-rc6-mm1/drivers/ata/pata_mpc52xx.c
--- linux.vanilla-2.6.24-rc6-mm1/drivers/ata/pata_mpc52xx.c 2008-01-02
Devices that misreport the validity bit for word 93 look like SATA. If
they are on the blacklist then we must not test for SATA but assume 40
wire in the 40 wire case (The TSSCorp reports 80 wire on SATA it seems!)
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file --recursive
It is legitimate (although annoying and silly) for a PCI IDE controller
not to be assigned an interrupt and to be polled. The libata-sff code
should therefore not try and request IRQ 0 in this case.
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file --recursive --exclude-from
I got my Promise card and everything is up and running without problems,
using kernel 2.6.24-rc6 and the sata_promise driver out of the box:
00:0c.0 Mass storage controller: Promise Technology, Inc. PDC40775 (SATA 300
TX2plus) (rev 02)
Subsystem: Promise Technology, Inc. PDC40775 (SATA
Turns out distros always enabled burst mode and it is pretty essential so
do the same. Also sort out the post DMA mode restore properly.
My 20263 card now seems happy but needs some four drive tests done yet
(when I've persuaded the kernel not to hang in the edd boot code if I
plug them in ..)
Dunno about the NVidia version.
Theirs works rather differently - the GO bit is there, but there's
another append register which is used to tell the controller
that a new
tag has been added to the CPB list.
The only thing we currently use the GO bit for is to switch
between ADMA
On Thursday 03 January 2008, Borislav Petkov wrote:
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
applied with two minor fixes (and sorry for being such a pedant ;):
* Summary line moved to patch description and ide-floppy: cleanup header
used instead. Please try to keep summary line
Hi,
On Thursday 03 January 2008, Borislav Petkov wrote:
Hi Bart,
here's the unfinished redux of ide-floppy which i'm REsending now so that we
could
sinchronize trees. The original send got busted in vger's filters due to
syntax
error in the Message-ID tag.
On Thursday 03 January 2008, Borislav Petkov wrote:
Replace the ide-floppy packet commands opcode defines with the generic ones.
Add a missing GPCMD_WRITE_12 (opcode 0xaa) to the generic ones in cdrom.h. The
last one can be found in the current version of INF-8090, p.905.
CC: Jens Axboe
On Thursday 03 January 2008, Borislav Petkov wrote:
There should be no functional change resulting from this patch.
the patch is fine but the description is a bit inaccurate:
* some debug_log() calls were not using ide-floppy: prefix
* a few used printk levels different than KERN_INFO
On Thursday 03 January 2008, Borislav Petkov wrote:
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
minor thing:
WARNING: line over 80 characters
#88: FILE: drivers/ide/ide-floppy.c:759:
+ put_unaligned(cpu_to_be16(blocks), (unsigned short *)
pc-c[7]);
seems like it can be
On Thursday 03 January 2008, Borislav Petkov wrote:
This BUG_ON is unneeded since the -handler != NULL check is performed in
ide_set_handler().
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
looks good, please move it at the beginning of the patch series
-
To unsubscribe from this list:
On Friday 04 January 2008, Alan Cox wrote:
Turns out distros always enabled burst mode and it is pretty essential so
Yeah and datasheet confirms that so burst mode config option should die
(now if somebody could hit me with a patch)...
Bart
-
To unsubscribe from this list: send the line
Benjamin Herrenschmidt wrote:
Another thing about the PacDigi core: one has to be very careful
to avoid sequential accesses to sequential PCI locations when
programming the chip -- it cannot handle merged register writes.
So for any group of sequentially laid out registers, the code has
to
Linda Walsh wrote:
Robert Hancock wrote:
Linda Walsh wrote:
Alan Cox wrote:
rate began falling; at 128k block-reads-at-a-time or larger, it
drops below
20MB/s (only on buffered SATA).
Try disabling NCQ - see if you've got a drive with the 'NCQ = no
readahead' flaw.
Mikael Pettersson wrote:
Linda Walsh writes:
Robert Hancock wrote:
Linda Walsh wrote:
read rate began falling; at 128k block-reads-at-a-time or larger, it
drops below 20MB/s (only on buffered SATA).
But more importantly -- I notice a chronic error message associate
with this
Robert Hancock wrote:
Looks like the drive reports ERR/ABRT (command aborted), meaning it
likely doesn't support those commands.
---
Except the PATA version of the drive does (same capacity, other
specs). Seagate would
disable advanced features for SATA but leave them for the older
Linda Walsh wrote:
I seem to remember reading about some problems with Promise SATA ACPI.
Does this address that or is that a separate issue? (Am using no-acpi for
now, but would like to try acpi again if it may be fixed (last time I tried
it with this card, sdb went offline (once it
Allen Martin wrote:
Dunno about the NVidia version.
Theirs works rather differently - the GO bit is there, but there's
another append register which is used to tell the controller
that a new
tag has been added to the CPB list.
The only thing we currently use the GO bit for is to switch
Linda Walsh wrote:
Robert Hancock wrote:
Looks like the drive reports ERR/ABRT (command aborted), meaning it
likely doesn't support those commands.
---
Except the PATA version of the drive does (same capacity, other
specs). Seagate would
disable advanced features for SATA but leave
On Thu, 2008-01-03 at 19:43 -0600, Robert Hancock wrote:
Benjamin Herrenschmidt wrote:
Another thing about the PacDigi core: one has to be very careful
to avoid sequential accesses to sequential PCI locations when
programming the chip -- it cannot handle merged register writes.
So for
37 matches
Mail list logo
