[PATCH 2/4] libata-core.c: add low-level I/O calls

2007-01-12 Thread Akira Iguchi
Using low-level I/O calls, similar functions (ex: ata_pio_devchk() and ata_mmio_devchk()) can be merged. And some branches which check MMIO/PIO flag can be removed. The idea comes from drivers/ide IN*/OUT* calls. By default, depending on the flag, default_pio_ops or default_mmio_ops are used as

[PATCH 4/4] drivers/ata: PATA driver for Celleb

2007-01-12 Thread Akira Iguchi
This patch adds kernel configuration and driver code for Celleb. Because this PATA controller supports only 32bit access, this driver define low-level calls in ata_io_operations. Signed-off-by: Kou Ishizaki [EMAIL PROTECTED] Signed-off-by: Akira Iguchi [EMAIL PROTECTED] --- ---

Re: [PATCH 0/4] drivers/ata: add low-level I/O calls

2007-01-12 Thread Benjamin Herrenschmidt
On Fri, 2007-01-12 at 10:24 +, Alan wrote: On Fri, 12 Jan 2007 19:00:45 +0900 Akira Iguchi [EMAIL PROTECTED] wrote: Dear everyone, This is the patchset (based on 2.6.20-rc4) to add low-level I/O calls which access the taskfile registers. The idea comes from drivers/ide IN*/OUT*

Re: [PATCH 0/4] drivers/ata: add low-level I/O calls

2007-01-12 Thread Jeff Garzik
Akira Iguchi wrote: Dear everyone, This is the patchset (based on 2.6.20-rc4) to add low-level I/O calls which access the taskfile registers. The idea comes from drivers/ide IN*/OUT* calls. As you know, these calls are unnecessary for most libata drivers. But the Celleb PATA driver needs them

Re: Norco DS-1220 (sil3726+sil3124) / libata-tj bug report

2007-01-12 Thread Brad Fitzpatrick
Tejun, On Mon, 8 Jan 2007, Tejun Heo wrote: Disks in DS-1220 show up, kinda, but don't work. Errors reading / writing blocks. Tried a single disk in both a PMP port and a direct (non-sil3726) port. From full dmesg... The following is when the drive is attached via PMP. 18:29:55

Re: [2.6.18,19] SATA boot problems (ICH6/ICH6W)

2007-01-12 Thread Tejun Heo
Kovid Goyal wrote: ata3: SATA max UDMA/133 cmd 0xFE00 ctl 0xFE12 bmdma 0xFEA0 irq 17 ata4: SATA max UDMA/133 cmd 0xFE20 ctl 0xFE32 bmdma 0xFEA8 irq 17 scsi2 : ata_piix scsi3 : ata_piix Hmmm... ata3.00 was /dev/sda1. Presence testing seems to have failed. Please give a shot at 2.6.20-rc4. We

Re: ICH6-M libata disk timeouts 2.6.18 - 2.6.19

2007-01-12 Thread Tejun Heo
Mike Accetta wrote: Here's a bit more information on these timeouts. I noticed a mention of changing the command queue depth in a recent lkml post and decided to give that a whirl. This problem seems to be related to the depth of the queue. When I set the value for

Re: [PATCH 19/19] ide: use PIO/MMIO operations directly where possible

2007-01-12 Thread Alan
On Fri, 12 Jan 2007 05:28:07 +0100 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: [PATCH] ide: use PIO/MMIO operations directly where possible This results in smaller/faster/simpler code and allows future optimizations. Also remove no longer needed ide[_mm]_{inl,outl}() and

Re: [PATCH 18/19] ide: add ide_use_fast_pio() helper

2007-01-12 Thread Alan
On Fri, 12 Jan 2007 05:28:00 +0100 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: [PATCH] ide: add ide_use_fast_pio() helper * add ide_use_fast_pio() helper for use by host drivers * add DMA capability and autodma checks to ide_use_dma() - au1xxx-ide/it8213/it821x drivers didn't check

Re: [PATCH 0/19] new IDE quilt tree

2007-01-12 Thread Alan
Generally looks very good - couple of odd items I noticed I've send replies about. Good to have someone working on the old IDE code again. Alan - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 18/19] ide: add ide_use_fast_pio() helper

2007-01-12 Thread Bartlomiej Zolnierkiewicz
On 1/12/07, Alan [EMAIL PROTECTED] wrote: On Fri, 12 Jan 2007 05:28:00 +0100 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: [PATCH] ide: add ide_use_fast_pio() helper * add ide_use_fast_pio() helper for use by host drivers * add DMA capability and autodma checks to ide_use_dma() -

Re: [PATCH 19/19] ide: use PIO/MMIO operations directly where possible

2007-01-12 Thread Bartlomiej Zolnierkiewicz
On 1/12/07, Alan [EMAIL PROTECTED] wrote: On Fri, 12 Jan 2007 05:28:07 +0100 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: [PATCH] ide: use PIO/MMIO operations directly where possible This results in smaller/faster/simpler code and allows future optimizations. Also remove no longer

Re: [PATCH 18/19] ide: add ide_use_fast_pio() helper

2007-01-12 Thread Bartlomiej Zolnierkiewicz
On 1/12/07, Alan [EMAIL PROTECTED] wrote: if(strstr(id-model, Integrated Technology Express)) { /* In raid mode the ident block is slightly buggy We need to set the bits so that the IDE layer knows LBA28.

Re: [PATCH 18/19] ide: add ide_use_fast_pio() helper

2007-01-12 Thread Alan
It seems that it821x_tune_chipset() is buggy since it sends SET FEATURES command even when in smart mode. Shouldn't there be don't tune flag in it812x_fixups() to tell it821x_tune_chipset() to not send SET FEATURES commands? It's itdev-smart but falls through to ide_config_drive_speed while

Re: [PATCH 18/19] ide: add ide_use_fast_pio() helper

2007-01-12 Thread Bartlomiej Zolnierkiewicz
On 1/12/07, Alan [EMAIL PROTECTED] wrote: It seems that it821x_tune_chipset() is buggy since it sends SET FEATURES command even when in smart mode. Shouldn't there be don't tune flag in it812x_fixups() to tell it821x_tune_chipset() to not send SET FEATURES commands? It's itdev-smart but

Re: ahci_softreset prevents acpi_power_off

2007-01-12 Thread Tejun Heo
Hello, Faik Uygur wrote: We have a Sony PCG-6H1M laptop. It started failing to poweroff with our switch from 2.6.16 stable series kernels to 2.6.18 stable series. Rebooting works. While searching for the cause, I have found these reported bug reports in the kernel bugzilla which may be

2.6.20-rc5: known unfixed regressions

2007-01-12 Thread Adrian Bunk
On Fri, Jan 12, 2007 at 02:27:48PM -0500, Linus Torvalds wrote: ... A lot of developers (including me) will be gone next week for Linux.Conf.Au, so you have a week of rest and quiet to test this, and report any problems. Not that there will be any, right? You all behave now! ... This