Gaston, Jason D wrote:
-Original Message-
From: Alan Cox [mailto:[EMAIL PROTECTED]
Sent: Monday, October 29, 2007 3:14 PM
To: Gaston, Jason D
Cc: linux-ide@vger.kernel.org
Subject: Re: ATAPI devices in AHCI mode not working
ata1: SATA max UDMA/133 abar [EMAIL PROTECTED] port
I looked into killing sg_last(), but really, this is the best its gonna
get (moving sg_last to libata-core.c).
You could maybe kill one use with caching, but in the other sg_last()
callsites there isn't another s/g loop we can stick a last_sg = sg;
into.
libata is stuck because we undertake the
Mikael Pettersson wrote:
That's my fault for misremembering the rule about the
number of dashes before the other comments part :-(
I'll remember better in the future.
Well, I should have caught it and hand-edited it on my side too...
Jeff
-
To unsubscribe from this list: send the
On Tue, 30 Oct 2007 11:54:01 -0700 (PDT), Linus Torvalds wrote:
On Tue, 30 Oct 2007, Jeff Garzik wrote:
Mikael Pettersson (2):
sata_promise: ASIC PRD table bug workaround, take 2
sata_promise: cleanups
You and Mikael need to sort out the way you send/accept patches.
On Wed, Oct 31 2007 at 10:49 +0200, Jeff Garzik [EMAIL PROTECTED] wrote:
I looked into killing sg_last(), but really, this is the best its gonna
get (moving sg_last to libata-core.c).
You could maybe kill one use with caching, but in the other sg_last()
callsites there isn't another s/g loop
Boaz Harrosh wrote:
On Wed, Oct 31 2007 at 10:49 +0200, Jeff Garzik [EMAIL PROTECTED] wrote:
I looked into killing sg_last(), but really, this is the best its gonna
get (moving sg_last to libata-core.c).
You could maybe kill one use with caching, but in the other sg_last()
callsites there
The same comes up for hdb (i have two hard drives installed) and those 3
messages repeat for a while and then this comes up
Oct 30 20:45:41 jimin-desktop kernel: [ 69.256000] hda: DMA disabled
Oct 30 20:45:41 jimin-desktop kernel: [ 69.592000] ide0: reset: success
The kernel switches
On Wed, Oct 31 2007 at 12:29 +0200, Jeff Garzik [EMAIL PROTECTED] wrote:
Boaz Harrosh wrote:
On Wed, Oct 31 2007 at 10:49 +0200, Jeff Garzik [EMAIL PROTECTED] wrote:
I looked into killing sg_last(), but really, this is the best its gonna
get (moving sg_last to libata-core.c).
You could maybe
Update the driver to use the newly added ata_link structure.
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
drivers/ata/sata_fsl.c | 31 ++-
1 files changed, 18 insertions(+), 13 deletions(-)
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
drivers/ata/sata_fsl.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 8a8ce9d..4c8c820 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -1323,8
Powerpc uses virtual irq which has to be unmapped.
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
drivers/ata/sata_fsl.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 4c8c820..f8d8614 100644
---
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
drivers/ata/sata_fsl.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index f8d8614..9e99cc8 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -355,7 +355,7 @@
From: Jeff Garzik [EMAIL PROTECTED]
SCRs in the driver map to the standard values found in include/linux/ata.h,
so no need for individual scr_read/scr_write case statements duplicating
the natural value.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
From: Jeff Garzik [EMAIL PROTECTED]
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
drivers/ata/sata_fsl.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index e04fb75..e3bf954
From: Jeff Garzik [EMAIL PROTECTED]
Remove unneeded on-stack copy of FIS
in sata_fsl_cache_taskfile_from_d2h_fis().
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
drivers/ata/sata_fsl.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
From: Jeff Garzik [EMAIL PROTECTED]
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
drivers/ata/sata_fsl.c | 14 +-
1 files changed, 1 insertions(+), 13 deletions(-)
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
drivers/ata/sata_fsl.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 03629b6..5892472 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -269,7
From: ashish kalra [EMAIL PROTECTED]
Signed-off-by: ashish kalra [EMAIL PROTECTED]
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
drivers/ata/sata_fsl.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 5892472..e076e1f
From: ashish kalra [EMAIL PROTECTED]
Signed-off-by: ashish kalra [EMAIL PROTECTED]
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
drivers/ata/sata_fsl.c | 70
1 files changed, 0 insertions(+), 70 deletions(-)
diff --git a/drivers/ata/sata_fsl.c
From: ashish kalra [EMAIL PROTECTED]
Signed-off-by: ashish kalra [EMAIL PROTECTED]
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
drivers/ata/sata_fsl.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index
The above output seems to indicate that the kernel is still relying on
drivers/ide instead of libata. To change this, I'd suggest setting
CONFIG_IDE=n and CONFIG_ATA=y in your .config before compiling the
kernel. Also, make sure everything that starts with CONFIG_ATA,
CONFIG_PATA,
On Tue, 30 Oct 2007 19:21:29 +
Daniel Drake [EMAIL PROTECTED] wrote:
Alan Cox wrote:
I would guess Brasero is issuing a command with the length of data
wrongly set. In the old code that might well just produce errors of the
Umm wtf is this data left over for ?, with the new code the
On Wed, Oct 31 2007, Alan Cox wrote:
On Tue, 30 Oct 2007 19:21:29 +
Daniel Drake [EMAIL PROTECTED] wrote:
Alan Cox wrote:
I would guess Brasero is issuing a command with the length of data
wrongly set. In the old code that might well just produce errors of the
Umm wtf is this
Jens Axboe wrote:
On Wed, Oct 31 2007, Alan Cox wrote:
On Tue, 30 Oct 2007 19:21:29 +
Daniel Drake [EMAIL PROTECTED] wrote:
Alan Cox wrote:
I would guess Brasero is issuing a command with the length of data
wrongly set. In the old code that might well just produce errors of the
Umm wtf
The original workaround for the Promise ASIC PRD bug
contained an endianess bug which I failed to detect:
the adjustment of the last PRD entry's length field
applied host arithmetic to little-endian data, which
is incorrect on big-endian machines.
We have the length available in host-endian
On Tue, 30 Oct 2007 11:44:35 -0400
Tony Battersby [EMAIL PROTECTED] wrote:
Commands sent to ATAPI tape drives via the SCSI generic (sg) driver are
limited in the amount of data that they can transfer by the max_sectors
value. The max_sectors value is currently calculated according to the
Would need to double check the SCSI specificatons to be sure but I think
you are asking for less data than the drive wishes to provide. You
aren't allowed to do that with ATA.
ide-cd handles this by throwing the excess away, which I think is the
sane way to do this.
It also fails for
On Wed, Oct 31 2007, Jeff Garzik wrote:
Jens Axboe wrote:
On Wed, Oct 31 2007, Alan Cox wrote:
On Tue, 30 Oct 2007 19:21:29 +
Daniel Drake [EMAIL PROTECTED] wrote:
Alan Cox wrote:
I would guess Brasero is issuing a command with the length of data
wrongly set. In the old code that might
On Wednesday, 31 October 2007 03:27, Len Brown wrote:
It would be interseting if any of the folks having power consumption
problems when suspended see an improvement with this patch.
Are there plans to refresh this patch and get it upstream?
Acked-by: Len Brown [EMAIL PROTECTED]
There was
Hi ,
I see this warnings on current git head with !CONFIG_PM :
...
drivers/ata/libata-core.c:768: warning: 'ata_lpm_enable' defined but not used
drivers/ata/libata-core.c:784: warning: 'ata_lpm_disable' defined but not used
...
So far I see ata_lpm_enable() is only used in
I am running the 'latest' kernel retrieved from Kumar Gala's
Powerpc git tree (mainly because I am running on a MPC8548 board)
and it appears to be in the full 2.6.23 version while the sata_mv
driver version seems to be 1.01.
I have searched the archives, and there has been some discussion
of
Jens Axboe wrote:
Right, that's of course problematic... There has to be a way to recover
that situation though, or you can't export any user command issue
facility.
You cannot hope to handle all possible effects arising from an app
providing an invalid sg header / cdb.
Once you start
Morrison, Tom wrote:
I am running the 'latest' kernel retrieved from Kumar Gala's
Powerpc git tree (mainly because I am running on a MPC8548 board)
and it appears to be in the full 2.6.23 version while the sata_mv
driver version seems to be 1.01.
I have searched the archives, and there has
Jeff Garzik wrote:
Jens Axboe wrote:
Right, that's of course problematic... There has to be a way to recover
that situation though, or you can't export any user command issue
facility.
You cannot hope to handle all possible effects arising from an app
providing an invalid sg header / cdb.
Hello.
Bartlomiej Zolnierkiewicz wrote:
special_t is used only internally by the IDE subsystem (it isn't
related to hardware registers and isn't exported to the user-space).
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
If this is NOT a privileged app, we must update the command validation
to ensure that invalid commands are not transported to the hardware.
We allow only a subset of standard commands to be issued by unprivileged
applications. We don't strictly enforce transfer sizes and its arguable
on SCSI
-Original Message-
From: [EMAIL PROTECTED] [mailto:linux-ide-
[EMAIL PROTECTED] On Behalf Of Tejun Heo
Sent: Wednesday, October 31, 2007 1:07 AM
To: Gaston, Jason D
Cc: Alan Cox; linux-ide@vger.kernel.org
Subject: Re: ATAPI devices in AHCI mode not working
Gaston, Jason D wrote:
kjournald starting Commit interval 5 seconds
VFS: Mounted root (ext3 filesystem) readonly
Freeing unused kernel memory: 168k freed
(keyboard still echoed onscreen, disk parked)
Adding init=/bin/bash is no better.
So its the user space which is broken. Make sure the user
--- Declan Moriarty [EMAIL PROTECTED] wrote:
piix_init
scsi0: ata_piix
scsi1: ata_piix
ata1: PATA max udma/33 cmd 0x000101f0 ctl 0x000103f6 bmdma
0x0001fcd0
irq 14
ata2: PATA max udma/33 cmd 0x00010170 ctl 0x00010376 bmdma
0x0001fcd8
irq 15
ATA1.00: ATA-3
On Wed, Oct 31 2007, Jeff Garzik wrote:
Jens Axboe wrote:
Right, that's of course problematic... There has to be a way to recover
that situation though, or you can't export any user command issue
facility.
You cannot hope to handle all possible effects arising from an app
providing an
Jeff / all -
Jeff is (again) 100% correct with comments - the sata_mv.c I used
from Kumar's 2.6.23 Powerpc tree is very *close*, but not exactly
the same as the sata_mv.c in the 'official' 2.6.23.1 tree.
I have verified that I now can access my disks behind the 7042 chip
with the 'mainline'
Hello.
Bartlomiej Zolnierkiewicz wrote:
Given that:
* hpt366.c::hpt3xx_intrproc() is the only user of hwif-intrproc
* hpt366.c::hpt3xx_quirkproc() sets drive-quirk_list to 1 for quirky drives
which is a value unique to hpt366 host driver
we can remove hwif-intproc and just check for
On Friday 26 October 2007, Jeff Garzik wrote:
Bartlomiej Zolnierkiewicz wrote:
On Thursday 25 October 2007, Jeff Garzik wrote:
Store our hwif indices at probe time, in order to eliminate a needless
and ugly loop across all hwifs, searching for our pci device.
It seems that we can
Frans de Boer wrote:
Dear Sir,
I know, I am not the only one to find out that we can't upgrade to a
newer kernel when using SUSE 10.3. It seems that in 2.6.23 the sil
modules have been updated (newer versions) and thus render the current
system mostly unuseable. I noticed that in the
Yeah, there has been quite some update in libata between SLES10_SP1
and
2.6.24-rc1. The controller being ahci, I wonder whether this is
caused
by the different in check_atapi_dma().
1. Does other optical drives have the same problem? If not, please
post
the result of hdparm -I /dev/sr0 with the
Hello,
Gaston, Jason D wrote:
Attached are the hdparm -I /dev/cdrom results for the three other drives
I am using. These do not include the original drive that had the major
issues on, TSSTcorpCD/DVDW SH-S183L.
Applying the patch to the 2.6.24-rc kernel did not cause the same
behavior,
On Wed, 2007-10-31 at 14:26 +0100, Rafael J. Wysocki wrote:
On Wednesday, 31 October 2007 03:27, Len Brown wrote:
It would be interseting if any of the folks having power consumption
problems when suspended see an improvement with this patch.
Are there plans to refresh this patch and get
47 matches
Mail list logo
