Alan Cox wrote:
Use qc_defer to serialize the two channels
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
applied... nice!
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordo
igned-off-by: Jeff Garzik <[EMAIL PROTECTED]>
commit defc9cd826e4a99f550504a744f9407b518828ae
Author: Alan Cox <[EMAIL PROTECTED]>
Date: Thu Jan 10 14:33:10 2008 -0800
pata_legacy: resychronize with upstream changes and resubmit
Update the legacy driver so it can handle VLB
Bryan Wu wrote:
From: Sonic Zhang <[EMAIL PROTECTED]>
Signed-off-by: Sonic Zhang <[EMAIL PROTECTED]>
Signed-off-by: Bryan Wu <[EMAIL PROTECTED]>
---
drivers/ata/pata_bf54x.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
applied 1-4
-
To unsubscribe from this list: send the l
[EMAIL PROTECTED] wrote:
From: Saeed Bishara <[EMAIL PROTECTED]>
The integrated SATA controller is connected directly to the SoC's
internal bus, not via PCI interface. this patch removes the dependency
on the PCI interface.
Signed-off-by: Saeed Bishara <[EMAIL PROTECTED]>
---
drivers/ata/Kconf
Robert Hancock wrote:
This patch is based on an original patch from Kuan Luo of NVIDIA,
posted under subject "fixed a bug of adma in rhel4u5 with HDS7250SASUN500G".
His description follows. I've reworked it a bit to avoid some unnecessary
repeated checks but it should be functionally identical.
Adrian Bunk wrote:
piix_merge_scr() can become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.htm
Tejun Heo wrote:
There's no reason not to allow multiple calls to pcim_enable_device().
Calls after the first one can simply be noop. All PCI resources will
be released when the initial pcim_enable_device() resource is
released.
This allows more flexibility to managed PCI users.
Signed-off-by:
Tejun Heo wrote:
This patch implements libata.force module parameter which can
selectively override ATA port, link and device configurations
including cable type, SATA PHY SPD limit, transfer mode and NCQ.
For example, you can say "use 1.5Gbps for all fan-out ports attached
to the second port bu
The PCI change was ack'd by Greg...
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/Kconfig |2 +-
drivers/ata/ahci.c |2 +
drivers/ata/ata_piix.
James Bottomley wrote:
From: James Bottomley <[EMAIL PROTECTED]>
Date: Thu, 10 Jan 2008 11:42:50 -0600
Subject: libata: implement drain buffers
This just updates the libata slave configure routine to take advantage
of the block layer drain buffers.
I suspect I should also be checking for AHCI a
James Bottomley wrote:
Could we please get this in ... I thought I mentioned several times that
it fixes a fatal oops in both aic94xx and ipr.
Tejun has a persistent objection... see other email.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the bod
I'm currently polling various drive manufacturers for comments, so I'm
going to delay ack/nak on this patchset until their comments come back.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info
Tejun Heo wrote:
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 07dcaf6..08301ca 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -351,6 +351,8 @@ static const struct ata_port_operations ahci_vt8251_ops = {
.port_suspend = ahci_port_suspend,
.port_
Tejun Heo wrote:
libata lets low level drivers build scsi_host_template and
ata_port_operations tables and register them with upper layers. This
allows low level drivers high level of flexibility but also burdens
them with lots of boilerplate entries in thoes data structures.
This becomes worse
ACK patches 6-9
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Tejun Heo wrote:
->irq_clear() is used to clear IRQ bit of a SFF controller and isn't
useful for drivers which don't use libata SFF HSM implementation.
However, it's a required callback and many drivers implement their own
noop version as placeholder. This patch implements ata_noop_irq_clear
and
Tejun Heo wrote:
diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c
index 7e68edf..5ef6594 100644
--- a/drivers/ata/pata_ali.c
+++ b/drivers/ata/pata_ali.c
@@ -597,6 +597,11 @@ static int ali_init_one(struct pci_dev *pdev, const struct
pci_device_id *id)
const struct ata_port_i
Tejun Heo wrote:
When no reset method is available, libata currently oopses. Although
the condition can't happen unless there's a bug in a low level driver,
oopsing isn't the best way to report the error condition. Complain,
dump stack and fail reset instead.
Signed-off-by: Tejun Heo <[EMAIL P
Tejun,
If you could explain your objection to James's patches in this area, I
would really appreciate it.
We have several conflicting patches in this area, and we need to get the
details sorted.
I think you mentioned a key objection that was we actually need to know
/two/ sizes at the bloc
[EMAIL PROTECTED] wrote:
From: Saeed Bishara <[EMAIL PROTECTED]>
Marvell's Orion SoC includes SATA controllers based on Marvell's
PCI-to-SATA 88SX controllers. This patch extends the libATA sata_mv
driver to support those controllers.
Signed-off-by: Saeed Bishara <[EMAIL PROTECTED]>
---
driver
Anantha Subramanyam wrote:
This patch adds ATAPI DMA support for HT1000 (aka BCM5785) & HT1100
(aka BCM11000) SATA Controller.
Signed-off-by: Anantha Subramanyam <[EMAIL PROTECTED]>
Thanks much for your patience. Feedback:
Engineering process issues:
1) patch is word-wrapped, and cannot be
Cai, Crane wrote:
From: Crane Cai <[EMAIL PROTECTED]>
PCI: modify SATA IDE mode quirk
When initialize and resume, SB600/700/800 need to set SATA mode
correctly.
Signed-off-by: Crane Cai <[EMAIL PROTECTED]>
--- a/drivers/pci/quirks.c 2007-09-24 1
Linux Kernel Mailing List wrote:
Commit: 0948391641918b95d8d96c15089eb5ac156850b3
PCI: Remove users of pci_enable_device_bars()
This patch converts users of pci_enable_device_bars() to the new
pci_enable_device_{io,mem} interface.
The new API fits nicely, except
Chris Rankin wrote:
ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata1.00: cmd c8/00:08:00:00:00/00:00:00:00:00/e0 tag 0 dma 4096 in
res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
ata1.00: status: { DRDY }
ata1: soft resetting link
ata1.00: configured for UDMA/66
a
James Bottomley wrote:
The aic94xx sequencer has a very finely honed sense of DMA transfers.
It's fully automated, and handles both ATA DMA and ATA PIO in the
sequencer engine (so all the driver sees is DMA).
ditto AHCI, and most other DMA engines
It reports both underrun and overrun conditi
Tuomas Jormola wrote:
On Sun, Feb 03, 2008 at 08:14:30AM +0900, Tejun Heo wrote:
Tuomas Jormola wrote:
00:08.0 IDE interface [0101]: nVidia Corporation MCP61 SATA Controller
[10de:03f6] (rev a2)
00:08.1 IDE interface [0101]: nVidia Corporation MCP61 SATA Controller
[10de:03f6] (rev a2)
That'
ACK patch series... would it be ok to send via the ARM maintainer?
I would prefer to add this at the same time as its user...
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/major
Tejun Heo wrote:
AHCI uses CAP.NP to indicate the number of ports and PI to tell which
ports are enabled. The only requirement is that the number of ports
indicated by CAP.NP should equal or be higher than the number of
enabled ports in PI.
CAP.NP and PI carry duplicate information and there ha
Tejun Heo wrote:
From: James Bottomley <[EMAIL PROTECTED]>
qc->n_iter was used for libata's own sg walking before sg chaining
replaced it. During conversion, the field and its usage in sata_fsl
were left behind. Kill the filed and update sata_fsl.
tj: This was part of James's libata-use-block
Adrian Bunk wrote:
This patch fixes the following section mismatches:
<-- snip -->
...
WARNING: drivers/ata/built-in.o(.text+0x15072): Section mismatch in reference
from the function piix_init_one() to the function
.devinit.text:piix_init_sata_map()
WARNING: drivers/ata/built-in.o(.text+0x1
libata-core: unblacklist HITACHI drives
James Bottomley (1):
libata: kill now unused n_iter and fix sata_fsl
Jeff Garzik (1):
Rename: linux/pata_platform.h to linux/ata_platform.h
Robert Hancock (1):
sata_nv: fix ATAPI issues with memory over 4GB (v7)
Saeed Bishara (1):
sata
David Milburn wrote:
The HITACHI HDS7250SASUN500G and HITACHI HDS7225SBSUN250 drives
do not need to be blacklisted, the NCQ problem has been resolved
with the "sata_nv: fix for completion handling" patch.
Signed-off-by David Milburn <[EMAIL PROTECTED]>
---
libata-core.c |2 --
1 files chan
Robert Hancock wrote:
This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode
on systems with memory located above 4GB. We need to delay setting the 64-bit
DMA mask until the PRD table and padding buffer are allocated so that they don't
get allocated above 4GB and break le
[EMAIL PROTECTED] wrote:
From: Andrew Morton <[EMAIL PROTECTED]>
mips:
drivers/ata/sata_mv.c: In function `mv_port_free_dma_mem':
drivers/ata/sata_mv.c:1080: error: implicit declaration of function
`dma_pool_free'
Cc: Jeff Garzik <[EMAIL PROTECTED]>
Signed-off-by:
Tejun Heo wrote:
This patchset updates block layer padding and draining support and
make libata use it. It's based on James Bottomley's initial work and,
of the five, the last two patches are from James with some
modifications.
Please read the following thread for more info.
http://thread.gm
Tejun Heo wrote:
For misc ATAPI commands which transfer variable length data to the
host, overflow can occur due to application or hardware bug. Such
overflows can be ignored safely as long as overflow data is properly
drained. libata HSM implementation has this implemented in
__atapi_pio_bytes
Tejun Heo wrote:
Misc ATAPI commands may try to transfer more bytes than requested.
For PIO which is performed by libata HSM, this is worked around by
draining extra bytes from __atapi_pio_bytes().
This patch implements drain buffer to perform draining for DMA and
PIO-over-DMA cases. One page i
Jeff Garzik wrote:
Tejun Heo wrote:
This patchset updates block layer padding and draining support and
make libata use it. It's based on James Bottomley's initial work and,
of the five, the last two patches are from James with some
modifications.
Please read the following thread for
Jens Axboe wrote:
On Fri, Feb 08 2008, Jeff Garzik wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
This patchset updates block layer padding and draining support and
make libata use it. It's based on James Bottomley's initial work and,
of the five, the last two patches are from James
Tejun Heo wrote:
When no reset method is available, libata currently oopses. Although
the condition can't happen unless there's a bug in a low level driver,
oopsing isn't the best way to report the error condition. Complain,
dump stack and fail reset instead.
Signed-off-by: Tejun Heo <[EMAIL P
Please pull from 'upstream-fixes' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-fixes
to receive the following updates:
drivers/ata/libata-core.c | 48 +-
drivers/ata/pata_amd.c |2 +-
drivers/ata/pata_l
Byron Bradley wrote:
When the sata_mv driver is used as a platform driver,
mv_create_dma_pools() is never called so it fails when trying
to alloc in mv_pool_start().
Signed-off-by: Byron Bradley <[EMAIL PROTECTED]>
Acked-by: Mark Lord <[EMAIL PROTECTED]>
---
Mark, based on the comment from Andr
Tejun Heo wrote:
Some controllers (VIA CX700) raise device error on SETXFER even after
mode configuration succeeded. Update ata_dev_set_mode() such that
device error is ignored if transfer mode is configured correctly. To
implement this, device is revalidated even after device error on
SETXFER.
Tejun Heo wrote:
PCI device should be powered up or powered up before its PCI regsiters
are accessed. Although PCI configuration register access is allowed
in D3hot, PCI device is free to reset its status when transiting from
D3hot to D0 causing configuration data to change.
Many libata SFF dri
Alan Cox wrote:
Forcibly set more of the configuration at init time. This seems to fix at
least one problem reported. We don't know what most of these bits do, but
we do know what windows stuffs there.
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send
Yinghai Lu wrote:
[PATCH] sata_mv: fix loop with last port
commit f351b2d638c3cb0b95adde3549b7bfaf3f991dfa
sata_mv: Support SoC controllers
cause panic:
[...]
last_port already include port0 base.
this patch change use last_port directly, and move pp assignment later.
Signed-off-by:
Tejun Heo wrote:
The first port of cx700 is SATA. Fix cable detection.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
drivers/ata/pata_via.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
applied
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the
Alan Cox wrote:
This has confused a few people so fix it
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.24-mm1/drivers/ata/pata_amd.c
linux-2.6.24-mm1/drivers/ata/pata_amd.c
--- linux.vanilla-2.6.24-mm1/drivers/ata/
Alan Cox wrote:
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.24-mm1/drivers/ata/pata_legacy.c
linux-2.6.24-mm1/drivers/ata/pata_legacy.c
--- linux.vanilla-2.6.24-mm1/drivers/ata/pata_legacy.c 2008-02-06
14:14:39.
Jens Axboe wrote:
On Fri, Jul 29 2005, Jeff Garzik wrote:
diff --git a/drivers/scsi/ahci.c b/drivers/scsi/ahci.c
--- a/drivers/scsi/ahci.c
+++ b/drivers/scsi/ahci.c
@@ -44,7 +44,7 @@
enum {
AHCI_PCI_BAR= 5,
- AHCI_MAX_SG = 168, /* hardware max is 64K
Edward Falk wrote:
Hi Tejun; I'm the guy at Google working on SATA drivers (port
multipliers right now). As soon as I can (next week perhaps, I'll start
looking at the driver you wrote. From what I can see, it looks quite good.
+
+static u8 sil24_check_status(struct ata_port *ap)
+{
+
On Sun, Aug 07, 2005 at 01:51:52PM -0700, Ravinandan Arakali wrote:
> Jeff,
> The entire set of patches have been resent and an additional
> patch13 to address earlier comments.
> Pls confirm if these patches apply correctly.
I'm in the process of moving to a new house, and getting a new computer
On Mon, Aug 08, 2005 at 10:43:41AM +0900, Tejun Heo wrote:
> I don't know much about PATA support. All I know is that ICH's seem
> to generate a lot of noise in this mailing list w/ its legacy, combined,
> ahci and whatever modes and no one setting seems to satisfy all. (If
> anyone knows mor
On Mon, Aug 08, 2005 at 10:31:45AM -0700, Carlos Pardo wrote:
> One question. Do the open source driver support pass-through commands ? if
> so, how ? If you do not support it, are you planning to implement
> pass-through commands sometime in the future ?
I don't know about sata_sil24 in particu
On Mon, Aug 08, 2005 at 05:05:38PM -0700, Edward Falk wrote:
> This patch adds a few constants related to port multipliers to libata.h,
> hdreg.h, and libata-core.c
Looks good, save for one detail:
hdreg.h is deprecated, and we want to put new defines in
include/linux/ata.h (which can be shared
On Tue, Aug 09, 2005 at 09:48:12AM -0400, Mark Lord wrote:
> Erik Slagter wrote:
> >
> >Is there a possibility that dell attaches PATA harddisks using a
> >SATA/PATA converter to the SATA connection of the ICH6M?
>
> That chipset is used in virtually all modern laptops,
> and includes a PATA inter
On Tue, Aug 09, 2005 at 10:10:17AM -0400, Mark Lord wrote:
> The PATA ATAPI works now -- perhaps it could be turned on by default
> while efforts continue to implement support for SATA ATAPI devices.
No, PATA ATAPI DMA still needs the same fixes that SATA ATAPI does.
ATAPI is incomplete, the reas
On Tue, Aug 09, 2005 at 07:05:33PM +0200, Erik Slagter wrote:
> On Tue, 2005-08-09 at 09:48 -0400, Mark Lord wrote:
> > But there's also a fix for that, again floating around only in private
> > repositories.
>
> Grmbl.
Mark is just working off steam. The "fix" causes leaks, and does
not really
On Tue, Aug 09, 2005 at 06:55:23PM +0100, James Courtier-Dutton wrote:
> Mark Lord wrote:
> >James Courtier-Dutton wrote:
> >
> >>Google did not help me.
> >>
> >>Can I use the kernel libata and do commands like this now? :
> >>hdparm -S60 /dev/sda
> >
> >
> >Yes, but only if you manually apply the
: Tejun Heo <[EMAIL PROTECTED]>
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
diff --git a/drivers/scsi/libata-scsi.c b/drivers/scsi/libata-scsi.c
--- a/drivers/scsi/libata-scsi.c
+++ b/drivers/scsi/libata-scsi.c
@@ -385,6 +385,7 @@ int ata_scsi_error(struct Scsi_Host *hos
Tejun Heo wrote:
sata_sx4 directly references sg->length to calculate total_len in
pdc20621_dma_prep(). This is incorrect as dma_map_sg() could have
merged multiple sg's into one and, in such case, sg->length doesn't
reflect true size of the entry. This patch makes it use
sg_dma_len(sg).
Sig
Tejun Heo wrote:
diff --git a/drivers/scsi/libata-scsi.c b/drivers/scsi/libata-scsi.c
--- a/drivers/scsi/libata-scsi.c
+++ b/drivers/scsi/libata-scsi.c
@@ -385,6 +385,7 @@ int ata_scsi_error(struct Scsi_Host *hos
* appropriate place
*/
host->host_failed--;
+ INIT_L
Brett Russ wrote:
Albert Lee wrote:
+cgcr = readl(port_mmio(ap, PDC_GLOBAL_CTL));
I've read that read[bwl]() and write[bwl]() are deprecated and
discouraged in new code and instead ioread{8,16,32}() and
iowrite{8,16,32}() should be used. Is this the case?
ioread/write should only be
Albert Lee wrote:
Jeff,
Patch 1/3: Convert pdc2027x from PIO to MMIO
Description:
Indexed registers need two PIO accesses: one access writes to the
index register and the other access
reads/writes the indexed register. Using MMIO can access the register
directly and simplify the code.
C
Albert Lee wrote:
Jeff,
Patch 2/3: pdc2027x mdelay() problem fix for micro-partitioning
Description:
The mdelay(100) does not delay exactly 100 ms on IBM power5 machines
when the power5 CPU micro-partitioning feature is turned on.
Ex. If micro-partitioning is set to use 0.1 of the CPU time,
Albert Lee wrote:
Jeff,
Patch 3/3: Fix pdc2027x ATAPI DMA lost irq problem
Description:
Sometimes pdc2027x will lost irq after ATAPI DMA data transfer.
With the previous rule (cmd->request_bufflen % 256), the ATAPI DMA irq
lost
problem still occurs during the test.
Root cause for the i
Timothy Thelin wrote:
Yes, but only if you manually apply the "libata-passthru" patch.
So, why hasn't that patch got into the kernel?
Because there are several reports of it causing problems, when used on a
loaded system.
Please post more information about these "problems".
I wonder i
Edward Falk wrote:
This patch adds a few constants related to port multipliers to libata.h,
hdreg.h, and libata-core.c
In addition to my previous comment ("ata.h not hdreg.h"), grep for
ATA_DEV_ATA and ATA_DEV_ATAPI in the code.
There are a few cases where you see code like
if (clas
Mark Lord wrote:
Erik Slagter wrote:
Is there a possibility that dell attaches PATA harddisks using a
SATA/PATA converter to the SATA connection of the ICH6M?
That chipset is used in virtually all modern laptops,
and includes a PATA interface as well as SATA.
Most current laptops ship with
Mark Lord wrote:
Jeff Garzik wrote:
currently no one should be using libata for PATA support.
We emailed back and forth extensively about how this has
not been true since early this year. Modern laptops are
using libata for the ICH6M support, simply because libata
claims that chipset, and
I'm getting confused with all the patches from you :/
It's my fault, but, would you be kind enough to resend the latest
versions of -all- libata and pdc2027x patches?
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTE
Brett Russ wrote:
Simple cleanup to eliminate X copies of the same function in libata.
Moved pci_enable_intx() to pci.c, added pci_disable_intx() as well,
and use them throughout libata and msi.c.
Signed-off-by: Brett Russ <[EMAIL PROTECTED]>
Though there is nothing wrong with this patch, I
Tejun Heo wrote:
02_sil24_separate-out-error-path.patch
Move error handling from sil24_host_intr into separate
function - sil24_error_intr.
Jeff, I don't think this patch actually improves readability
and/or performance. Is this what you wanted?
Yes.
It impro
Tejun Heo wrote:
01_sil24_add-status-emulation.patch
Add back status register emulation. It's very simple. If the
previous command completed successfully, we return ATA_DRDY
for all following status register queries; otherwise, we
return ATA_DRDY | ATA_ERR. We
Tejun Heo wrote:
03_sil24_add-test-for-PCI-fault.patch
On entry to interrupt handler, PORT_SLOT_STAT register is read
first. Check if PCI fault or device removal has occurred by
testing the value for 0x.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
ACK
-
To
Tejun Heo wrote:
04_sil24_remove-irq-disable-on-spurious-interrupt.patch
If interrupt occurs on a disabled port, the driver used to
mask the port's interrupt, but we don't know if such action is
necessary yet and that's not what other drives do. So, just
do nothi
Tejun Heo wrote:
05_sil24_mdelay-instead-of-udelay.patch
loop 100 times with mdelay(1) instead of 1000 times with
udelay(100) in sil24_reset_controller.
Jeff, is this what you wanted? If not, just ignore this
patch. The following patches will apply without this
Tejun Heo wrote:
06_sil24_add-flusing-after-masking-irq.patch
Add IO flushing after masking irq during initialization.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
ACK
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED
Tejun Heo wrote:
07_sil24_add-FIXME-ata_device_add-return_value.patch
Add FIXME comment above ata_device_add.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
ACK
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More ma
Tejun Heo wrote:
Hello, Jeff & Carlos.
These patches are misc fixes suggested by Jeff for rewritten sil24
driver. The follwing issues are not fixed in this patchset. I need
more info to work on these.
* Device signature access on reset.
* How to discern completion interrupts from error on
Timothy Thelin wrote:
Well it doesn't seem that nasty to adopt flagged access. From a userland
API point of view how about adopting the IDE driver's taskfile mechanism,
and simply translating that into the yet-to-be internal flagged mechanism?
There is actually already an internal flagged mech
Tejun Heo wrote:
And this is the combined patch against ncq head of libata-dev-2.6
tree. Commit d032ec9048ff82a704b96b93cfd6f2e8e3a06b19.
Only ata_piix, sata_sil and ahci are converted and all other SATA
drivers are broken. So, enable only those three SATA drivers when
compiling with this pa
Erik Slagter wrote:
On Thu, 2005-08-11 at 13:19 -0400, Jeff Garzik wrote:
Mark Lord wrote:
Jeff Garzik wrote:
currently no one should be using libata for PATA support.
We emailed back and forth extensively about how this has
not been true since early this year. Modern laptops are
using
Jeff Garzik wrote:
The system is thus:
1) drivers/pci/quirks.c reserves SATA ports (only!) for libata
2) Legacy IDE driver claims the unreserved PATA port
3) libata loads and uses the ports reserved in #1
This requires a specific kernel configuration:
(a) CONFIG_IDE_GENERIC be set, and
(b) IDE
Dick wrote:
How do I put an SATA ata_piix harddisk to sleep?
I've tried blktool, hdparm and sdparm but none seem to work, does it need a
special ioctl or should I patch something?
Apply the ATA passthru patch, or grab the latest 'upstream' branch of
libata-dev.git and use the SCSI START STOP
Bjorn Helgaas wrote:
IA64 boxes only have PCI IDE devices, so there's no need to blindly poke
around in I/O port space. Poking at things that don't exist causes MCAs
on HP ia64 systems.
Signed-off-by: Bjorn Helgaas <[EMAIL PROTECTED]>
Index: work-vga/drivers/ide/Kconfig
===
Since there's been some recent interest in the subject, I thought I
would post the PATA todo list for libata. Some of these items are from
my memory, and some are from a list Alan was kind enough to create. The
items verbatim from Alan are prefixed "Alan: ".
1) Locked device/host speed
T
Bjorn Helgaas wrote:
On Thursday 11 August 2005 2:36 pm, Jeff Garzik wrote:
Bjorn Helgaas wrote:
IA64 boxes only have PCI IDE devices, so there's no need to blindly poke
around in I/O port space. Poking at things that don't exist causes MCAs
on HP ia64 systems.
Signed-off-by: Bjo
On Thu, Aug 11, 2005 at 03:42:07PM -0600, Bjorn Helgaas wrote:
> Tony, others, does this change give you any heartburn? On
> the 460GX and 870 boxes I have, IDE is a PCI device.
>
> (I have been told that the SGI ia64 simulator depends on
> IDE_GENERIC. But it really should make the IDE device
>
Jeff Garzik wrote:
00:1f.1 IDE interface: Intel Corporation 82801EB/ER (ICH5/ICH5R) IDE Controller
(rev 02) (prog-if 8a [Master SecP PriP])
Subsystem: Hewlett-Packard Company d530 CMT (DG746A)
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
ping- SERR
Luck, Tony wrote:
Tony, others, does this change give you any heartburn? On
the 460GX and 870 boxes I have, IDE is a PCI device.
No heartburn for me ... as you say IDE is built into one
of the 870 chips.
I don't know whether any non-Intel chipsets provide legacy IDE.
The question is not ab
Bjorn Helgaas wrote:
You deduce this by the absence of SecO and PriO? I wonder if lspci
should be enhanced to notice this, too. I assume that the IRQ 169
doesn't correspond to anything in /proc/interrupts.
Correct.
So the scenario in question (correct me if I'm wrong) is that we
have a PCI
Things in SATA-land have been moving along recently, so I updated the
software status report:
http://linux.yyz.us/sata/software-status.html
Although I have not updated it in several weeks, folks may wish to refer
to the hardware status report as well:
http://linux.yyz.us/sa
Rob van Nieuwkerk wrote:
On Fri, 12 Aug 2005 01:09:12 -0400
Jeff Garzik <[EMAIL PROTECTED]> wrote:
Hi Jeff,
Things in SATA-land have been moving along recently, so I updated the
software status report:
http://linux.yyz.us/sata/software-status.html
Is any progress made on
Albert Lee wrote:
Jeff,
The PIO fixes revised according to the previous reviews.
1/2 pio1.diff:
- Modify ata_mmio_data_xfer() and ata_pio_data_xfer() to handle buffer
with odd length.
2/2 pio2.diff:
- Modify __atapi_pio_bytes() to handle the case where device
returns/needs extra data.
Albert Lee wrote:
Jeff,
pdc2027x driver fix:
1/3 pdc1.diff:
- Convert pdc2027x from PIO to MMIO.
2/3 pdc2.diff:
- use "long" for the counter data type instead of "unsigned long"
3/3 pdc3.diff:
- pdc2027x ATAPI DMA irq lost problem workaround
Applied all three patches to pdc2027x b
Albert Lee wrote:
Root cause for the irq lost is unknown yet. I've tried your ATAPI DMA
alignment
patch, but the problem still occurs, even the buffer is aligned. I guess
it is pdc2027x hardware problem.
Note that my ATAPI DMA alignment patch was buggy, as Tejun noted...
Tejun's updated pa
Brett Russ wrote:
Jeff Garzik wrote:
Though there is nothing wrong with this patch, I would prefer a single
function, pci_intx(), as found in drivers/scsi/ahci.c.
Sounds like what I did, except for the naming change. I did away with
pci_disable_intx() and changed the names. Look ok
Greg KH wrote:
On Fri, Aug 12, 2005 at 01:10:43PM -0400, Brett Russ wrote:
Jeff Garzik wrote:
Brett Russ wrote:
Simple cleanup to eliminate X copies of the same function in libata.
Moved pci_enable_intx() to pci.c, added pci_disable_intx() as well,
and use them throughout libata and
Matthew Garrett wrote:
Jeff Garzik <[EMAIL PROTECTED]> wrote:
Things in SATA-land have been moving along recently, so I updated the
software status report:
http://linux.yyz.us/sata/software-status.html
I couldn't see any reference to system-wide power management (
201 - 300 of 2011 matches
Mail list logo
