Tejun Heo wrote:
devres change moved iomap.o from obj-$(CONFIG_GENERIC_IOMAP) to lib-y
making it not linked if no in-kernel driver uses it. Fix it.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
applied
BTW can you update your scripts to email [EMAIL PROTECTED] ? That's the
primary email add
Eric D. Mudama wrote:
Per Jeff's suggestion, this patch rearranges the info printed for ATA
drives into dmesg to add the full ATA firmware revision and model
information, while keeping the output to 2 lines.
Signed-off-by: Eric D. Mudama <[EMAIL PROTECTED]>
---
This extra information is helpfu
Tejun Heo wrote:
Alan wrote:
Some SATA controllers use 0xff to indicate empty port. This seldomly
matters as we have the almighty SStatus register to check device
presence (there is a bug regarding this, patch pending).
This GoVault drive fails because ata_piix doesn't have SCR while using
0xf
Tejun Heo wrote:
Also, you can avoid that by configuring aliases to the thunderbird
account. It's in account setting -> Manage Identities. Thungerbird is
pretty neat. :-)
Already done that, it doesn't seem to work :/
If you ever see [EMAIL PROTECTED] in a From line, that's
Thunderbird scre
Luca Tettamanti wrote:
Hi Jeff, linux-ide,
I'm having troubles with libata and UDF on RW media. See below.
Il Tue, Jan 30, 2007 at 09:42:34PM +0100, Jan Engelhardt ha scritto:
On Jan 30 2007 21:36, Luca Tettamanti wrote:
Il Tue, Jan 30, 2007 at 09:02:20PM +0100, Jan Engelhardt ha scritto:
On
Tejun Heo wrote:
Implement device resource management, in short, devres. A device
ACK patches 1-7. Applied patches 1-6 (with some remaining pata_platform
damage) to #upstream.
Please examine the resulting damage, and resend patch #7, plus any
missing bits
Jeff
-
To unsubscrib
Alan wrote:
@@ -5142,6 +5174,20 @@
status = ata_chk_status(ap);
if (unlikely(status & ATA_BUSY))
goto idle_irq;
+
+ if (unlikely(qc->tf.command == ATA_CMD_SET_FEATURES &&
+ qc->tf.feature == SETFEATURES_XFER)) {
+ /* Let the timings
Mark Lord wrote:
Eric D. Mudama wrote:
Actually, it's possibly worse, since each failure in libata will
generate 3-4 retries. With existing ATA error recovery in the drives,
that's about 3 seconds per retry on average, or 12 seconds per
failure. Multiply that by the number of blocks past t
Mark Lord wrote:
For example, I think all existing ATAPI drives only speak 12-byte packet
protocols, and so if we tell SCSI we're good for 16-byte, then won't the
SCSI layer suddenly start sending us READ_16 and the like?
Speaking strictly about the device, IDENTIFY PACKET DEVICE data page
te
Tejun Heo wrote:
SCSI always uses the smallest command it can use, so we're safe. Most
other commands are issued directly from the userland and it's their
responsibility not to feed disallowed commands to a device (or we need
more advanced filter). Anyways, this has never been guaranteed becaus
Mark Lord wrote:
Tejun Heo wrote:
Anyways, this has never been guaranteed because
the limit is host wide.
But until very very recently, "host wide" meant just a single device
for libata. I was just assuming we did all of the fiddling to ensure
a minimal value there for some real reason.
But,
Tejun Heo wrote:
Jeff Garzik wrote:
Mark Lord wrote:
For example, I think all existing ATAPI drives only speak 12-byte packet
protocols, and so if we tell SCSI we're good for 16-byte, then won't the
SCSI layer suddenly start sending us READ_16 and the like?
Speaking strictly about
Tejun Heo wrote:
Well, it's not any worse than what we're currently doing. We don't set
Agreed... but that doesn't make it the /right/ thing to do ;-)
The logic behind the current code, which limits to the maximum size
allowed by an attached device on the port, is mainly to leverage the
SCS
James Bottomley wrote:
But you're requesting code changes in the SCSI layer because of this
incorrect usage. max_cdb is supposed to be the *host* limit. The mid
layer finds out and respects device limits separately from this.
I never requested any such thing.
Jeff
-
To unsubscribe
Douglas Gilbert wrote:
It is the ATAPI _transport_ that has the 12 byte cdb
limit *** (at least according to MMC-5 rev Annex A;
is S-ATAPI any better?).
Then the spec is wrong.
1) The transport does not limit the CDB size.
2) The ATAPI device limits the CDB size, and it exports this limit via
It's amazing how poorly we have programmed PIIX, for the lifespan of
Linux...
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Alan wrote:
I don't have the hardware combination to test this one so would
appreciate people testing it before it goes anywhere further
I wonder if sata_promise PATA support needs this too?
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMA
Brian King wrote:
Some LLDDs, like ipr, use nbytes and pad_len to determine
the total data transfer length of a command. Make sure
nbytes gets initialized for internally generated commands.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
Jeff,
This bug is already fixed in #upstream, with Tej
Tejun Heo wrote:
For all JMicrons except for 361 and 368, AHCI mode enable bits in the
Control(1) should be set. This used to be done in both ahci and
pata_jmicron but while moving programming to PCI quirk, it was removed
from ahci part while still left in pata_jmicron.
The implemented JMicron
[EMAIL PROTECTED] wrote:
BTW: In function ata_dev_set_mode in libata_core.c the variable err_mask is not
initialized (line 2386). I changed that and initialized err_mask with 0, but
that did'nt solve my problem. I did'nt expect to :-)
It's initialized prior to its first use, by a call to
ata_d
Alan wrote:
Looks like you should use ata_busy_wait() here, rather than reproducing
the same code again.
It waits in 10uS chunks while 1uS chunks were used in the workaround.
Could indeed do that once I know the fix is right. While I'm at it the
ata_busy_wait kerneldoc is borked so here's a fix
Tejun Heo wrote:
devres updates for pata_platform were dropped while merging devres
patches due to merge conflict. This is the updated version.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
applied 1-2
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a me
Brian and Tejun's patches fix really ugly bugs, Alan's are of less
importance
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/libata-core.c |1 +
drivers/ata/pata_a
Linus Torvalds wrote:
On Fri, 2 Feb 2007, Jeff Garzik wrote:
pata_atiixp: propogate cable detection hack from drivers/ide to the new
driver
It's prop*a*gate.
Damn.
Linus "some speling mistaeks drive me wild" Torvalds
Those UK types don't kn
Alan wrote:
Well we can certainly do some of that if ACPI is present and active. In
particular since _GTM will give us current modes allowing for hotplug and
post BIOS boot kexec etc it ought to be safe to do Tejun's hack that way.
We could even probe UDMA3+ capable devices by doing _STM to a hig
[EMAIL PROTECTED] wrote:
My problem is it does not work with kernel sata_mv driver, only highpoint's
binary hptvm6 driver, which is very slow.
I would like to know when will the kernel support Highpoint 2220(Marvell
Technology Group Ltd. MV88SX6081 8-port SATA II PCI-X Controller (rev 07))
s
Mikael Pettersson wrote:
This patch updates the sata_promise driver to use new-style
libata error handling for 20619 (TX4000) chips. sata_promise
already uses new EH for the other chips it supports, so the
patch is quite simple:
* remove ->phy_reset and ->eng_timeout ops from pdc_pata_ops,
and
Akira Iguchi wrote:
This patch is against the libata core and headers.
Two IRQ calls are added in ata_port_operations.
- irq_on() is used to enable interrupts.
- irq_ack() is used to acknowledge a device interrupt.
In most drivers, ata_irq_on() and ata_irq_ack() are used for
irq_on and irq_ac
Akira Iguchi wrote:
This patch is against each libata driver.
Two IRQ calls are added in ata_port_operations.
- irq_on() is used to enable interrupts.
- irq_ack() is used to acknowledge a device interrupt.
In most drivers, ata_irq_on() and ata_irq_ack() are used for
irq_on and irq_ack respect
Eric D. Mudama wrote:
Per Jeff's suggestion, this patch rearranges the info printed for ATA
drives into dmesg to add the full ATA firmware revision and model
information, while keeping the output to 2 lines.
Signed-off-by: Eric D. Mudama <[EMAIL PROTECTED]>
diff --git a/include/linux/ata.h b/
Tejun Heo wrote:
Follow the old SRST rule and delay 150ms between completion of
hardreset and status checking. Debouncing delay should usually cover
this but debounce duration could be shorter than 150ms under certain
circumstances.
Usefulness depends on host controller implementation but it ca
Tejun Heo wrote:
* Hardreset must not exit without actually performing reset regardless
of link status. We're resetting the link after all.
* Minor message update.
* 150ms delay is meaningful iff link is online after reset is
complete.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
dri
Alan wrote:
People are getting confused about which drivers to enable for PATA PIIX
type devices. Change the ATA_PIIX line and help to make it clearer.
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a
Alan wrote:
IORDY and IORDY enable/disable flags.
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Alan wrote:
This is the first preparation to doing the !IORDY cases properly. Further
diffs will then add the needed logic to do it right.
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
ACK but please rediff&resend, it clashed with some previous driver
bombing runs
-
To unsubscribe from this
Sergei Shtylyov wrote:
[Cr*p, forgot both the sign-off and cut-off! :-)]
MPIIX has only single channel IDE which can be configured for either primary or
secondary legacy I/O ports and IRQ. So, get rid of the unneeded second probe
entry in mpiix_init_one() and of the invalid (but unused anyway)
Sergei Shtylyov wrote:
Fix clearing/setting the wrong TIME/IE/PPE bits for a slave drive caused by a
wrong shift count.
Fix the PIO mode 1 being overclocked by wrongly selecting the fast timing bank.
Also, fix/rephrase some comments while at it.
Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]>
Sergei Shtylyov wrote:
Fix the PIO mode 2 using mode 0 timings -- this driver should enable the
fast timing bank starting with PIO2, just like the ata_piix driver does.
Also, fix/rephrase some comments while at it.
Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]>
---
drivers/ata/pata_oldpiix
Alan wrote:
If we are doing a PIO setup for a CFA card and it blows up with a device
error then assume it is an older CFA card which doesn't support this
rather than failing the device out of existance.
Stands seperate to the quieting patch but that is obviously useful with
this change.
Signed-
Michal Piotrowski wrote:
Hi Jeff,
What does this mean?
ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata1.00: cmd c8/00:08:67:40:68/00:00:00:00:00/e3 tag 0 cdb 0x0 data 4096 in
res 40/00:01:00:4f:c2/00:00:00:00:00/00 Emask 0x4 (timeout)
ata1: soft resetting port
ata1.
Mikael Pettersson wrote:
This patch fixes an oversight which caused sata_promise to
not perform cable detection on the TX2plus chips' PATA ports.
Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]>
---
This patch adds yet another is-PATA-or-SATA? check, but it's in a
cold path so shouldn't ma
Mikael Pettersson wrote:
On Thu, 08 Feb 2007 08:50:09 -0500, Jeff Garzik wrote:
Mikael Pettersson wrote:
This patch fixes an oversight which caused sata_promise to
not perform cable detection on the TX2plus chips' PATA ports.
Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]>
Zhang, Yanmin wrote:
If an ATA drive uses legacy mode, ata driver will choose 14 and 15 as the
fixed irq number. On ia64 platform, such numbers are GSI and should be converted
to irq vector.
Below patch against kernel 2.6.20 fixes it.
Signed-off-by: Zhang Yanmin <[EMAIL PROTECTED]>
IA64 shoul
Williams, Dan J wrote:
When I fire up 2.6.20 with an iq3124h I get:
ata1: SATA max UDMA/133 cmd 0xC8822200 ctl 0xC889 bmdma 0xC8822270
irq 25
ata2: SATA max UDMA/133 cmd 0xC8822400 ctl 0xC8822429 bmdma 0xC8822470
irq 25
ata3: SATA max UDMA/133 cmd 0xC8822600 ctl 0xC8822629 bmdma 0xC8822670
i
libata: rearrange dmesg info to add full ATA revision
J J (1):
ata_piix: add ICH7 on Acer 3682WLMi to laptop list
Jakub W. Jozwicki J (1):
pata_sis: implement laptop list and add ASUS A6K/A6U
Jeff Garzik (5):
[libata] trim trailing whitespace
[libata] sata_vsc: build fix
Benjamin Herrenschmidt wrote:
2.6.20 has been released and (I think) it is the time of merge-window
for 2.6.21. I want this patch to be merged at this time.
Please tell me if there are anything I should do.
FYI, Jeff, we have merged the rest of the celleb platform support in the
2.6.21 merge wi
My overall impression of spidernet development is that EVERYBODY is submitting
patches at once, and expecting me to sort out the mess. No thanks.
Speaking with one voice would be much appreciated. And said speaker should patch the MAINTAINERS file to reflect reality.
To be specific, I have
Robert Hancock wrote:
It's curious that only the post-cache-flush command is having issues,
and normal NCQ operation seems fine. Maybe it's related to that tag 0
being reused repeatedly?
If you take cache flush out of the equation, what happens when NCQ is
enabled with a queue depth of 1 (to
Florin Andrei wrote:
(I'm not subscribed to linux-ide)
I've two almost identical systems (slightly different CPUs) that use SiI
3114 for SATA and RAID.
One of them was installed a while ago with Fedora Core 5 (kernel
2.6.15-1.2054_FC5smp) and whoever installed it was able to turn on
hardwar
Florin Andrei wrote:
Jeff Garzik wrote:
Florin Andrei wrote:
(I'm not subscribed to linux-ide)
I've two almost identical systems (slightly different CPUs) that use
SiI 3114 for SATA and RAID.
One of them was installed a while ago with Fedora Core 5 (kernel
2.6.15-1.2054_F
Alan wrote:
Currently we don't report PIO/DMA information in the case we are using
firmware mode setup by drivers, or where the value is meaningless. Even
when we don't know the mode, or the mode is meaningless it would be nice
to report PIO or DMA and to keep stylistic consistency. For MW/UDMA w
Tejun Heo wrote:
The 80c wire bit is bit 13, not 14. Bit 14 is always 1 if word93 is
implemented. This increases the chance of incorrect wire detection
especially because host side cable detection is often unreliable and
we sometimes soley depend on drive side cable detection. Fix the test
and
Mikael Pettersson wrote:
This patch fixes an oversight which caused sata_promise to
not perform cable detection on the TX2plus chips' PATA ports.
Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]>
---
This patch adds yet another is-PATA-or-SATA? check, but it's in a
cold path so shouldn't ma
Tejun Heo wrote:
Some devices chock if Feature is not clear when IDENTIFY is issued.
Set ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE for IDENTIFY such that whole
TF is cleared when reading ID data.
Kudos to Art Haas for testing various futile patches over several
months and Mark Lord for pointing out th
Olaf Hering wrote:
The hald media changed polling does really confuse things.
Noone knows why the delays are needed, but they give us access to the CD.
An udelay(50) will give reliable access to the drive, but there is still
one (or more) EH reset. The drive works without EH resets with udelay(1
Mikael Pettersson wrote:
This patch updates the sata_promise driver to use new-style
libata error handling for 20619 (TX4000) chips. sata_promise
already uses new EH for the other chips it supports, so the
patch is quite simple:
* remove ->phy_reset and ->eng_timeout ops from pdc_pata_ops,
and
Jeremy Higdon wrote:
On Wed, Feb 07, 2007 at 09:29:28AM -0500, Dailey, Nate wrote:
The attached patch modifies drivers/ata/sata_vsc.c to only set the cache
line size to 0x80 if the default value is zero. Apparently zero isn't
allowed due to a bug in the chip, but I've found performance is much
b
Robin H. Johnson wrote:
No, that's not a correct assertion. We can only say that device-mapper
is being used somehow. It could be LVM, EVMS2, dmraid, or a few other
things.
When using the stock open source ATA drivers, of those DM-related actors
only dmraid can claim support for Sil 3114 prop
Robert Hancock wrote:
ADMA-capable controllers provide a bit in the status register that appears
to indicate that the controller detected an SError condition. Update
sata_nv
to detect this and trigger error handling in order to handle the fault.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]
The pile that was waiting for post-conference, largely bug fixes.
As mentioned in the last push, were two other push points planned for
2.6.21:
1) merge libata support for ACPI
2) Remove ugly combined mode hacks in libata-sff and pci/quirks, now
that old-IDE and libata have the necessary impro
Jeff Garzik wrote:
--- a/include/linux/ata.h
+++ b/include/linux/ata.h
@@ -352,7 +352,7 @@ static inline int ata_drive_40wire(const u16 *dev_id)
{
if (ata_id_major_version(dev_id) >= 5 && ata_id_is_sata(dev_id))
return 0; /* SATA */
- if (dev_id[9
Linus Torvalds wrote:
On Thu, 15 Feb 2007, Jeff Garzik wrote:
diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
index db185f3..d51f0f1 100644
--- a/arch/ia64/Kconfig
+++ b/arch/ia64/Kconfig
@@ -22,6 +22,7 @@ config IA64
config 64BIT
bool
+ select ATA_NONSTANDARD if ATA
Tejun Heo wrote:
Hello,
Robert Hancock wrote:
[--correct summary snipped--]
Given the above, what I'm proposing to do is:
-Remove the blacklisting of Maxtor BANC1G10 firmware for FUA. If we
need to FUA-blacklist any drives this should likely be added to the
existing "horkage" mechanism we no
Zhang, Yanmin wrote:
On Thu, 2007-02-08 at 20:19 -0500, Jeff Garzik wrote:
Zhang, Yanmin wrote:
If an ATA drive uses legacy mode, ata driver will choose 14 and 15 as the
fixed irq number. On ia64 platform, such numbers are GSI and should be converted
to irq vector.
Below patch against kernel
Robert Hancock wrote:
Tobias Diedrich wrote:
Possibly a known issue:
After resume pata_amd drops from UDMA/33 to PIO on my system.
Reloading the module puts both attached optical drives (master and
slave) back to UDMA/33.
AFAICS "simplex DMA is claimed by other device, disabling DMA" seems
to
Olaf Hering wrote:
Change the default for the built-in IDE on p610/p615/p630 from
ide to libata. libata has better error handling and the drive can
recover when hald does its CD media polling.
Signed-off-by: Olaf Hering <[EMAIL PROTECTED]>
---
arch/powerpc/configs/ppc64_defconfig |4 ++--
_params[0].buffer.pointer = (u8 *)atadev->id;
+ /* Output buffer: _SDD has no output */
+
+ /* It's OK for _SDD to be missing too. */
+ swap_buf_le16(atadev->id, ATA_ID_WORDS);
+ status = acpi_evaluate_object(atadev->obj_handle, "_SDD", &input, N
Tejun Heo wrote:
Make ata_down_xfermask_limit() accept @sel instead of @force_pio0.
@sel selects how the xfermask limit will be adjusted. The following
selectors are defined.
* ATA_DNXFER_PIO: only speed down PIO
* ATA_DNXFER_DMA: only speed down DMA, don't cause transfer mode c
Tejun Heo wrote:
SDB FIS containing spurious NCQ completions is a clear protocol
violation. Currently, only some Maxtors with early firmware revisions
are showing this problem. Those firmwares have other NCQ related
problems including buggy NCQ error reporting and occasional lock up
after NCQ e
Akira Iguchi wrote:
This is the patch for PATA controller of Celleb.
This driver uses the managed iomap (devres).
Because this driver needs special taskfile accesses, there is
a copy of ata_std_softreset(). ata_dev_try_classify() is exported
so that it can be used in this function.
Signed-off-
Mark Lord wrote:
I was trying to use HDIO_DRIVE_TASK for something today,
and discovered that the libata implementation does not copy
over the upper four LBA bits from args[6].
This is serious, as any tools using this ioctl would have their
commands applied to the wrong sectors on the drive, pos
Tejun Heo wrote:
Separate out ata_ncq_enabled().
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
drivers/ata/libata-core.c |4 +---
include/linux/libata.h| 15 +++
2 files changed, 16 insertions(+), 3 deletions(-)
applied 1-3
-
To unsubscribe from this list: send the
Tejun Heo wrote:
libata used disable pdev only on PM_EVENT_SUSPEND while re-enable pdev
unconditionally. This was okay before ref-counted pdev enable update
but it now makes the pdev pinned after swsusp cycle (enabled twice but
disabled only once) and devres sanity check whines about it.
Fix it
Magnus Damm wrote:
libata: Remove duplicate dma blacklist entry
The exact same entry is already present.
Signed-off-by: Magnus Damm <[EMAIL PROTECTED]>
---
Applies to 2.6.20-git14.
applied
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [
Tejun Heo wrote:
ata_port has two different id fields - id and port_no. id is
system-wide 1-based unique id for the port while port_no is 0-based
host-wide port number. The former is primarily used to identify the
ATA port to the user in printk messages while the latter is used in
various place
Tejun Heo wrote:
ata_probe_ent_alloc() had a temporary hack such that devm_kzalloc()
was used for allocation if devres had been previously initialized on
the device; otherwise, plain kzalloc() was used. This was to make the
code useable from both the old and devres-aware libata drivers during
tr
Alan wrote:
Deleting the ata_pci_clear_simplex() call, then adding
ATA_FLAG_IGN_SIMPLEX to the ata_port_info info[] array, is also worth
trying.
I think I know what is going on here. Firstly the simplex bits
need re-clearing on a resume. On my todo list now I'm back
If the bit does not actua
Robert Hancock wrote:
Some debug output in the ADMA error_handler function was removed recently,
but it may be useful in certain cases, like NCQ commands timing out. Add it
back in, but make it a bit more intelligent so that it only prints if
command(s) are active and only prints the CPBs for tho
Robert Hancock wrote:
This patch appears to solve some problems with commands timing out in
cases where an NCQ command is immediately followed by a non-NCQ command
(or possibly vice versa). This is a rather ugly solution, but until we
know more about why this is needed, this is about all we can d
Tejun Heo wrote:
Conversion to resource-managed iomap was buggy causing init failures
on both vt6420 and 6421 - BAR5 wasn't mapped for both controllers
while on vt6420 sata_via tried to map BAR0-4 twice. Fix it.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
I thought I have a vt6421 but mine
Robert Hancock wrote:
When error handling occurs with pending commands, output the contents
of the next CPB count and next CPB index registers as well as the others,
since these may be useful for debugging.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
applied 1-5. Thanks for splitting it
Magnus Damm wrote:
pata_pcmcia: Update device table
Add CFA devices from I-O Data, Mitsubishi and Viking. Add SanDisk comment.
Signed-off-by: Magnus Damm <[EMAIL PROTECTED]>
---
Applies to 2.6.20-git14.
applied
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the
Rafael J. Wysocki wrote:
FWIW, with CONFIG_PREEMPT unset (CONFIG_PREEMPT_VOLUNTARY is set instead), I'm
unable to reproduce this problem on the box on which it is readily reproducible
with
CONFIG_PREEMPT set.
I'm not surprised... I routinely tell people to turn it off, when
debugging a probl
Lukas Hejtmanek wrote:
On Tue, Feb 20, 2007 at 05:23:21PM -0500, Jeff Garzik wrote:
introducing SATA ACPI does not work for me (I've filled the bug
report: http://bugzilla.kernel.org/show_bug.cgi?id=8046) beside those error
messages, IDE performance is decreased. libata.noacpi=1 option wor
Robert Hancock wrote:
This patch adds in some NCQ blacklist entries taken from the Silicon
Image Windows drivers' .inf files for the 3124 and 3132 controllers.
These entries were marked as ""DisableSataQueueing". Assume these are
in their blacklist for a reason and disable NCQ on these drives.
S
Alan wrote:
Since Sil3124 has better PCI read/write performance, as a reference,
could someone explain or point me to the PCI configuration code for
Sil3124? I couldn't find it in sata_sil24.c.
Are you sure the values used are not the power on ones in this case ?
The values used, most likely,
Fajun Chen wrote:
On 2/22/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
Alan wrote:
>> Since Sil3124 has better PCI read/write performance, as a reference,
>> could someone explain or point me to the PCI configuration code for
>> Sil3124? I couldn't find it in sata_
Is this detection problem limited to Promise controllers?
It's possible we might be programming the Promise controllers in "dual
master" mode, and then accidentally missing the second channel somehow.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the
Alan wrote:
We want to be able to issue commands that fail silently some of the time
(set_features/xfer rate to CF 1.4 devices, perhaps some others such as
user SG_IO commands ought to be silent too as the error is for the app)
This is a minimal implementation, we can extend it so the QUIET flag
Alan wrote:
For further review
Turn on the IORDY handling logic.
If a controller doesnt support IORDY don't try and use it
If a device doesn't support IORDY don't try and use it
Otherwise use it whenever possible.
Always use IORDY for PIO3 and higher (it's mandatory)
Send the correct set_featu
Adam J. Richter wrote:
Hi Tejun and Jeff,
The discussion about the vt6421 problems caused me to glance
at the code and try a very minor clean-up to vt6421_init_addrs().
Please note that I don't have a vt6421, so this patch is UNTESTED.
The patch does two things:
1. Elminate the
Tejun Heo wrote:
SDB FIS containing spurious NCQ completions is a clear protocol
violation. Currently, only some Maxtors with early firmware revisions
are showing this problem. Those firmwares have other NCQ related
problems including buggy NCQ error reporting and occasional lock up
after NCQ e
Tejun Heo wrote:
Merge order left libata-acpi and pata_scc with remainling usage of
ap->id. Kill superflous id printing and substitute the remaining ones
with ap->print_id.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe linux
Greg KH wrote:
From: Greg Kroah-Hartman <[EMAIL PROTECTED]>
It seems that the ata_piix driver has two duplicate ids, one of them
with a different 'private' field in it, which was never being used due
to the match for the device happening on an earlier entry.
This patch removes the duplicates, i
Tejun Heo wrote:
Sorry to keep nagging about patch separation and your way could be okay
too, but IMHO this can be done better in one of the following ways.
1. Keep two patches. One to break down the interrupt handler the other
to improve it. In this case the first one shouldn't introduce majo
Robert Hancock wrote:
sata_nv implemented its own copies of the BMDMA helper functions for ADMA,
since the ADMA BMDMA status registers are PIO while the other registers
are MMIO, and this was the only way to handle this previously. Now that
we have iomap support, the standard routines should just
Tejun Heo wrote:
Test major version in ata_id_is_sata() not separately.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/maj
Robert Hancock wrote:
Recently Tejun wrote a patch to ahci.c to make it raise a HSM violation
if the drive attempted to complete a tag that wasn't outstanding. We could
run into the same problem with sata_nv ADMA. This adds code to raise a HSM
violation error if the controller gives us a notifier
Alan wrote:
If you've got a CF adapter or PCMCIA disc which shows up twice in libata
pata_pcmcia can you try this patch on top of the updates posted. It tries
to spot when the slave is a mirror of the master and to fix up problems
that causes.
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u
Robert Hancock wrote:
This patch adds in some NCQ blacklist entries taken from the Silicon
Image Windows drivers' .inf files for the 3124 and 3132 controllers.
These entries were marked as ""DisableSataQueueing". Assume these are
in their blacklist for a reason and disable NCQ on these drives.
S
601 - 700 of 2011 matches
Mail list logo
