Uwe Koziolek wrote:
Jeff Garzik wrote:
Jeff,
Did you have added the patch you have mailed on 06.06. anywhere or is
this patch an email only patch. And how to continue?
It's in my mbox queue, should be in my next run... :)
Jeff
I have 3 fixes that i want to add on top
Chuck Ebbert wrote:
On 06/28/2007 03:16 PM, Chuck Ebbert wrote:
[Forgot to mark subj: as a patch; attached]
Sorry, using attachments (a) decreases reviewers and (b) makes your
patch HARDER to apply. See #7 under Documentation/SubmittingPatches.
Jeff
-
To unsubscribe from this
Alan Cox wrote:
I'm not even sure this report is IT8212 related rather than just an IRQ
storm
Why does the driver report irq 0?
ata7: PATA max UDMA/133 cmd blah ctl blah bmdma blah irq 0
Above that, the ACPI layer says it assigned IRQ 20
Because the libata core code in 2.6.22rc6
Alan Cox wrote:
On Fri, 29 Jun 2007 14:10:49 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
Alan Cox wrote:
I'm not even sure this report is IT8212 related rather than just an IRQ
storm
Why does the driver report irq 0?
ata7: PATA max UDMA/133 cmd blah ctl blah bmdma blah irq 0
Above
Bartlomiej Zolnierkiewicz wrote:
* Add IDE_HFLAG_ABUSE_{PREFETCH,FAST_DEVSEL,DMA_MODES} flags
and set them in ht6560, cmd640, cmd64x and sc1200 host drivers.
* Add set_pio_mode_abuse() for checking if host driver has a non-standard
-tuneproc() implementation and use it in do_special().
*
Bartlomiej Zolnierkiewicz wrote:
* Add ATA_PIO[0-6] defines to linux/ata.h.
ACK
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Bartlomiej Zolnierkiewicz wrote:
* Add ata_pio_cycle_time() helper.
ditto previous comment about highly inconsistent prefix usage
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Charles Shannon Hendrix wrote:
Following this post is output from Linux kernel 2.6.21 showing ADMA
timeouts.
2.6.21 has improved the situation over earlier kernels, but the problems
do still occur.
nforce4 chipset, Seagate Barracuda SATA drives.
This is meant mainly as an additional
Bartlomiej Zolnierkiewicz wrote:
This has been changing recently since ide_ prefix seems to have
negative emotional connotations. :-)
New patches for drivers/ide should use exclusively the ata_ prefix.
So this choice to be inconsistent was made based entirely on fashion?
This is the same as
Daniel Schroeder wrote:
hello list,
i do not know, what this could mean, but i have never seen it before.
System is 2.6.22-rc6, sil3132, samsung hd501lj (new hd under 10 power on
hours)
time line:
1: power on (single esata enclosure)
2: system recognizes and configures the disk
3: mount disk
Daniel Schroeder wrote:
ata3.00: exception Emask 0x0 SAct 0x2ef SErr 0x0 action 0x0
ata3.00: (irq_stat 0x00020002, device error via SDB FIS)
ata3.00: cmd 61/28:30:17:83:68/00:00:1f:00:00/40 tag 6 cdb 0x0 data
20480 out
res 51/04:30:17:83:68/50:04:1f:00:00/40 Emask 0x1 (device error)
.
* Remove stale comment from ide_config_drive_speed().
v2:
* Fix ata_ prefix (Noticed by Jeff).
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Cc: Jeff Garzik [EMAIL PROTECTED]
Thanks Bart!
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body
Florian Attenberger wrote:
Hi,
added this pci id to support my:
lspci:
01:00.0 RAID bus controller: Adaptec Unknown device 0243 (rev 02)
lspci -n:
01:00.0 0104: 9005:0243 (rev 02)
seems to work fine.
florian attenberger
--- 2.6.22-rc6/drivers/ata/sata_mv.c2007-06-30 16:21:47.462020256
Albert Lee wrote:
In ata_hsm_qc_complete():
Calling ata_altstatus() after the qc is completed might race with next qc.
Remove it.
Signed-off-by: Albert Lee [EMAIL PROTECTED]
---
Jeff,
(Sorry for re-submitting this patch so late.)
The unneeded reading of alt_status might cause trouble when
Albert Lee wrote:
Recently the PLL input clock of pata_pdc2027x is sometimes detected
higer than expected (e.g. 20.027 MHz compared to 16.714 MHz).
It seems sometimes the mdelay() function is not as precise as it
used to be. Per Alan's advice, HT or power management might affect
the precision of
Tejun Heo wrote:
sata_inic162x can't do LBA48 properly yet and is likely to corrupt
data on drives larger than LBA28 limit. Disable LBA48 devices during
device configuration.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/sata_inic162x.c |7 +++
1 file changed, 7
Robert Hancock wrote:
The sata_nv driver was missing the change_queue_depth hook in the SCSI host
template which the other NCQ-capable libata drivers had. This made it impossible
to change the queue depth by user request. Add this in.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
---
Tejun Heo wrote:
Another member of HTS5416* family doing spurious NCQ completion.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Cc: Enrico Sardi [EMAIL PROTECTED]
---
drivers/ata/libata-core.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/libata-core.c
Uwe Koziolek wrote:
Changed PATA handler for PATA-ports used by sata_sis.
This patch was originally submitted by Jeff Garzik.
Added PCI-ID 1180 for SiS966 Controller in pata_sis.
The 1180 mode is fully compatible to other SiS PATA-controller.
The PCI-ID 1183 is SATA in PATA-emulation
Uwe Koziolek wrote:
The SiS966 has an alternate PCI-ID 1180 for an IDE compatible controller
The primaty channel acts as PATA-controller, the secondary channel
acts as SATA-controller in PATA-emulation.
Signed-off-by: Uwe Koziolek [EMAIL PROTECTED]
--- a/drivers/ata/pata_sis.c2007-06-30
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/Kconfig |5
drivers/ata/libata-core.c |3 +-
drivers/ata/pata_pdc2027x.c | 11 -
===
===
The following changes are found in the 'upstream' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
(this is what is queued for 2.6.23 currently)
Alessandro Zummo (1):
[libata] pata_ixp4xx: convert to new EH
Jeff Garzik (13):
[libata] pata_atiixp: add SB700 PCI
I have patches from Alan (pata_sis FIFO whack, pata_dma option), Tejun,
Albert and Kristen still to be reviewed. Will get to those on Friday,
after the July 4th US holiday.tions(-)
Just to be more specific, my to-review inbox contains:
Alan: pata_sis FIFO whack, pata_dma option
Tejun: PMP
Bartlomiej Zolnierkiewicz wrote:
Add the new code inside #ifdef X86, marking alim15x3 X86-only would be
on over-kill...
Ugh. That's not how we do Linux development. It is better to convert
the new code and wait for alpha/sparc users to scream, than add platform
ifdefs. To do so creates
Alan Cox wrote:
I am not ready to trust that pata_ali works as well as alim15x3 in all
cases. Someone should test e.g. Alpha AXP systems with IDE (use
alim15x3) to make sure all is well.
My pata_ali is reported to do so. I don't know if yours does because my
Good to hear, thanks for the
531e3a61f55261bf466d0415c48999511334933c
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Mon Jul 2 18:12:19 2007 -0400
[libata] sata_nv: undo merge error
Only the ADMA entry was supposed to be able to change queue depth.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
drivers/ata/sata_nv.c |1 -
1 file
Tejun Heo wrote:
host-irq and host-irq2 should be set before ata_host_register() for
IRQ reporting to work. Move up host-irq assignment in
ata_host_activate() and add it to ata_pci_init_one() native path and
pata_cs5520.
The port info printing in ata_host_register() doesn't fit all the
Florian Attenberger wrote:
Signed-off-by: Florian Attenberger [EMAIL PROTECTED]
--- 2.6.22-rc6/drivers/ata/sata_mv.c2007-06-30 16:21:47.462020256 +0200
+++ 2.6.22-rc6.mine/drivers/ata/sata_mv.c 2007-06-30 16:25:25.999165444
+0200
@@ -582,6 +582,9 @@ static const struct
Chuck Ebbert wrote:
This patch was found to fix some of the problems with the
pata_ali driver. Is it going to be merged in 2.6.22?
[https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=156482]
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a
Jose Alberto Reguero wrote:
This patch add support to Marvell 6121.
Looking at the code I think that AHCI_FLAG_MV_PATA flag must be assigned to
the PATA port.
Signed-off-by: Jose Alberto Reguero [EMAIL PROTECTED]
applied, thanks
-
To unsubscribe from this list: send the line unsubscribe
Olof Johansson wrote:
CONFIG_PM=n compile fix.
Signed-off-by: Olof Johansson [EMAIL PROTECTED]
---
Hi,
On Sat, May 26, 2007 at 11:09:54PM -0400, Jeff Garzik wrote:
This is checked into the 'mv-ahci-pata' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
Mikael Pettersson wrote:
sil24_interrupt() loads host-ports[i] into a local variable,
validates it, and then loads the value again in the call to
sil24_host_intr(). This patch replaces the second load by a
reference to the local variable.
This is safe since no side-effects have occurred since
Chr wrote:
Hi,
I got a new laptop and I had a little problem that the DVD drive wasn't
recognized by
libata's piix driver (but the old IDE Subsystem found it!!).
So, after adding the new pciid 8086:2850 it works!
But, I don't know if it's ich_pata_100 or ich_pata_133 since the
dvd/cd drives
Tejun Heo wrote:
Update formatting for LLD provided error descriptions such that...
* No default () around it
* Each element is separated by not ,
This change makes each element responsible for putting a space after
itself instead of before - e.g. elem not , elem. This is more
conventional
Tejun Heo wrote:
+++ b/include/linux/libata.h
@@ -322,7 +322,8 @@ enum ata_completion_errors {
AC_ERR_SYSTEM = (1 6), /* system error */
AC_ERR_INVALID = (1 7), /* invalid argument */
AC_ERR_OTHER= (1 8), /* unknown */
-
Tejun Heo wrote:
Convert -scr_read/write callbacks to return error code to better
indicate failure. This will help handling of SCR_NOTIFICATION.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
ACK
but I do not look forward to merging this with #mv-eh :)
[my problem, not yours]
-
To unsubscribe
Tejun Heo wrote:
ahci_save_initial_config() is responsible for reading, screening the
host CAP register and storing the modified result into hpriv-cap for
the rest of the driver. Move ATA_FLAG_NO_NCQ handling into
ahci_save_initial_config(). It's more consistent this way and the
rest of the
Tejun Heo wrote:
ATA_EHI_HOTPLUGGED is a hint for reset functions indicating the the
port might have gone through hotplug/unplug just before entering EH.
Reset functions modify their behaviors a bit to handle the situation
better - e.g. using longer debouncing delay.
Currently, once HOTPLUG is
Tejun Heo wrote:
If SError isn't accessible, EH can't tell whether hotplug has happened
or not. Report SError read failure with AC_ERR_OTHER and schedule
probing with hardreset. This will be mainly useful for PMPs.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-eh.c |6
Matt Sealey wrote:
Yes but the libata driver doesn't check the config register, it checks
the class code, no?
Talking about the end result...
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Andrew Morton wrote:
On Thu, 5 Jul 2007 13:05:30 -0700
Kristen Carlson Accardi [EMAIL PROTECTED] wrote:
+ ATA_DFLAG_IPM = (1 6), /* device supports interface PM */
ATA_DFLAG_CFG_MASK = (1 8) - 1,
I had to bump this to (17), so we've run out.
You can shuffle
Andrew Morton wrote:
I guess we can bump ATA_DFLAG_CFG_MASK up to 12, like this?
Yep
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
of
'ata_fill_sg_dumb' was here
drivers/ata/libata-core.c:4375: error: redefinition of 'ata_dumb_qc_prep'
drivers/ata/libata-core.c:4358: error: previous definition of
'ata_dumb_qc_prep' was here
Cc: Jeff Garzik [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---
drivers/ata/libata-core.c
Sergei Shtylyov wrote:
Hello.
Bartlomiej Zolnierkiewicz wrote:
* Add ATA_PIO[0-6] defines to linux/ata.h.
* Add -pio_mask field to ide_pci_device_t and ide_hwif_t.
* Add PIO masks to host drivers.
Hm, the next logical step would be to use the mask constants in
linux/ata.h for the
Chuck Ebbert wrote:
On 07/06/2007 03:09 PM, Jeff Garzik wrote:
{Maxtor 6B200M0, BANC1BM0, ATA_HORKAGE_NONCQ }
Or should *all* Maxtor 6B200M0 be blacklisted, since there's already
one of them in the list?
Wanna send that as a patch, with attribution and sign-offs? :)
For all
(just to provide my indicator of status)
Andrew Morton wrote:
libata-config_pm=n-compile-fix.patch
that's for a branch that you don't get via libata-dev#ALL, #mv-ahci-pata.
pata_acpi-restore-driver.patch
see Alan's comments. I've been ignoring pata_acpi for a while, because
IMO it
Tejun Heo wrote:
Horkage handling had the following problems.
* dev-horkage was positioned after ATA_DEVICE_CLEAR_OFFSET, so it was
cleared before the device is configured. This broke
HORKAGE_DIAGNOSTIC.
* Some used dev-horkage while others called ata_device_blacklisted()
directly.
[EMAIL PROTECTED] wrote:
From: Alan Cox [EMAIL PROTECTED]
The HPT343/345 (aka 363) is a bit of a warped device. For many setups you
need to access the other registers via BAR4 offsets. PIO is now rock
solid, DMA isn't. Unfortunately the drivers/ide hpt34x driver is
completely broken so
Tejun Heo wrote:
The Zip 250 which chokes on MWDMA SET_XFERMODE sometimes have Floppy
appeneded to its model number. Quirk it too.
http://bugzilla.kernel.org/show_bug.cgi?id=8563
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Cc: Hans de Bruin [EMAIL PROTECTED]
---
It seems the Zip 250 mwdma
Tejun Heo wrote:
Separate out ata_eh_handle_dev_fail() from ata_eh_recover(). This is
in preparation of ata_link and PMP support.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-eh.c | 96 +-
1 files changed, 52 insertions(+), 44
Tejun Heo wrote:
Separate out link initialization into ata_link_init() and
ata_link_init_sata_spd_limit().
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Function name too long :) Drop _limit perhaps.
Anyway, ACK 3-10
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the
Tejun Heo wrote:
Update Power Management to consider PMP links.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
ACK
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of
This patch is diff'd against virgin 2.6.22 kernel, and does not require
any other patches (and indeed no other sata_mv patches should be applied
alongside this one).
Thanks to dean's feedback (and similar feedback from Dave), I think I
killed two key sata_mv bugs, either of which could cause the
dean gaudet wrote:
On Wed, 11 Jul 2007, Jeff Garzik wrote:
As before, this patch is against 2.6.22 with no other patches needed nor
applied.
In this revision, interrupt handling was improved quite a bit,
particularly for EDMA. The WARNING in mv_get_crpb_status() goes away,
because
I just noticed that ipr is still using the old reset and error handling
methods. Once libata-dev.git (#mv-eh, #new-eh) work is merged, ipr is
the last driver that uses old error handling methods. Please look into
upgrading the driver to -error_handler(), -freeze(), -thaw().
Thanks.
Tejun Heo wrote:
The last two slots of MAP 00b of ich6m was incorrectly marked as
reserved. This is left over from converting the entry to allow 00b.
This causes no real problem. It only makes the driver print annoying
warning message. Fix it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
--
Chuck Ebbert wrote:
Add another Maxtor 6B200M0 drive with broken NCQ to the list.
Signed-off-by: Chuck Ebbert [EMAIL PROTECTED]
---
drivers/ata/libata-core.c |1 +
1 file changed, 1 insertion(+)
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of
Albert Lee wrote:
It seems irq_on() in ata_bus_reset() and ata_std_postreset()
are leftover of the EDD reset. Remove them.
Signed-off-by: Albert Lee [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
Tejun Heo wrote:
Extend ata_acpi_associate_sata_port() such that it can handle PMP and
call it when PMP is attached and detached.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Though not your fault, I predict much puking of BIOS code, when PMP are
attached and suspend/whatever ACPI-related. I
Tejun Heo wrote:
Separate out sil24_exec_polled_cmd() from sil24_softreset(). This
will be used to implement sil24_pmp_read/write().
you should order patches like these near the top of the first patchset,
since they are so easy and quick to review and merge.
-
To unsubscribe from this
Tejun Heo wrote:
Separate out sil24_do_softreset() which takes @pmp as its last
argument. This will be used to implement sil24_pmp_softreset().
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
ditto last comment
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of
Tejun Heo wrote:
Separate out stop_engine - CLO - start_engine sequence from
ahci_softreset() and ahci_clo() into ahci_reset_engine() and use it in
ahci_softreset() and ahci_post_internal_cmd(). The function will also
be used to prepare for and clean up after PMP register access
commands.
Tejun Heo wrote:
Separate out ahci_exec_polled_cmd() from ahci_softreset(). This will
be used to implement ahci_pmp_read/write(). ahci_exec_polled_cmd()
performs reset_engine before returning if the command fails (times
out). This is to improve robustness.
Signed-off-by: Tejun Heo [EMAIL
Tejun Heo wrote:
Separate out ahci_do_softreset() which takes @pmp as its last
argument. This will be used to implement ahci_pmp_softreset().
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
ditto
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to
Alan Cox wrote:
Underneath all the HPT packaging, PCI identifiers, binary driver modules
and stuff you find that ...
Signed-off-by: Alan Cox [EMAIL PROTECTED]
--- drivers/ata/sata_mv.c~ 2007-07-09 13:19:57.003052904 +0100
+++ drivers/ata/sata_mv.c 2007-07-09 13:19:57.004052752 +0100
Craig Block wrote:
Linux kernel: version 2.6.22.1
Chipset: VIA VT8363 + VT82C686A
Hard drives: Quantum Fireball LCT10 (UDMA66)
I'm having a problem with the 80-wire/40-wire cable detection in the
ata driver. Even when I configure the kernel with IDEDMA_IVB set, I
still get the 40-wire speed
Fajun Chen wrote:
I wonder if there's an official way to disable hotplug for SATA Sil24?
Not really. We do need to get our act together and figure out how to
export knobs to blktool and similar programs, so that people can
easily control this stuff without resorting to module options.
These patches add proto_mask alongside pio_mask, mwdma_mask, and
udma_mask. This is a more uniform way to export which features host
controllers support (DMA? NCQ? ATAPI? ATAPI DMA?), rather than creating
a new ATA_FLAG_xxx for each.
This also opens the door to useful things like combining if
commit c7baac44f3a02b895873cce48c6e426ddbea06b9
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Sat Jul 14 03:27:11 2007 -0400
[libata] Introduce per-port taskfile protocol masks
One ATA_PMASK_$name bitmapped value exists for each ATA_PROT_$name
value.
-proto_mask member
commit a02791c8298bc0c2202a49c5e781ed2c68132dc8
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Sat Jul 14 04:10:11 2007 -0400
[libata] Use -proto_mask to replace NCQ and NO_ATAPI flags
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
drivers/ata/ahci.c |2 +-
drivers/ata
jm_928 wrote:
Hi,
I have an esata PCMCIA card based on the Initio 1620 chipset. When inserting
this into my Dell D600 laptop (running Ubuntu 7.04 with the 2.6.20-16
kernel) I get the following error messages:
[ 27.66] sata_inic162x :03:00.0: version 0.1
[ 27.66] PCI: Enabling
Paul Mundt wrote:
On Tue, Jul 17, 2007 at 05:33:00AM -0400, Jeff Garzik wrote:
Paul Mundt wrote:
It would be great if libata people could actually be bothered to CC
driver authors on driver changes so that way these things don't get
completely broken in mainline when simple testing
and nothing else.
WYSIWYG. You'll see in the second email why I distinguish the two.
Please pull from 'warnings' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git warnings
Jeff Garzik (11):
kernel/auditfilter: kill bogus uninit'd-var compiler warning
[netdrvr
.
Please pull from 'uninit-var' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git uninit-var
commit 8e1c091cccd551557d24ce845715e8ceb6c49d36
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Tue Jul 17 05:40:59 2007 -0400
arch/i386/* fs/* ipc/*: mark variables
in either case, AFAICS.
I was considering use of uninitialized_var(), but looking at the
complex flow of control in each function, I feel it is wiser and
safer to simply zero the var and be certain of ourselves.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
I don't
Jeff Garzik wrote:
I don't buy that performance argument, in this case. You are already
dirtying the same cacheline with other variable initializations.
Or simply sitting in a CPU register for large stretches of function
runtime...
Jeff
-
To unsubscribe from this list: send
Roland Dreier wrote:
In this case the code is basically
u32 x;
for (n = 0; cond; ++n) {
...
if (!n)
x = something;
...
}
if (n) {
...
use(x);
Greg KH wrote:
On Tue, Jul 17, 2007 at 05:42:39PM -0400, Jeff Garzik wrote:
commit ae97fec3701a559929c3529e35417fab133a4d39
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Tue Jul 17 01:08:29 2007 -0400
drivers/usb/misc/auerswald: fix status check, remove redundant check
1) We
Petr Vandrovec wrote:
On Mon, Jul 16, 2007 at 07:32:57PM +0900, Tejun Heo wrote:
[cc'ing Jeff and Albert]
Petr Vandrovec wrote:
Fix reported task file values in sense data
ata_tf_read was setting HOB bit when lba48 command was submitted, but
was not clearing it before reading normal data.
Chuck Ebbert wrote:
libata: fix last_ctl caching in ata_tf_read()
last_ctl was not cached properly. (Pointed out
by Tejun Heo.)
Signed-off-by: Chuck Ebbert [EMAIL PROTECTED]
---
(Apply after Petr's patch to fix SMART bugs.)
drivers/ata/libata-sff.c |4
1 file changed, 4
Tejun Heo wrote:
Yay, the first one from Seagate. 3.ALC firmware is okay. This was
reported by Sam Freed on bugzilla bug 8759.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Signed-off-by: Sam Freed [EMAIL PROTECTED]
---
drivers/ata/libata-core.c |1 +
1 file changed, 1 insertion(+)
Alexey Dobriyan wrote:
Commit df69c9c5438b4e396a64d42608b2a6c48a3e7475 moved only prototype of
out of CONFIG_PM. Move function out as well. Box seems to boot fine.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/ata/ahci.c | 16
1 file changed, 8 insertions(+),
Akira Iguchi wrote:
This patch fixes some issues of the previous patch:
- Use mode_filter() hook to limit ATAPI UDMA mode
- data loss warning message
- handling of udma_mask
Signed-off-by: Kou Ishizaki [EMAIL PROTECTED]
Signed-off-by: Akira Iguchi [EMAIL PROTECTED]
applied
-
To unsubscribe
su henry wrote:
From: [EMAIL PROTECTED]
The SATA controller device ID is different according to
the onchip SATA type set in the system BIOS:
Device Device ID
SATA in IDE mode 0x4390
SATA in AHCI mode 0x4391
SATA in non-raid5 driver 0x4392
Where does this stand, now that I dove into PMP patchset 1 of 4?
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
their own iomap_name() and
we can add ARCH_HAVE_IOMAP_NAME later as such a platform needs it.
Signed-off-by: Alan Cox [EMAIL PROTECTED]
Cc: Jeff Garzik [EMAIL PROTECTED]
Cc: Tejun Heo [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---
include/asm-generic/iomap.h |5 +
lib
[EMAIL PROTECTED] wrote:
From: Alan Cox [EMAIL PROTECTED]
Use iomap_name() in the libata layer
Signed-off-by: Alan Cox [EMAIL PROTECTED]
Cc: Jeff Garzik [EMAIL PROTECTED]
Cc: Tejun Heo [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
ACK
will await resend when previous patch
Tejun Heo wrote:
SCSI scan may fail due to memory allocation failure even if EH is not
in progress. Due to use of GFP_ATOMIC in SCSI scan path, allocation
failure isn't too rare especially while probing multiple devices at
once which is the case when a bunch of devices are connected to PMP.
Tejun Heo wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
Add @is_cmd to ata_tf_to_fis(). This controls bit 7 of the second
byte which tells the device whether this H2D FIS is for a command or
not. This cleans up ahci a bit and will be used by PMP.
Signed-off-by: Tejun Heo [EMAIL PROTECTED
Tejun Heo wrote:
+extern void ata_tf_to_fis(const struct ata_taskfile *tf,
+ u8 pmp, int is_cmd, u8 *fis);
I'm applying these... but I would like to start seeing 'bool' type used
for arguments like is_cmd, for situations where the only values we
-ever- care about are
Tejun Heo wrote:
Add @is_cmd to ata_tf_to_fis(). This controls bit 7 of the second
byte which tells the device whether this H2D FIS is for a command or
not. This cleans up ahci a bit and will be used by PMP.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/ahci.c| 10
Tejun Heo wrote:
Convert -scr_read/write callbacks to return error code to better
indicate failure. This will help handling of SCR_NOTIFICATION.
This is a welcome improvement, for reasons beyond PMP.
Thanks,
Jeff
-
To unsubscribe from this list: send the line unsubscribe
, as this
patch, buggy or not, includes the changes that will be required to
enable command queueing in sata_mv.
commit 6bef64243c68bf637b5594a0a363d8105efedfa6
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Wed Jul 11 18:56:46 2007 -0400
[libata mv-ncq] sata_mv: Add NCQ support
Currently
or this patch breaks stuff feedback from users
is useful.
Jeff
commit 99ad0b4cd2d73815db6370fa6f89d7053ca21016
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Mon May 28 06:21:45 2007 -0400
[libata] sata_sx4: convert to new EH
Signed-off-by: Jeff Garzik [EMAIL PROTECTED
Alan Cox wrote:
Just one version of Linux ago
The PLL code broke - oh no!
But set the right mode
And fix up the code
Makes the PLL timing sync go
Closes-bug: #8791
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send
Alan Cox wrote:
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.22-rc6-mm1/drivers/ata/pata_ali.c
linux-2.6.22-rc6-mm1/drivers/ata/pata_ali.c
--- linux.vanilla-2.6.22-rc6-mm1/drivers/ata/pata_ali.c 2007-07-02
Tejun Heo wrote:
+ /* Some braindamaged ACPI suspend implementations expect the
+* controller to be awake on entry; otherwise, it burns cpu
+* cycles and power trying to do something to the sleeping
+* beauty.
+*/
applied 1-2... HOWEVER...
I would not
Alan Cox wrote:
A more generalized rule to consider for the future would be to ensure
that ALL suspend routines put the hardware back into its pre-Linux init
mode before suspending. i.e. that means if we turned on some enhanced
mode, we must switch back to legacy mode before calling pci_xxx
Sergei Shtylyov wrote:
Note that the olde driver has MWDMA fixed, and the new one has it
still borken, yet MWDMA2 is the mode you're using.
What about MWDMA is broken?
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL
Please pull
commit fe36cb53cfd82f3c0796a0826e1c9caf198c8f97
Author: Petr Vandrovec [EMAIL PROTECTED]
Date: Fri Jul 20 07:44:44 2007 -0400
[libata] Fix reported task file values in sense data
into the 2.6.22 stable tree.
-
To unsubscribe from this list:
801 - 900 of 1579 matches
Mail list logo
