Re: [PATCH] pata_cmd64x: Correct the speed ranges

2007-07-27 Thread Jeff Garzik
Sergei Shtylyov wrote: Hello. Jeff Garzik wrote: Note that the olde driver has MWDMA fixed, and the new one has it still borken, yet MWDMA2 is the mode you're using. What about MWDMA is broken? The code that sets MWDMA timings is completely bogus -- I've already reported

Re: [PATCH] ide: make CONFIG_IDE_GENERIC default to N

2007-07-27 Thread Jeff Garzik
Tejun Heo wrote: These days, CONFIG_IDE_GENERIC causes more confusion and misconfiguration than it helps. Especially so because libata is linked after the generic driver. Default to N. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ide/Kconfig |4 ++-- 1 file changed, 2

Re: [PATCH 1/4] libata: ACPI checks for 80wire cable

2007-07-27 Thread Jeff Garzik
Alan Cox wrote: We can use the ACPI mode information with several drivers as a hint to cable type. If the ACPI mode set by the BIOS is faster than UDMA33 then we know the BIOS thinks there are 80wire cables. If it doesn't set such a mode or it has no ACPI method then we get no further

Re: [PATCH] ide: make CONFIG_IDE_GENERIC default to N

2007-07-28 Thread Jeff Garzik
Tejun Heo wrote: These days, CONFIG_IDE_GENERIC causes more confusion and misconfiguration than it helps. Especially so because libata is linked after the generic driver. Default to N. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- Aye, aye. drivers/ide/Kconfig |3 +-- 1 file changed, 1

Re: [PATCH] fix IDE legacy mode resource

2007-07-28 Thread Jeff Garzik
Yoichi Yuasa wrote: Hi, I got the following error on MIPS Cobalt. MIPS Cobalt has the 0x1000 offset between resource and bus region. PCI: Unable to reserve I/O region #1:[EMAIL PROTECTED] for device :00:09.1 pata_via :00:09.1: failed to request/iomap BARs for port 0 (errno=-16)

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-30 Thread Jeff Garzik
Kristen Carlson Accardi wrote: @@ -42,6 +42,16 @@ enum scsi_eh_timer_return { EH_RESET_TIMER, }; +/* + * shost pm policy: If you alter this, you also need to alter scsi_sysfs.c + * (for the ascii descriptions) + */ +enum scsi_host_link_pm { + SHOST_NOT_AVAILABLE, +

Re: [PATCH] sata_mv: Test patch for Hightpoint RocketRaid 1740/1742

2007-08-01 Thread Jeff Garzik
Alan Cox wrote: Underneath all the HPT packaging, PCI identifiers, binary driver modules and stuff you find that ... Signed-off-by: Alan Cox [EMAIL PROTECTED] --- drivers/ata/sata_mv.c~ 2007-07-09 13:19:57.003052904 +0100 +++ drivers/ata/sata_mv.c 2007-07-09 13:19:57.004052752 +0100

Re: Early ATA devices

2007-08-01 Thread Jeff Garzik
Alan Cox wrote: #1 We assume identify works. Early ATA actually lists this command as optional ITYM we assume identify command exists on the device? We certainly do not assume IDENTIFY command, if exists, succeeds. What is the proper probing method -- notice if command-aborted is

Re: [PATCH] pata_sis: fix MWDMA for = UDMA66 chipsets and UDMA for UDMA33 chipsets

2007-08-01 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: * Fix MWDMA timings setup in sis_old_set_dmamode() and sis_66_set_dmamode(). The old timings were overclocked (even worse behavior than sis5513 IDE driver which depends on BIOS to program correct timings), the new timings are taken from the datasheet (they

Re: [PATCH] libata: blacklist SAMSUNG HD401LJ / ZZ100-15 for NCQ

2007-08-01 Thread Jeff Garzik
Tejun Heo wrote: SAMSUNG HD401LJ / ZZ100-15 does spurious completion of NCQ commands. Disable NCQ. Reported by Ulrich in bugzilla #8805. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Ulrich [EMAIL PROTECTED] --- And, finally one from samsung. How come vendors got this right previously but

Re: [PATCH] pci: rename __pci_reenable_device() to pci_reenable_device()

2007-08-01 Thread Jeff Garzik
Tejun Heo wrote: Rename __pci_reenable_device() to pci_reenable_device(). Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- Jeff, Greg wanted to drop the preceding underscores before exporting the function and the updated patch was posted but the earlier version was applied. This patch renames

Re: [patch 1/4] Store interrupt value

2007-08-01 Thread Jeff Garzik
Kristen Carlson Accardi wrote: Use a stored value for which interrupts to enable. Changing this allows us to selectively turn off certain interrupts later and have them stay off. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] ACK. Regenerate against current kernel and I'll

Re: [PATCH UPDATED] libata: add support for ATA_16 on ATAPI

2007-08-01 Thread Jeff Garzik
Tejun Heo wrote: From: Mark Lord [EMAIL PROTECTED] Add support for issuing ATA_16 passthru commands to ATAPI devices managed by libata. It requires the previous CDB length fix patch. A boot/module parameter, atapi_scmd85=1 can be used to globally disable this feature, if ever desired. tj:

Re: [PATCH] pata_cmd64x: Correct the speed ranges

2007-08-01 Thread Jeff Garzik
Alan Cox wrote: I must have been half asleep when doing the original code Signed-off-by: Alan Cox [EMAIL PROTECTED] applied to #upstream-fixes - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] libata-sff; Unbreak non DMA capable controllers again

2007-08-01 Thread Jeff Garzik
Alan Cox wrote: Seems nobody else is checking/testing this case as it keeps getting horked. If we have no BAR4 mapping on an SFF controller this is *NOT* an error, it just means it isn't doing BMDMA. Signed-off-by: Alan Cox [EMAIL PROTECTED] applied to #upstream-fixes - To unsubscribe from

[git patches] libata fixes

2007-08-01 Thread Jeff Garzik
The only notable: GregKH wanted the pci_reenable_device() change associated with ata_piix to go in before the release, to avoiding release with an imperfect API. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to

[PATCH] pata_isapnp: use MODULE_DEVICE_TABLE()

2007-08-02 Thread Jeff Garzik
I found this while doing ISDN PCI API conversions... I presume this omission was not intentional? Signed-off-by: Jeff Garzik [EMAIL PROTECTED] diff --git a/drivers/ata/pata_isapnp.c b/drivers/ata/pata_isapnp.c index 5525518..91a396f 100644 --- a/drivers/ata/pata_isapnp.c +++ b/drivers/ata

Re: Libata Sil3124 hybrid drive failure

2007-08-02 Thread Jeff Garzik
Fajun Chen wrote: Does anyone know if libata supports hybrid drive on Sil3124? I tried to play with Seagate hybrid drive and got protocol mismatch error when adding LBAs to pinned set or querying pinned set? Sil24 driver code does not set Protocol Override field in PRB, just wonder if we need

Re: [PATCH] sata_qstor, pdc_adma, sata_sx4: convert to new EH

2007-08-03 Thread Jeff Garzik
Tejun Heo wrote: Jeff Garzik wrote: This is just a refresh of the existing libata-dev.git#new-eh patches that convert all remaining old-EH drivers to new EH, against 2.6.23-rc1. All three conversions are completely untested. pdc_adma and sata_qstor need reviewing by someone with docs

libata git tree, mbox queue status and contents

2007-08-03 Thread Jeff Garzik
This is a quick guide to current libata work that is queued or in progress in some way, shape or form. First, a guide to the branches currently in use in git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git ALL Everything that is exported for testing (and akpm's -mm tree).

Re: [PATCH] libata: implement BROKEN_HPA horkage and apply it to HDS724040KLSA80

2007-08-07 Thread Jeff Garzik
People should check out Ben C's HPA fixes and cleanups, too. (attached) I was hoping one of the original libata HPA authors would review that in depth and integrate. (it no longer applies cleanly) Jeff From: Ben Collins [EMAIL PROTECTED] The original HPA patch that Kyle worked

Re: [PATCH] libata: implement BROKEN_HPA horkage and apply it to HDS724040KLSA80

2007-08-07 Thread Jeff Garzik
Alan Cox wrote: On Tue, 07 Aug 2007 11:47:38 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: People should check out Ben C's HPA fixes and cleanups, too. (attached) I was hoping one of the original libata HPA authors would review that in depth and integrate. (it no longer applies cleanly

Re: [PATCH 1/1] AVR32 PATA driver

2007-08-07 Thread Jeff Garzik
Kristoffer Nyborg Gregertsen wrote: On Tuesday 07 August 2007 17:54:09 Alan Cox wrote: +static int pata_at32_get_pio_mask(void) +{ + switch (max_pio) { + case 0: + return 0x01; + case 1: + return 0x03; + case 2: + return 0x07;

Re: [PATCH 1/2] pata_hpt37x: actually clock HPT374 by 50 MHz DPLL

2007-08-07 Thread Jeff Garzik
Alan Cox wrote: /* Compute DPLL */ - dpll = 2; - if (port-udma_mask 0xE0) - dpll = 3; + dpll = (port-udma_mask 0xC0) ? 3 : 2; Gak, I'd much rather people kept to the nice easy to read if() but fine

Re: [PATCH] ata_piix: update map 10b for ich8m

2007-08-07 Thread Jeff Garzik
Tejun Heo wrote: Fix map entry 10b for ich8. It's [P0 P2 IDE IDE] like ich6 / ich6m. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Kristen Carlson Accardi [EMAIL PROTECTED] --- Many users can be hit by this. Please consider for -stable. Thanks. drivers/ata/ata_piix.c |2 +- 1 file

[git patches] libata fixes

2007-08-07 Thread Jeff Garzik
/ata/sata_mv.c |3 +++ 3 files changed, 6 insertions(+), 1 deletions(-) Alan Cox (1): sata_mv: PCI IDs for Hightpoint RocketRaid 1740/1742 Jeff Garzik (1): [libata] pata_isapnp: replace missing module device table Tejun Heo (1): ata_piix: update map 10b for ich8m diff

Re: [PATCH 1/2] pata_hpt37x: actually clock HPT374 by 50 MHz DPLL

2007-08-07 Thread Jeff Garzik
Alan Cox wrote: On Tue, 07 Aug 2007 20:49:34 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Alan Cox wrote: /* Compute DPLL */ - dpll = 2; - if (port-udma_mask 0xE0) - dpll = 3; + dpll = (port-udma_mask 0xC0) ? 3

Re: libata git tree, mbox queue status and contents

2007-08-08 Thread Jeff Garzik
Mark Lord wrote: Jeff, This patch (below) is needed by WD drives that powerup-in-standby. drivers/ata/libata-core.c~libata-adjust-libata-to-ignore-errors-after drivers/ata/libata-core.c --- a/drivers/ata/libata-core.c~libata-adjust-libata-to-ignore-errors-after +++

Re: [PATCH 01/14] libata-link: introduce ata_link

2007-08-15 Thread Jeff Garzik
Tejun Heo wrote: Introduce ata_link. It abstracts PHY and sits between ata_port and ata_device. This new level of abstraction is necessary to support SATA Port Multiplier, which basically adds a bunch of links (PHYs) to a ATA host port. Fields related to command execution, spd_limit and EH

Re: [PATCH] libata: Correct IORDY handling

2007-08-15 Thread Jeff Garzik
Alan Cox wrote: Debugging a report of a problem with an ancient solid state disk showed up some problems in the IORDY handling 1. We check the wrong bit to see if the device has IORDY 2. Even then some ancient creaking piles of crap don't support SETXFER at all. I think this

Re: [PATCH 1/2] libata: move ata_altstatus() to pio data xfer functions

2007-08-15 Thread Jeff Garzik
Albert Lee wrote: Patch 1/2: Move ata_altstatus() out from ata_hsm_move() to the pio data xfer functions like ata_pio_sectors() and atapi_pio_bytes() where it makes more sense. Signed-off-by: Albert Lee [EMAIL PROTECTED] --- atapi_send_cdb() already calls ata_altstatus() inside. This patch

Re: [PATCH RE-UPDATED] libata: add support for ATA_16 on ATAPI

2007-08-15 Thread Jeff Garzik
Tejun Heo wrote: From: Mark Lord [EMAIL PROTECTED] Add support for issuing ATA_16 passthru commands to ATAPI devices managed by libata. It requires the previous CDB length fix patch. A boot/module parameter, atapi_scmd85=1 can be used to globally disable this feature, if ever desired. tj:

Re: [PATCH] libata-core: Document some limits/assumptions about ID_ATA

2007-08-15 Thread Jeff Garzik
Alan Cox wrote: Signed-off-by: Alan Cox [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libata: Note that our cache flush code needs fixing up

2007-08-15 Thread Jeff Garzik
Alan Cox wrote: Remembered this while doing auditing and code review versus the specs Signed-off-by: Alan Cox [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [patch 24/25] pata_cmd64x: Set up MWDMA modes properly

2007-08-15 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Alan Cox [EMAIL PROTECTED] Set the MWDMA timing by updating the correct registers. Split the PIO path as this is mostly shared code. Wants testing. Signed-off-by: Alan Cox [EMAIL PROTECTED] Tested-by: Mikael Pettersson [EMAIL PROTECTED] Signed-off-by: Andrew

Re: [patch 4/4] libata: send event when AN received

2007-08-15 Thread Jeff Garzik
applied the attached slightly modified patch. main changes: * SCSI stuff has not been applied yet, so libata's notify is a no-op for now * fixed endian bug in SDB FIS handling diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 757369e..c41bd2c 100644 --- a/drivers/ata/ahci.c +++

Re: [patch 2/4] scsi: expose AN support to user space

2007-08-15 Thread Jeff Garzik
Kristen Carlson Accardi wrote: If a scsi_device supports async notification for media change, then let user space know this capability exists by creating a new sysfs entry media_change_notify, which will be 1 if it is supported, and 0 if not supported. Create a routine which allows scsi devices

Re: [patch 1/4] Store interrupt value

2007-08-15 Thread Jeff Garzik
Kristen Carlson Accardi wrote: Use a stored value for which interrupts to enable. Changing this allows us to selectively turn off certain interrupts later and have them stay off. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] applied, after adding ahci: prefix to subject line

Re: [PATCH] pata_artop: fix UDMA5 for AEC6280[R] and UDMA6 for AEC6880[R]

2007-08-15 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: Maximum supported UDMA mode for AEC6280[R] is UDMA5 (not UDMA4) and for AEC6880[R] it is UDMA6 (not UDMA5): * Fix the problem by adding missing struct ata_port_info to artop_init_one(). * Use the right naming (s/626/628/). * Bump driver version. Fixes

Re: [PATCH 1/2] pata_hpt37x: actually clock HPT374 with 50 MHz DPLL (take 2)

2007-08-15 Thread Jeff Garzik
Sergei Shtylyov wrote: The DPLL tuning code always set up it for 66 MHz due to wrong UltraDMA mask including mode 5 used to check for the necessity of 66 MHz clocking -- this caused 66 MHz clock to be used for HPT374 chip that does not tolerate it. While fixing this, also remove PLL mode from

Re: [PATCH] ata_piix: add TECRA M7 to broken suspend list

2007-08-15 Thread Jeff Garzik
Tejun Heo wrote: Add TECRA M7 to broken suspend list. Reported by Marie Koreen. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Marie Koreen [EMAIL PROTECTED] --- drivers/ata/ata_piix.c |7 +++ 1 file changed, 7 insertions(+) applied to #upstream-fixes - To unsubscribe from this

Re: [patch 25/25] ata_piix: disallow UDMA 133 on ICH5 ICH7

2007-08-15 Thread Jeff Garzik
the safety of the patch patch: http://lkml.org/lkml/2007/7/6/292 (It was already tested by an Intel employee, but I guess a bit more user input is necessary here... ) This patch implements 1. Cc: Alan Cox [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Cc: Tejun Heo [EMAIL PROTECTED] Signed-off

Re: [patch 04/25] libata-add-irq_flags-to-struct-pata_platform_info-fix

2007-08-15 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Remove unneeded, undesirable cast of void*. Cc: Jeff Garzik [EMAIL PROTECTED] Cc: Sonic Zhang [EMAIL PROTECTED] Cc: Tejun Heo [EMAIL PROTECTED] Cc: Alan Cox [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED

Re: [PATCH libata-dev#upstream 3/3] libata: implement and use ata_port_desc() to report port configuration

2007-08-15 Thread Jeff Garzik
Tejun Heo wrote: Currently, port configuration reporting has the following problems. * iomapped address is reported instead of raw address * report contains irrelevant fields or lacks necessary fields for non-SFF controllers. * host-irq/irq2 are there just for reporting and hacky. This patch

Re: [PATCH libata-dev#upstream 1/3] libata: use ata_port_printk() in ata_wait_idle()

2007-08-15 Thread Jeff Garzik
Tejun Heo wrote: ata_wait_idle() identified controller by printing out the address of the Status register. This is bogus because 1. it's iomapped address 2. some controllers don't have Status register and don't initialize the field. Use ata_port_printk() instead. Signed-off-by: Tejun Heo

Re: [PATCH libata-dev#upstream 2/2] libata: move EH repeat reporting into ata_eh_report()

2007-08-15 Thread Jeff Garzik
Tejun Heo wrote: EH is sometimes repeated without any error or action. For example, this happens when probing IDENTIFY fails because of a phantom device. In these cases, all the repeated EH does is making sure there is no unhandled error or pending action and return. This repeation is

[git patches] libata fixes

2007-08-15 Thread Jeff Garzik
1740/1742 Bartlomiej Zolnierkiewicz (1): pata_artop: fix UDMA5 for AEC6280[R] and UDMA6 for AEC6880[R] Jeff Garzik (1): [libata] pata_isapnp: replace missing module device table Ryan Power (1): libata: adjust libata to ignore errors after spinup Sergei Shtylyov (2

Re: [PATCH 3/4] libata: ACPI checks for 80wire cable

2007-08-16 Thread Jeff Garzik
Alan Cox wrote: We can make use of this on the pata_amd driver as many Nvidia devices don't have reliable cable detect. Signed-off-by: Alan Cox [EMAIL PROTECTED] applied 3-4 - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED]

Re: [PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-16 Thread Jeff Garzik
Sonic Zhang wrote: Update: 1. Condition branch code instead of while loop from Alan Cox. 2. Condtinue in PIO mode after failing to request DMA. Signed-off-by: Sonic Zhang [EMAIL PROTECTED] --- drivers/ata/Kconfig | 28 + drivers/ata/Makefile |1 drivers/ata/pata_bf54x.c | 1581

Re: [PATCHSET #upstream-fixes] libata: update HPA handling

2007-08-16 Thread Jeff Garzik
Tejun Heo wrote: Hello, The current HPA handling implementation isn't robust enough and causes regressions on several cases. This patchset contains HPA handling update. * blacklist devices which puke on READ_NATIVE_MAX * proper/better error handling - in most cases, HPA failure won't result

Re: [PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-16 Thread Jeff Garzik
Mike Frysinger wrote: On 8/16/07, Jeff Garzik [EMAIL PROTECTED] wrote: Sonic Zhang wrote: +static void bfin_set_piomode(struct ata_port *ap, struct ata_device *adev) +{ + int mode = adev-pio_mode - XFER_PIO_0; + unsigned long base = (unsigned long)ap-ioaddr.ctl_addr; (added Bryan Wu

Re: [PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-16 Thread Jeff Garzik
Mike Frysinger wrote: On 8/16/07, Jeff Garzik [EMAIL PROTECTED] wrote: Mike Frysinger wrote: On 8/16/07, Jeff Garzik [EMAIL PROTECTED] wrote: Sonic Zhang wrote: +static void bfin_set_piomode(struct ata_port *ap, struct ata_device *adev) +{ + int mode = adev-pio_mode - XFER_PIO_0

Re: [PATCH] libata-core: support wildcard matching in ata_blacklist_entry

2007-08-16 Thread Jeff Garzik
Alan Cox wrote: On Wed, 8 Aug 2007 15:20:57 -0500 David Milburn [EMAIL PROTECTED] wrote: Support the use of '*' in model_num and model_rev entries in ata_device_blacklist[]. CC: [EMAIL PROTECTED] Signed-off-by: David Milburn [EMAIL PROTECTED] Suggestion: Pull the match function out of line

Re: [PATCH 1/1] libata: pata_pdc2027x PLL input clock fix

2007-08-16 Thread Jeff Garzik
Mikael Pettersson wrote: (cc:ing linuxppc-dev) On Tue, 26 Jun 2007 13:43:15 +0800, Albert Lee wrote: Recently the PLL input clock of pata_pdc2027x is sometimes detected higer than expected (e.g. 20.027 MHz compared to 16.714 MHz). It seems sometimes the mdelay() function is not as precise as

Re: [PATCH] libata: kill sector_buf temporary buffer

2007-08-16 Thread Jeff Garzik
*Thats* why I left the patch aside and didn't commit it... :) Thanks for the reminder, Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2.6.23-rc3] pata_pdc2027x: PLL detection fixes

2007-08-18 Thread Jeff Garzik
Mikael Pettersson wrote: Previously I reported that the pata_pdc2027x PLL detection changes in kernel 2.6.22 broke the driver on my PowerMac: pata_pdc2027x: Invalid PLL input clock 1691742kHz, give up! This is followed by a number of errors and speed reduction steps on the affected ports.

Re: [PATCH 2.6.23-rc3] pata_pdc2027x: PLL detection fixes

2007-08-18 Thread Jeff Garzik
Albert Lee wrote: The first rmb() is to make sure bccrl is read before bccrlv for later (bccrl = bccrlv) check since both reading the same memory address. That's already guaranteed without the rmb(), AFAICS. Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide

Re: [PATCH 2.6.23-rc3] pata_pdc2027x: PLL detection fixes

2007-08-19 Thread Jeff Garzik
Sergei Shtylyov wrote: What have really surpried me about Promise was that they gave their SATA chip docs to Jeff who made them public and yet they continue to conceal the old PATA chip docs... :-/ They probably just need to be poked. I've been sitting on the sata_sx4 docs and cards,

Re: no need to add new DID's to AHCI driver?

2007-08-22 Thread Jeff Garzik
Gaston, Jason D wrote: Hello, Now that the AHCI driver has support for all controllers with the 0x0106 (AHCI) class code, I am not planning on adding controller DeviceID's for AHCI controllers. I want to verify that this is the correct course of action. Note: I still will have to add the

Re: [PATCH #upstream-fixes] libata: fix n_sectors failure handling during revalidation

2007-08-23 Thread Jeff Garzik
Tejun Heo wrote: If revalidation fails because device has different n_sectors after configuration the original n_sectors should be restored before failing revalidation. Without this fix, n_sectors difference will incorrectly and silently pass revalidation when revalidation is retried.

Re: [PATCH] pata_marvell: Add another PCI identifier

2007-08-23 Thread Jeff Garzik
Alan Cox wrote: Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc3-mm1/drivers/ata/pata_marvell.c linux-2.6.23rc3-mm1/drivers/ata/pata_marvell.c --- linux.vanilla-2.6.23rc3-mm1/drivers/ata/pata_marvell.c

Re: [PATCH] pata_sis: Add the FSC Amilo and friends

2007-08-23 Thread Jeff Garzik
Alan Cox wrote: More short cables Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc3-mm1/drivers/ata/pata_sis.c linux-2.6.23rc3-mm1/drivers/ata/pata_sis.c --- linux.vanilla-2.6.23rc3-mm1/drivers/ata/pata_sis.c

Re: [PATCH] pata_via: Add Armia W730-K8 and other rebadgings

2007-08-23 Thread Jeff Garzik
Alan Cox wrote: More cable funnies Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc3-mm1/drivers/ata/pata_via.c linux-2.6.23rc3-mm1/drivers/ata/pata_via.c --- linux.vanilla-2.6.23rc3-mm1/drivers/ata/pata_via.c

Re: [PATCH #upstream-fixes] libata: don't check n_sectors during revalidation if zero

2007-08-23 Thread Jeff Garzik
Tejun Heo wrote: If the initial configuration fails early, n_sectors is left at zero. Checking against it during revalidation makes retried configuration fail due to n_sectors mismatch. Ignore zero n_sectors during revalidation. Signed-off-by: Tejun Heo [EMAIL PROTECTED] ---

[git patches] libata fixes

2007-08-23 Thread Jeff Garzik
Fixes + more laptop IDs Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/libata-core.c |7 ++- drivers/ata/pata_pdc2027x.c | 18 +-

Re: Should sata_mv work with Highpoint RocketRAID 2300?

2007-08-24 Thread Jeff Garzik
Karim 'Kasi Mir' Senoucci wrote: Alan Cox schrieb: in the sata_mv source. Should I add something like: { PCI_VDEVICE(TTI, 0x2300), chip_604x }, Yes Just to not leave this thread hanging in the mail archives: this didn't work for me. With the above patch, the controller is

Re: readXs on pci*iomap-ped regions [Was: [PATCH] /drivers/char sx.c ioremap - pci_ioremap api]

2007-08-25 Thread Jeff Garzik
If the driver knows its MMIO, using readX/writeX after pci_iomap() is just fine, for all current implementations, and it makes sense that way. Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCHSET #upstream-fixes] libata: update HPA handling

2007-08-28 Thread Jeff Garzik
Tejun Heo wrote: Tejun Heo wrote: Jeff Garzik wrote: Tejun Heo wrote: Hello, The current HPA handling implementation isn't robust enough and causes regressions on several cases. This patchset contains HPA handling update. * blacklist devices which puke on READ_NATIVE_MAX * proper/better

Re: ATAPI tape drives broken with libata

2007-08-29 Thread Jeff Garzik
Chuck Ebbert wrote: https://bugzilla.redhat.com/show_bug.cgi?id=243568 Using kernel 2.6.22: Aug 29 17:08:11 itox kernel: ata2.00: ATAPI: Seagate STT8000A, 5.51, max MWDMA2 Aug 29 17:08:11 itox kernel: ata2.00: configured for MWDMA2 Aug 29 17:08:11 itox kernel: scsi 1:0:0:0: Sequential-Access

Re: Port Multiplier Patch 2.6.22.1 on Alpha

2007-08-29 Thread Jeff Garzik
Tom Evans wrote: Have you heard of such and issue with the 3124-2/4276 combination? Is anyone else trying this driver on an Alpha? Alpha should not be operationally much different from other little endian 64-bit platforms. The PCI swizzle might be weird (what is your Alpha platform?), is

Re: [PATCH] libata-core: Allow translation setting to fail

2007-08-31 Thread Jeff Garzik
Alan Cox wrote: On some early drives (pre ATA1) this feature is not supported. If it fails then we know the drive geometry is the hardware geometry and the one we tried to set anyway so just carry on. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from

Re: [PATCH 2.6.23-rc4][reRESEND] ata_piix: IDE mode SATA patch for Intel Tolapai

2007-08-31 Thread Jeff Garzik
In the future, consider following the information convention we have for patch revisions: [PATCH 2.6.23-rc4] ata_piix: do some stuff [PATCH 2.6.23-rc4 v2] ata_piix: do some stuff [PATCH 2.6.23-rc4 v3] ata_piix: do some stuff [PATCH 2.6.23-rc4 v4] ata_piix: do

Re: [PATCH 2.6.23-rc4][reRESEND] ahci: RAID mode SATA patch for Intel Tolapai

2007-08-31 Thread Jeff Garzik
Jason Gaston wrote: Resend trying to remove 8-bit characters in the email. This patch adds the Intel Tolapai RAID controller DID's for SATA support. Signed-off-by: Jason Gaston [EMAIL PROTECTED] --- linux-2.6.23-rc4/drivers/ata/ahci.c.orig2007-08-27 18:32:35.0 -0700 +++

Re: [PATCH 2.6.23-rc4][reRESEND] ata_piix: IDE mode SATA patch for Intel Tolapai

2007-08-31 Thread Jeff Garzik
Jason Gaston wrote: Resend trying to remove 8-bit characters in the email. This patch adds the Intel Tolapai IDE mode SATA controller DID's. Signed-off-by: Jason Gaston [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message

Re: [PATCH] pata_marvell: Add more identifiers

2007-08-31 Thread Jeff Garzik
Alan Cox wrote: This replaces the patch which incorrectly removed the 6145 Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc3-mm1/drivers/ata/pata_marvell.c linux-2.6.23rc3-mm1/drivers/ata/pata_marvell.c ---

Re: [PATCH #upstream-fixes] ata_piix: add Satellite U200 to broken suspend list

2007-08-31 Thread Jeff Garzik
Tejun Heo wrote: Satellite U200 also shares the problem. Add it to the broken suspend list. Original patch from John Schember. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: John Schember [EMAIL PROTECTED] --- drivers/ata/ata_piix.c |7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [PATCH 8/8] ata: add ATA_MWDMA* and ATA_SWDMA* defines

2007-08-31 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- include/linux/ata.h | 13 + 1 file changed, 13 insertions(+) Index: b/include/linux/ata.h

Re: [PATCH 2.6.23-rc4] sata_promise: FastTrack TX4200 is a second-generation chip

2007-08-31 Thread Jeff Garzik
Mikael Pettersson wrote: This patch corrects sata_promise to classify FastTrack TX4200 (DID 3515/3519) as a second-generation chip. Promise's partial- source FT TX4200 driver confirms this classification. Treating it as a first-generation chip causes several problems: 1. Detection failures.

Re: [PATCH #upstream-fixes] libata: implement BROKEN_HPA horkage and apply it to affected drives

2007-08-31 Thread Jeff Garzik
Tejun Heo wrote: Some drives choke on READ_NATIVE_MAX_ADDRESS[_EXT]. Implement ATA_HORKAGE_BROKEN_HPA and apply it to affected drives. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- MAXTOR 6L080L4 added from bugzilla bug 7119. drivers/ata/libata-core.c | 11 ---

[git patches] libata fixes

2007-08-31 Thread Jeff Garzik
: IDE mode SATA patch for Intel Tolapai Jeff Garzik (1): [libata] Bump driver versions Mikael Pettersson (1): sata_promise: FastTrack TX4200 is a second-generation chip Tejun Heo (3): ata_piix: add Satellite U200 to broken suspend list libata: implement BROKEN_HPA horkage

Re: [PATCH 1/2 #upstream] libata: udpate ata_dev_try_classify() arguments

2007-08-31 Thread Jeff Garzik
Tejun Heo wrote: Make ata_dev_try_classify() take a pointer to ata_device instead of ata_port/port_number combination for consistency and add @present argument. @present indicates whether the device seems present during reset. It's the result of TF access during softreset and link onlineness

Re: [PATCH] libata: Switch most of the remaining SFF drivers to ata_sff_port_start

2007-08-31 Thread Jeff Garzik
Alan Cox wrote: This avoids allocating DMA buffers if not needed but at the moment is mostly just a neatness item. Signed-off-by: Alan Cox [EMAIL PROTECTED] applied sans pata_acpi change, which is because pata_acpi is not in libata-dev.git#upstream - To unsubscribe from this list: send

Re: [PATCH] libata: Strict checking for identify reporting

2007-08-31 Thread Jeff Garzik
Alan Cox wrote: The ATA specifications require checks on certain flags before assuming the validity of other data. Go through the methods and correct those needing extra checks. Also note limits on ata_id_major_version with respect to ATA-1 and ATA-2. Correct the 32bit PIO check. Wants to sit

Re: [PATCH 2.6.23-rc3] libata: pata_pdc2027x PLL detection minor cleanup

2007-08-31 Thread Jeff Garzik
Albert Lee wrote: Minor cleanup to remove the unneeded rmb()s per Jeff's advice. Also removed the pll_clock 0 check since pll_clock now guaranteed to be = 0 after Mikael's patch. Signed-off-by: Albert Lee [EMAIL PROTECTED] --- Tested ok on both x86 and ppc64, together with Mikael's patch.

Re: [PATCH libata-dev#upstream 3/3 REGENERATED] libata: implement and use ata_port_desc() to report port configuration

2007-08-31 Thread Jeff Garzik
Tejun Heo wrote: Currently, port configuration reporting has the following problems. * iomapped address is reported instead of raw address * report contains irrelevant fields or lacks necessary fields for non-SFF controllers. * host-irq/irq2 are there just for reporting and hacky. This patch

Re: [PATCH libata-dev#upstream REGENERATED] libata: move EH repeat reporting into ata_eh_report()

2007-08-31 Thread Jeff Garzik
Tejun Heo wrote: EH is sometimes repeated without any error or action. For example, this happens when probing IDENTIFY fails because of a phantom device. In these cases, all the repeated EH does is making sure there is no unhandled error or pending action and return. This repeation is

Re: [PATCH] libata-portmap: Remove unused definitions

2007-08-31 Thread Jeff Garzik
Alan Cox wrote: With the PCI layer properly handling legacy IDE and the kernel now using it these can go Signed-off-by: Alan Cox [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 1/1] AVR32 PATA driver

2007-08-31 Thread Jeff Garzik
Kristoffer Nyborg Gregertsen wrote: Updated and simplified driver. Use only register transfer timing for both data and register transfers. This gives poorer performance in PIO1 and 2, but should not be a problem in PIO3 and 4, correct me if I'm wrong :) The driver works very we'll but I still

Re: [PATCH take #6] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-31 Thread Jeff Garzik
Sonic Zhang wrote: Fix all issues pointed out in Jeff's email. Acked-by: Alan Cox [EMAIL PROTECTED] Signed-off-by: Sonic Zhang [EMAIL PROTECTED] --- drivers/ata/Kconfig | 16 drivers/ata/Makefile |1 drivers/ata/pata_bf54x.c | 1627

Re: sata_via: write errors on PATA drive connected to VT6421

2007-09-01 Thread Jeff Garzik
Ondrej Zary wrote: Hello, I think that I've found and fixed the problem. There is a copy/paste bug in vt6421_set_dma_mode() function which causes wrong values to be written to PATA_UDMA_TIMING register. This patch fixes a copy/paste bug that breaks DMA modes on VT6421 PATA port.

Re: [PATCH] sata_mv: Test patch for Hightpoint RocketRaid 1740/1742

2007-09-01 Thread Jeff Garzik
Krzysztof Oledzki wrote: On 2007-08-01 17:46, Alan Cox wrote: On Wed, 01 Aug 2007 09:49:19 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Alan Cox wrote: Underneath all the HPT packaging, PCI identifiers, binary driver modules and stuff you find that ... Signed-off-by: Alan Cox [EMAIL

[PATCH] drivers/firmware: const-ify DMI API and internals

2007-09-01 Thread Jeff Garzik
commit 457b6eb3bf3341d2e143518a0bb99ffbb8d754c4 Author: Jeff Garzik [EMAIL PROTECTED] Date: Sat Sep 1 10:16:45 2007 -0400 drivers/firmware: const-ify DMI API and internals Three main sets of changes: 1) dmi_get_system_info() return value should have been marked const

Re: [PATCH] drivers/firmware: const-ify DMI API and internals

2007-09-01 Thread Jeff Garzik
Greg KH wrote: On Sat, Sep 01, 2007 at 10:27:19AM -0400, Jeff Garzik wrote: commit 457b6eb3bf3341d2e143518a0bb99ffbb8d754c4 Author: Jeff Garzik [EMAIL PROTECTED] Date: Sat Sep 1 10:16:45 2007 -0400 drivers/firmware: const-ify DMI API and internals Three main sets of changes

[git patches] libata critical fixes

2007-09-02 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/ata_piix.c |5 - drivers/ata/sata_via.c |2 +- 2 files changed, 5 insertions(+), 2 deletions(-) Jeff Garzik

Re: [PATCH 5/13] ide: add IDE_HFLAG_ERROR_STOPS_FIFO host flag

2007-09-06 Thread Jeff Garzik
On Wed, Sep 05, 2007 at 11:52:57PM +0200, Bartlomiej Zolnierkiewicz wrote: Add IDE_HFLAG_ERROR_STOPS_FIFO host flag and use it instead of hwif-err_stops_fifo. As a side-effect this change fixes hwif-err_stops_fifo not being restored by ide_hwif_restore(). Signed-off-by: Bartlomiej

Re: [PATCH 2.6.23-rc4][reRESEND] ahci: RAID mode SATA patch for Intel Tolapai

2007-09-07 Thread Jeff Garzik
Gaston, Jason D wrote: -Original Message- From: Gaston, Jason D Sent: Friday, August 31, 2007 10:10 AM To: 'Jeff Garzik' Cc: linux-ide@vger.kernel.org; [EMAIL PROTECTED] Subject: RE: [PATCH 2.6.23-rc4][reRESEND] ahci: RAID mode SATA patch for Intel Tolapai This device has both AHCI

Re: [RFT][PATCH v7] sata_mv: convert to new EH

2007-09-07 Thread Jeff Garzik
dean gaudet wrote: On Fri, 13 Jul 2007, greg wrote: dean gaudet dean at arctic.org writes: if you've got any other workload you'd like me to throw at it, let me know. I've had a few problems with the driver in 2.6.20 (fc6xen x86_64). The machine tended to lock up after a random period of

Re: [PATCH] libata: Add a drivers/ide style DMA disable

2007-09-07 Thread Jeff Garzik
Tejun Heo wrote: Alan Cox wrote: This is useful when debugging, handling problem systems, or for distributions just to get the system installed so it can be sorted out later. This is a bit smarter than the old IDE one and lets you do libata.pata_dma=0 Disable all PATA DMA like

Re: ICH Intel PATA short cable override...

2007-09-07 Thread Jeff Garzik
Mark Lord wrote: Ditto for selecting transfer modes. Waiting on one thing AFAICS: ability to drain/idle all ports + issue a command on one port + resume normal parallel port operation SET FEATURES - XFER MODE is special in that it requires all sorts of additional

Re: [PATCH 2.6.23-rc4][reRESEND] ata_piix: IDE mode SATA patch for Intel Tolapai

2007-09-07 Thread Jeff Garzik
Gaston, Jason D wrote: -Original Message- From: Jeff Garzik [mailto:[EMAIL PROTECTED] Sent: Friday, August 31, 2007 12:51 AM To: Gaston, Jason D Cc: linux-ide@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: Re: [PATCH 2.6.23-rc4][reRESEND] ata_piix: IDE mode SATA patch

<    5   6   7   8   9   10   11   12   13   14   >