Pierre Tardy wrote:
The map for ich6m chip had a typo, which caused to output a harmless
error at boot.
Signed-off-by: Pierre Tardy [EMAIL PROTECTED]
Acked-by: Tejun Heo [EMAIL PROTECTED]
--
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body
.
This was fixed recently by the following commit.
Commit: 551c012d7eea3dc5ec063c7ff9c718d39e77634f
Author: Tejun Heo [EMAIL PROTECTED] 2006-12-12 20:17:32
Committer: Jeff Garzik [EMAIL PROTECTED] 2006-12-17 00:13:29
Branches: upstream-fixes, upstream, quilt-init
Follows: v2.6.19
Precedes:
[PATCH] ahci: do
'hdparm -I' doesn't work with ATAPI devices and sg_sat is not widely
spread yet leaving no easy way to access ATAPI IDENTIFY data.
Implement HDIO_GET_IDENTITY such that at least 'hdparm -i' works.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-scsi.c | 43
The last one was 3/3 of course.
--
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Mark Lord wrote:
Tejun Heo wrote:
'hdparm -I' doesn't work with ATAPI devices and sg_sat is not widely
spread yet leaving no easy way to access ATAPI IDENTIFY data.
Implement HDIO_GET_IDENTITY such that at least 'hdparm -i' works.
Mmm.. I still think this old ioctl is ugly, and I'd rather
Art Haas wrote:
Hi.
I wanted to try the two patches you've sent against the current
2.6.20-rc3, but there have been numerous changes to the files
so neither patch can apply cleanly. I'm not familiar enough
with the libata to try and make similar changes to the current
files to match your
Matthew Stapleton wrote:
Tejun Heo wrote:
Please apply the attached patch over 2.6.19 and report what the kernel says.
Thanks.
I got the following errors during the timeout when running hald:
ata1.01: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata1.01: cmd a0/00:00:00:00
bbee wrote:
Yeap, I have major issues with SDB FISes which contains spurious
completions but most other spurious interrupts shouldn't be dangerous
and I haven't seen spurious completions for quite some time, so I was
thinking either removing the message or printing it only on SDB FIS
Jeff Garzik wrote:
+ * - ATA disks work.
+ * - Hotplug works.
+ * - ATAPI read works but burning doesn't. This thing is really
+ * peculiar about ATAPI and I couldn't figure out how ATAPI PIO and
+ * ATAPI DMA WRITE should be programmed. If you've got a clue, be
+ * my guest.
+ * -
Driver for Initio 162x SATA controllers. ATA r/w, ATAPI r, hotplug
and suspend/resume work. ATAPI w (recording, that is) broken. Feel
free to fix it, but be warned, this controller is weird.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
* Modified as advised by Jeff.
* Made config option
bbee wrote:
Sorry, I thought you meant you would need to update it *further*. I
applied the patch you gave to Andrew with this result so far:
$ dmesg | grep -A1 spurious interrupt
ata1: spurious interrupt (irq_stat 0x8 active_tag 0xfafbfcfd sactive 0x0)
ata1: issue=0x0 SAct=0x0
Andrew Lyon wrote:
Is there anything more I can do to assist? I plan to upgrade to
2.6.19/latest at the weekend, let me know if there is anything more i
can do.
WD740ADFD-00 is blacklisted for NCQ in .20-rcX kernels, so you won't see
the problem anymore there. If you're gonna use 2.6.19, you
Bjorn Wesen wrote:
Just adding some info here!
I added this to the bottom of ata_interrupt in libata-core.c which fixed
the problem:
if(!handled) {
printk(ata_interrupt nobody cared. Trying to clear irq src\n);
for (i = 0; i host-n_ports; i++) {
Brad Fitzpatrick wrote:
Tejun,
(I wanted to send this to linux-ide, but vger's majordomo isn't replying
to me. Feel free to cc: the list...)
Just cc'ing linux-ide@vger.kernel.org is enough. (done)
Disks in DS-1220 show up, kinda, but don't work. Errors reading /
writing blocks. Tried
Jeff Garzik wrote:
Tejun Heo wrote:
'hdparm -I' doesn't work with ATAPI devices and sg_sat is not widely
spread yet leaving no easy way to access ATAPI IDENTIFY data.
Implement HDIO_GET_IDENTITY such that at least 'hdparm -i' works.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Are you
Hello,
[cc'ing lkml and linux-ide]
Philippe Grenard wrote:
To close this problem, here are the latest news :
I just bought some new power supply, and the problem has gone...
Maybe that was due to poor power flow or crappy connexion ?...
now everything seems to work well, so as suspected,
From: J J [EMAIL PROTECTED]
In Acer Aspire hdd is connected to ICH7 via 40c cable, however it is
short cable and it is UDMA66 capable.
Signed-off-by: J J [EMAIL PROTECTED]
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index 7959e4c
Hello,
This is the second take of devres patchset. Changes from the last
take[L] are...
* generic managed iomap interface functions implemented
- devm_ioport_map/unmap()
- devm_ioremap[_nocache](), devm_iounmap()
* libata-sff legacy mode now uses generic managed iomap interface
Implement managed DMA interface - dmam_alloc_coherent(),
dmam_free_coherent(), dmam_declare_coherent_memory(),
dmam_pool_create() and dmam_pool_destroy(). Except for being managed,
these take the same arguments and have the same effect as non-managed
counterparts.
Signed-off-by: Tejun Heo [EMAIL
Implement managed IRQ interface - devm_request_irq() and
devm_free_irq(). Except for the first @dev argument and being
managed, these take the same arguments and have the same effect as
non-managed coutnerparts.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
include/linux/interrupt.h |6
-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/pci/pci.c | 127 ++-
include/linux/pci.h |9
2 files changed, 135 insertions(+), 1 deletions(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 6bfb942..2ab2f8a 100644
--- a/drivers/pci
Implement pcim_iomap_regions(). This function takes mask of BARs to
request and iomap. No BAR should have length of zero. BARs are
iomapped using pcim_iomap_table().
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
include/linux/io.h |2 +
lib/iomap.c| 53
Implement ata_host_detach() which calls ata_port_detach() for each
port in the host and export it. ata_port_detach() is now internal and
thus un-exported. ata_host_detach() will be used as the 'deregister
from libata layer' function after devres conversion.
Signed-off-by: Tejun Heo [EMAIL
Now that all LLDs are converted to use devres, default stop callbacks
are unused. Remove them.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c | 81 +++-
include/linux/libata.h|4 --
2 files changed, 6 insertions(+), 79
Kovid Goyal wrote:
ata3: SATA max UDMA/133 cmd 0xFE00 ctl 0xFE12 bmdma 0xFEA0 irq 17
ata4: SATA max UDMA/133 cmd 0xFE20 ctl 0xFE32 bmdma 0xFEA8 irq 17
scsi2 : ata_piix
scsi3 : ata_piix
Hmmm... ata3.00 was /dev/sda1. Presence testing seems to have failed.
Please give a shot at 2.6.20-rc4. We
Mike Accetta wrote:
Here's a bit more information on these timeouts. I noticed a mention
of changing the command queue depth in a recent lkml post and decided
to give that a whirl.
This problem seems to be related to the depth of the queue. When I
set the value for
4658f79bec0b51222e769e328c2923f39f3bda77
Author: Tejun Heo [EMAIL PROTECTED]
Date: Wed Mar 22 21:07:03 2006 +0900
[PATCH] ahci: add softreset
Now that libata is smart enought to handle both soft and hard resets,
add softreset method.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Signed-off
Matthew Stapleton wrote:
Tejun Heo wrote:
Can you try the attached patch over 2.6.19 and report full dmesg? Thanks.
--
tejun
Attached is my full dmesg.
Does the problem still persist?
--
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body
such that more info can be reported while not
disturbing users too much.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 5998f74..00c6bcc 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -75,6 +75,7 @@ enum {
AHCI_CMD_CLR_BUSY
kenneth johansson wrote:
I changed my bios setting for SATA from IDE to AHCI.
This resulted in some interesting read throughput.
plots can be found at http://kenjo.org/~ken/sata/
The plots was done on a live disk so some noise is expected but in the
ahci mode the throughput get stuck at
kenneth johansson wrote:
On Mon, 2007-01-15 at 18:13 +0900, Tejun Heo wrote:
kenneth johansson wrote:
I changed my bios setting for SATA from IDE to AHCI.
This resulted in some interesting read throughput.
plots can be found at http://kenjo.org/~ken/sata/
The plots was done on a live disk
Jordan Neumeyer wrote:
Well recently I've been using libata since my my distribution offered it when
they switched to 2.6.19( maybe? 18) in the initramfs image. I have a sis 5513
controller, which after a couple of days started acting up and coming up with
the following error:
sg_write:
From: Luca Pedrielli [EMAIL PROTECTED]
Add PCI ID 0x5337 to supported PCI ID. This is VT8237 in IDE mode.
Signed-off-by: Luca Pedrielli [EMAIL PROTECTED]
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
Luca, I formatted the patch in the form Jeff can take. Please format
patches like this next
Some uli controllers have stuck SIMPLEX bit which can't be cleared
with ata_pci_clear_simplex(), but the controller is capable of doing
DMAs on both channels simultaneously. Ignore it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
diff --git a/drivers/ata/sata_uli.c b/drivers/ata/sata_uli.c
index
Matthew Stapleton wrote:
Tejun Heo wrote:
Does the problem still persist?
With that kernel and the previous patches it does. I'll try kernel
2.6.20-rc5
and the which-cocktail-2.6.19.patch
I got confused between your report and Jan's. Yours (not so sure about
Jan's) seems to be drive
Jan Gutter wrote:
On Tue, 2007-01-16 at 17:56 +0900, Tejun Heo wrote:
Matthew Stapleton wrote:
Tejun Heo wrote:
Does the problem still persist?
Sorry for the delayed reply: Holidays attacked before I could apply the
patch.
I got confused between your report and Jan's. Yours (not so
jnengland77 wrote:
Hi
Thank you for your help. So all I need to do is update the sg3_utils?
It's the only package I can find dealing with sg and scsi? And do I
have to set this parameter or is it automatically set? I've never
dealt with this scsi system, because all I have are pata disks.
.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Cc: James Bottomley [EMAIL PROTECTED]
diff --git a/include/linux/libata.h b/include/linux/libata.h
index 7cfc18f..925ad7f 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -1139,6 +1139,7 @@ static inline void ata_tf_init(struct ata_device
Jan Gutter wrote:
ata1.01: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata1.01: cmd a0/01:00:00:00:00/00:00:00:00:00/b0 tag 0 cdb 0x43 data 12 in
res 40/00:03:00:00:00/00:00:00:00:00/b0 Emask 0x4 (timeout)
That's READ TOC. Does the problem happen if you boot into single
Jan Gutter wrote:
If it's a firmware bug and implementing a workaround in hald helps it,
would other userspace apps (k3b, cdrecord, etc.) also be affected?
Quite some number of ODDs don't seem to like the way hald polls them. I
don't think other apps will be affected by this. I dunno much
Brian King wrote:
Some LLDDs, like ipr, use nbytes and pad_len to determine
the total data transfer length of a command. Make sure
nbytes gets initialized for internally generated commands.
I think it's better to apply the following patch instead of this one.
James Bottomley wrote:
This looks perfectly fine as a possible solution. Is there any reason
not to initialise qc-dma_dir unconditionally from the SCSI command?
That should work too. I did what I did because it was more in line with
what the current code assumed and initializing the field on
Hello, Douglas.
Douglas Gilbert wrote:
This patch implements sd attribute stop_on_shutdown. If set to 1, sd
stops the drive on non-restarting shutdown. stop_on_shutdown is
initialized from sd parameter stop_on_shutdown_default which defaults
to 0. So, this patch does not change the default
Darrick J. Wong wrote:
Tejun Heo wrote:
sd doesn't stop (unload head) on shutdown. This behavior is necessary
for multi initiator cases. Unloading head by powering off stresses
the drive and sometimes produces distinct clunking noise which
apparently disturbs users considering multiple
Jeff Garzik wrote:
Tejun Heo wrote:
Some uli controllers have stuck SIMPLEX bit which can't be cleared
with ata_pci_clear_simplex(), but the controller is capable of doing
DMAs on both channels simultaneously. Ignore it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
This is going
Merge order left qc-nsect usage in sata_promise dangling. Kill it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
diff --git a/drivers/ata/sata_promise.c b/drivers/ata/sata_promise.c
index 551644a..32ae03e 100644
--- a/drivers/ata/sata_promise.c
+++ b/drivers/ata/sata_promise.c
@@ -502,8 +502,6
Fix compile warnings in pata_cs5530, sata_inic162x and sata_nv which
are caused by throwing away return values marked with __must_check.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/pata_cs5530.c |6 +-
drivers/ata/sata_inic162x.c |4 +++-
drivers/ata/sata_nv.c
. This patch adds dummy assignment to rc
to remove the warnings. Ignoring the return value is intentional.
Acquiring regions for legacy ctl and bmdma areas is recently added
and we don't wanna fail initialization even if it fails (at least
not yet).
Signed-off-by: Tejun Heo [EMAIL PROTECTED
Hello,
This is the third iteration of devres patchset. Changes from the last
take[L] are...
* devres patches collapsed into one as Jeff requested
* updates for sata_inic162x added
* rebased to the current upstream
Git tree is available at the following URLs.
Implement ata_host_detach() which calls ata_port_detach() for each
port in the host and export it. ata_port_detach() is now internal and
thus un-exported. ata_host_detach() will be used as the 'deregister
from libata layer' function after devres conversion.
Signed-off-by: Tejun Heo [EMAIL
removal is handedl by releasing
devres group.
* Except for ata_scsi_release() removal, LLD interface remains the
same. Some functions use hacky is_managed test to support both
managed and unmanaged devices. These will go away once all LLDs are
updated to use devres.
Signed-off-by: Tejun Heo
Now that all LLDs are converted to use devres, default stop callbacks
are unused. Remove them.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c | 81 +++-
include/linux/libata.h|4 --
2 files changed, 6 insertions(+), 79
Implement pcim_iomap_regions(). This function takes mask of BARs to
request and iomap. No BAR should have length of zero. BARs are
iomapped using pcim_iomap_table().
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
include/linux/io.h |2 +
lib/iomap.c| 53
Jeff Garzik wrote:
Tejun Heo wrote:
For ATA, it's currently being done inside libata proper (a bit ugly).
It would be nice to have those implemented at sd layer but I wonder how
useful it's going to be for actual SCSI devices. Do people actually
suspend using SCSI? If it's useful
down the link in the first place.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/ahci.c | 37 ++---
1 file changed, 10 insertions(+), 27 deletions(-)
Index: work/drivers/ata/ahci.c
Mike Accetta wrote:
The distinguishing factor appears to be the queue depth (4 works, 5
and various values up to and including 31 fail) not the kernel version.
I am going to try running with the queue depth clamped at 4 to see if
this consistently masks the problem. I may also try some more
Jaychander T wrote:
I understand from the SATA II NCQ specs that for NCQ commands(FPDMA)
we need not have to setup the DMA (PRD) for the commands issued but
has to do
That's different thing. NCQ protocol doesn't require DMA SETUP FIS
which is required for normal DMA commands but the
Alan wrote:
On Sat, 20 Jan 2007 14:23:29 +0900
Tejun Heo [EMAIL PROTECTED] wrote:
Fix compile warnings in pata_cs5530, sata_inic162x and sata_nv which
are caused by throwing away return values marked with __must_check.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
NAK NAK NAK NAK NAK NAK
As with JMicron controllers, ULi M5288 sets interface fatal error bit
on device error including ATAPI CC. This makes libata hardreset the
port on ATAPI CC thus making it impossible to use. Ignore interface
fatal error bit on ULi M5288. This fixes bugzilla bug #7837.
Signed-off-by: Tejun Heo
such that more info can be reported while not
disturbing users too much.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
Fixed as advised. Thanks.
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 5998f74..659949a 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -75,6 +75,7 @@ enum
Some uli controllers have stuck SIMPLEX bit which can't be cleared
with ata_pci_clear_simplex(), but the controller is capable of doing
DMAs on both channels simultaneously. Implement ATA_FLAG_IGN_SIMPLEX
which makes libata ignore the simplex bit and use it in sata_uli.
Signed-off-by: Tejun Heo
PIO xfermask limits should be shared by all devices on the same
channel to avoid violating device selection timing. libata used to
guarantee this at core level but I mistakenly dropped the code during
conversion to new EH. This patch revives that guarantee.
Signed-off-by: Tejun Heo [EMAIL
this problem. This makes
vt6420 relatively more prone to IRQ storms but the controller is way
too braindamaged to worry about that anyway.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
Jeff, this fix is verified to fix J. Taimr's case and a few other
reported that 2.6.20-rc5 fixed their ATAPI
V VS wrote:
Can you please give us your inputs on why the NCQ depth is not getting
set correctly? Should we be looking at any other place for fixing this
problem?
Please give a shot at 2.6.20-rc5. There was a related bug fix for ahci.
Thanks.
--
tejun
-
To unsubscribe from this list: send
V VS wrote:
Thanks for your immediate response. Really appreciate it very much.
With the kind of output that 2.16.19.1 http://2.16.19.1 has displayed,
should we be suspecting lack of NCQ support in the on-board SATA port or
the hard disk or anywhere else?
Nope, just driver bug, I think.
Jeff Garzik wrote:
Alan wrote:
On Thu, 25 Jan 2007 20:29:47 +0900
Tejun Heo [EMAIL PROTECTED] wrote:
PIO xfermask limits should be shared by all devices on the same
channel to avoid violating device selection timing. libata used to
NAK, this is totally wrong
Eek.. You actually said
Alan wrote:
NAK, this is totally wrong
Eek.. You actually said this is/was documented and relied upon all over.
http://thread.gmane.org/gmane.linux.ide/13184/focus=14486
What I said (well tried to say since it was apparently vague and caused
confusion) was relied upon was the hardware
Call ata_bmdma_irq_clear() directly instead of through
ap-ops-irq_clear() according to libata style guideline.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c
index 55b0123..d3d5c0d 100644
--- a/drivers/ata/sata_via.c
+++ b/drivers/ata
ata_eh_suspend() was returning 0 regardless of failure. This bug has
potential to lose data on suspend. Fix it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
Jeff, this one is definitely for 2.6.20. Thanks.
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index eee3525..52c85af
Jeff Garzik wrote:
Tejun Heo wrote:
Before hardreset, ahci initialized stat part of received FIS area to
0xff to wait for the first D2H Reg FIS which would change the value to
device ready state. This used to work but now libata considers status
value of 0xff as device not present making
-by: Tejun Heo [EMAIL PROTECTED]
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index ab73b0a..7f1bf85 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1281,7 +1281,7 @@ static void ahci_thaw(struct ata_port *ap)
/* clear IRQ */
tmp = readl(port_mmio + PORT_IRQ_STAT
Jim Paris wrote:
Tejun Heo wrote:
Andrew Paprocki wrote:
On 10/30/06, Tejun Heo [EMAIL PROTECTED] wrote:
Please read the following thread.
http://thread.gmane.org/gmane.linux.ide/13222/focus=13235
Worked like a charm! Just patched up smartmontools now and I don't get
the failed cmds
Zhang Rui wrote:
But how to make SATA drive S3 work properly in 2.6.16.33?
There is no simple patch which can fix S3 support in 2.6.16. You need
to backport whole libata EH including PM support. If you absolutely
have to keep using 2.6.16.33, consider backporting libata as a whole
from 2.6.19
Hello, Gary.
Gary Hade wrote:
If they verify your fix (ie,
GoVault sometimes take more than 150ms to transmit the first D2H Reg FIs
after SRST), I'll push similar patch upstream.
Thanks. If you think that changes to increase the delays are
the way to go (at least until we can find a better
);
I would prefer
dev-multi_count, dev-cylinders,
dev-heads, dev-sectors
Other than these,
Acked-by: Tejun Heo [EMAIL PROTECTED]
--
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
Jeff Garzik wrote:
Tejun Heo wrote:
devres change moved iomap.o from obj-$(CONFIG_GENERIC_IOMAP) to lib-y
making it not linked if no in-kernel driver uses it. Fix it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
applied
BTW can you update your scripts to email [EMAIL PROTECTED] ? That's
Mark Lord wrote:
In an ideal world, we would use the existing ATA_12 opcode
to issue 12-byte ATA passthrough commands for libata ATAPI drives
from userspace.
But ATA_12 happens to have the same SCSI opcode value as the older
CD/RW BLANK command, widely used by cdrecord and friends.
So,
Mark Lord wrote:
Tejun Heo wrote:
Mark Lord wrote:
..
So, to achieve ATA passthru capability for libata ATAPI,
we have to instead use the ATA_16 opcode: a 16-byte command.
SCSI normally disallows issuing 16-byte commands to 12-byte devices,
so special support has to be added for this.
I
e983d3f4c3fccad0679aa8ae18a0c3ce91bfafe7
parent 8fa29b23d9e0ef976dc578aab98297d4f24f70da
author Tejun Heo [EMAIL PROTECTED] 1150899168 +0900
committer Jeff Garzik [EMAIL PROTECTED] 1151032959 -0400
[PATCH] ahci: disable NCQ support on vt8251
vt8251 chokes on NCQ commands. Two different disks from different
vendors are showing
Mark Lord wrote:
Robert Hancock wrote:
I'd love to, but unfortunately nobody seems to have come up with a way
of doing this in Thunderbird that keeps it from mangling whitespace
Yup, major nuisance. I have to fire up Kmail whenever I'm posting patches,
and then go back to Thunderbird
devres updates for pata_platform were dropped while merging devres
patches due to merge conflict. This is the updated version.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/pata_platform.c | 31 +++
1 file changed, 7 insertions(+), 24 deletions
Jeff Garzik wrote:
Mark Lord wrote:
For example, I think all existing ATAPI drives only speak 12-byte packet
protocols, and so if we tell SCSI we're good for 16-byte, then won't the
SCSI layer suddenly start sending us READ_16 and the like?
Speaking strictly about the device, IDENTIFY
Jeff Garzik wrote:
Tejun Heo wrote:
SCSI always uses the smallest command it can use, so we're safe. Most
other commands are issued directly from the userland and it's their
responsibility not to feed disallowed commands to a device (or we need
more advanced filter). Anyways, this has never
Florian Effenberger wrote:
Hi there,
I am not sure if the sata_sil-Module is the culprit, but I think so. We
ran a 2.6.15.1 kernel for months without any problems. Now I tried to
switch to 2.6.19.2, and every night when our backup routine runs, the
machine locks up. No log entry, no
and serves as a reminder that 2s delay for GoVault should also be
added here.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index f210dbd..582e44d
* Hardreset must not exit without actually performing reset regardless
of link status. We're resetting the link after all.
* Minor message update.
* 150ms delay is meaningful iff link is online after reset is
complete.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata
-by: Tejun Heo [EMAIL PROTECTED]
---
I think we've waited enough. Combined with EH updates which will soon
be posted, this should make life much easier (well, at least
responsive) when something goes wrong with ATA.
drivers/ata/libata-core.c |2 +-
drivers/ata/libata-scsi.c |6 ++
include
. Other selectors will be used later to improve EH speed down
sequence.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c | 105 ++---
drivers/ata/libata-eh.c |9 +++-
drivers/ata/libata.h | 12 +-
3 files changed, 96
-ENODEV. Some devices report garbled
IDENTIFY data after certain events. This shouldn't cause device
detach and re-attach.
* Rearrange EH failure path for simplicity.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c | 39
Subject: [PATCHSET] put some intelligence into speed down sequence
Hello,
The current EH speed down code is more of a feature demonstration and
goes through rdiculously many meaningless steps when condition is met.
This patchset tries to put some intelligence into speed down sequence.
The goal
ATA_DNXFER_ANY isn't used anymore. Kill it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c |9 -
drivers/ata/libata.h |1 -
2 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index
spurious NCQ completions HSM violation and freeze the port
after it. EH will turn off NCQ after this happens several times.
Eventually drives which show this behavior should be blacklisted for
NCQ.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/ahci.c | 26
Tejun Heo wrote:
Eek, sorry.
--
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
-ENODEV. Some devices report garbled
IDENTIFY data after certain events. This shouldn't cause device
detach and re-attach.
* Rearrange EH failure path for simplicity.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c | 39
. Other selectors will be used later to improve EH speed down
sequence.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c | 105 ++---
drivers/ata/libata-eh.c |9 +++-
drivers/ata/libata.h | 12 +-
3 files changed, 96
is
triggered, error history is cleared such that the next speed down
happens only after some number of errors are accumulated. This makes
sense because now speed down is done in bigger stride.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-eh.c | 184
Sorry, bad script day.
--
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
and at least right after the third try
@20.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c | 35 +--
drivers/ata/libata-eh.c | 58 +++-
include/linux/libata.h| 16
3 files changed, 42
as prereset() will be called
with shorter timeout.
* If ata_wait_ready() fails, whine and request hardreset instead.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-core.c | 22 +++---
1 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/drivers/ata
Alan wrote:
Note that both normal commands and EH commands timeouts are adjusted
to 7 secs, but cache flushses still have 30sec timeout. This is a
side effect of the way sd makes use of sdev-timeout, but this is a
good side effect in that ATA spec requires cache flushes are given
longer
201 - 300 of 2104 matches
Mail list logo
