Tejun Heo wrote:
> I'll follow up with conversion to ata_do_simple_cmd().
The current situation is...
ata_exec_internal_sg() : no user except for ata_exec_internal() yet
ata_exec_internal() : one data transferring user. other are non-data
ata_do_simple_cmd() : three users
So
bmitted by Arnd
Bergmann.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
Cc: Arnd Bergmann <[EMAIL PROTECTED]>
---
Modified as suggested.
Thanks.
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 011c0a8..0d51d13 100644
--- a/drivers/ata/libata-core.c
+++ b/dri
Hi,
Alan wrote:
>>
>> How did this go? I doubt I'm the only one who fell afoul of the "has linux
>> drivers" implication on initio's website...
>>
>> I know its early days, but any idea when this might be ready for production?
>
> I sent Tejun the data book but we've yet to succeed in cloning hi
to access more than just CDB and they have already been accessing scmd
via qc->scsicmd. Just pass in qc.
* Variable names are normalized. scsi_cmnd is scmd and CDB, cdb.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
Cc: Jens Axboe <[EMAIL PROTECTED]>
Cc: Douglas Gilbert <[E
Upper layer is already passing in enough information via req->cmd_len
and requiring it to do the same thing twice makes it easy to miss -
scsi_execute() doesn't do it.
Now that libata is updated to handle garbage after CDB, remove
unnecessary CDB clearing.
Signed-off-by: Tejun Heo
nstead of sectors. The field used to be used in bytes
for ATAPI and in sectors for ATA.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
drivers/ata/libata-core.c | 15 ---
drivers/ata/libata-eh.c |7 +--
drivers/ata/libata-scsi.c |4 ++
Driver for Initio 162x SATA controllers. ATA r/w, ATAPI r, hotplug
and suspend/resume work. ATAPI w (recording, that is) broken. Feel
free to fix it, but be warned, this controller is weird.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
drivers/ata/Kconfig |6 +
drive
alized
via probe_ent (or port_info) and used in ->slave_config to configure
maximum segment size. LLDs without braindamage can leave this alone.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
drivers/ata/libata-core.c |3 +++
drivers/ata/libata-scsi.c |9 +
include
These three patches implement sata_inic162x. As usual, the patches are
against the current libata-dev#upstream
(b6c0159899e9742f5462ae3ee19e6573aa47b5d8).
It seems to run pretty stable on my machine but I'm the developer and no
one should trust my testing. So, knock yourself out. Remember, this
/focus=14605
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 1748e27..644f711 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -191,6 +191,7 @@ int scsi_execute(struct scsi_device *sdev, const unsigned
cha
csi_cmnd and 'cdb' for CDB. Also, 'scmd' local
variable is added if qc->scsicmd is used multiple times.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
Okay, separated as suggested and regenerated against
libata-dev#upstream-fixes.
Thanks.
drivers/ata/libata-scsi.c
xlat function will be updated to consider qc->scsicmd->cmd_len and
many xlat functions deference qc->scsicmd already. It doesn't make
sense to pass qc->scsicmd->cmnd as @cdb separately. Kill the
argument.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
driver
nctions on initialization commands issued from
SCSI.
This patch makes xlat functions always consider SCSI cmd_len. Each
translation function checks for proper cmd_len and ATAPI translaation
clears bytes after CDB.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
Cc: Jens Axboe <[EMAIL PROTECTED]&g
Upper layer is already passing in enough information via req->cmd_len
and requiring it to do the same thing twice makes it easy to miss -
scsi_execute() doesn't do it.
Now that libata is updated to handle garbage after CDB, remove
unnecessary CDB clearing.
Signed-off-by: Tejun Heo
nstead of sectors. The field used to be used in bytes
for ATAPI and in sectors for ATA.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
drivers/ata/libata-core.c | 15 ---
drivers/ata/libata-eh.c |7 +--
drivers/ata/libata-scsi.c |4 ++
Driver for Initio 162x SATA controllers. ATA r/w, ATAPI r, hotplug
and suspend/resume work. ATAPI w (recording, that is) broken. Feel
free to fix it, but be warned, this controller is weird.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
As suggested, custom ->slave_configure inst
Alan wrote:
> On Sun, 17 Dec 2006 10:50:08 +0900
> Tejun Heo <[EMAIL PROTECTED]> wrote:
>
>> Driver for Initio 162x SATA controllers. ATA r/w, ATAPI r, hotplug
>> and suspend/resume work. ATAPI w (recording, that is) broken.
>
> Does atapi write work if yo
Patrik Jonsson wrote:
> First I thought it was a cabling or card issue, because the same drive
> got kicked twice. That drive was connected to a 2-port SIG sata_sil24
> card. However, I just had another drive kicked that's connected to the
> onboard sata_nv, which leads me to suspect that the upgra
ters back to the
> user-space application on a check condition similiar to ata_cmd_ioctl().
>
> Please ACK or comment.
Acked-by: Tejun Heo <[EMAIL PROTECTED]>
Great, but you need to resend the patch with Signed-off-by: line.
--
tejun
-
To unsubscribe from this list: send the line
Matteo Croce wrote:
> Hi people,
> i've done some benchmarks with the new drivers and
> i want to share them with you.
And, where's the benchmark result?
> --
> .""`.Matteo Croce <[EMAIL PROTECTED]>
> : :" : proud Debian admin and user
> `. `"`
> `- Debian - when you have better things t
<[EMAIL PROTECTED]>
Acked-by: Tejun Heo <[EMAIL PROTECTED]>
--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Jan Gutter wrote:
> Our company has recently purchased two Acer 5632WSMi laptops and we're
> running Gentoo x86 unstable on them. The most hindering problem that's
> currently plaguing us is the IDE chipset.
>
> Without the combined_mode=libata on the command line, DMA is disabled
> and the hard
Patrik Jonsson wrote:
> At the time it happened, none of the devices responded to smart commands
> ("not an ATA device"). After resetting, they do. The outputs are at the
> bottom.
Hmmm... Nothing indicative of power problem. The first drive seems to
have suffered quite some number of read failur
Kovid Goyal wrote:
> Hi,
>
> I'm having problems booting from a SATA disk with 2.6.19.
> Grub loads fine, but when the kernel boots, it *sometimes* ends up with
> VFS: Cannot open root device "sda5" or unknown-block(0,0).
>
> This issue appears to be identical with the one reported in
> http://
Kovid Goyal wrote:
> Yes going back to 2.6.17 does fix it. Also windows and various LiveCDs boot
> without problems.
>
> Here is the output
> smartctl -d ata -a /dev/sda
> smartctl version 5.36 [i686-pc-linux-gnu] Copyright (C) 2002-6 Bruce Allen
> Home page is http://smartmontools.sourceforge.
Howdy,
Gary Hade wrote:
> I noticed that Tejun recently provided a "libata: handle 0xff status
> properly" patch that is now in mainline that improves this code
> re: http://marc.theaimsgroup.com/?l=linux-ide&m=116038642105802&w=2
> but I found that the check still failed but more silently and
Tejun Heo wrote:
> I would be surprised if Kovid's sda not detected case is caused by this.
> For GoVault (that's SATAPI right?), yeah, maybe. For an ATA disk, no
> way (hopefully).
>
> Can you consult with quantum about it? If they verify your fix (ie,
> GoVault so
x Products GmbH
+ * Copyright 2006 Tejun Heo <[EMAIL PROTECTED]>
+ *
+ * This file is released under GPL v2.
+ *
+ * This controller is eccentric and easily locks up if something isn't
+ * right. Documentation is available at initio's website but it only
+ * documents registers
Driver for Initio 162x SATA controllers. ATA r/w, ATAPI r, hotplug
and suspend/resume work. ATAPI w (recording, that is) broken. Feel
free to fix it, but be warned, this controller is weird.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
Just two cosmetic changes.
* printk("XX
Handle pci_enable_device() failure while resuming. This patch kills
the "ignoring return value of 'pci_enable_device'" warning message and
propagates __must_check through ata_pci_device_do_resume().
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
drivers/ata/ahci.c
through initialization
or selectively release resources (e.g. resources for port 1 out of 4
ports).
In addition, managed kzalloc() and kfree() are implemented by this
patch.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
drivers/base/Kconfig | 12 +
drivers/base/Makefile |2 +-
d
Implement managed DMA interface - dmam_alloc_coherent(),
dmam_free_coherent(), dmam_declare_coherent_memory(),
dmam_pool_create() and dmam_pool_destroy(). Except for being managed,
these take the same arguments and have the same effect as non-managed
counterparts.
Signed-off-by: Tejun Heo
Implement managed IRQ interface - devm_request_irq() and
devm_free_irq(). Except for the first @dev argument and being
managed, these take the same arguments and have the same effect as
non-managed coutnerparts.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
include/linux/interrupt.h
Hello, all.
This patchset implements managed device resources, in short, devres.
## Intro
devres came up while trying to convert libata to use iomap. Each
iomapped address should be kept and unmapped on driver detach. For
example, a plain SFF ATA controller (that is, good old PCI IDE) in
nativ
*
which record addresses for all mapped BARs. This function is
guaranteed to succeed after successful pcim_iomap() and drivers are
free to reference the returned iomap table.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
include/linux/io.h |7 +++
lib/Makefile |3 +-
lib/i
Implement managed IO region interface - devm_request_region() and
devm_release_region(). Except for the first @dev argument and being
managed, these take the same arguments and have the same effect as
non-managed coutnerparts.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
include
Implement pcim_iomap_regions(). This function takes mask of BARs to
request and iomap. No BAR should have length of zero. BARs are
iomapped using pcim_iomap_table().
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
include/linux/io.h |2 +
lib/iomap.c
Handle pci_enable_device() failure while resuming. This patch kills
the "ignoring return value of 'pci_enable_device'" warning message and
propagates __must_check through ata_pci_device_do_resume().
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
drivers/ata/ahci.c
removal is handedl by releasing
devres group.
* Except for ata_scsi_release() removal, LLD interface remains the
same. Some functions use hacky is_managed test to support both
managed and unmanaged devices. These will go away once all LLDs are
updated to use devres.
Signed-off-by: Tejun Heo
Now that all LLDs are converted to use devres, default stop callbacks
are unused. Remove them.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
drivers/ata/libata-core.c | 91 -
include/linux/libata.h|4 --
2 files changed, 8 inse
ff-by: Tejun Heo <[EMAIL PROTECTED]>
---
drivers/pci/pci.c | 127 ++-
include/linux/pci.h |9
2 files changed, 135 insertions(+), 1 deletions(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 6bfb942..2ab2f8a 100644
--- a/
cables as 80c. This patch fixes it.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
This certainly is a regression and there are users affected by this.
I've verified this on both primary and secondary channel of vt6421.
Who takes IDE patches these days? Jeff, can you push this thr
Art Haas wrote:
> Sorry to report that patch did not work. I applied the patch against
> Linus's tree this morning, built and installed that kernel, and
> the CD-ROM was not found. I also tried the patch with an update
> from Linus's tree from this evening, and again the same result.
Hello, Art.
d Signed-off-by: line.
Other than that,
Acked-by: Tejun Heo <[EMAIL PROTECTED]>
--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Tejun Heo wrote:
> Art Haas wrote:
>> Sorry to report that patch did not work. I applied the patch against
>> Linus's tree this morning, built and installed that kernel, and
>> the CD-ROM was not found. I also tried the patch with an update
>> from Linus's
Robin H. Johnson wrote:
> I forward-ported Tejun's PMP patches to libata#upstream (my first attempt at
> it
> a few weeks ago failed, but this round works fine, tested at each branch
> stage), and in using them, I have noticed a bit of oddity.
Great, care to share them?
> While dmesg claims that
Andrew Lyon wrote:
> Hi,
>
> My system is gigabyte ds3 motherboard with onboard SATA JMicron
> 20360/20363 AHCI Controller (rev 02), drive connected is WDC
> WD740ADFD-00 20.0, I am running 2.6.18.6 32 bit, under heavy i/o I get
> the following messaegs:
>
> ata1: spurious interrupt (irq_stat 0x8
Pierre Tardy wrote:
> The map for ich6m chip had a typo, which caused to output a harmless
> error at boot.
>
> Signed-off-by: Pierre Tardy <[EMAIL PROTECTED]>
Acked-by: Tejun Heo <[EMAIL PROTECTED]>
--
tejun
-
To unsubscribe from this list: send the line "unsub
.
This was fixed recently by the following commit.
Commit: 551c012d7eea3dc5ec063c7ff9c718d39e77634f
Author: Tejun Heo <[EMAIL PROTECTED]> 2006-12-12 20:17:32
Committer: Jeff Garzik <[EMAIL PROTECTED]> 2006-12-17 00:13:29
Branches: upstream-fixes, upstream, quilt-init
Follows: v2.6.19
Prec
: Tejun Heo <[EMAIL PROTECTED]>
---
drivers/ata/libata-core.c | 21 ++---
drivers/ata/libata-scsi.c | 33 -
drivers/ata/pata_ali.c |4 ++--
drivers/ata/pata_hpt366.c |4 ++--
drivers/ata/pata_hpt37x.c
There were several places where ATA ID strings are manually terminated
and in some places possibly unterminated strings were passed to string
functions which don't limit length like strstr(). This patch converts
all of them over to ata_id_c_string().
Signed-off-by: Tejun Heo <[EMAIL P
'hdparm -I' doesn't work with ATAPI devices and sg_sat is not widely
spread yet leaving no easy way to access ATAPI IDENTIFY data.
Implement HDIO_GET_IDENTITY such that at least 'hdparm -i' works.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
d
The last one was 3/3 of course.
--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Mark Lord wrote:
> Tejun Heo wrote:
>> 'hdparm -I' doesn't work with ATAPI devices and sg_sat is not widely
>> spread yet leaving no easy way to access ATAPI IDENTIFY data.
>> Implement HDIO_GET_IDENTITY such that at least 'hdparm -i' works.
>
>
Art Haas wrote:
> Hi.
>
> I wanted to try the two patches you've sent against the current
> 2.6.20-rc3, but there have been numerous changes to the files
> so neither patch can apply cleanly. I'm not familiar enough
> with the libata to try and make similar changes to the current
> files to match
Matthew Stapleton wrote:
> Tejun Heo wrote:
>> Please apply the attached patch over 2.6.19 and report what the kernel says.
>>
>> Thanks.
>>
>
> I got the following errors during the timeout when running hald:
>
> ata1.01: exception Emask 0x0 SAct 0x0 SErr
[cc'ing linux-ide]
bbee wrote:
> Tejun Heo gmail.com> writes:
>> Andrew Lyon wrote:
>>> My system is gigabyte ds3 motherboard with onboard SATA JMicron
>>> 20360/20363 AHCI Controller (rev 02), drive connected is WDC
>>> WD740ADFD-00 20.0, I am ru
bbee wrote:
>> Yeap, I have major issues with SDB FISes which contains spurious
>> completions but most other spurious interrupts shouldn't be dangerous
>> and I haven't seen spurious completions for quite some time, so I was
>> thinking either removing the message or printing it only on SDB FIS
>>
Jeff Garzik wrote:
>> + * - ATA disks work.
>> + * - Hotplug works.
>> + * - ATAPI read works but burning doesn't. This thing is really
>> + * peculiar about ATAPI and I couldn't figure out how ATAPI PIO and
>> + * ATAPI DMA WRITE should be programmed. If you've got a clue, be
>> + * my gue
nstead of sectors. The field used to be used in bytes
for ATAPI and in sectors for ATA.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
drivers/ata/libata-core.c | 15 ---
drivers/ata/libata-eh.c |7 +--
drivers/ata/libata-scsi.c |4 ++
Driver for Initio 162x SATA controllers. ATA r/w, ATAPI r, hotplug
and suspend/resume work. ATAPI w (recording, that is) broken. Feel
free to fix it, but be warned, this controller is weird.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
* Modified as advised by Jeff.
* Made config
bbee wrote:
> Sorry, I thought you meant you would need to update it *further*. I
> applied the patch you gave to Andrew with this result so far:
>
> $ dmesg | grep -A1 "spurious interrupt"
> ata1: spurious interrupt (irq_stat 0x8 active_tag 0xfafbfcfd sactive 0x0)
> ata1: issue=0x0 SAct=0x0 SDB_F
Andrew Lyon wrote:
> Is there anything more I can do to assist? I plan to upgrade to
> 2.6.19/latest at the weekend, let me know if there is anything more i
> can do.
WD740ADFD-00 is blacklisted for NCQ in .20-rcX kernels, so you won't see
the problem anymore there. If you're gonna use 2.6.19, yo
Bjorn Wesen wrote:
> Just adding some info here!
>
> I added this to the bottom of ata_interrupt in libata-core.c which fixed
> the problem:
>
> if(!handled) {
> printk("ata_interrupt nobody cared. Trying to clear irq src\n");
> for (i = 0; i < host->n_ports; i++) {
>
Brad Fitzpatrick wrote:
> Tejun,
>
> (I wanted to send this to linux-ide, but vger's majordomo isn't replying
> to me. Feel free to cc: the list...)
Just cc'ing linux-ide@vger.kernel.org is enough. (done)
> Disks in DS-1220 show up, kinda, but don't work. Errors reading /
> writing blocks. T
Jeff Garzik wrote:
> Tejun Heo wrote:
>> 'hdparm -I' doesn't work with ATAPI devices and sg_sat is not widely
>> spread yet leaving no easy way to access ATAPI IDENTIFY data.
>> Implement HDIO_GET_IDENTITY such that at least 'hdparm -i' works.
&g
Hello,
[cc'ing lkml and linux-ide]
Philippe Grenard wrote:
> To "close" this problem, here are the latest news :
> I just bought some new power supply, and the problem has gone...
> Maybe that was due to poor power flow or crappy connexion ?...
>
> now everything seems to work well, so as suspec
Greg KH wrote:
> On Thu, Jan 04, 2007 at 05:26:43PM -0500, Jeff Garzik wrote:
>> Greg KH wrote:
>>> Hm, but I guess without the follow-up patches for libata, it will not
>>> really get tested much. Jeff, if I accept this, what's your feelings of
>>> letting libata be the "test bed" for it?
>>
>> I
From: J J <[EMAIL PROTECTED]>
In Acer Aspire hdd is connected to ICH7 via 40c cable, however it is
short cable and it is UDMA66 capable.
Signed-off-by: J J <[EMAIL PROTECTED]>
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_pi
From: J J <[EMAIL PROTECTED]>
In ASUS A6K/A6U hdd is connected to SiS 96x via 40c cable, however it
is short cable and is UDMA66 capable.
tj: fixed if () conditionals.
Signed-off-by: J J <[EMAIL PROTECTED]>
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
diff --git a/driver
sson <[EMAIL PROTECTED]>
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
lap++ was missing. This will result in infinite loop. Please apply
this one. Thanks to Andreas Henriksson for spotting this.
diff --git a/drivers/ata/pata_sis.c b/drivers/ata/pata_sis.c
index c434c4e..d9486fc
Hello,
This is the second take of devres patchset. Changes from the last
take[L] are...
* generic managed iomap interface functions implemented
- devm_ioport_map/unmap()
- devm_ioremap[_nocache](), devm_iounmap()
* libata-sff legacy mode now uses generic managed iomap interface
Implement managed DMA interface - dmam_alloc_coherent(),
dmam_free_coherent(), dmam_declare_coherent_memory(),
dmam_pool_create() and dmam_pool_destroy(). Except for being managed,
these take the same arguments and have the same effect as non-managed
counterparts.
Signed-off-by: Tejun Heo
: Tejun Heo <[EMAIL PROTECTED]>
---
include/linux/io.h | 17
lib/Makefile |3 +-
lib/iomap.c| 246 +++-
3 files changed, 263 insertions(+), 3 deletions(-)
diff --git a/include/linux/io.h b/include/linux/io.h
index 8
Implement managed IRQ interface - devm_request_irq() and
devm_free_irq(). Except for the first @dev argument and being
managed, these take the same arguments and have the same effect as
non-managed coutnerparts.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
include/linux/interrupt.h
removal is handedl by releasing
devres group.
* Except for ata_scsi_release() removal, LLD interface remains the
same. Some functions use hacky is_managed test to support both
managed and unmanaged devices. These will go away once all LLDs are
updated to use devres.
Signed-off-by: Tejun Heo
Implement managed IO region interface - devm_request_region() and
devm_release_region(). Except for the first @dev argument and being
managed, these take the same arguments and have the same effect as
non-managed coutnerparts.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
include
Add Documentation/driver-model/drvres.txt.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
Documentation/driver-model/devres.txt | 268 +
1 files changed, 268 insertions(+), 0 deletions(-)
diff --git a/Documentation/driver-model/devres.txt
b/Documen
ff-by: Tejun Heo <[EMAIL PROTECTED]>
---
drivers/pci/pci.c | 127 ++-
include/linux/pci.h |9
2 files changed, 135 insertions(+), 1 deletions(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 6bfb942..2ab2f8a 100644
--- a/
Implement pcim_iomap_regions(). This function takes mask of BARs to
request and iomap. No BAR should have length of zero. BARs are
iomapped using pcim_iomap_table().
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
include/linux/io.h |2 +
lib/iomap.c
Implement ata_host_detach() which calls ata_port_detach() for each
port in the host and export it. ata_port_detach() is now internal and
thus un-exported. ata_host_detach() will be used as the 'deregister
from libata layer' function after devres conversion.
Signed-off-by: Tejun H
through initialization
or selectively release resources (e.g. resources for port 1 out of 4
ports).
In addition, managed kzalloc() and kfree() are implemented by this
patch.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
drivers/base/Kconfig | 12 +
drivers/base/Makefile |2 +-
d
Now that all LLDs are converted to use devres, default stop callbacks
are unused. Remove them.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
drivers/ata/libata-core.c | 81 +++-
include/linux/libata.h|4 --
2 files changed, 6 inse
Kovid Goyal wrote:
> ata3: SATA max UDMA/133 cmd 0xFE00 ctl 0xFE12 bmdma 0xFEA0 irq 17
> ata4: SATA max UDMA/133 cmd 0xFE20 ctl 0xFE32 bmdma 0xFEA8 irq 17
> scsi2 : ata_piix
> scsi3 : ata_piix
Hmmm... ata3.00 was /dev/sda1. Presence testing seems to have failed.
Please give a shot at 2.6.20-rc4.
Mike Accetta wrote:
> Here's a bit more information on these timeouts. I noticed a mention
> of changing the command queue depth in a recent lkml post and decided
> to give that a whirl.
>
> This problem seems to be related to the depth of the queue. When I
> set the value for /sys/block/sdb/dev
f3bda77 is first bad commit
> commit 4658f79bec0b51222e769e328c2923f39f3bda77
> Author: Tejun Heo <[EMAIL PROTECTED]>
> Date: Wed Mar 22 21:07:03 2006 +0900
>
> [PATCH] ahci: add softreset
>
> Now that libata is smart enought to handle both soft and hard resets,
>
Alan wrote:
> I'm currently hacking on the speed handling code a bit
>
> I'd like to do the following unless anyone has any objections
>
> - Remove post_set_mode and make drivers wrap the guts of the existing
> set_mode() function. This allows a driver to wrap and see success/failure
> while remo
Alan wrote:
> O> Wouldn't it be better to have ->determine_xfer_mask() and
>> ->set_specific_mode() than having two somewhat overlapping callbacks?
>> Or is there some problem that can't be handled that way?
>
> I'm not sure I follow what you are suggesting - can you explain further.
>
> Right no
Brad Fitzpatrick wrote:
> On Sat, 13 Jan 2007, Brad Fitzpatrick wrote:
>
>> I tried another disk (but of the same type), and got the same results both
>> direct and via PMP.
>>
>> Are these disks too old to be hot-plugged? (but I recall the
>> identical errors happening on boot after I power-cycl
Matthew Stapleton wrote:
> Tejun Heo wrote:
>> Can you try the attached patch over 2.6.19 and report full dmesg? Thanks.
>>
>> --
>> tejun
>>
>
> Attached is my full dmesg.
Does the problem still persist?
--
tejun
-
To unsubscribe from this list: send
Hello, all.
Many people have been reporting libata PATA ATAPI detection problem. In
many but not all cases, the ATAPI device was occupying the slave slot
while a disk drive occupies the master slot. Based on that and J.
Taimr's nullify freeze on via fix, I made a cocktail patch which
contained f
such that more info can be reported while not
disturbing users too much.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 5998f74..00c6bcc 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -75,6 +75,7 @@ enum {
AHCI_C
kenneth johansson wrote:
> I changed my bios setting for SATA from IDE to AHCI.
>
> This resulted in some "interesting" read throughput.
>
> plots can be found at http://kenjo.org/~ken/sata/
> The plots was done on a live disk so some noise is expected but in the
> ahci mode the throughput get s
kenneth johansson wrote:
> On Mon, 2007-01-15 at 18:13 +0900, Tejun Heo wrote:
>> kenneth johansson wrote:
>>> I changed my bios setting for SATA from IDE to AHCI.
>>>
>>> This resulted in some "interesting" read throughput.
>>>
>>>
Jordan Neumeyer wrote:
> Well recently I've been using libata since my my distribution offered it when
> they switched to 2.6.19( maybe? 18) in the initramfs image. I have a sis 5513
> controller, which after a couple of days started acting up and coming up with
> the following error:
>
> sg_writ
From: Luca Pedrielli <[EMAIL PROTECTED]>
Add PCI ID 0x5337 to supported PCI ID. This is VT8237 in IDE mode.
Signed-off-by: Luca Pedrielli <[EMAIL PROTECTED]>
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
Luca, I formatted the patch in the form Jeff can take. Please format
Some uli controllers have stuck SIMPLEX bit which can't be cleared
with ata_pci_clear_simplex(), but the controller is capable of doing
DMAs on both channels simultaneously. Ignore it.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
diff --git a/drivers/ata/sata_uli.c b/drivers/ata
such that more info can be reported while not
disturbing users too much.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
Updated to not use bitfields as requested. Thanks.
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 5998f74..d5ea1c3 100644
--- a/drivers/ata/ahci.c
+++ b/
Matthew Stapleton wrote:
> Tejun Heo wrote:
>> Does the problem still persist?
>>
> With that kernel and the previous patches it does. I'll try kernel
> 2.6.20-rc5
> and the which-cocktail-2.6.19.patch
I got confused between your report and Jan's. Yours (no
Jan Gutter wrote:
> On Tue, 2007-01-16 at 17:56 +0900, Tejun Heo wrote:
>> Matthew Stapleton wrote:
>>> Tejun Heo wrote:
>>>> Does the problem still persist?
>
> Sorry for the delayed reply: Holidays attacked before I could apply the
> patch.
>
>&
701 - 800 of 2578 matches
Mail list logo
