Re: [PATCH] enclosure: add support for enclosure services

2008-02-13 Thread Kristen Carlson Accardi
On Tue, 12 Feb 2008 13:28:15 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-02-12 at 11:07 -0800, Kristen Carlson Accardi wrote: I understand what you are trying to do - I guess I just doubt the value you've added by doing this. I think that there's going to be so much

Re: [PATCH] enclosure: add support for enclosure services

2008-02-12 Thread Kristen Carlson Accardi
On Tue, 12 Feb 2008 12:45:35 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-02-12 at 10:22 -0800, Kristen Carlson Accardi wrote: I apologize for taking so long to review this patch. I obviously agree wholeheartedly with Luben. The problem I ran into while trying to design

Re: [PATCH] enclosure: add support for enclosure services

2008-02-12 Thread Kristen Carlson Accardi
On Mon, 4 Feb 2008 18:01:36 -0800 (PST) Luben Tuikov [EMAIL PROTECTED] wrote: --- On Mon, 2/4/08, James Bottomley [EMAIL PROTECTED] wrote: The enclosure misc device is really just a library providing sysfs support for physical enclosure devices and their components. Who

Re: [PATCH] libata: add enclosure management support

2008-01-18 Thread Kristen Carlson Accardi
On Thu, 17 Jan 2008 16:50:42 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-01-15 at 16:44 -0800, Kristen Carlson Accardi wrote: Add Enclosure Management support to libata and ahci. This patch adds support for the LED protocol, as defined in the AHCI spec. It adds a generic

Re: [PATCH] libata: add enclosure management support

2008-01-18 Thread Kristen Carlson Accardi
On Fri, 18 Jan 2008 18:16:34 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Fri, 2008-01-18 at 09:41 -0800, Kristen Carlson Accardi wrote: On Fri, 18 Jan 2008 11:11:21 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Fri, 2008-01-18 at 08:52 -0800, Kristen Carlson Accardi wrote

Re: [PATCH] libata: add enclosure management support

2008-01-18 Thread Kristen Carlson Accardi
On Fri, 18 Jan 2008 18:47:18 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Fri, 2008-01-18 at 16:35 -0800, Kristen Carlson Accardi wrote: Unfortunately, all the dual SAS/SATA enclosures seem to be coming with either SGPIO devices or full fledged SES-2 devices. I've actually got

Re: [PATCH] libata: add enclosure management support

2008-01-18 Thread Kristen Carlson Accardi
On Fri, 18 Jan 2008 18:16:34 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Fri, 2008-01-18 at 09:41 -0800, Kristen Carlson Accardi wrote: On Fri, 18 Jan 2008 11:11:21 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Fri, 2008-01-18 at 08:52 -0800, Kristen Carlson Accardi wrote

Re: [PATCH] libata: add enclosure management support

2008-01-18 Thread Kristen Carlson Accardi
On Fri, 18 Jan 2008 11:11:21 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Fri, 2008-01-18 at 08:52 -0800, Kristen Carlson Accardi wrote: On Thu, 17 Jan 2008 16:50:42 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-01-15 at 16:44 -0800, Kristen Carlson Accardi wrote

Re: [PATCH] libata: add enclosure management support

2008-01-17 Thread Kristen Carlson Accardi
On Thu, 17 Jan 2008 16:50:42 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-01-15 at 16:44 -0800, Kristen Carlson Accardi wrote: Add Enclosure Management support to libata and ahci. This patch adds support for the LED protocol, as defined in the AHCI spec. It adds a generic

[PATCH] libata: add enclosure management support

2008-01-15 Thread Kristen Carlson Accardi
, and blinks off every 10ms when activity is detected. It's important to note that the user must turn sw_activity OFF it they wish to control the activity LED via the em_message file. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- I'm concerned about my locking, cause I

Re: [patch 7/9] ata: ahci: Enclosure Management via LED

2007-12-14 Thread Kristen Carlson Accardi
On Thu, 13 Dec 2007 16:01:42 -0800 [EMAIL PROTECTED] wrote: From: Kristen Carlson Accardi [EMAIL PROTECTED] Implement Enclosure Management via the LED protocol. See the AHCI 1.1 spec for details. Hi Andrew and Jeff, I am working on a revised version of this patch, so you can go ahead

Re: [patch] ata: ahci: Enclosure Management via LED rev2

2007-12-03 Thread Kristen Carlson Accardi
On Sat, 01 Dec 2007 18:28:54 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Kristen Carlson Accardi wrote: Enclosure Management via LED This patch implements Enclosure Management via the LED protocol as specified in AHCI specification. Signed-off-by: Kristen Carlson Accardi [EMAIL

Re: [patch] ata: ahci: Enclosure Management via LED rev2

2007-11-30 Thread Kristen Carlson Accardi
Enclosure Management via LED This patch implements Enclosure Management via the LED protocol as specified in AHCI specification. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- This revision makes the change to the comment requested by Mark Lord, fixes some bugs in the bit shifting

[patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Kristen Carlson Accardi
This patch implements Enclosure Management via the LED protocol. See the AHCI 1.1 spec for details. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- Here's a new version of the Enclosure management patch I sent a few weeks ago. I tried to incorporate all the feedback, although I'm

Re: [patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Kristen Carlson Accardi
On Thu, 29 Nov 2007 09:48:02 -0800 Kristen Carlson Accardi [EMAIL PROTECTED] wrote: This patch implements Enclosure Management via the LED protocol. See the AHCI 1.1 spec for details. Whoops, I totally messed up and sent the wrong version of this patch. I'll send an updated one, ignore

Re: [patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Kristen Carlson Accardi
On Thu, 29 Nov 2007 13:16:07 -0500 Mark Lord [EMAIL PROTECTED] wrote: Kristen wrote: ... + * XXX will need Port Multiplier support What's that all about ? I didn't have any hardware that had LED support as well as Port Multiplier, so I didn't implement port multiplier support for

[patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Kristen Carlson Accardi
This patch implements Enclosure Management via the LED protocol. See the AHCI 1.1 spec for details. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- Ok, here's one that actually compiles... drivers/ata/ahci.c| 154 - drivers/ata

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-05 Thread Kristen Carlson Accardi
On Mon, 05 Nov 2007 07:53:58 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Yep, works for me! Can we get this expedited upstream? If everybody's happy with it, I've got it ready for upstream in libata-dev.git#dlpm-fix Jeff Thanks! It'd be great if you could get it in ASAP. - To

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-02 Thread Kristen Carlson Accardi
while disabling DIPM, and after thinking about this a bit, I don't think we really need to do this anyway. Don't disable dipm with SET FEATURES Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- drivers/ata/libata-core.c | 18 ++ 1 file changed, 10 insertions(+), 8

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Kristen Carlson Accardi
On Thu, 01 Nov 2007 07:20:16 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Jens Axboe wrote: Reverting just the default AHCI flags makes it work again. IOW, with the below patch I can suspend properly with current -git. diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index

[PATCH] ata: ahci: Enable enclosure management via LED (resend)

2007-10-24 Thread Kristen Carlson Accardi
Enable enclosure management via LED As described in the AHCI spec, some AHCI controllers may support Enclosure management via a variety of protocols. This patch adds support for the LED message type that is specified in AHCI 1.1 and higher. Signed-off-by: Kristen Carlson Accardi [EMAIL

[PATCH] ata: ahci: Enable enclosure management via LED

2007-10-17 Thread Kristen Carlson Accardi
Enable enclosure management via LED As described in the AHCI spec, some AHCI controllers may support Enclosure management via a variety of protocols. This patch adds support for the LED message type that is specified in AHCI 1.1 and higher. Signed-off-by: Kristen Carlson Accardi [EMAIL

Re: [patch] ata: libata: add per device private data

2007-10-09 Thread Kristen Carlson Accardi
Sorry for the delay in responding, I was on vacation. On Tue, 02 Oct 2007 11:07:30 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Kristen Carlson Accardi wrote: Allow host controllers to store private data per device. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 3

2007-09-27 Thread Kristen Carlson Accardi
On Tue, 25 Sep 2007 00:14:36 +0100 Matthew Garrett [EMAIL PROTECTED] wrote: Modern laptops with hotswap bays still tend to utilise a PATA interface on a SATA bridge, generally with the host controller in some legacy emulation mode rather than AHCI. This means that the existing hotplug code

[patch 0/2] SATA Link Power Management patches

2007-09-24 Thread Kristen Carlson Accardi
Here's a set of patches which implement link power management for SATA. We had talked at kernel summit of moving sysfs interface for setting the link power management policy to the block layer, but after a lot of consideration, I think this doesn't make sense. Mainly because I feel for SATA the

[patch 1/2] Enable link power management for ata drivers

2007-09-24 Thread Kristen Carlson Accardi
, but not change link power management policy. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- Documentation/scsi/link_power_management_policy.txt | 19 + drivers/ata/libata-core.c | 194 +++- drivers/ata/libata-eh.c

[patch 2/2] Enable Aggressive Link Power management for AHCI controllers.

2007-09-24 Thread Kristen Carlson Accardi
idle. Hot plug not allowed. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- drivers/ata/ahci.c | 154 - 1 file changed, 153 insertions(+), 1 deletion(-) Index: libata-dev/drivers/ata/ahci.c

[patch] ata: libata: add per device private data

2007-09-24 Thread Kristen Carlson Accardi
Allow host controllers to store private data per device. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- include/linux/libata.h |3 +++ 1 file changed, 3 insertions(+) Index: libata-dev/include/linux/libata.h

Re: [patch 1/2] Enable link power management for ata drivers

2007-09-24 Thread Kristen Carlson Accardi
On Tue, 25 Sep 2007 01:12:32 +0200 roel [EMAIL PROTECTED] wrote: #define ata_id_cdb_intr(id)(((id)[0] 0x60) == 0x20) +#define ata_id_has_hipm(id)\ + ( (((id)[76] != 0x) ((id)[76] != 0x)) \ + ((id)[76] (1 9)) ) ^ | are you

[patch] ata: increase allowed config flags

2007-09-11 Thread Kristen Carlson Accardi
In anticipation of more features, increase number of config flags allowed, and move the init flags. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Cc: Hugh Dickens [EMAIL PROTECTED] Index: 2.6-mm/include/linux/libata.h

Re: [patch 1/4] libata: check for AN support

2007-08-15 Thread Kristen Carlson Accardi
On Wed, 15 Aug 2007 03:59:10 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Since I wanted to get in Tejun's ata_link changes before this, this will require a rediff. But more importantly, as I was going to apply it I noticed another problem: we need to verify that SiS and NVIDIA both

Re: [patch 2/4] scsi: expose AN support to user space

2007-08-15 Thread Kristen Carlson Accardi
On Wed, 15 Aug 2007 09:01:49 -0500 James Bottomley [EMAIL PROTECTED] wrote: On Wed, 2007-08-15 at 04:13 -0400, Jeff Garzik wrote: Kristen Carlson Accardi wrote: If a scsi_device supports async notification for media change, then let user space know this capability exists by creating

Re: [patch 0/4] Updated AN patches, now without gendisk

2007-08-13 Thread Kristen Carlson Accardi
On Sat, 11 Aug 2007 16:00:53 +0200 Kay Sievers [EMAIL PROTECTED] wrote: On 8/8/07, Kristen Carlson Accardi [EMAIL PROTECTED] wrote: Here is an updated set of patches that implement Asynchronous Notification support for ATAPI devices. In this version I no longer export the AN capability

Re: [patch 3/4] Enable link power management for ata drivers

2007-08-13 Thread Kristen Carlson Accardi
Andrew, can you fold this into this patch change to KERN_INFO for failure to set pm policy Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- drivers/ata/libata-scsi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: 2.6-git/drivers/ata/libata-scsi.c

Re: [patch 2/4] Expose Power Management Policy option to users

2007-08-09 Thread Kristen Carlson Accardi
On Wed, 1 Aug 2007 14:16:51 -0700 Kristen Carlson Accardi [EMAIL PROTECTED] wrote: I was able to duplicate Tejun's problem on an ATAPI device I had here. this updated patch fixed my problem. These devices are just setting PhyReady (N) and CommWake (W) in Serror on power state changes

[patch 0/4] Updated SATA Link Power Management patches

2007-08-09 Thread Kristen Carlson Accardi
Hello, Here are some updated ALPM patches. These patches are different from the last version in that they now use the error handler to enable link power management. Please review and let me know what you think. Kristen -- - To unsubscribe from this list: send the line unsubscribe linux-ide in

[patch 1/4] Store interrupt value

2007-08-09 Thread Kristen Carlson Accardi
Use a stored value for which interrupts to enable. Changing this allows us to selectively turn off certain interrupts later and have them stay off. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/ahci.c

[patch 2/4] increase number of allowable device flags

2007-08-09 Thread Kristen Carlson Accardi
Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/include/linux/libata.h === --- 2.6-git.orig/include/linux/libata.h +++ 2.6-git/include/linux/libata.h @@ -139,7 +139,7 @@ enum { ATA_DFLAG_FLUSH_EXT

[patch 3/4] Enable link power management for ata drivers

2007-08-09 Thread Kristen Carlson Accardi
and intialized. Drivers should also define disable_pm, which will turn off link power management, but not change link power management policy. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/libata-scsi.c

[patch 4/4] Enable Aggressive Link Power management for AHCI controllers.

2007-08-09 Thread Kristen Carlson Accardi
idle. Hot plug not allowed. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/ahci.c === --- 2.6-git.orig/drivers/ata/ahci.c +++ 2.6-git/drivers/ata/ahci.c @@ -48,6 +48,9 @@ #define DRV_NAME

[patch 0/4] Updated AN patches, now without gendisk

2007-08-08 Thread Kristen Carlson Accardi
Hello, Here is an updated set of patches that implement Asynchronous Notification support for ATAPI devices. In this version I no longer export the AN capability through genhd, and the uevent is sent by the scsi_device instead of gendisk. I added a generic SCSI device event mechanism so that it

[patch 1/4] libata: check for AN support

2007-08-08 Thread Kristen Carlson Accardi
Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/libata-core.c === --- 2.6-git.orig/drivers/ata/libata-core.c

[patch 2/4] scsi: expose AN support to user space

2007-08-08 Thread Kristen Carlson Accardi
change events occur. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/include/scsi/scsi_device.h === --- 2.6-git.orig/include/scsi/scsi_device.h +++ 2.6-git/include/scsi/scsi_device.h @@ -46,6 +46,16 @@ enum

[patch 3/4] libata: expose AN to user space

2007-08-08 Thread Kristen Carlson Accardi
If Asynchronous Notification of media change events is supported, pass that information up to the SCSI layer. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/libata-scsi.c === --- 2.6-git.orig

[patch 4/4] libata: send event when AN received

2007-08-08 Thread Kristen Carlson Accardi
When we get an SDB FIS with the 'N' bit set, we should send an event to user space to indicate that there has been a media change. This will be done via the scsi device. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/ahci.c

Re: ICH8 CF timeout (regression)...

2007-08-06 Thread Kristen Carlson Accardi
On Sat, 04 Aug 2007 15:04:54 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Daniel J Blueman wrote: Tejun, On 03/08/07, Tejun Heo [EMAIL PROTECTED] wrote: Daniel J Blueman wrote: The ICH8 south-bridge I have is the mobile variant and does come equipped with native parallel IDE - see page

Re: [PATCH] ata_piix: update map 10b for ich8m

2007-08-06 Thread Kristen Carlson Accardi
On Tue, 7 Aug 2007 02:43:27 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Fix map entry 10b for ich8. It's [P0 P2 IDE IDE] like ich6 / ich6m. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Kristen Carlson Accardi [EMAIL PROTECTED] Acked-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- Many

Re: [patch 2/4] Expose Power Management Policy option to users

2007-08-01 Thread Kristen Carlson Accardi
On Wed, 01 Aug 2007 12:24:44 +0900 Tejun Heo [EMAIL PROTECTED] wrote: It would be *really* great if we can find more about how they do it. How and when it's enabled and on which systems. Is it possible to find this out? No - it's really not a good idea for us to go and ask other OS's how

Re: [patch 2/4] Expose Power Management Policy option to users

2007-08-01 Thread Kristen Carlson Accardi
On Wed, 01 Aug 2007 18:23:21 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Tejun Heo wrote: Arjan van de Ven wrote: They were hardware problems. I don't think any amount of proper implementation can fix them. I have one DVD RAM somewhere in my pile of hardware which locks up solidly if any

Re: [patch 3/4] Enable link power management for ata drivers

2007-08-01 Thread Kristen Carlson Accardi
On Wed, 01 Aug 2007 17:27:39 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Kristen Carlson Accardi wrote: snippy Is it safe to use ALPM on a device which only claims to support DIPM? Yes - I doubled checked this with the AHCI people - and of course you have Edvin's testing to prove it does fine

Re: [patch 1/4] Store interrupt value

2007-08-01 Thread Kristen Carlson Accardi
Store interrupt value Use a stored value for which interrupts to enable. Changing this allows us to selectively turn off certain interrupts later and have them stay off. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/ahci.c

Re: [patch 2/4] Expose Power Management Policy option to users

2007-08-01 Thread Kristen Carlson Accardi
On Wed, 01 Aug 2007 12:24:44 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Kristen Carlson Accardi wrote: I don't think the interface you're suggesting is a good one. Do you? I think if it's applicable to SCSI at all it is fine. If it is not, then I think we need to make do

[patch 0/3] Updated ALPM patches

2007-08-01 Thread Kristen Carlson Accardi
Hi, This is an updated series of ALPM patches. I moved all link power management stuff out of scsi sysfs and just use the shost_addr pointer in the host template to create the sysfs files. This provides the same interface as before, without requiring any scsi changes. I also fixed a bug in the

[patch 1/3] Store interrupt value

2007-08-01 Thread Kristen Carlson Accardi
Use a stored value for which interrupts to enable. Changing this allows us to selectively turn off certain interrupts later and have them stay off. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/ahci.c

[patch 2/3] Enable link power management for ata drivers

2007-08-01 Thread Kristen Carlson Accardi
and intialized. Drivers should also define disable_pm, which will turn off link power management, but not change link power management policy. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/libata-scsi.c

[patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-08-01 Thread Kristen Carlson Accardi
idle. Hot plug not allowed. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/ahci.c === --- 2.6-git.orig/drivers/ata/ahci.c +++ 2.6-git/drivers/ata/ahci.c @@ -48,6 +48,9 @@ #define DRV_NAME

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Kristen Carlson Accardi
On Tue, 31 Jul 2007 23:45:25 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Anyways, I don't really think this attribute belongs to SCSI sysfs hierarchy. There currently isn't any alternative but sysfs is part of userland visible interface and putting something into SCSI sysfs hierarchy just

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Kristen Carlson Accardi
On Tue, 31 Jul 2007 15:27:34 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Jeff Garzik wrote: Any chance the SCSI peeps could ACK this, and then let me include it in the ALPM patchset in the libata tree? ATA link PS is pretty complex with HIPM, DIPM and AHCI ALPM. I'm not sure whether this

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Kristen Carlson Accardi
On Wed, 01 Aug 2007 03:02:55 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Kristen Carlson Accardi wrote: I think what you are saying is that you'd like a way to use your HIPM and DIPM without ALPM on the AHCI driver. Fine - it's really easy to add these levels later - if they don't make sense

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Kristen Carlson Accardi
On Wed, 01 Aug 2007 02:48:42 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Hello, Kristen. Kristen Carlson Accardi wrote: On Tue, 31 Jul 2007 23:45:25 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Anyways, I don't really think this attribute belongs to SCSI sysfs hierarchy. There currently

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-11 Thread Kristen Carlson Accardi
On Mon, 9 Jul 2007 19:36:04 + Pavel Machek [EMAIL PROTECTED] wrote: Hi! This patch will modify the scsi subsystem to allow users to set a power management policy for the link. The scsi subsystem will create a new sysfs file for each host in /sys/class/scsi_host called

[patch 0/4] SATA power savings patches (ALPM)

2007-07-05 Thread Kristen Carlson Accardi
Hi Jeff, Here's the most recent patches for ALPM. These are also located at: http://www.kernel.org/pub/linux/kernel/people/kristen/patches/SATA/alpm These patches implement Aggressive Link Power management for AHCI controllers. This feature is described in detail in the AHCI 1.x spec. It

[patch 1/4] Store interrupt value

2007-07-05 Thread Kristen Carlson Accardi
Use a stored value for which interrupts to enable. Changing this allows us to selectively turn off certain interrupts later and have them stay off. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/ahci.c

[patch 3/4] Enable link power management for ata drivers

2007-07-05 Thread Kristen Carlson Accardi
and intialized. Drivers should also define disable_pm, which will turn off link power management, but not change link power management policy. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/libata-scsi.c

[patch 4/4] Enable Aggressive Link Power management for AHCI controllers.

2007-07-05 Thread Kristen Carlson Accardi
idle. Hot plug not allowed. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/ahci.c === --- 2.6-git.orig/drivers/ata/ahci.c +++ 2.6-git/drivers/ata/ahci.c @@ -48,6 +48,9 @@ #define DRV_NAME

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-26 Thread Kristen Carlson Accardi
Carlson Accardi [EMAIL PROTECTED] Will you integrate it into the next posting? yes, I will do that. Kristen - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: ALPM on devices not supporting HIPM?

2007-06-26 Thread Kristen Carlson Accardi
On Sat, 23 Jun 2007 14:23:12 +0300 Török Edvin [EMAIL PROTECTED] wrote: Hi, With the ALPM patches I get: Unable to set link PM policy. [until now I've tested only the combination of your, and Tejun's port-stopping patch, as I already reported in a past thread] It looks like my device

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-22 Thread Kristen Carlson Accardi
On Thu, 21 Jun 2007 15:08:32 +0200 Jens Axboe [EMAIL PROTECTED] wrote: On Wed, Jun 20 2007, Kristen Carlson Accardi wrote: Enable Aggressive Link Power management for AHCI controllers. This patch will set the correct bits to turn on Aggressive Link Power Management (ALPM) for the ahci

Re: [patch 2b/3] Expose Power Management Policy option to users

2007-06-20 Thread Kristen Carlson Accardi
will be activated after all disks have been enumerated and initialized. Drivers should also define disable_pm, which will turn off link power management, but not change link power management policy. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- I've updated this patch to fix a problem

[patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-20 Thread Kristen Carlson Accardi
second lowest power state (PARTIAL) when idle. Hot plug not allowed. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- I've changed this patch to define disable_pm, and to change the behavior of ahci_disable_alpm() to not change the link pm policy, and just

Re: [patch 2a/3] Expose Power Management Policy option to users

2007-06-14 Thread Kristen Carlson Accardi
On Wed, 13 Jun 2007 08:26:48 -0700 James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2007-06-12 at 10:46 -0700, Kristen Carlson Accardi wrote: Expose Power Management Policy option to users This patch will modify the scsi subsystem to allow users to set a power management policy

Re: [patch 0/3] AHCI Link Power Management

2007-06-13 Thread Kristen Carlson Accardi
On Wed, 13 Jun 2007 11:04:30 +0200 Pavel Machek [EMAIL PROTECTED] wrote: Hi! I'm not sure about this. We need better PM framework to support powersaving in other controllers and some ahcis don't save much when only link power management is used, do you have data to support

Re: [patch 0/3] AHCI Link Power Management

2007-06-12 Thread Kristen Carlson Accardi
On Tue, 12 Jun 2007 13:40:15 +0900 Tejun Heo [EMAIL PROTECTED] wrote: I don't think the end result will vary in any significant way. My biggest argument for sw implementation is it can be used for other controllers. What I had in mind when I created the new port operation enable_pm was that

[patch 0/3] AHCI Link Power Management

2007-06-11 Thread Kristen Carlson Accardi
Hi, This series of patches enables Aggressive Link Power Management for AHCI devices, as documented in the AHCI spec. On my laptop (a Lenovo X60), this saves me a full watt of power. On other systems, reported power savings range from .5-1.5 Watts. It has been tested by the kind folks at

[patch 2/3] Expose Power Management Policy option to users

2007-06-11 Thread Kristen Carlson Accardi
power savings, with less performance cost than min_power (but less power savings as well). Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/libata-scsi.c === --- 2.6-git.orig/drivers

[patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-11 Thread Kristen Carlson Accardi
idle. Hot plug not allowed. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/ahci.c === --- 2.6-git.orig/drivers/ata/ahci.c +++ 2.6-git/drivers/ata/ahci.c @@ -48,6 +48,9 @@ #define DRV_NAME

Re: [PATCH] AHCI powersaving and port-stopping (2.6.22-rc4)

2007-06-11 Thread Kristen Carlson Accardi
On Mon, 11 Jun 2007 07:05:38 -0700 Arjan van de Ven [EMAIL PROTECTED] wrote: This is very different from the patch I posted a while ago turning on a few bits in the CMD register (ALPE and ASP) and which Intel is we've not seen a patch that actually works in this area unfortunately. We

Re: [patch 1/7] libata: check for AN support

2007-06-11 Thread Kristen Carlson Accardi
On Thu, 24 May 2007 23:15:56 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Kristen Carlson Accardi wrote: Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- Andrew, I cleaned up the function

Re: [patch 5/7] genhd: send async notification on media change

2007-05-23 Thread Kristen Carlson Accardi
On Tue, 22 May 2007 14:12:11 -0700 Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 9 May 2007 16:38:35 -0700 Kristen Carlson Accardi [EMAIL PROTECTED] wrote: Send an uevent to user space to indicate that a media change event has occurred. Signed-off-by: Kristen Carlson Accardi [EMAIL

Re: [patch 5/7] genhd: send async notification on media change

2007-05-23 Thread Kristen Carlson Accardi
On Wed, 23 May 2007 12:03:55 -0500 James Bottomley [EMAIL PROTECTED] wrote: On Wed, 2007-05-23 at 09:31 -0700, Kristen Carlson Accardi wrote: On Tue, 22 May 2007 14:12:11 -0700 Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 9 May 2007 16:38:35 -0700 Kristen Carlson Accardi [EMAIL

Re: [patch 5/7] genhd: send async notification on media change

2007-05-23 Thread Kristen Carlson Accardi
On Wed, 23 May 2007 13:51:51 -0500 James Bottomley [EMAIL PROTECTED] wrote: On Wed, 2007-05-23 at 11:26 -0700, Kristen Carlson Accardi wrote: On Wed, 23 May 2007 12:03:55 -0500 James Bottomley [EMAIL PROTECTED] wrote: On Wed, 2007-05-23 at 09:31 -0700, Kristen Carlson Accardi wrote

Re: [patch 1/7] libata: check for AN support

2007-05-10 Thread Kristen Carlson Accardi
Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- Andrew, I cleaned up the function header to properly comply with kernel doc requirements. Other than that, this patch is the same. Index: 2.6-mm

[patch 0/7] Asynchronous Notification for ATAPI devices (resend)

2007-05-09 Thread Kristen Carlson Accardi
Hi Jeff, Here are the AN patches again, they have not changed with the exception of patch #1, which does set the host flag in board_ahci and board_ahci_pi now (thanks Tejun). This patch series implements Asynchronous Notification (AN) for SATA ATAPI devices as defined in SATA 2.5 and AHCI 1.1 and

[patch 1/7] libata: check for AN support

2007-05-09 Thread Kristen Carlson Accardi
Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/libata-core.c === --- 2.6-git.orig/drivers/ata/libata-core.c

[patch 2/7] genhd: expose AN to user space

2007-05-09 Thread Kristen Carlson Accardi
to define the media change notification capability. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/block/genhd.c === --- 2.6-git.orig/block/genhd.c +++ 2.6-git/block/genhd.c @@ -370,7 +370,10 @@ static ssize_t

[patch 3/7] scsi: expose AN to user space

2007-05-09 Thread Kristen Carlson Accardi
Get media change notification capability from disk and pass this information to genhd by setting appropriate flag. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/scsi/sr.c === --- 2.6-git.orig

[patch 5/7] genhd: send async notification on media change

2007-05-09 Thread Kristen Carlson Accardi
Send an uevent to user space to indicate that a media change event has occurred. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/block/genhd.c === --- 2.6-git.orig/block/genhd.c +++ 2.6-git/block/genhd.c

[patch 6/7] SCSI: save disk in scsi_device

2007-05-09 Thread Kristen Carlson Accardi
Give anyone who has access to scsi_device access to the genhd struct as well. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/scsi/sd.c === --- 2.6-git.orig/drivers/scsi/sd.c +++ 2.6-git/drivers/scsi

[patch 7/7] libata: send event when AN received

2007-05-09 Thread Kristen Carlson Accardi
When we get an SDB FIS with the 'N' bit set, we should send an event to user space to indicate that there has been a media change. This will be done via the block device. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/ahci.c

Re: [patch 0/7] Asynchronous Notification for ATAPI devices (v2) - resend

2007-05-07 Thread Kristen Carlson Accardi
On Sun, 06 May 2007 12:15:34 +0200 Tejun Heo [EMAIL PROTECTED] wrote: Kristen Carlson Accardi wrote: This patch series implements Asynchronous Notification (AN) for SATA ATAPI devices as defined in SATA 2.5 and AHCI 1.1 and higher. Drives which support this feature will send

[patch 0/7] Asynchronous Notification for ATAPI devices (v2) - resend

2007-05-04 Thread Kristen Carlson Accardi
This patch series implements Asynchronous Notification (AN) for SATA ATAPI devices as defined in SATA 2.5 and AHCI 1.1 and higher. Drives which support this feature will send a notification when new media is inserted and removed, preventing the need for user space to poll for new media. This

[patch 1/7] libata: check for AN support - resend

2007-05-04 Thread Kristen Carlson Accardi
Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. Changes from last version: * use parens around id in ata.h Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/libata-core.c

[patch 2/7] genhd: expose AN to user space - resend

2007-05-04 Thread Kristen Carlson Accardi
to define the media change notification capability. Changed from last version: * changed sysfs filename to capability from capability_flags Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/block/genhd.c === --- 2.6

[patch 3/7] scsi: expose AN to user space - resend

2007-05-04 Thread Kristen Carlson Accardi
Get media change notification capability from disk and pass this information to genhd by setting appropriate flag. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/scsi/sr.c === --- 2.6-git.orig

[patch 4/7] libata: expose AN to user space - resend

2007-05-04 Thread Kristen Carlson Accardi
If Asynchronous Notification of media change events is supported, pass that information up to the SCSI layer. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/libata-scsi.c === --- 2.6-git.orig

[patch 6/7] SCSI: save disk in scsi_device - resend

2007-05-04 Thread Kristen Carlson Accardi
Give anyone who has access to scsi_device access to the genhd struct as well. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/scsi/sd.c === --- 2.6-git.orig/drivers/scsi/sd.c +++ 2.6-git/drivers/scsi

[patch 7/7] libata: send event when AN received - resend

2007-05-04 Thread Kristen Carlson Accardi
When we get an SDB FIS with the 'N' bit set, we should send an event to user space to indicate that there has been a media change. This will be done via the block device. changed from last version: * Make sure that port_addr is within ATA_MAX_DEVICES Signed-off-by: Kristen Carlson Accardi

Re: [patch 5/7] genhd: send async notification on media change

2007-05-04 Thread Kristen Carlson Accardi
Send an uevent to user space to indicate that a media change event has occurred. Changes from last version: * use get/put_device to increment reference count on the device struct Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/block/genhd.c

Re: [patch 0/7] Asynchronous Notification for ATAPI devices (v2) - resend

2007-05-04 Thread Kristen Carlson Accardi
On Fri, 04 May 2007 15:30:03 -0500 James Bottomley [EMAIL PROTECTED] wrote: On Fri, 2007-05-04 at 11:12 -0700, Kristen Carlson Accardi wrote: This patch series implements Asynchronous Notification (AN) for SATA ATAPI devices as defined in SATA 2.5 and AHCI 1.1 and higher. Drives which

Re: [patch 1/7] libata: check for AN support

2007-04-25 Thread Kristen Carlson Accardi
On Wed, 25 Apr 2007 02:49:46 +0200 Olivier Galibert [EMAIL PROTECTED] wrote: On Tue, Apr 24, 2007 at 01:53:27PM -0700, Kristen Carlson Accardi wrote: Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. changes from last version: * fix typo

  1   2   >