[PATCH ht6560b] Force prefetch for some devices

2008-02-18 Thread Jan Evert van Grootheest
Prefetch needs to be set for some ide devices to work when connected to a ht6560b interface. This was not always done properly, causing a system with a HD and CD on the primary interface to not work properly. Or, in effect, hang hard. This patch forces prefetch on devices before checking whether

Re: [PATCH ht6560b] Force prefetch for some devices

2008-02-18 Thread Sergei Shtylyov
Hello. Jan Evert van Grootheest wrote: Prefetch needs to be set for some ide devices to work when connected to Prefetch bit seems to mean 1=disable, 0=enable despite what the datasheet says... a ht6560b interface. This was not always done properly, causing a system with a HD and CD on

[PATCH] ht6560b can only do up to PIO mode 4

2008-02-18 Thread Jan Evert van Grootheest
According to the datasheet, ht6560b only supports up to PIO mode 4. Signed-off-by: Jan Evert van Grootheest [EMAIL PROTECTED] --- a/drivers/ide/legacy/ht6560b.c +++ b/drivers/ide/legacy/ht6560b.c @@ -343,7 +343,7 @@ int __init ht6560b_init(void) hwif-chipset = ide_ht6560b; hwif-selectproc =

[PATCH] next-20080218 build failure at pmac_ide_macio_attach ()

2008-02-18 Thread Kamalesh Babulal
Hi, The next-20080218 kernel build fails on the powerpc(s) drivers/ide/ppc/pmac.c: In function ‘pmac_ide_macio_attach’: drivers/ide/ppc/pmac.c:1094: error: conversion to non-scalar type requested drivers/ide/ppc/pmac.c: In function ‘pmac_ide_pci_attach’: drivers/ide/ppc/pmac.c:1232: error

DMA on ht6560b?

2008-02-18 Thread Jan Evert van Grootheest
Hi, With digging into the code... I think the ht6560b controller supports DMA. At least it did so in 2.2 (where hdparm could still turn it on). DMA in 2.2 would improve the HD from about 1M/s to 4M/s. So that's quite interesting. Also the datasheet claims that there is full ANSI ATA-4a

Re: [PATCH] next-20080218 build failure at pmac_ide_macio_attach ()

2008-02-18 Thread Andreas Schwab
Kamalesh Babulal [EMAIL PROTECTED] writes: --- linux-2.6.25-rc1/drivers/ide/ppc/pmac.c 2008-02-18 18:41:48.0 +0530 +++ linux-2.6.25-rc1/drivers/ide/ppc/~pmac.c 2008-02-18 19:20:37.0 +0530 @@ -1091,7 +1091,7 @@ pmac_ide_macio_attach(struct macio_dev * int irq, rc;

Re: [PATCH ht6560b] Force prefetch for some devices

2008-02-18 Thread Alan Cox
On Mon, 18 Feb 2008 13:50:02 +0100 Jan Evert van Grootheest [EMAIL PROTECTED] wrote: Prefetch needs to be set for some ide devices to work when connected to a ht6560b interface. This was not always done properly, causing a system with a HD and CD on the primary interface to not work properly.

Re: DMA on ht6560b?

2008-02-18 Thread Alan Cox
I think the ht6560b controller supports DMA. The data sheet doesn't. It's a PIO controller capable of PIO4 with 32bit host to cpu transfers are best. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: DMA on ht6560b?

2008-02-18 Thread Jan Evert van Grootheest
Alan Cox wrote: I think the ht6560b controller supports DMA. The data sheet doesn't. It's a PIO controller capable of PIO4 with 32bit host to cpu transfers are best. Hmm. But what do you then think that 2.2 did? I mean it now does 1.15M/s and in 2.2 it would do ~4M/s with DMA on.

Re: Optiarc DVD RW AD-5200A audio playing

2008-02-18 Thread Stefan Bader
Borislav Petkov wrote: On Sat, Feb 16, 2008 at 04:24:01PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, On Saturday 16 February 2008, Borislav Petkov wrote: On Fri, Feb 15, 2008 at 02:53:27PM -0500, Stefan Bader wrote: Hello Borislav, I worked on a problem with an DVD driver (model=Optiarc

Re: [PATCH 1/4] ide: fix sparse warning about shadowing 'flags' symbol

2008-02-18 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: drivers/ide/ide.c:801:18: warning: symbol 'flags' shadows an earlier one drivers/ide/ide.c:732:16: originally declared here Also fix some whitespace damage while at it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov

Re: [PATCH 7/9] ht6560b: use driver name for resource allocation

2008-02-18 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH ht6560b] Force prefetch for some devices

2008-02-18 Thread Jan Evert van Grootheest
Alan, Alan Cox wrote: On Mon, 18 Feb 2008 13:50:02 +0100 Jan Evert van Grootheest [EMAIL PROTECTED] wrote: Prefetch needs to be set for some ide devices to work when connected to a ht6560b interface. This was not always done properly, causing a system with a HD and CD on the primary

Re: 2.6.25 Regression: DriveStatusError

2008-02-18 Thread Daniel Exner
Hi! Bartlomiej Zolnierkiewicz wrote: On Monday 11 February 2008, Daniel Exner wrote: Hi! Please CC me as I'm not subscribed to any list, thx in advance. I tried all -git Kernels since begining of cycle and starting when they finaly compiled fine, they weren't able to mount my root.

[Bug 3615] Kernels 2.6.9 and 2.6.10-rc1 hang for 30 seconds during boot

2008-02-18 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=3615 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Status|NEW

Re: [PATCH 1/5] ide: remove PIO downgrade quirk

2008-02-18 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: No need for it nowadays Since which moment, could you elaborate so remove quirk code from ide_get_best_pio_mode() and IDE_HFLAG_PIO_DOWNGRADE host flag. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this

Re: [PATCH 2/4] ide-disk: add missing printk() KERN_* levels

2008-02-18 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH ht6560b] Force prefetch for some devices

2008-02-18 Thread Alan Cox
I think, but didn't look real good nor test yet, that pata_legacy also needs something comparable to select_proc? Or is that implemented in some generic manner? It sets it in the timing routine: pata_legacy:ht6560b_set_piomode - To unsubscribe from this list: send the line

Re: DMA on ht6560b?

2008-02-18 Thread Alan Cox
Hmm. But what do you then think that 2.2 did? PIO4 I mean it now does 1.15M/s and in 2.2 it would do ~4M/s with DMA on. It's never done DMA. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH] sata_mv: remove iounmap in mv_platform_remove and use devm_iomap

2008-02-18 Thread Saeed Bishara
this will fix crash bug when doing rmmod to the driver, this is because the port_stop function get called later and it could access the device's registers. Signed-off-by: Saeed Bishara [EMAIL PROTECTED] --- drivers/ata/sata_mv.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-)

[PATCH-RESEND] next-20080218 build failure at pmac_ide_macio_attach ()

2008-02-18 Thread Kamalesh Babulal
On Mon, Feb 18, 2008 at 03:17:49PM +0100, Andreas Schwab wrote: Kamalesh Babulal [EMAIL PROTECTED] writes: . . snip Just remove the cast. Andreas. Resending the patch after making the changes Andreas said. Signed-off-by: Kamalesh Babulal [EMAIL PROTECTED] Cc: Andreas Schwab [EMAIL

Re: [PATCH 1/5] ide: remove PIO downgrade quirk

2008-02-18 Thread Bartlomiej Zolnierkiewicz
Hi Sergei, On Feb 18, 2008 5:06 PM, Sergei Shtylyov [EMAIL PROTECTED] wrote: Bartlomiej Zolnierkiewicz wrote: No need for it nowadays Since which moment, could you elaborate We fixed: - PIO auto-tuning in core code - PIO programming in host drivers - IORDY handling in core code and

Re: [PATCH 8/9] qd65xx: return error value in qd_probe()

2008-02-18 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Return error value in qd_probe() and use it in qd65xx_init() instead of checking ide_hwifs[].chipset. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send

atapi_dmadir: why do we not (also) auto-detect it from IDENTIFY PACKET ??

2008-02-18 Thread Mark Lord
Albert / Jeff, Way back in 2.6.17-rc2, you guys signed-off on 95de719adc94392a95c3c4d0a2d6b8b1ea39d236, which added a libata module parameter for atapi_dmadir. That's nice, but many modern drives (or bridge chips) flag this in their IDENTIFY PACKET response, as bit-15 of word-62 of the

Re: Current qc_defer implementation may lead to infinite recursion

2008-02-18 Thread Elias Oltmanns
Hi Tejun, Tejun Heo [EMAIL PROTECTED] wrote: Elias Oltmanns wrote: Tejun Heo [EMAIL PROTECTED] wrote: Elias Oltmanns wrote: This proves that piix_qc_defer() has declined the same command 100 times in succession. However, this will only happen if the status of all the commands enqueued for

Re: [PATCH] libata-scsi: automatically use DMADIR if drive/bridge requires it

2008-02-18 Thread Alan Cox
On Mon, Feb 18, 2008 at 03:53:46PM -0500, Mark Lord wrote: + /* some SATA bridges need us to indicate data xfer direction */ + if (atapi_dmadir || (dev-id[62] 0x8000)) The rest of the code uses ata_ inlines/defines in ata.h for things like this and religiously checks

Re: [PATCH] libata-scsi: automatically use DMADIR if drive/bridge requires it

2008-02-18 Thread Mark Lord
Alan Cox wrote: On Mon, Feb 18, 2008 at 03:53:46PM -0500, Mark Lord wrote: + /* some SATA bridges need us to indicate data xfer direction */ + if (atapi_dmadir || (dev-id[62] 0x8000)) The rest of the code uses ata_ inlines/defines in ata.h for things like this and religiously

hdparm-8.2 now available

2008-02-18 Thread Mark Lord
hdparm for SATA/PATA has now been updated to version 8.2. Upgrading is strongly recommended for all users. This version fixes several bugs in earlier 7.x/8.x releases that could cause issues when advanced features are attempted on devices being driven by the old drivers/ide subsystem. libata

Re: [PATCH] next-20080218 build failure at pmac_ide_macio_attach ()

2008-02-18 Thread Bartlomiej Zolnierkiewicz
On Monday 18 February 2008, Kamalesh Babulal wrote: Hi, The next-20080218 kernel build fails on the powerpc(s) drivers/ide/ppc/pmac.c: In function ‘pmac_ide_macio_attach’: drivers/ide/ppc/pmac.c:1094: error: conversion to non-scalar type requested drivers/ide/ppc/pmac.c: In function

Re: Optiarc DVD RW AD-5200A audio playing

2008-02-18 Thread Bartlomiej Zolnierkiewicz
On Monday 18 February 2008, Stefan Bader wrote: Borislav Petkov wrote: On Sat, Feb 16, 2008 at 04:24:01PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, On Saturday 16 February 2008, Borislav Petkov wrote: On Fri, Feb 15, 2008 at 02:53:27PM -0500, Stefan Bader wrote: Hello Borislav,

Re: [PATCH ht6560b] Force prefetch for some devices

2008-02-18 Thread Bartlomiej Zolnierkiewicz
On Monday 18 February 2008, Jan Evert van Grootheest wrote: Prefetch needs to be set for some ide devices to work when connected to a ht6560b interface. This was not always done properly, causing a system with a HD and CD on the primary interface to not work properly. Or, in effect, hang hard.

Re: [PATCH] ht6560b can only do up to PIO mode 4

2008-02-18 Thread Bartlomiej Zolnierkiewicz
On Monday 18 February 2008, Jan Evert van Grootheest wrote: According to the datasheet, ht6560b only supports up to PIO mode 4. Signed-off-by: Jan Evert van Grootheest [EMAIL PROTECTED] applied, thanks! PS I had to manually port it over 2.6.25-rc2, patch below From: Jan Evert van Grootheest

[git patches] IDE fixes

2008-02-18 Thread Bartlomiej Zolnierkiewicz
Hi, This update fixes all known/open 2.6.25 IDE regressions + few other things: - fix ide-cd cd/dvd burning regression (Kiyoshi Ueda) - fix falconide/macide regressions (Geert Uytterhoeven) - another device needs HPA workaround (Mikko Rapeli) - ht6560b bugfixes (Jan Evert van Grootheest) -

sata_sil24 stability and performance

2008-02-18 Thread Denys Dmytriyenko
Hi Gurus! Preamble: I've been following this list for several months now trying to spot a similar issue or to gain knowledge to resolve mine. I'm pretty sure the problem is with my setup/configuration, but I've been unable to fix it so far. I would be eternally grateful if someone can help me in

Re: sata_sil24 stability and performance

2008-02-18 Thread Jim Paris
Denys Dmytriyenko wrote: I've been following this list for several months now trying to spot a similar issue or to gain knowledge to resolve mine. .. I'm running a fileserver with array of 10 disks (8 Seagate 500GB 7200.9 and 7200.10 plus 2 Maxtors) .. Power supply was originally 550 watt

Re: Optiarc DVD RW AD-5200A audio playing

2008-02-18 Thread Borislav Petkov
On Tue, Feb 19, 2008 at 12:18:48AM +0100, Bartlomiej Zolnierkiewicz wrote: On Monday 18 February 2008, Stefan Bader wrote: Borislav Petkov wrote: On Sat, Feb 16, 2008 at 04:24:01PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, On Saturday 16 February 2008, Borislav Petkov wrote: On

Re: sata_sil24 stability and performance

2008-02-18 Thread Denys Dmytriyenko
On Mon, Feb 18, 2008 at 11:36:59PM -0500, Jim Paris wrote: Denys Dmytriyenko wrote: I've been following this list for several months now trying to spot a similar issue or to gain knowledge to resolve mine. .. I'm running a fileserver with array of 10 disks (8 Seagate 500GB 7200.9 and