[PATCH 01/11] ata: fix sparse warning in ata_piix.c

drivers/ata/ata_piix.c:1655:8: warning: symbol 'rc' shadows an earlier one drivers/ata/ata_piix.c:1616:6: originally declared here Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/ata/ata_piix.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ata

[PATCH 03/11] ata: fix sparse warning in sata_via.c

drivers/ata/sata_via.c:336:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/ata/sata_via.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c index 30caa03..0d03f44

[PATCH 04/11] ata: fix sparse warnings in sata_mv.c

/sata_mv.c:1501:22: originally declared here Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/ata/sata_mv.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index 04b5717..2ecd44d 100644 --- a/drivers/ata/sata_mv.c +++ b

[PATCH 05/11] ata: replace macro with static inline in libata.h

Avoid a metric ton of sparse warnings like: drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one drivers/ata/pata_ali.c:176:14: originally declared here Due to nesting min_t macro inside max_t macro which both use a __x identifier internally. Signed-off-by: Harvey Harrison

[PATCH 06/11] ata: sparse fixes for pata_amd.c

/pata_amd.c:509:3: warning: Initializer entry defined twice drivers/ata/pata_amd.c:521:3: also defined here drivers/ata/pata_amd.c:544:3: warning: Initializer entry defined twice drivers/ata/pata_amd.c:556:3: also defined here Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/ata

[PATCH 07/11] ata: fix sparse warning in pata_cs5536.c

Everybody passes in a u32...why fight it. drivers/ata/pata_cs5536.c:124:26: warning: incorrect type in argument 3 (different signedness) drivers/ata/pata_cs5536.c:124:26:expected int *val drivers/ata/pata_cs5536.c:124:26:got unsigned int *noident Signed-off-by: Harvey Harrison [EMAIL

[PATCH 08/11] ata: fix sparse warning in pata_jmicron.c

drivers/ata/pata_jmicron.c:118:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/ata/pata_jmicron.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/ata/pata_jmicron.c b/drivers/ata/pata_jmicron.c index

[PATCH 09/11] ata: fix sparse warning in pata_marvell.c

drivers/ata/pata_marvell.c:88:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/ata/pata_marvell.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_marvell.c b/drivers/ata/pata_marvell.c index

[PATCH 10/11] ata: fix sparse warning in pata_acpi.c

drivers/ata/pata_acpi.c:80:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/ata/pata_acpi.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_acpi.c b/drivers/ata/pata_acpi.c index 244098a

[PATCH 11/11] ata: fix sparse warnings in pata_legacy.c

:128:12: originally declared here drivers/ata/pata_legacy.c:1040:21: warning: symbol 'winbond' shadows an earlier one drivers/ata/pata_legacy.c:129:12: originally declared here Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/ata/pata_legacy.c | 44

[PATCH 02/11] ata: fix sparse warning in sata_promise.c

drivers/ata/sata_promise.c:546:15: warning: symbol 'len' shadows an earlier one drivers/ata/sata_promise.c:538:6: originally declared here len is set again immediately after the loop, so this is safe. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/ata/sata_promise.c |2 +- 1

sparse patches for libata

Just a note to let you know that with the series of 11 patches I just sent, libata is almost sparse-clean on X86_32 (~250 sparse warnings to ~40). The remaining warnings are: drivers/ata/libata-core.c:7089:7: warning: symbol 'rc' shadows an earlier one drivers/ata/libata-core.c:7030:9:

[PATCH 11/11v2] ata: fix sparse warnings in pata_legacy.c

' shadows an earlier one drivers/ata/pata_legacy.c:128:12: originally declared here drivers/ata/pata_legacy.c:1040:21: warning: symbol 'winbond' shadows an earlier one drivers/ata/pata_legacy.c:129:12: originally declared here Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- Alan Cox's suggestion

Re: [PATCH 05/11] ata: replace macro with static inline in libata.h

On Thu, 2008-02-14 at 12:01 +, Alan Cox wrote: On Wed, 13 Feb 2008 21:14:18 -0800 Harvey Harrison [EMAIL PROTECTED] wrote: Avoid a metric ton of sparse warnings like: drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one drivers/ata/pata_ali.c:176:14: originally

[PATCH 05/11v2] ata: replace macro with static inline in libata.h

inside max_t macro which both use a __x identifier internally. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- Alan, is this more to your liking? include/linux/libata.h |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/include/linux/libata.h b/include/linux

[PATCH 2/3] ata: fix sparse warning in libata-core.c

rc is used to test the return value and possibly return an error. No need to redeclare inside the loop. drivers/ata/libata-core.c:7089:7: warning: symbol 'rc' shadows an earlier one drivers/ata/libata-core.c:7030:9: originally declared here Signed-off-by: Harvey Harrison [EMAIL PROTECTED

[PATCH 1/3] ata: make ata_scsiop_inq_89 static in libata-scsi.c

Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/ata/libata-scsi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index c02c490..1cea18f 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata

[PATCH 3/3] ata: simplify clock divisor logic in pata_amd.c

-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/ata/pata_amd.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/ata/pata_amd.c b/drivers/ata/pata_amd.c index 4b8d9b5..eaadb78 100644 --- a/drivers/ata/pata_amd.c +++ b/drivers/ata/pata_amd.c @@ -56,7 +56,10

[RFC-UGLYPATCH] ata: small optimization in linux/libata.h

sata_pmp_detach+0xbb Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- I know it's ugly, but I had it done anyways. The one real problem I have with it is that if link and ap-pmp_link ever get changed to different types the compiler will not even warn as we cast away to (char *). To make it a bit more

Re: [RFC-UGLYPATCH] ata: small optimization in linux/libata.h

On Fri, 2008-02-15 at 08:39 +0900, Tejun Heo wrote: Harvey Harrison wrote: This patch may be too ugly to live, it suppresses a lot of sparse warnings in the libata build and produces slightly tighter code. (4 instructions vs 5 and a few bytes saved). include/linux/libata.h:1214:13

Re: [PATCH 1/3] ata: make ata_scsiop_inq_89 static in libata-scsi.c

On Fri, 2008-02-15 at 13:51 -0500, Jeff Garzik wrote: Harvey Harrison wrote: Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/ata/libata-scsi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) applied 1-2 of 3 Any particular objection to 3/3? Harvey

[PATCH] ata: fix sparse warnings in pata_legacy.c

' shadows an earlier one drivers/ata/pata_legacy.c:128:12: originally declared here drivers/ata/pata_legacy.c:1040:21: warning: symbol 'winbond' shadows an earlier one drivers/ata/pata_legacy.c:129:12: originally declared here Acked-by: Alan Cox [EMAIL PROTECTED] Signed-off-by: Harvey Harrison [EMAIL

[PATCH 5/11v2] ata: replace macro with static inline in libata.h

Due to nesting min_t macro inside max_t macro which both use a __x identifier internally. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- include/linux/libata.h |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/include/linux/libata.h b/include/linux/libata.h index

Re: [PATCH 5/11v2] ata: replace macro with static inline in libata.h

On Fri, 2008-02-15 at 22:53 +, Alan Cox wrote: NAK. This is a sparse bug, fix sparse. Yes, fair enough, but that's not all the patch is about. 1) it's using a max_t and min_t to force the comparisons as shorts, why not just make it a static inline? Because max_t and min_t

[PATCH] ata: fix sparse warning in libata.h

Avoids lots of these, also is more readable. include/linux/libata.h:1210:13: warning: potentially expensive pointer subtraction Change the subtraction to addition on the other side of the comparison. Thanks to Christer Weinigel for the suggestion. Signed-off-by: Harvey Harrison [EMAIL

Re: [PATCH 5/11v2] ata: replace macro with static inline in libata.h

On Fri, 2008-02-15 at 22:30 +, Alan Cox wrote: On Fri, 15 Feb 2008 14:06:55 -0800 Harvey Harrison [EMAIL PROTECTED] wrote: Move to using a static inline which will force the same typechecking that min_t/max_t do (in this case, short). As a bonus, avoid a ton of sparse warnings like

Re: [PATCH 5/11v2] ata: replace macro with static inline in libata.h

On Sat, 2008-02-16 at 00:05 +, Alan Cox wrote: On Fri, 15 Feb 2008 15:08:50 -0800 Harvey Harrison [EMAIL PROTECTED] wrote: On Fri, 2008-02-15 at 22:53 +, Alan Cox wrote: NAK. This is a sparse bug, fix sparse. Yes, fair enough, but that's not all the patch is about

Re: [PATCH 5/11v2] ata: replace macro with static inline in libata.h

From: Harvey Harrison [EMAIL PROTECTED] Subject: [PATCH 3/3] ata: simplify clock divisor logic in pata_amd.c Current code is essentially choosing between dividing by 1 or dividing by two, make the conditions a little more obvious. As a bonus, removes a sparse error: drivers/ata/pata_amd.c:59:11