Re: stable basic 4-port SATA card

2007-11-15 Thread Mikael Pettersson
On Thu, 15 Nov 2007 12:32:14 +0900, Tejun Heo wrote: > * sata_promise: Generally works okay; however there are still some > problems with recent 3Gbps chips. (Mikael, please pitch in) Right, 2nd-gen 3Gbps chips have had "intermittent" issues, which we hope are cured by the recent ASIC bug workarou

Re: [PATCH RFC] sata_promise: make pdc_atapi_pkt() use values from qc->tf

2007-11-26 Thread Mikael Pettersson
On Mon, 26 Nov 2007 20:34:38 +0900, Tejun Heo wrote: > Make pdc_atapi_pkt() use values from qc->tf instead of creating its > own. This is to ease future ATAPI handling changes. > > DONT APPLY YET > --- > Mikael, would this work? Values other than lbam and lbah remain the > same. Does sata_promi

Re: [PATCH RFC] sata_promise: make pdc_atapi_pkt() use values from qc->tf

2007-12-02 Thread Mikael Pettersson
On Sat, 01 Dec 2007 18:23:44 -0500, Jeff Garzik wrote: > Tejun Heo wrote: > > Make pdc_atapi_pkt() use values from qc->tf instead of creating its > > own. This is to ease future ATAPI handling changes. > > > > DONT APPLY YET > > --- > > Mikael, would this work? Values other than lbam and lbah re

Re: [PATCH RFC] sata_promise: make pdc_atapi_pkt() use values from qc->tf

2007-12-03 Thread Mikael Pettersson
On Mon, 03 Dec 2007 13:49:36 +0900, Tejun Heo wrote: > Mikael Pettersson wrote: > >> what was the outcome of this discussion? > >> > >> I haven't looked over the Promise datasheet nor checked my brain for > >> details, hoping Mikael would do that for me

Re: stable basic 4-port SATA card

2007-12-13 Thread Mikael Pettersson
Patric Karlsson writes: > Mikael Pettersson wrote: > > On Thu, 15 Nov 2007 12:32:14 +0900, Tejun Heo wrote: > >> * sata_promise: Generally works okay; however there are still some > >> problems with recent 3Gbps chips. (Mikael, please pitch in) > > > &

Re: HSM violation erros on sata_promise

2007-12-27 Thread Mikael Pettersson
Theo Baumgartner writes: > Hello List > > I'm getting these HSM violation's too on all the SATA 300 TX4 ports with > Seagate ST3250824NS disks. > In the files attached are informations about the system with logs included > and the kernel .config. > > > Theo > This is on Promise SATA3

Re: PIIX driver

2008-01-02 Thread Mikael Pettersson
Kalev Toots writes: > Hello > > For specific reason I need to install old FC4 ( kernel 2.6.11 ) to new > hardware ( Intel DP35DP motherboard ). > Installation failed and the reason I think is that FC4 ata-piix driver > don't have ICH9 support. > Is it possible to port new ata-piix driver

Re: SATA kernel-buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

2008-01-03 Thread Mikael Pettersson
Linda Walsh writes: > Robert Hancock wrote: > > Linda Walsh wrote: > >> Alan Cox wrote: > rate began falling; at 128k block-reads-at-a-time or larger, it > drops below > 20MB/s (only on buffered SATA). > >>> Try disabling NCQ - see if you've got a drive with the 'NCQ = no >

Re: Re:Believed resolved: SATA kern-buffRd read slow: based on promise driver bug

2008-01-04 Thread Mikael Pettersson
Linda Walsh writes: > Mikael Pettersson wrote: > > Linda Walsh writes: > > > Robert Hancock wrote: > > > > Linda Walsh wrote: > > > >>>> read rate began falling; at 128k block-reads-at-a-time or larger, > > it > > > >

Re: SATA timeouts on two disks

2008-01-13 Thread Mikael Pettersson
Jim MacBaine writes: > Hi, > > Recently I'm experiencing strange sata errors on my desktop system. > The system was recently equipped with three 250 GB SATA drives from Clue #1: added drives > three different manufacturers and I'm having an identical problem on > two of them. The drives a

Re: sata_promise: Keeps saying SATA link down (SStatus 0 SControl 0)

2008-01-14 Thread Mikael Pettersson
Kurt Roeckx writes: > Hi, > > I've just tried the 2.6.24-rc7 kernel (from Debian's experimental kernel > archive), running the x86_64 kernel. > > > I keep getting things like this in my log: > Jan 13 19:21:10 intrepid kernel: ata2: exception Emask 0x10 SAct 0x0 SErr > 0x0 action 0xa fr

Re: sata_promise: Keeps saying SATA link down (SStatus 0 SControl 0)

2008-01-15 Thread Mikael Pettersson
Kurt Roeckx writes: > On Mon, Jan 14, 2008 at 09:30:07AM +0100, Mikael Pettersson wrote: > > > > The chip repeatedly signals plug and unplug events on its second > > ATA port. This is not a common error. > > > > I need a lot more information to debug this:

Re: sata_promise: Keeps saying SATA link down (SStatus 0 SControl 0)

2008-01-16 Thread Mikael Pettersson
Kurt Roeckx writes: > On Tue, Jan 15, 2008 at 10:28:06AM +0100, Mikael Pettersson wrote: > > > 00:08.0 RAID bus controller: Promise Technology, Inc. PDC20376 > > (FastTrak 376) (rev 02) > > ... > > > 00:08.0 0104: 105a:3376 (rev 02) > > > >

Re: The SX4 challenge

2008-01-20 Thread Mikael Pettersson
Jeff Garzik writes: > > Promise just gave permission to post the docs for their PDC20621 (i.e. > SX4) hardware: > http://gkernel.sourceforge.net/specs/promise/pdc20621-pguide-1.2.pdf.bz2 > > joining the existing PDC20621 DIMM and PLL docs: > http://gkernel.sourceforge.net/specs/promise/pd

Re: Linux 2.6.24 sata_promise SATA300TX4 problems

2008-01-26 Thread Mikael Pettersson
Peter Favrholdt writes: > Hi Mikael & list, > > I have previously reported problems with my setup: > > SATA300TX4 + 4 Seagate Barracuda ES 500GB > > I just tested with 2.6.24. After copying approx 25GB of each drive using > dd if=/dev/sd[abcd] of=/dev/null bs=1M > sda failed with the

Re: Linux 2.6.24 sata_promise SATA300TX4 problems

2008-01-26 Thread Mikael Pettersson
Peter Favrholdt writes: > Hi Mikael, > > Thanks for your reply :-) > > Mikael Pettersson wrote: > > Mysterious. What you have there is a transmission error between the > > controller and the disk, which is bad in and by itself, but then there's > >

Re: Problem with ata layer in 2.6.24

2008-01-28 Thread Mikael Pettersson
Gene Heskett writes: > On Monday 28 January 2008, Peter Zijlstra wrote: > >On Mon, 2008-01-28 at 09:17 +0100, Mikael Pettersson wrote: > >> 1. Wrong mailing list; use linux-ide (@vger) instead. > > > >What, and keep all us other interested people in the d

Re: Problem with ata layer in 2.6.24

2008-01-29 Thread Mikael Pettersson
Gene Heskett writes: > On Tuesday 29 January 2008, Alan Cox wrote: > >> As slight change here, I was going to use the same .config as 2.6.24-rc8, > >> but just discovered that neither rc8 nor final is finding the drivers for > >> my > > > >If it is not finding a driver that is nothing to do w

Re: [PATCH 09/13] sata_mv ncq Use DMA memory pools for hardware memory tables

2008-01-31 Thread Mikael Pettersson
Mark Lord writes: > Tejun Heo wrote: > >.. > > I'm skeptical about the benefit of IRQ coalescing on storage > > controllers. Coalescing improves performance when there are many small > > requests to complete and if you put a lot of small non-consecutive > > requests to a disk, it gets really

[PATCH 2.6.19 2/3] sata_promise: new EH conversion

2006-12-01 Thread Mikael Pettersson
ave no documentation for the PATA-only 20619, I let the driver continue using old-style EH for it (easily changed). This patch is intended to be applied on top of the sata_promise SATAII updates patch I sent recently, but will apply and work even if that patch has not been applied. Signed-off-by:

[PATCH 2.6.19 1/3] sata_promise: PHYMODE4 fixup

2006-12-01 Thread Mikael Pettersson
MODE4 just like this patch does. This patch depends on the sata_promise SATAII updates patch I sent recently. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> diff -rupN linux-2.6.19.sata_promise-1-genII-fixes/drivers/ata/sata_promise.c linux-2.6.19.sata_promise-2-PHYMODE4-fixup/

[PATCH 2.6.19 3/3] sata_promise: cleanups

2006-12-01 Thread Mikael Pettersson
LAG_GEN_II to compute hotplug_offset in pdc_host_init(). This patch depends on the sata_promise SATAII updates patch I sent recently. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> diff -rupN linux-2.6.19.sata_promise-3-new_EH/drivers/ata/sata_promise.c linux-2.6.19.sata_promise-4-clea

Re: [PATCH 2.6.19 3/3] sata_promise: cleanups

2006-12-06 Thread Mikael Pettersson
On Sun, 03 Dec 2006 22:05:51 +0900, Tejun Heo wrote: >Mikael Pettersson wrote: >> This patch performs two simple cleanups of sata_promise. >> >> * Remove board_20771 and map device id 0x3577 to board_2057x. >> After the recent corrections for SATAII chips, board_2077

Re: [PATCH 2.6.19 2/3] sata_promise: new EH conversion

2006-12-06 Thread Mikael Pettersson
On Sun, 03 Dec 2006 22:19:35 +0900, Tejun Heo wrote: >Jeff Garzik wrote: >> Tejun Heo wrote: >>> Hello, Mikael. >>> >>> Thanks for doing this. >>> >>> Mikael Pettersson wrote: >>> [--snip--] >>>> +static void pdc_freez

Re: [PATCH 2.6.19 2/3] sata_promise: new EH conversion

2006-12-06 Thread Mikael Pettersson
On Sun, 03 Dec 2006 22:00:42 +0900, Tejun Heo wrote: >Mikael Pettersson wrote: >> +} >> + >> +static void pdc_error_handler(struct ata_port *ap) >> +{ >> +struct ata_eh_context *ehc = &ap->eh_context; >> +ata_reset_fn_t hardreset; >> + &

[PATCH 2.6.19] sata_promise: cleanups, take 2

2006-12-06 Thread Mikael Pettersson
mission: rebased on libata-dev #upstream, cleaned up hotplug_offset computation based on Tejun's comments, expanded hotplug_offset removal rationale. This patch does not depend on the pending new EH conversion patch. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- linux-2.6.19

[PATCH 2.6.19-git7] sata_promise: new EH conversion, take 2

2006-12-06 Thread Mikael Pettersson
patch: this patch removes pdc_sata_phy_reset() while #promise-sata-pata modifies it. The correct patch resolution is to remove the function. Tested on 2037x and 2057x chips, with PATA patches on top and disks on both SATA and PATA ports. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> -

Re: OOPS: deref 0x14 at pdc_port_start+0x82 [Was: 2.6.20-rc1-mm1]

2006-12-15 Thread Mikael Pettersson
On Fri, 15 Dec 2006 11:24:12 -0800, Andrew Morton wrote: >On Fri, 15 Dec 2006 15:45:55 +0059 >Jiri Slaby <[EMAIL PROTECTED]> wrote: > >> Andrew Morton wrote: >> > Temporarily at >> > >> >http://userweb.kernel.org/~akpm/2.6.20-rc1-mm1/ >> > >> > Will appear later at >> > >> > >> > ftp://f

Re: SATA Promise

2006-12-19 Thread Mikael Pettersson
On Tue, 19 Dec 2006 08:54:07 -0700, Gary Thomas wrote: > I'm trying to use the sata_promise driver (1.04) with a CDROM > and having little luck. I'm using this chipset: >00:0b.0 Mass storage controller: Promise Technology, Inc. PDC40775 (SATA > 300 TX2plus) (rev 02) > > If I plug in a SATAPI

Re: SATA300 TX4 + WD2500KS = status=0x50 { DriveReady SeekComplete }

2006-12-19 Thread Mikael Pettersson
(cc: linux-ide added) On Tue, 19 Dec 2006 12:26:07 +0100, Roel Teuwen wrote: > I am seeing the exact same 'problem'. I have 4 WDC WD2500KS-00MJB0 > drives connected to a promise SATA300 TX4. The messages have been > flooding syslog since the drives were installed. Running 2.6.18 or > 2.6.19 vanill

[PATCH] preliminary sata_promise ATAPI support

2006-12-30 Thread Mikael Pettersson
This patch against 2.6.20-rc2 adds partial ATAPI support to the sata_promise driver. This patch is preliminary and for review only. Current Status: - Tested with PATA optical devices on 20378 and 20575 chips. - Mounting and reading CD/DVD discs in DMA mode works fine. - Using cdrecord to write CD-

Re: [PATCH] preliminary sata_promise ATAPI support

2007-01-01 Thread Mikael Pettersson
On Sat, 30 Dec 2006 18:37:18 +0100 (MET), Mikael Pettersson wrote: >This patch against 2.6.20-rc2 adds partial ATAPI support to >the sata_promise driver. This patch is preliminary and for >review only. ... >As to why CD-writing fails with DMA enabled, I suspect that I >either ne

[PATCH 2.6.20-rc3] sata_promise: ATAPI support

2007-01-06 Thread Mikael Pettersson
followup patch for the #promise-sata-pata branch. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- linux-2.6.20-rc3/drivers/ata/sata_promise.c.~1~ 2007-01-01 13:32:35.0 +0100 +++ linux-2.6.20-rc3/drivers/ata/sata_promise.c 2007-01-06 15:36:43.0 +0100 @@ -39,6

[PATCH libata #promise-sata-pata] sata_promise: unbreak 20619

2007-01-06 Thread Mikael Pettersson
ixed by moving the port 0 and 1 settings as SATA into the TX4 and TX2plus specific initialisation code. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- linux-2.6.20-rc3/drivers/ata/sata_promise.c.~1~ 2007-01-06 17:05:29.0 +0100 +++ linux-2.6.20-rc3/drivers/ata/

[PATCH libata #promise-sata-pata] sata_promise: 2037x PATAPI support

2007-01-06 Thread Mikael Pettersson
a the _port_flags[] entries for the SATA ports. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- linux-2.6.20-rc3/drivers/ata/sata_promise.c.~1~ 2007-01-06 17:10:56.0 +0100 +++ linux-2.6.20-rc3/drivers/ata/sata_promise.c 2007-01-06 17:14:23.0 +0100 @@ -187,7 +187,

[RFC] sata_promise: handle TX2plus PATA locally

2007-01-07 Thread Mikael Pettersson
nalise the flags. This patch also eliminates #promise-sata-pata's redundant code formatting changes, and eliminates the redundant port_flags[] assignments for the SATA-only TX4 chips. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- linux-2.6.20-rc4/drivers/ata/sata_promise.c

Re: [PATCH libata #promise-sata-pata] sata_promise: 2037x PATAPI support

2007-01-07 Thread Mikael Pettersson
On Sat, 6 Jan 2007 21:32:03 +0100 (MET), Mikael Pettersson wrote: >This patch adds ATAPI support for the PATA port on Promise 2037x chips. >It depends on the common sata_promise ATAPI support patch. > >First-generation chips don't support ATAPI on their SATA ports, so &

Re: [RFC] sata_promise: handle TX2plus PATA locally

2007-01-08 Thread Mikael Pettersson
On Sun, 07 Jan 2007 20:38:56 -0500, Jeff Garzik wrote: > > This alternative patch is based on the observation that ap->flags > > isn't really used until after ->port_start() has been invoked. > > So this patch places the "exceptional" per-port flags array in > > the driver's private host structure,

Re: [PATCH libata #promise-sata-pata] sata_promise: unbreak 20619

2007-01-08 Thread Mikael Pettersson
On Sun, 07 Jan 2007 20:46:13 -0500, Jeff Garzik wrote: > Given that I agree with your RFC, this means I can drop all these > #promise-sata-pata patches, and kill the #promise-sata-pata branch soon, > right? Yes /Mikael - To unsubscribe from this list: send the line "unsubscribe linux-ide" in th

Re: [PATCH libata #promise-sata-pata] sata_promise: 2037x PATAPI support

2007-01-08 Thread Mikael Pettersson
On Sun, 07 Jan 2007 20:47:35 -0500, Jeff Garzik wrote: > Mikael Pettersson wrote: > > @@ -789,8 +789,14 @@ static void pdc_exec_command_mmio(struct > > static int pdc_check_atapi_dma(struct ata_queued_cmd *qc) > > { > > u8 *scsicmd = qc->scsicmd->cmnd; >

Re: [PATCH 2.6.20-rc3] sata_promise: ATAPI support

2007-01-08 Thread Mikael Pettersson
s updated. ATAPI on the 2037x' PATA port is enabled by a followup > > patch for the #promise-sata-pata branch. > > > > Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> > > No objections, minor revision requests follow. > > * general comment: please

Re: SATA Promise

2007-01-08 Thread Mikael Pettersson
Gary Thomas writes: > Mikael Pettersson wrote: > > On Tue, 19 Dec 2006 08:54:07 -0700, Gary Thomas wrote: > > > >> I'm trying to use the sata_promise driver (1.04) with a CDROM > >> and having little luck. I'm using this chipset: >

Re: SATA Promise

2007-01-09 Thread Mikael Pettersson
On Mon, 08 Jan 2007 10:06:49 -0700, Gary Thomas wrote: > > Yes. SATAPI and PATAPI are working. Patches have been posted > > to linux-ide, and hopefully final combined/reworked/tidied-up > > patches should be available tomorrow. > > Very nice, thanks. > > BTW, what SATAPI drive did you try this wi

[PATCH 2.6.20-rc4 1/2] sata_promise: TX2plus PATA support

2007-01-09 Thread Mikael Pettersson
o it places the "exceptional" per-port flags array in the driver's private host structure, and uses it in ->port_start() to finalise the port's flags. This patch obsoletes the #promise-sata-pata branch included in the #all branch. Signed-off-by: Mikael Pettersson <[EMAIL PR

[PATCH 2.6.20-rc4 2/2] sata_promise: ATAPI support

2007-01-09 Thread Mikael Pettersson
actual CDB; this procedure was ported from Promise's driver Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- Changes since the previous version: - merge the changes needed to make SATAPI work on older chips - define pdc_old_check_atapi_dma(), move more restrictive SATAPI DMA

[PATCH 2.6.20-rc4] sata_promise: ATAPI cleanup

2007-01-10 Thread Mikael Pettersson
it-for-INT issue cannot occur in the current driver, but may occur if the driver starts issuing ATAPI non-DMA commands as PDC packets Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- linux-2.6.20-rc4/drivers/ata/sata_promise.c.~1~ 2007-01-09 18:53:25.0 +0100 +++ linux-2.

[PATCH 2.6.20-rc4] MAINTAINERS: maintainer for sata_promise

2007-01-10 Thread Mikael Pettersson
This patch adds myself as maintainer of the sata_promise libata driver. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- linux-2.6.20-rc4/MAINTAINERS.~1~2007-01-08 20:42:55.0 +0100 +++ linux-2.6.20-rc4/MAINTAINERS2007-01-10 01:04:23.0 +0100 @@ -2622,6 +2

[PATCH 1/2] sata_promise: issue ATAPI commands as normal packets

2007-01-13 Thread Mikael Pettersson
extract the data it needs - pdc_issue_atai_pkt_cmd() and its two helper procedures pdc_wait_for_drq() and pdc_wait_on_busy() are removed Tested on first- and second-generation chips, SATAPI and PATAPI, with no observable regressions. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> -

[PATCH 2/2] sata_promise: handle ATAPI_NODATA ourselves

2007-01-13 Thread Mikael Pettersson
I and PATAPI, with no observable regressions. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- drivers/ata/sata_promise.c | 30 +++--- 1 files changed, 23 insertions(+), 7 deletions(-) --- linux-2.6.20-rc5/drivers/ata/sata_promise.c.~1~ 2007-01-13 16:45:5

Re: [TEST] PATA Promise 20378

2007-01-14 Thread Mikael Pettersson
Vincent Legoll writes: > Hello, > > I tested libata-dev#promise-sata-pata branch, then I saw Mikael > Pettersson's patch, which kind of obsoleted the testing. > So I did libata-dev#upstream too. > > Nothig bad happened yet, after about 1h30 of test for each kernel. > bonnie++, dd, untar,

Re: ICH7m problem using libata

2007-01-16 Thread Mikael Pettersson
On Tue, 16 Jan 2007 15:53:14 +0200, Jan Gutter wrote: > On Tue, 2007-01-16 at 20:42 +0900, Tejun Heo wrote: > > Can you try 2.6.20-rc5? It has better error reporting and will tell us > > which SCSI command is timing out. > > Here you go: attaching dmesg ... > nvidia: module license 'NVIDIA' taint

Re: [PATCH 2/4] libata-core.c: add another IRQ calls

2007-01-17 Thread Mikael Pettersson
On Tue, 16 Jan 2007 17:04:27 -0500, Jeff Garzik wrote: >Alan wrote: >> Jeff - at some point we could eliminate a lot of the NULL checks like >> these by having the registration code fill in the defaults where >> appropriate ? > >libata policy up until this point has been to require all drivers fill

Re: [PATCH 2/4] libata-core.c: add another IRQ calls

2007-01-17 Thread Mikael Pettersson
Jeff Garzik writes: > Mikael Pettersson wrote: > > If there is a highly common case, the code for that case > > is available, and the code is cheap to execute (doesn't > > require too many additional variables), then having an > > explicit test + inline co

Re: Implement the technote about promise/maxtor drives

2007-02-02 Thread Mikael Pettersson
On Fri, 02 Feb 2007 11:49:17 -0500, Jeff Garzik wrote: >Alan wrote: >> I don't have the hardware combination to test this one so would >> appreciate people testing it before it goes anywhere further > >I wonder if sata_promise PATA support needs this too? Hmm, I saw Alan's post but ignored it beca

[PATCH] sata_promise: new EH conversion for 20619 chips

2007-02-04 Thread Mikael Pettersson
e that I don't think is mentioned in public documentation, so for now I just wrapped it with #if 0/#endif Tested on a TX4000 with both modern working disks and old/quirky disks. Also used a CD-RW drive to test reading and writing CDs. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]>

Re: [PATCH] (2.6.20) cmd64x: fix PIO mode setup (take 3)

2007-02-06 Thread Mikael Pettersson
Sergei Shtylyov writes: > The driver's tuneproc() method fails to set the drive's own speed -- fix this > by renaming the function to cmd64x_tune_pio(), making it return the mode set, > and "wrapping" the new tuneproc() method around it; while at it, also get rid > of the non-working prefetch c

Re: [PATCH] sata_promise: new EH conversion for 20619 chips

2007-02-07 Thread Mikael Pettersson
Jeff Garzik writes: > Mikael Pettersson wrote: > > This patch updates the sata_promise driver to use new-style > > libata error handling for 20619 (TX4000) chips. sata_promise > > already uses new EH for the other chips it supports, so the > > patch is quite

[PATCH] sata_promise: fix missing PATA cable detection

2007-02-07 Thread Mikael Pettersson
This patch fixes an oversight which caused sata_promise to not perform cable detection on the TX2plus chips' PATA ports. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- This patch adds yet another is-PATA-or-SATA? check, but it's in a cold path so shouldn't matt

Re: [PATCH] (pata-2.6 fix queue) cmd64x: remove broken SW/MW DMA support

2007-02-08 Thread Mikael Pettersson
On Thu, 8 Feb 2007 00:00:32 +0300, Sergei Shtylyov wrote: >Remove the bogus code pretending to set SW/MW DMA timings -- I wonder whether >its author really thought that he could achieve that wrtiting to BMIDE status >registers? Stop fiddling with the DMA capable bits in the speedproc() -- they >do

Re: [PATCH] sata_promise: fix missing PATA cable detection

2007-02-08 Thread Mikael Pettersson
On Thu, 08 Feb 2007 08:50:09 -0500, Jeff Garzik wrote: > Mikael Pettersson wrote: > > This patch fixes an oversight which caused sata_promise to > > not perform cable detection on the TX2plus chips' PATA ports. > > > > Signed-off-by: Mik

Re: What's the status of hotplugging a disc on a Promise TX4-controller

2007-02-08 Thread Mikael Pettersson
On Thu, 08 Feb 2007 14:36:10 +0100, Matthias Schniedermeyer wrote: > In two computer i have an onboard AHCI controller and hotplugging works like > a charm. (The few times i actually tried that) > > In another computer i have 2 Promise TX4 controllers and i couldn't find the > information if 2.6

[PATCH] sata_promise: new EH conversion for 20619 chips, take 2

2007-02-11 Thread Mikael Pettersson
W drive to test reading and writing CDs. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- Changes since first version: pdc_pata_cbl_detect() is not removed since it's now called from pdc_error_handler() via pdc_pre_reset(). drivers/ata/sata_promise.c | 55 +++---

Re: [PATCH] (pata-2.6 fix queue) cmd64x: remove broken SW/MW DMA support

2007-02-16 Thread Mikael Pettersson
On Thu, 8 Feb 2007 09:58:45 +0100 (MET), Mikael Pettersson wrote: >On Thu, 8 Feb 2007 00:00:32 +0300, Sergei Shtylyov wrote: >>Remove the bogus code pretending to set SW/MW DMA timings -- I wonder whether >>its author really thought that he could achieve that wrtiting to BMIDE sta

Re: sata_promise: random/intermittent errors

2007-02-19 Thread Mikael Pettersson
On Mon, 19 Feb 2007 12:43:50 +0800, Marc Marais wrote: > I've decided to post this to the linux-ide list to see if I can get to the > bottom of this problem I'm experiencing with sata_promise and my PATA drives. > > I've pasted a thread from the linux-raid list where I was trying to > troubleshoot

[PATCH 2.6.21-rc1] sata_promise: fix 20619 new EH merge error

2007-02-25 Thread Mikael Pettersson
When I merged my 20619 new EH conversion with #libata-upstream I had to manually resolve a conflict, and inadvertently lost pdc_pata_ops' ->post_internal_cmd binding. Corrected by this patch. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- drivers/ata/sata_promise.c |

[PATCH 2.6.21-rc1] sata_promise: simplify port setup

2007-02-25 Thread Mikael Pettersson
lisation of the PATA-only 20619 redundantly set up scr_addr for the ports. Remove this. Tested on 20619, 20575, and 20775 chips. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- drivers/ata/sata_promise.c | 29 ++--- 1 files changed, 10 insertions(+)

[RFT] sata_promise: intermittent errors bug hunting

2007-02-27 Thread Mikael Pettersson
There have been some reports of intermittent errors with sata_promise, especially with newer disks. My theory is that the driver isn't initialisating the controller properly for SATAII 3Gbps transfer speeds. It would be helpful if people seeing intermittent errors with sata_promise could do the fo

[RFT] sata_promise: decode and report error reasons

2007-02-28 Thread Mikael Pettersson
This is a preliminary patch to add error reason decoding and reporting to sata_promise. It's fairly simplistic but should log all error info the controller is able to provide. Works for me, but my test rig hardly ever throws any errors. Testing by those that experience frequent errors would be mos

Re: [RFT] sata_promise: intermittent errors bug hunting

2007-03-02 Thread Mikael Pettersson
On Fri, 2 Mar 2007 13:51:19 +0200 (EET), Tomi Orava wrote: > > There have been some reports of intermittent errors > > with sata_promise, especially with newer disks. > > My theory is that the driver isn't initialisating the > > controller properly for SATAII 3Gbps transfer speeds. > > I did a tes

[PATCH 2.6.21-rc2] pmac ide: fix pmac_ide_dma_host_on() declaration

2007-03-03 Thread Mikael Pettersson
control reaches end of non-void function These occur because ->dma_host_on should be a function returning void, but pmac.c bogusly declares it as returning int, and furthermore fails to return a value from it. Correcting the return type to void fixes both warnings. Signed-off-by: Mikael Pette

[PATCH 2.6.21-rc2] pata_legacy: fix io/irq mismatch

2007-03-03 Thread Mikael Pettersson
gacy work on my 486. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- linux-2.6.21-rc2/drivers/ata/pata_legacy.c.~1~ 2007-02-28 13:32:46.0 +0100 +++ linux-2.6.21-rc2/drivers/ata/pata_legacy.c 2007-03-03 18:40:37.0 +0100 @@ -69,7 +69,7 @@ #define NR_HOST 6 s

[BUG] pata_legacy reserves too many io/irq resources

2007-03-03 Thread Mikael Pettersson
pata_legacy probes 6 io/ctr/irq combinations for devices. Or rather, it loops, claims an io/ctr/irq combination, does an ata_device_add(), and libata then does the probing. However, the io/ctr/irq resource combinations aren't released after failed probes (as in: no devices found). The result is th

Re: [RFT] sata_promise: decode and report error reasons

2007-03-07 Thread Mikael Pettersson
Tejun, Tejun Heo writes: > Hello, Mikael. > > Mikael Pettersson wrote: > > +static void pdc_error_intr(struct ata_port *ap, struct ata_queued_cmd > > *qc, u32 port_status) > > +{ > > + struct pdc_host_priv *hp = ap->host->private_data; > &

Re: sata_promise SATA300TX4 "intermittent problems"

2007-03-07 Thread Mikael Pettersson
Peter Favrholdt writes: > Hi, > > I've seen "intermittent problems" with Promise SATA300 TX4 controllers > and Linux kernel 2.6.19 (through 2.6.20-rc2 with some additional > patches). > > Sometimes the TX4 will loose a port - a reboot brings the drive back up > again. I'm quite sure the

Re: [RFT] sata_promise: decode and report error reasons

2007-03-08 Thread Mikael Pettersson
Jeff Garzik writes: > > ATA_DMA_CNT_ERR is when a DMA FIS data size differs from total DMA S/G > > size. > > I think AC_ERR_ATA_BUS is the correct choice for this one too. > > Where is this in the Promise docs, so that I can take a closer look? Pages 38-39 in the PDC205xx development guide

Re: [PATCH 08/12] libata: convert drivers with combined SATA/PATA ports to new init model

2007-03-09 Thread Mikael Pettersson
On Fri, 9 Mar 2007 20:15:36 +0900, Tejun Heo wrote: > Convert sata_via and sata_promise to nwe init model. Both controllers > can have combined configuration (SATA + PATA) and used twisted > initialization method (modifying port in ->port_start) to overcome > probe_ent limitations. > > This patch

[BUG 2.6.21-rc3] libata PATA CDROM detection problems

2007-03-10 Thread Mikael Pettersson
I tried to convert a machine with an Intel 815EP chipset from IDE to libata. There's a single master disk on the first channel, and a single master CDROM on the second. With kernel 2.6.21-rc3 and the IDE PIIX driver things work fine: Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2 ide: A

pata_pdc2027x success on a PowerMac

2007-03-10 Thread Mikael Pettersson
This is just to let folks know that the 2.6.21-rc3 kernel's pata_pdc2027x works w/o issues with a PDC20269 in an old PowerMac G3 of mine: pata_pdc2027x :00:0e.0: version 0.8 pata_pdc2027x :00:0e.0: PLL input clock 16000 kHz ata1: PATA max UDMA/133 cmd 0xf10197c0 ctl 0xf1019fda bmdma 0xf101

[PATCH libata#upstream 1/2] sata_promise: add missing cable_detect hooks

2007-03-11 Thread Mikael Pettersson
The recent change which moved cable detection from pdc_pre_reset() to the new ->cable_detect hook only added the hook for SATAII chips, leaving SATAI chips and the 20619 without the hook. Fixed by this patch. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- drivers/ata/sata_

[PATCH libata#upstream 2/2] sata_promise: separate SATA and PATA ops

2007-03-11 Thread Mikael Pettersson
TX2plus PATA ports, a procedure with the common code, and a procedure with the SATA-specific code (this bit might be cleaned up by Tejun's new init model) Tested on 20619, 20575, and 20775 chips. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- drivers/a

[PATCH libata#upstream] sata_promise: decode and report error reasons

2007-03-14 Thread Mikael Pettersson
This patch adds much needed error reason decoding and reporting to sata_promise. It's simplistic but should log all relevant error info the controller provides. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- drivers/ata/sata_promi

Re: [PATCH libata#upstream] sata_promise: decode and report error reasons

2007-03-14 Thread Mikael Pettersson
On Wed, 14 Mar 2007 05:06:11 -0400, Jeff Garzik wrote: > > - tmp = readl(mmio); > > - if (tmp & PDC_ERR_MASK) { > > - qc->err_mask |= AC_ERR_DEV; > > - pdc_reset_port(ap); > > AFAICS pdc_reset_port() will no longer be called, after this change. > > Since you are freezing t

Re: [2.6.23-rc1] ata_piix: EH pending after completion, repeating EH (cnt=4)

2007-07-26 Thread Mikael Pettersson
On Thu, 26 Jul 2007 15:31:10 +0900, Tejun Heo wrote: > Mikael Pettersson wrote: > > On Tue, 24 Jul 2007 17:32:29 +0900, Tejun Heo wrote: > >> Mikael Pettersson wrote: > >>> This machine has a known good Samsung SATA DVD on ICH8 [8086:2820]. > >>> With

Re: [2.6.23-rc1] ata_piix: EH pending after completion, repeating EH (cnt=4)

2007-07-30 Thread Mikael Pettersson
On Mon, 30 Jul 2007 16:52:01 +0900, Tejun Heo wrote: > Mikael Pettersson wrote: > > Sure, here are the boot messages with the newer debug patch: > > Of course I missed again. Here's yet another debug patch. Sorry about > the trouble. No problem. Here's the kernel m

Re: [PATCH libata-dev#upstream 2/2] libata: move EH repeat reporting into ata_eh_report()

2007-07-31 Thread Mikael Pettersson
report() such that it's more compact and skipped on dry runs. > > Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> > Cc: Mikael Pettersson <[EMAIL PROTECTED]> > --- > Mikael, please verify this removes the annonying message you're > seeing. Yes, this patch

2.6.23-rc1: pata_via cable detection differs from via82cxxx

2007-08-03 Thread Mikael Pettersson
The machine is an Athlon64 laptop with a K8T800 chipset. With the IDE VIA driver the disk is detected as udma/100: VP_IDE: IDE controller at PCI slot :00:11.1 ACPI: PCI Interrupt Link [ALKA] disabled and referenced, BIOS bug ACPI: PCI Interrupt Link [ALKA] BIOS reported IRQ 0, using IRQ 23 ACP

Re: 2.6.23-rc1: pata_via cable detection differs from via82cxxx

2007-08-04 Thread Mikael Pettersson
On Fri, 3 Aug 2007 23:32:17 +0100, Alan Cox wrote: > Mikael Pettersson <[EMAIL PROTECTED]> wrote: > > > The machine is an Athlon64 laptop with a K8T800 chipset. With the IDE > > VIA driver the disk is detected as udma/100: > > Currently old IDE via driver has a

2.6.23-rc2 regression: check_irq_resend() warning from cmd64x

2007-08-05 Thread Mikael Pettersson
This is on a sparc64 ultra5 with a rev 3 CMD646. Starting with kernel 2.6.23-rc2, each boot triggers a WARNING from kernel/irq/resend.c: Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2 ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx CMD646: IDE controller at PC

Re: [PATCH] pata_cmd64x: Set up MWDMA modes properly

2007-08-09 Thread Mikael Pettersson
On Wed, 8 Aug 2007 14:33:20 +0100, Alan Cox wrote: > Set the MWDMA timing by updating the correct registers. Split the PIO > path as this is mostly shared code. Wants testing. Works fine on my CMD646 SPARC Ultra5. /Mikael - To unsubscribe from this list: send the line "unsubscribe linux-ide" in t

Re: [PATCH] pata_artop: fix UDMA5 for AEC6280[R] and UDMA6 for AEC6880[R]

2007-08-10 Thread Mikael Pettersson
On Fri, 10 Aug 2007 01:45:38 +0200, Bartlomiej Zolnierkiewicz wrote: > On Friday 10 August 2007, Alan Cox wrote: > > On Thu, 9 Aug 2007 23:19:34 +0200 > > Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > > > > > > > > Maximum supported UDMA mode for AEC6280[R] is UDMA5 (not UDMA4) > > > and

Re: [PATCH] pata_artop: fix UDMA5 for AEC6280[R] and UDMA6 for AEC6880[R]

2007-08-12 Thread Mikael Pettersson
On Fri, 10 Aug 2007 18:33:43 +0100, Alan Cox wrote: > > However, I'm gettting consistently lower read throughput with pata_artop > > (13-19 MB/s) than with aec62xx (22 MB/s) on an oldish WD drive, and using > > pata_artop triggers a WARN_ON(irqs_disabled()) in arch/arm/mm/consistent.c: > > It woul

Re: Still having problems with sata_promise on all late kernels

2007-08-15 Thread Mikael Pettersson
On Wed, 15 Aug 2007 16:54:52 +0900, Tejun Heo wrote: >Brad Campbell wrote: >> Tejun Heo wrote: >> >>> ATA bus error is a strong indicator for hardware problem. Please get a >>> separate power supply (doesn't have to be an expensive one), power it up >>> [1], and connect some of the drives to the

Re: [PATCH 1/1] libata: pata_pdc2027x PLL input clock fix

2007-08-17 Thread Mikael Pettersson
On Thu, 16 Aug 2007 21:19:40 +0100, Alan Cox wrote: > > > Unfortunately this breaks pata_pdc2027x on my PowerMac G3: > > > > Did this ever get resolved? > > All went quiet so I assume its gone away ? -ENOTIME The regression is still there in 2.6.23-rc3 (I just checked), but I haven't had time t

[PATCH 2.6.23-rc3] pata_pdc2027x: PLL detection fixes

2007-08-18 Thread Mikael Pettersson
three changes. It fixes the PLL detection failure on my PowerMac, and doesn't cause any regressions on an x86 with an identical card. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- drivers/ata/pata_pdc2027x.c | 18 +- 1 files changed, 9 insertions(+), 9 de

Re: [PATCH 2.6.23-rc3] pata_pdc2027x: PLL detection fixes

2007-08-19 Thread Mikael Pettersson
On Sun, 19 Aug 2007 20:13:46 +0400, Sergei Shtylyov wrote: > Mikael Pettersson wrote: > > > Previously I reported that the pata_pdc2027x PLL detection changes > > in kernel 2.6.22 broke the driver on my PowerMac: > > >>pata_pdc2027x: Invalid PLL input clock 16917

[PATCH 2.6.23-rc3] pata_via cable override for Arima W730-K8

2007-08-22 Thread Mikael Pettersson
On Fri, 3 Aug 2007 23:32:17 +0100, Alan Cox wrote: >On Fri, 3 Aug 2007 20:28:39 +0200 (MEST) >Mikael Pettersson <[EMAIL PROTECTED]> wrote: > >> The machine is an Athlon64 laptop with a K8T800 chipset. With the IDE >> VIA driver the disk is detected as udma/100: > >

Re: [PATCH] pata_via: Add Armia W730-K8 and other rebadgings

2007-08-23 Thread Mikael Pettersson
ble_dmi_table)) > return 1; > + /* Armia W730-K8/Targa Visionary 811/... */ > + if (pdev->subsystem_vendor == 0x161F && pdev->subsystem_device == > 0x2032) > + return 1; > return 0; > } s/Armia/Arima/ Apart from that it w

Re: [Bugme-new] [Bug 8936] New: sata_promise 2.09 fails to identify ST3400832AS

2007-08-25 Thread Mikael Pettersson
st bad commit. > > > > linux-2.6# git bisect good > > a77720ad0a4049e4bc6355e4febf899966a48222 is first bad commit > > commit a77720ad0a4049e4bc6355e4febf899966a48222 > > Author: Mikael Pettersson <[EMAIL PROTECTED]> > > Date: Tue Jul 3 01:09:05 2007

[PATCH 2.6.23-rc4] sata_promise: FastTrack TX4200 is a second-generation chip

2007-08-29 Thread Mikael Pettersson
ssion triggered by the hotplug-enabling changes in 2.6.23-rc1. 2. Various "failed to resume link for reset" warnings. This patch fixes <http://bugzilla.kernel.org/show_bug.cgi?id=8936>. Thanks to Stephen Ziemba for reporting the bug and for testing the fix. Signed-off-by: Mika

Re: sata_promise: port is slow to respond, reset failed

2007-09-02 Thread Mikael Pettersson
On Sun, 02 Sep 2007 13:12:42 +0200, Peter Favrholdt wrote: > I'm still experiencing the same "port is slow to respond" problem using > sata_promise in linux-2.6.22.6 with my Promise Technology, Inc. PDC40718 > (SATA 300 TX4) (rev 02) and 4 Seagate 500GB ES drives: > Model Number: S

  1   2   >