Re: [PATCH #upstream-fixes] sata_nv: disable ADMA mode by default
Tejun Heo wrote: There still are remaining issues with ADMA support. Disable it by default and warn when enabling. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- Jeff, please hold off till Robert acks. Robert, what do you think? drivers/ata/sata_nv.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) Don't worry, I won't pull the trigger immediately and without a lot of discussion. (and please help keep nvidia cc'd on changes to sata_nv) Current sleepless (thus discountable? :)) thoughts: * definitely leaning towards adma=0 default. if distros are disabling it, and upstream is not, that's a big hint :) * By switching to the tried-and-true legacy-IDE-like interface, adma=0 seems to make a lot of problems go away. * It is so late in 2.6.24-rc, it seems unlikely that we have enough time for testing such a major, fundamental behavior change in sata_nv, this late in the game. If it weren't for the time factor, I would be in favor of applying the patch and getting test results. Overall, while I do have docs under NDA (the only one in the world outside of NV?), they are pretty bare bones. And the ADMA interface, while found on many thousands of NV chips, was only one rev -- CK804 -- and is no longer being used. NV uses AHCI now. I think ADMA is an experiment that failed, in both the software sense and the hardware sense. The effort Robert has put into the ADMA code, fixing many bugs (I think I have a fix from him still to be applied, during my absence) is frankly amazing given the limits, but IMO ADMA is just not there. If docs were available and NV actively supported the ADMA mode, things would probably be different, but they aren't. Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH #upstream-fixes] sata_nv: disable ADMA mode by default
Hello, haven't fell asleep yet? Jeff Garzik wrote: Tejun Heo wrote: There still are remaining issues with ADMA support. Disable it by default and warn when enabling. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- Jeff, please hold off till Robert acks. Robert, what do you think? drivers/ata/sata_nv.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) Don't worry, I won't pull the trigger immediately and without a lot of discussion. (and please help keep nvidia cc'd on changes to sata_nv) Current sleepless (thus discountable? :)) thoughts: * definitely leaning towards adma=0 default. if distros are disabling it, and upstream is not, that's a big hint :) Well, here the distro is just 'me', so don't put too much weight on it. Maybe I'm just stressed out from all the bugs. * By switching to the tried-and-true legacy-IDE-like interface, adma=0 seems to make a lot of problems go away. * It is so late in 2.6.24-rc, it seems unlikely that we have enough time for testing such a major, fundamental behavior change in sata_nv, this late in the game. If it weren't for the time factor, I would be in favor of applying the patch and getting test results. Everyone using suse using CK804 will end up testing adma=0 in a few weeks. Let's see how it explodes. -- tejun - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH #upstream-fixes] sata_nv: disable ADMA mode by default
There still are remaining issues with ADMA support. Disable it by
default and warn when enabling.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
Jeff, please hold off till Robert acks. Robert, what do you think?
drivers/ata/sata_nv.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c
index ed5dc7c..27a0e34 100644
--- a/drivers/ata/sata_nv.c
+++ b/drivers/ata/sata_nv.c
@@ -639,7 +639,7 @@ MODULE_LICENSE(GPL);
MODULE_DEVICE_TABLE(pci, nv_pci_tbl);
MODULE_VERSION(DRV_VERSION);
-static int adma_enabled = 1;
+static int adma_enabled = 0;
static int swncq_enabled;
static void nv_adma_register_mode(struct ata_port *ap)
@@ -2396,6 +2396,9 @@ static int nv_init_one(struct pci_dev *pdev, const struct
pci_device_id *ent)
/* determine type and allocate host */
if (type == CK804 adma_enabled) {
dev_printk(KERN_NOTICE, pdev-dev, Using ADMA mode\n);
+ dev_printk(KERN_WARNING, pdev-dev,
+ WARNING: There are known problems with ADMA mode
+ which may lead to timeouts and/or system lock
ups.\n);
type = ADMA;
}
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
