Re: [PATCH 0/12] ide-floppy redux v2.5
On Mon, Jan 21, 2008 at 11:45:35PM +0100, Bartlomiej Zolnierkiewicz wrote: > > Hi Borislav, > > On Sunday 20 January 2008, Borislav Petkov wrote: > > On Mon, Jan 14, 2008 at 10:38:17PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > > By the way, I have an Iomega ZIP 100 drive somewhere in my hardware > > > > pile and > > > > will do some testing with the "new" :) driver just in case. > > > > > > This would be great. :) > > Hi Bart, > > > > i just whipped rc8 along with your pata-2.6 tree on top and had several test > > runs of the ide-floppy driver (raw reads, software floppy disk eject, etc) > > and > > everything seems to work fine. I will keep this hardware setup here so that > > we > > could at least test ide-floppy occasionally. We should probably acknowledge > > this > > Big thanks for all great ide-floppy work! I hope that you'll continue with > putting IDE device drivers in shape. :) Sure, no problem :). I'm on ide-tape right now and probably will have most of it ready for submission on the weekend so keep your fingers crossed... :) -- Regards/Gruß, Boris. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/12] ide-floppy redux v2.5
Hi Borislav, On Sunday 20 January 2008, Borislav Petkov wrote: > On Mon, Jan 14, 2008 at 10:38:17PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > By the way, I have an Iomega ZIP 100 drive somewhere in my hardware pile > > > and > > > will do some testing with the "new" :) driver just in case. > > > > This would be great. :) > Hi Bart, > > i just whipped rc8 along with your pata-2.6 tree on top and had several test > runs of the ide-floppy driver (raw reads, software floppy disk eject, etc) and > everything seems to work fine. I will keep this hardware setup here so that we > could at least test ide-floppy occasionally. We should probably acknowledge > this Big thanks for all great ide-floppy work! I hope that you'll continue with putting IDE device drivers in shape. :) > major driver cleanup with a new driver version? Yep. > --- > From 6f948b93839cdf397cb38ca75c3c6cc9a21e6070 Mon Sep 17 00:00:00 2001 > From: Borislav Petkov <[EMAIL PROTECTED]> > Date: Sun, 20 Jan 2008 13:32:24 +0100 > Subject: [PATCH] ide-floppy: bump driver version number > > Acknowledge major ide-floppy code refactoring and cleanup by bumping the > driver > version number. Also, remove a wrong comment. > > Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/12] ide-floppy redux v2.5
On Mon, Jan 14, 2008 at 10:38:17PM +0100, Bartlomiej Zolnierkiewicz wrote: > > By the way, I have an Iomega ZIP 100 drive somewhere in my hardware pile and > > will do some testing with the "new" :) driver just in case. > > This would be great. :) Hi Bart, i just whipped rc8 along with your pata-2.6 tree on top and had several test runs of the ide-floppy driver (raw reads, software floppy disk eject, etc) and everything seems to work fine. I will keep this hardware setup here so that we could at least test ide-floppy occasionally. We should probably acknowledge this major driver cleanup with a new driver version? --- >From 6f948b93839cdf397cb38ca75c3c6cc9a21e6070 Mon Sep 17 00:00:00 2001 From: Borislav Petkov <[EMAIL PROTECTED]> Date: Sun, 20 Jan 2008 13:32:24 +0100 Subject: [PATCH] ide-floppy: bump driver version number Acknowledge major ide-floppy code refactoring and cleanup by bumping the driver version number. Also, remove a wrong comment. Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> --- drivers/ide/ide-floppy.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c index 0bf6596..b455cf1 100644 --- a/drivers/ide/ide-floppy.c +++ b/drivers/ide/ide-floppy.c @@ -5,9 +5,6 @@ * Copyright (C) 2000-2002 Paul Bristow <[EMAIL PROTECTED]> * Copyright (C) 2005 Bartlomiej Zolnierkiewicz * - * The driver currently doesn't have any fancy features, just the bare - * minimum read/write support. - * * This driver supports the following IDE floppy drives: * * LS-120/240 SuperDisk @@ -18,7 +15,7 @@ * Documentation/ide/ChangeLog.ide-floppy.1996-2002 */ -#define IDEFLOPPY_VERSION "0.99.newide" +#define IDEFLOPPY_VERSION "1.00" #include #include -- 1.5.3.7 -- Regards/Gruß, Boris. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/12] ide-floppy redux v2.5
Hi, On Sunday 13 January 2008, Borislav Petkov wrote: > Hi Bart, > > here are the remaining patches which had issues to be worked out. I decided > to keep the Flexible Disk Page and Capacity Descriptor in > idefloppy_floppy_t for the sake of the two printk calls for which they are > used. Otherwise, we'll be changing long-known driver behavior and this won't > be acceptable. I'll audit the driver to see whether rq_data_dir() can replace > the PC_WRITING flag completely and get rid of that one too. Thanks, I applied patches #1-9 and #11, #10 needs small corrections and will be applied once they are addressed (#12 is fine but since it depends on #11 it has also to wait a bit more). > By the way, I have an Iomega ZIP 100 drive somewhere in my hardware pile and > will do some testing with the "new" :) driver just in case. This would be great. :) Cheers, Bart - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/12] ide-floppy redux v2.5
Hi Bart, here are the remaining patches which had issues to be worked out. I decided to keep the Flexible Disk Page and Capacity Descriptor in idefloppy_floppy_t for the sake of the two printk calls for which they are used. Otherwise, we'll be changing long-known driver behavior and this won't be acceptable. I'll audit the driver to see whether rq_data_dir() can replace the PC_WRITING flag completely and get rid of that one too. By the way, I have an Iomega ZIP 100 drive somewhere in my hardware pile and will do some testing with the "new" :) driver just in case. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
