Re: [PATCH] AMD SB700/SB800 SATA support 64bit DMA
Shane Huang wrote: Jeff and Tejun: I'm using my private mailbox to submit it before I set up the connection to our exchange mail server under linux. Please check whether this patch can be accepted. Thanks Shane CUT HERE SB700 SATA controller can support 64 bit DMA, the previous commit badc2341579511a247f5993865aa68379e283c5c was added with careless reference to SB600, which should be modified by this patch. Signed-off-by: Shane Huang [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] AMD SB700/SB800 SATA support 64bit DMA
On Fri, 22 Feb 2008 12:55:20 +0800 Huang, Shane [EMAIL PROTECTED] wrote: Jeff: SB700 SATA controller can support 64 bit DMA, the previous commit badc2341579511a247f5993865aa68379e283c5c was added with careless reference to SB600, which should be modified by this patch. Does the SB700 have the same limits as the SB600 on 256 sectors in one PRD entry ? If it does then this change needs to wait until the workaround for that is included. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] AMD SB700/SB800 SATA support 64bit DMA
Alan: SB700 SATA controller can support 64 bit DMA, the previous commit badc2341579511a247f5993865aa68379e283c5c was added with careless reference to SB600, which should be modified by this patch. Does the SB700 have the same limits as the SB600 on 256 sectors in one PRD entry ? If it does then this change needs to wait until the workaround for that is included. Thanks for the reminder, but that issue only appears on SB600, while SB700 does not have that limitation. I'll submit this SB700/800 patch again with a private mail box later. Thanks Shane - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] AMD SB700/SB800 SATA support 64bit DMA
Jeff and Tejun: I'm using my private mailbox to submit it before I set up the connection to our exchange mail server under linux. Please check whether this patch can be accepted. Thanks Shane CUT HERE SB700 SATA controller can support 64 bit DMA, the previous commit badc2341579511a247f5993865aa68379e283c5c was added with careless reference to SB600, which should be modified by this patch. Signed-off-by: Shane Huang [EMAIL PROTECTED] diff -ruN a/drivers/ata/ahci.c b/drivers/ata/ahci.c --- a/drivers/ata/ahci.c2008-02-22 18:17:03.0 +0800 +++ b/drivers/ata/ahci.c2008-02-22 18:16:54.0 +0800 @@ -85,6 +85,7 @@ board_ahci_ign_iferr= 2, board_ahci_sb600= 3, board_ahci_mv = 4, + board_ahci_sb700= 5, /* global controller registers */ HOST_CAP= 0x00, /* host capabilities */ @@ -442,6 +443,16 @@ .udma_mask = ATA_UDMA6, .port_ops = ahci_ops, }, + /* board_ahci_sb700 */ + { + AHCI_HFLAGS (AHCI_HFLAG_IGN_SERR_INTERNAL | +AHCI_HFLAG_NO_PMP), + .flags = AHCI_FLAG_COMMON, + .link_flags = AHCI_LFLAG_COMMON, + .pio_mask = 0x1f, /* pio0-4 */ + .udma_mask = ATA_UDMA6, + .port_ops = ahci_ops, + }, }; static const struct pci_device_id ahci_pci_tbl[] = { @@ -484,12 +495,12 @@ /* ATI */ { PCI_VDEVICE(ATI, 0x4380), board_ahci_sb600 }, /* ATI SB600 */ - { PCI_VDEVICE(ATI, 0x4390), board_ahci_sb600 }, /* ATI SB700/800 */ - { PCI_VDEVICE(ATI, 0x4391), board_ahci_sb600 }, /* ATI SB700/800 */ - { PCI_VDEVICE(ATI, 0x4392), board_ahci_sb600 }, /* ATI SB700/800 */ - { PCI_VDEVICE(ATI, 0x4393), board_ahci_sb600 }, /* ATI SB700/800 */ - { PCI_VDEVICE(ATI, 0x4394), board_ahci_sb600 }, /* ATI SB700/800 */ - { PCI_VDEVICE(ATI, 0x4395), board_ahci_sb600 }, /* ATI SB700/800 */ + { PCI_VDEVICE(ATI, 0x4390), board_ahci_sb700 }, /* ATI SB700/800 */ + { PCI_VDEVICE(ATI, 0x4391), board_ahci_sb700 }, /* ATI SB700/800 */ + { PCI_VDEVICE(ATI, 0x4392), board_ahci_sb700 }, /* ATI SB700/800 */ + { PCI_VDEVICE(ATI, 0x4393), board_ahci_sb700 }, /* ATI SB700/800 */ + { PCI_VDEVICE(ATI, 0x4394), board_ahci_sb700 }, /* ATI SB700/800 */ + { PCI_VDEVICE(ATI, 0x4395), board_ahci_sb700 }, /* ATI SB700/800 */ /* VIA */ { PCI_VDEVICE(VIA, 0x3349), board_ahci_vt8251 }, /* VIA VT8251 */ - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] AMD SB700/SB800 SATA support 64bit DMA
Shane Huang wrote: Jeff and Tejun: I'm using my private mailbox to submit it before I set up the connection to our exchange mail server under linux. Please check whether this patch can be accepted. Patch looks fine to me. -- tejun - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] AMD SB700/SB800 SATA support 64bit DMA
OMG, but I modified my settings and verified that the patch can really work here before I sent it to you... Shane -Original Message- From: Tejun Heo [mailto:[EMAIL PROTECTED] Sent: Friday, February 22, 2008 12:59 PM To: Huang, Shane Cc: [EMAIL PROTECTED]; linux-ide@vger.kernel.org; Su, Henry Subject: Re: [PATCH] AMD SB700/SB800 SATA support 64bit DMA Huang, Shane wrote: Jeff: SB700 SATA controller can support 64 bit DMA, the previous commit badc2341579511a247f5993865aa68379e283c5c was added with careless reference to SB600, which should be modified by this patch. Signed-off-by: Shane Huang [EMAIL PROTECTED] Shane, it still wraps. Just give up outlook and use thunderbird + toggle wordwrap + external editor or mutt/pine. -- tejun - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] AMD SB700/SB800 SATA support 64bit DMA
Huang, Shane wrote: OMG, but I modified my settings and verified that the patch can really work here before I sent it to you... It's word-wrapping, and also quoting a bunch of characters, which make it difficult for tools to pick up: @ -85,6 +85,7 @@ board_ahci_ign_iferr=3D 2, board_ahci_sb600=3D 3, board_ahci_mv =3D 4, + board_ahci_sb700=3D 5, =20 That =3D and =20 stuff was added by your mailer (normal MIME email quoted-printable quoting) Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] AMD SB700/SB800 SATA support 64bit DMA
Huang, Shane wrote: Jeff: SB700 SATA controller can support 64 bit DMA, the previous commit badc2341579511a247f5993865aa68379e283c5c was added with careless reference to SB600, which should be modified by this patch. Signed-off-by: Shane Huang [EMAIL PROTECTED] Shane, it still wraps. Just give up outlook and use thunderbird + toggle wordwrap + external editor or mutt/pine. -- tejun - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html