Re: [PATCH #upstream-fixes] ata_piix: ignore ATA_DMA_ERR on vmware ich4

2008-01-10 Thread Jeff Garzik

Tejun Heo wrote:

VMware ich4 emulation incorrectly sets DMA_ERR on TF error.  Ignore
it.

Signed-off-by: Tejun Heo [EMAIL PROTECTED]


hrm.  IIRC, the old-IDE code just sorta ignores this, and in the 
original libata I followed old-IDE's habit of acking events with


write-to-dma-status-register(err | intr)

so what part of libata-core cares about this distinction?  what is the 
specific behavior from the original problem report that this solves?


Jeff



-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH #upstream-fixes] ata_piix: ignore ATA_DMA_ERR on vmware ich4

2008-01-10 Thread Tejun Heo
Jeff Garzik wrote:
 Tejun Heo wrote:
 VMware ich4 emulation incorrectly sets DMA_ERR on TF error.  Ignore
 it.

 Signed-off-by: Tejun Heo [EMAIL PROTECTED]
 
 hrm.  IIRC, the old-IDE code just sorta ignores this, and in the
 original libata I followed old-IDE's habit of acking events with
 
 write-to-dma-status-register(err | intr)
 
 so what part of libata-core cares about this distinction?  what is the
 specific behavior from the original problem report that this solves?

Well, basically, some versions of vmware sets DMA_ERR on CHECK_SENSE, so
cdroms get reset when they try to report sense data.

Thanks.

-- 
tejun

-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html