Re: [PATCH 03/12] ide: add ide-4drives host driver
On Tuesday 19 February 2008, Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > > CONFIG_BLK_DEV_4DRIVES deserves its own host driver: > > > * Add drivers/ide/legacy/ide-4drives.c and move "4drives" support there. > > > * Add ide-4drives.o in the link order after all other legacy host > > drivers enabled by "ide0=" options (they all are mutually exclusive). > > > * Make ide-4drives host driver probe itself for IDE devices instead of > > indirectly depending on ide_generic host driver. > > > * Add "probe" module parameter to ide-4drives and update documentation. > > > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> > > > Index: b/drivers/ide/Kconfig > > === > > --- a/drivers/ide/Kconfig > > +++ b/drivers/ide/Kconfig > > @@ -1042,8 +1042,8 @@ config BLK_DEV_4DRIVES > > Certain older chipsets, including the Tekram 690CD, use a single set > > of I/O ports at 0x1f0 to control up to four drives, instead of the > > customary two drives per port. Support for this can be enabled at > > - runtime using the "ide0=four" kernel boot parameter if you say Y > > - here. > > + runtime using the "ide_4drives.probe" kernel boot parameter if you > > Not "ide-4drives.probe? > Looks correct otherwise. I believe that both versions are correct but I fixed this in 'take 3' to be on the safe side. Thanks, Bart - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 03/12] ide: add ide-4drives host driver
Bartlomiej Zolnierkiewicz wrote: CONFIG_BLK_DEV_4DRIVES deserves its own host driver: * Add drivers/ide/legacy/ide-4drives.c and move "4drives" support there. * Add ide-4drives.o in the link order after all other legacy host drivers enabled by "ide0=" options (they all are mutually exclusive). * Make ide-4drives host driver probe itself for IDE devices instead of indirectly depending on ide_generic host driver. * Add "probe" module parameter to ide-4drives and update documentation. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Index: b/drivers/ide/Kconfig === --- a/drivers/ide/Kconfig +++ b/drivers/ide/Kconfig @@ -1042,8 +1042,8 @@ config BLK_DEV_4DRIVES Certain older chipsets, including the Tekram 690CD, use a single set of I/O ports at 0x1f0 to control up to four drives, instead of the customary two drives per port. Support for this can be enabled at - runtime using the "ide0=four" kernel boot parameter if you say Y - here. + runtime using the "ide_4drives.probe" kernel boot parameter if you Not "ide-4drives.probe? Looks correct otherwise. MBR, Sergei - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 03/12] ide: add ide-4drives host driver
On Saturday 16 February 2008, Randy Dunlap wrote: [...] > > +You also need to use "probe" kernel paramater for ide-4drives driver > >parameter thanks, fixed in "take 2" - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 03/12] ide: add ide-4drives host driver
On Sat, 16 Feb 2008 17:39:11 +0100 Bartlomiej Zolnierkiewicz wrote: > CONFIG_BLK_DEV_4DRIVES deserves its own host driver: > > * Add drivers/ide/legacy/ide-4drives.c and move "4drives" support there. > > * Add ide-4drives.o in the link order after all other legacy host > drivers enabled by "ide0=" options (they all are mutually exclusive). > > * Make ide-4drives host driver probe itself for IDE devices instead of > indirectly depending on ide_generic host driver. > > * Add "probe" module parameter to ide-4drives and update documentation. > > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> > --- > Documentation/ide.txt|5 ++-- > drivers/ide/Kconfig |4 +-- > drivers/ide/ide.c| 15 ++-- > drivers/ide/legacy/Makefile |1 > drivers/ide/legacy/ide-4drives.c | 46 > +++ > 5 files changed, 55 insertions(+), 16 deletions(-) > > Index: b/Documentation/ide.txt > === > --- a/Documentation/ide.txt > +++ b/Documentation/ide.txt > @@ -242,8 +242,6 @@ Summary of ide driver parameters for ker > both the respective primary and secondary channel > to take effect. > > - "idex=four" : four drives on idex and ide(x^1) share same ports > - > "idex=reset": reset interface after probe > > "idex=ata66": informs the interface that it has an 80c cable > @@ -276,6 +274,9 @@ Also for legacy CMD640 host driver (cmd6 > kernel paremeter to enable probing for VLB version of the chipset (PCI ones > are detected automatically). > > +You also need to use "probe" kernel paramater for ide-4drives driver parameter > +(support for IDE generic chipset with four drives on one port). > + --- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
