Re: [PATCH 07/14] sata_mv Use hqtag instead of ioid
Jeff Garzik wrote: Mark Lord wrote: sata_mv Use hqtag instead of ioid. Simplify tag handling by using the cid/hqtag field instead of ioid, as recommended by Marvell. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata/sata_mv.c2008-01-24 12:07:16.0 -0500 +++ new/drivers/ata/sata_mv.c2008-01-24 12:35:14.0 -0500 @@ -132,15 +132,12 @@ CRQB_FLAG_READ= (1 0), CRQB_TAG_SHIFT= 1, -CRQB_IOID_SHIFT= 6,/* CRQB Gen-II/IIE IO Id shift */ CRQB_HOSTQ_SHIFT= 17,/* CRQB Gen-II/IIE HostQueTag shift */ CRQB_CMD_ADDR_SHIFT= 8, CRQB_CMD_CS= (0x2 11), CRQB_CMD_LAST= (1 15), CRPB_FLAG_STATUS_SHIFT= 8, -CRPB_IOID_SHIFT_6= 5,/* CRPB Gen-II IO Id shift */ -CRPB_IOID_SHIFT_7= 7,/* CRPB Gen-IIE IO Id shift */ EPRD_FLAG_END_OF_TBL= (1 31), don't delete details of otherwise undocumented [publicly] hardware .. Okay. Do you want to just nuke the first fragment of that patch and keep the rest, then? Or resubmit ? - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 07/14] sata_mv Use hqtag instead of ioid
Mark Lord wrote: sata_mv Use hqtag instead of ioid. Simplify tag handling by using the cid/hqtag field instead of ioid, as recommended by Marvell. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata/sata_mv.c2008-01-24 12:07:16.0 -0500 +++ new/drivers/ata/sata_mv.c2008-01-24 12:35:14.0 -0500 @@ -132,15 +132,12 @@ CRQB_FLAG_READ= (1 0), CRQB_TAG_SHIFT= 1, -CRQB_IOID_SHIFT= 6,/* CRQB Gen-II/IIE IO Id shift */ CRQB_HOSTQ_SHIFT= 17,/* CRQB Gen-II/IIE HostQueTag shift */ CRQB_CMD_ADDR_SHIFT= 8, CRQB_CMD_CS= (0x2 11), CRQB_CMD_LAST= (1 15), CRPB_FLAG_STATUS_SHIFT= 8, -CRPB_IOID_SHIFT_6= 5,/* CRPB Gen-II IO Id shift */ -CRPB_IOID_SHIFT_7= 7,/* CRPB Gen-IIE IO Id shift */ EPRD_FLAG_END_OF_TBL= (1 31), don't delete details of otherwise undocumented [publicly] hardware everything else OK - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html