Re: [PATCH 4/9] libata: normalize port_info, port_operations and sht tables

Jeff Garzik wrote: Tejun Heo wrote: diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 07dcaf6..08301ca 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -351,6 +351,8 @@ static const struct ata_port_operations ahci_vt8251_ops = { .port_suspend=

Re: [PATCH 4/9] libata: normalize port_info, port_operations and sht tables

Alan Cox wrote: * Every driver for SFF controllers now uses ata_pci_default_filter() unless the driver has custom implementation. That is only needed for DMA capable devices. I guess it does no harm to be consistent and call it anyway but you then say .. Yeah, it's kind of fuzzy to

Re: [PATCH 4/9] libata: normalize port_info, port_operations and sht tables

Tejun Heo wrote: * No reason to set ata_pci_default_filter() for PIO-only drivers. and your patches add the calls for the CS5520 ? diff --git a/drivers/ata/pata_cs5520.c b/drivers/ata/pata_cs5520.c index 972ed9f..5614e76 100644 --- a/drivers/ata/pata_cs5520.c +++ b/drivers/ata/pata_cs5520.c

Re: [PATCH 4/9] libata: normalize port_info, port_operations and sht tables

* Every driver for SFF controllers now uses ata_pci_default_filter() unless the driver has custom implementation. That is only needed for DMA capable devices. I guess it does no harm to be consistent and call it anyway but you then say .. * No reason to set ata_pci_default_filter() for

Re: [PATCH 4/9] libata: normalize port_info, port_operations and sht tables

Tejun Heo wrote: diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 07dcaf6..08301ca 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -351,6 +351,8 @@ static const struct ata_port_operations ahci_vt8251_ops = { .port_suspend = ahci_port_suspend,