Re: ops-qc_defer not invoked on ata_exec_internal_sg() paths ?

[Alan Cox]

On Mon, 25 Feb 2008 19:20:59 -0500
Mark Lord [EMAIL PROTECTED] wrote:

 The optional .qc_defer() methods don't seem to be called
 on the ata_exec_internal_sg() path.
 
 At present, this is probably okay.  But in the future,
 as we add functionality for link power management
 and hotplug polling, this could be a problem.

It becomes a problem for me certainly if we ever issue anything via
exec_internal_sg while another command may be outstanding anywhere on the
same *host*. Right now its ok.

Alan
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: ops-qc_defer not invoked on ata_exec_internal_sg() paths ?

[Mark Lord]

Alan Cox wrote:

On Mon, 25 Feb 2008 19:20:59 -0500
Mark Lord [EMAIL PROTECTED] wrote:


The optional .qc_defer() methods don't seem to be called
on the ata_exec_internal_sg() path.

At present, this is probably okay.  But in the future,
as we add functionality for link power management
and hotplug polling, this could be a problem.


It becomes a problem for me certainly if we ever issue anything via
exec_internal_sg while another command may be outstanding anywhere on the
same *host*. Right now its ok.

..

Yeah, for serializing a pair of ATA channels on the same host chip.

-ml
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: ops-qc_defer not invoked on ata_exec_internal_sg() paths ?

[Tejun Heo]

Hello, Mark.

Mark Lord wrote:
 The optional .qc_defer() methods don't seem to be called
 on the ata_exec_internal_sg() path.
 
 At present, this is probably okay.  But in the future,
 as we add functionality for link power management
 and hotplug polling, this could be a problem.
 
 I think.  Or is it possibly also a problem today
 for sata_send_pmp() and friends ?

That's intentional and okay.  Currently, EH can only issue one non-NCQ
command at a time and dynamic link PM and hotplug polling shouldn't be
done via EH anyway.  EH is way too big a hammer for those.

Thanks.

-- 
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html