Re: [PATCH] HID: Separate struct hid_device's driver_lock into two locks.

2012-12-04 Thread Jiri Kosina
On Mon, 26 Nov 2012, David Herrmann wrote: The fix you are proposing actually looks pretty nice, although it puts the burden of locking to the hid-driver instead of the hid-core. So every .probe function must go sure that the lock is held when returning. This means if you unlock the

Re: Caps lock XOR on multiple keyboards?

2012-12-04 Thread George Spelvin
This is known to be broken in X (and should be reported [again] there) but if you can provide scenario to break it in VT I'd love to know it. Ding ding ding, you win the prize! Yes, I was in X at the time. Me dumbshit; I should have realized that this was relevant and mentioned it. My

Re: [PATCH v3] i2c-hid: introduce HID over i2c specification implementation

2012-12-04 Thread Jiri Kosina
On Mon, 3 Dec 2012, Benjamin Tissoires wrote: I know that it already have been used by one Nvidia team and by Elan for internal tests. So I don't know if it's possible to change it now (though it's not a big deal). Yes it is possible, as long as the code isn't in Linus' tree (and I'd

Re: [PATCH v3] i2c-hid: introduce HID over i2c specification implementation

2012-12-04 Thread Benjamin Tissoires
On Tue, Dec 4, 2012 at 11:31 AM, Jiri Kosina jkos...@suse.cz wrote: On Mon, 3 Dec 2012, Benjamin Tissoires wrote: I know that it already have been used by one Nvidia team and by Elan for internal tests. So I don't know if it's possible to change it now (though it's not a big deal). Yes

[PATCH 08/14] HID: i2c-hid: fix error messages

2012-12-04 Thread Benjamin Tissoires
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- drivers/hid/i2c-hid/i2c-hid.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c index d6fdb3e..da04948 100644 ---

Re: [PATCH 01/14] HID: i2c-hid: change I2C name

2012-12-04 Thread Jean Delvare
On Tue, 4 Dec 2012 16:27:42 +0100, Benjamin Tissoires wrote: no I2C driver has i2c in its name. It makes more sense to call this i2c driver hid. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- drivers/hid/i2c-hid/i2c-hid.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 1/2] input: wacom - Prepare for syncing with input-mt changes

2012-12-04 Thread Henrik Rydberg
Hi Ping, Henrik added new MT routines in release 3.7. This patch is to prepare for the use of new MT routines. Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/input/tablet/wacom_wac.c | 85 -- 1 file changed, 45 insertions(+), 40 deletions(-)

Re: [PATCH 1/2] input: wacom - Prepare for syncing with input-mt changes

2012-12-04 Thread Ping Cheng
Hi Henrik, Thank you for your review. Please see my reply inline. Ping On Tue, Dec 4, 2012 at 8:10 AM, Henrik Rydberg rydb...@euromail.se wrote: Hi Ping, Henrik added new MT routines in release 3.7. This patch is to prepare for the use of new MT routines. Signed-off-by: Ping Cheng

Re: [PATCH 2/2] input: wacom - use new input-mt routines

2012-12-04 Thread Ping Cheng
On Tue, Dec 4, 2012 at 8:13 AM, Henrik Rydberg rydb...@euromail.se wrote: Hi Ping, This patch brings wacom driver in-sync with input-mt changes made in release 3.7. Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/input/tablet/wacom_wac.c | 84

Re: [PATCH 1/2] Input: xpad - Minor coding style errors fixed.

2012-12-04 Thread Dmitry Torokhov
On Mon, Dec 03, 2012 at 11:28:36PM -0800, Guillermo A. Amaral wrote: On Mon, Dec 03, 2012 at 09:24:00PM -0800, Dmitry Torokhov wrote: On Sat, Dec 01, 2012 at 11:36:19PM -0800, Guillermo A. Amaral wrote: From: Guillermo A. Amaral g...@maral.me Fixed a few minor coding style issues in

Re: [PATCH v2 1/1] Input: STMicroelectronics multi touch capacitive touchscreen ftk

2012-12-04 Thread Felipe Balbi
Hi, On Tue, Dec 04, 2012 at 11:10:42AM -0800, Dmitry Torokhov wrote: Hi Li, On Tue, Dec 04, 2012 at 06:26:29AM -0500, Li Wu wrote: +STM FTK TOUCHSCREEN DRIVER +M: Li Wu li...@st.com +L: device-drivers-de...@blackfin.uclinux.org +W: http://www.st.com +S: Supported

Re: [PATCH 02/14] HID: i2c-hid: fix memory corruption due to missing hid declaration

2012-12-04 Thread Jean Delvare
On Tue, 4 Dec 2012 16:27:43 +0100, Benjamin Tissoires wrote: HID descriptors contains 4 bytes of reserved field. The previous implementation was overriding the next fields in struct i2c_hid. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- drivers/hid/i2c-hid/i2c-hid.c |

Re: hid-multitouch: eGalax Touchscreen not resuming after suspend

2012-12-04 Thread Jan-Matthias Braun
Hi Rafael, Am Donnerstag 29. November 2012, 23:28:55 schrieb Rafael J. Wysocki: On Thursday, November 29, 2012 03:03:04 PM Jan-Matthias Braun wrote: Am Donnerstag, 29. November 2012, 01:20:04 schrieb Rafael J. Wysocki: On Tuesday, November 27, 2012 09:26:11 PM Jiri Kosina wrote: On Sun,

SEMI_MT vs. simulated mt (was Re: [PATCH v3 0/4] Cypress PS/2 Trackpad driver)

2012-12-04 Thread Kamal Mostafa
Hi Dmitry and Henrik- Regarding SEMI_MT vs. simulated multitouch . . . Patch #4 (new) reintroduces simulated multitouch for up to 5 fingers (#if CYPRESS_SIMULATE_MT), disabling SEMI_MT again. If that functionality (support for 2 fingers) can be acheived in some better way,

[PATCH v4 4/4] input: Cypress PS/2 Trackpad simulated multitouch (disabled)

2012-12-04 Thread Kamal Mostafa
This feature is disabled by default; enable with CYPRESS_SIMULATED_MT. Instead of SEMI_MT, present a full mt interface with simulated contact positions for =3 fingers. Enables e.g. multi-finger tap and drag for old userspace applications which only count the contact positions. Signed-off-by:

[PATCH v4 3/4] input: Cypress PS/2 Trackpad link into psmouse-base

2012-12-04 Thread Kamal Mostafa
From: Dudley Du d...@cypress.com Original code contributed by Dudley Du (Cypress Semiconductor Corporation), modified by Kamal Mostafa. BugLink: http://launchpad.net/bugs/978807 Signed-off-by: Dudley Du d...@cypress.com Signed-off-by: Kamal Mostafa ka...@canonical.com Signed-off-by: Mario

[PATCH v4 1/4] input: increase struct ps2dev cmdbuf[] to 8 bytes

2012-12-04 Thread Kamal Mostafa
Cypress PS/2 Trackpad (drivers/input/mouse/cypress_ps2.c) needs this larger cmdbuf[] to handle 8-byte packet responses. Signed-off-by: Kamal Mostafa ka...@canonical.com --- include/linux/libps2.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/libps2.h

[PATCH v4 2/4] input: Cypress PS/2 Trackpad psmouse driver

2012-12-04 Thread Kamal Mostafa
From: Dudley Du d...@cypress.com Input/mouse driver for Cypress PS/2 Trackpad. Original code contributed by Dudley Du (Cypress Semiconductor Corporation), modified by Kamal Mostafa and Kyle Fazzari. BugLink: http://launchpad.net/bugs/978807 Signed-off-by: Dudley Du d...@cypress.com

RE: [PATCH v3 2/4] input: Cypress PS/2 Trackpad psmouse driver

2012-12-04 Thread Dudley Du
Hi Henrik, Kamal, Thanks for your review. And I add some comments in below. Thanks. Dudley Du d...@cypress.com Hi Henrik- Thanks again for your review. The forthcoming PATCH v4 includes the majority of your change requests, except where noted below (and considering my email Subject: