[PATCH] HID: Add driver for ION iCade

2012-10-31 Thread Bastien Nocera
Add a driver for the ION iCade mini arcade cabinet [1]. The device generates a key press and release for each joystick movement or button press or release. For example, moving the stick to the left will generate the A key being pressed and the released. A list of all the combinations is

Re: [PATCH] HID: Add driver for ION iCade

2012-10-31 Thread Benjamin Tissoires
Hi Bastien, this v2 is good for me: Reviewed-by: Benjamin Tissoires benjamin.tissoi...@gmail.com Cheers, Benjamin On Wed, Oct 31, 2012 at 12:10 PM, Bastien Nocera had...@hadess.net wrote: Add a driver for the ION iCade mini arcade cabinet [1]. The device generates a key press and release

Re: [PATCH] HID: Add driver for ION iCade

2012-10-31 Thread Jiri Kosina
On Wed, 31 Oct 2012, Bastien Nocera wrote: Add a driver for the ION iCade mini arcade cabinet [1]. The device generates a key press and release for each joystick movement or button press or release. For example, moving the stick to the left will generate the A key being pressed and the

Re: [PATCH] HID: Add driver for ION iCade

2012-10-31 Thread Jiri Kosina
On Wed, 31 Oct 2012, Bastien Nocera wrote: Probably because whatever I copy/pasted it from had the brackets. I don't see any such occurence in hid/Kconfig. Anyway, not important at all :) Did you make the typos changes in the commit message itself as well? Yup. Thanks, -- Jiri Kosina

Re: [PATCH] HID: Add driver for ION iCade

2012-10-31 Thread Bastien Nocera
On Wed, 2012-10-31 at 16:52 +0100, Jiri Kosina wrote: On Wed, 31 Oct 2012, Bastien Nocera wrote: Probably because whatever I copy/pasted it from had the brackets. I don't see any such occurence in hid/Kconfig. Anyway, not important at all :) I wrote the driver nearly a year ago,

[PATCH] HID: Add driver for ION iCade

2012-10-30 Thread Bastien Nocera
Add a driver for the ION iCade mini arcade cabinet [1]. The device generates a key press and release for each joystick movement or button press or release. For example, moving the stick to the left will generate the A key being pressed and the released. A list of all the combinations is

Re: [PATCH] HID: Add driver for ION iCade

2012-10-30 Thread Benjamin Tissoires
Hi Bastien, a few random comments: On Tue, Oct 30, 2012 at 8:55 PM, Bastien Nocera had...@hadess.net wrote: Add a driver for the ION iCade mini arcade cabinet [1]. The device generates a key press and release for each joystick movement or button press or release. For example, moving the