Re: input: gpio_keys_polled: Request GPIO pin as input.

2015-08-20 Thread Dmitry Torokhov
On Thu, Aug 20, 2015 at 07:50:00PM +0200, Vincent Pelletier wrote: > GPIOF_IN flag was lost in: > Commit 633a21d80b4a("input: gpio_keys_polled: Add support for GPIO > descriptors"). > > Without this flag, legacy code path (for non-descriptor GPIO declarations) > would configure GPIO as output (0 m

[Try 2] input: gpio_keys_polled: Request GPIO pin as input.

2015-08-20 Thread Vincent Pelletier
Changes since try 1: - Added Reviewed-By Mika - Made commit log more verbose (I'm very bad at this suggestions very welcome) Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo

input: gpio_keys_polled: Request GPIO pin as input.

2015-08-20 Thread Vincent Pelletier
GPIOF_IN flag was lost in: Commit 633a21d80b4a("input: gpio_keys_polled: Add support for GPIO descriptors"). Without this flag, legacy code path (for non-descriptor GPIO declarations) would configure GPIO as output (0 meaning GPIOF_DIR_OUT | GPIOF_INIT_LOW). Signed-off-by: Vincent Pelletier Revi

Re: input: gpio_keys_polled: Request GPIO pin as input.

2015-08-18 Thread Mika Westerberg
On Mon, Aug 17, 2015 at 11:29:32PM +0200, Vincent Pelletier wrote: > Flag was lost in: > Commit 633a21d80b4a("input: gpio_keys_polled: Add support for GPIO > descriptors"). You could add a bit more verbose changelog here. > Signed-off-by: Vincent Pelletier Regardless of that the patch itself lo

input: gpio_keys_polled: Request GPIO pin as input.

2015-08-17 Thread Vincent Pelletier
Hello, Please keep me cc'ed on replies, I'm not subscribed. Regards, -- Vincent Pelletier -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

input: gpio_keys_polled: Request GPIO pin as input.

2015-08-17 Thread Vincent Pelletier
Flag was lost in: Commit 633a21d80b4a("input: gpio_keys_polled: Add support for GPIO descriptors"). Signed-off-by: Vincent Pelletier --- drivers/input/keyboard/gpio_keys_polled.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/gpio_keys_polled.c b/driv