[PATCH] HID: hid-multitouch.c: fix formatting warnings

Fixed the following checkpatch.pl warnings: WARNING: line over 80 characters: line 163 WARNING: Missing a blank line after declarations: line 359 WARNING: Missing a blank line after declarations: line 572 WARNING: Missing a blank line after declarations: line 708 WARNING: Missing a blank line

Re: [RFC PATCH] PM / Runtime: runtime: Add sysfs option for forcing runtime suspend

Hi Alan, On Mon, Sep 28, 2015 at 4:29 PM, Alan Stern wrote: > On Mon, 28 Sep 2015, Rafael J. Wysocki wrote: > >> > This suggests we forget about power/wakeup == "off" and introduce an >> > "inhibit" attribute instead. >> >> If we do that, can it still be regarded as a

Re: [PATCH v2] Input: drivers/joystick: use parallel port device model

On Friday 14 August 2015 08:55:42 Sudip Mukherjee wrote: > > > Pali Rohár has the hardware and he is ready to test it. > > > > Pali, could you give the v2 version of the patch a spin > > (https://patchwork.kernel.org/patch/6940321/)? > > Adding Pali to the cc list. > > Hi Pali, > Are you still

Re: [RFC PATCH] PM / Runtime: runtime: Add sysfs option for forcing runtime suspend

On Mon, 28 Sep 2015, Rafael J. Wysocki wrote: > Hi Alan, > > On Mon, Sep 28, 2015 at 4:29 PM, Alan Stern wrote: > > On Mon, 28 Sep 2015, Rafael J. Wysocki wrote: > > > >> > This suggests we forget about power/wakeup == "off" and introduce an > >> > "inhibit" attribute

[PATCH] HID: multitouch: Add suffix for HID_DG_TOUCHPAD

Instead of printing "UNKNOWN" as device suffix for HID_DG_TOUCHPAD call the device as "Touchpad". Signed-off-by: Mika Westerberg --- drivers/hid/hid-multitouch.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/hid/hid-multitouch.c

[PATCH] HID: multitouch: Fetch feature reports on demand for Win8 devices

Some newer Intel Skylake based Dell laptops with Win8 precision touchpad fail when initial feature reports are fetched from it. Below is an example output with some additional debug included: i2c_hid i2c-DLL0704:01: Fetching the HID descriptor i2c_hid i2c-DLL0704:01: __i2c_hid_command: cmd=20

Re: [RFC PATCH] PM / Runtime: runtime: Add sysfs option for forcing runtime suspend

On Mon, 28 Sep 2015, Rafael J. Wysocki wrote: > > This suggests we forget about power/wakeup == "off" and introduce an > > "inhibit" attribute instead. > > If we do that, can it still be regarded as a PM attribute? Why not? Consider this: Is there any reason to support inhibit when CONFIG_PM

RE: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey

> Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for > DA9062 OnKey > > On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote: > > On Thu, Jul 23, 2015 at 05:17:41PM +0100, S Twiss wrote: > > > From: S Twiss > > > > > > Add

Re: [Linux v4.2] workqueue: llvmlinux: acpid: BUG: sleeping function called from invalid context at kernel/workqueue.c:2680

On Mon, Sep 28, 2015 at 8:50 AM, Sedat Dilek wrote: > [ CC only relevant people plus Paul as he took care in another thread ] > > First of all, sorry for flooding anybody or any mailing-list. > > Of course, using LLVM/Clang for the Linux-kernel is still WIP, but > this does

[PATCH] usbhid: Fix lockdep unannotated irqs-off warning

When compiling Linux v4.2+ and v4.3-rc2+ with a llvmlinux patchset and CLANG v3.7 I see a BUG line like this: [ 24.705463] BUG: sleeping function called from invalid context at kernel/workqueue.c:2680 [ 24.705576] in_atomic(): 0, irqs_disabled(): 1, pid: 1447, name: acpid After some vital

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

On Mon, 28 Sep 2015, Sedat Dilek wrote: > When compiling Linux v4.2+ and v4.3-rc2+ with a llvmlinux patchset > and CLANG v3.7 I see a BUG line like this: > > [ 24.705463] BUG: sleeping function called from invalid context at > kernel/workqueue.c:2680 > [ 24.705576] in_atomic(): 0,

[PATCH 2/2] HID: i2c-hid: Fill in physical device providing HID functionality

Currently hid_connect() prints out following when I2C connected HID devices is connected: hid-multitouch 0018:03EB:2136.0001: ... [ATML3432:00 03EB:2136] on After "on " should read physical device name but it is left empty by the driver. Make it look better and fill in the physical device

[PATCH 1/2] HID: Show I2C bus type in hid_connect()

For I2C HID devices output currently looks like: hid-multitouch ... input,hidraw0: HID v1.00 Mouse ... Add knowledge about I2C bus to hid_connect() so that it shows "I2C" correctly instead of "". Signed-off-by: Mika Westerberg --- drivers/hid/hid-core.c | 3

Re: [PATCH] HID: hid-input: allow input_configured callback return errors

Hi On Mon, Sep 28, 2015 at 2:23 AM, Dmitry Torokhov wrote: [...] >> >> > } >> > >> > static int mt_probe(struct hid_device *hdev, const struct hid_device_id >> > *id) >> >> [snip] >> >> > diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c >> > index

Re: [PATCH] Input: cyapa: remove variable overwriting

Hi Sudip, On Tue, Sep 15, 2015 at 3:06 AM, Sudip Mukherjee wrote: > Even if rotat_align is true or false the final value of > cyapa->electrodes_rx is always cyapa->electrodes_y. remove the variable > overwriting and in the process remove the variable rotat_align which

Re: PROBLEM: Missing events on thinkpad trackpoint buttons

On Sun, Sep 27, 2015 at 5:14 AM, Benjamin Tissoires wrote: > [re-sending because my gmail client decided to turn on HTML for all > mails I wrote. Sorry for the duplicate ] > > On Sun, Sep 27, 2015 at 8:12 AM, Benjamin Tissoires > wrote:

Re: [PATCH v2] Input: drivers/joystick: use parallel port device model

On Mon, Sep 28, 2015 at 06:40:51PM +0200, Pali Rohár wrote: > On Friday 14 August 2015 08:55:42 Sudip Mukherjee wrote: > > > > Pali Rohár has the hardware and he is ready to test it. > > > > > > Pali, could you give the v2 version of the patch a spin > > >

Re: [PATCH] HID: hid-input: allow input_configured callback return errors

On 09/28/2015 03:10 AM, David Herrmann wrote: Hi On Mon, Sep 28, 2015 at 2:23 AM, Dmitry Torokhov wrote: [...] } static int mt_probe(struct hid_device *hdev, const struct hid_device_id *id) [snip] diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c

Re: [PATCH] Input: omap-keypad: fix memory leak

On Fri, Sep 18, 2015 at 04:54:40PM +0530, Sudip Mukherjee wrote: > If omap4_keypad_parse_dt() fails we returned the error code but we > missed releasing keypad_data. > > Signed-off-by: Sudip Mukherjee Applied, thank you. > --- > drivers/input/keyboard/omap4-keypad.c | 2

Re: [PATCH] HID: hid-lg: Add USBID for Logitech G29 Wheel

> I was able to get some more information, but as yet have not been able to > get time on the real hardware. Attached is a 2nd patch which should > improve the support, I'll formally submit it next week But if anyone > can test it first that would be great. Obviously the 'submit next week'

Re: [PATCH v3 1/5] Input: goodix - reset device at init

On Fri, 2015-09-25 at 21:04 +, Tirdea, Irina wrote: > > > -Original Message- > > From: Bastien Nocera [mailto:had...@hadess.net] > > Sent: 25 September, 2015 17:44 > > To: Tirdea, Irina; linux-input@vger.kernel.org > > Cc: linux-ker...@vger.kernel.org; Rob Herring; Pawel Moll; Ian > >

Re: [PATCH] Input: elan_i2c - Add all valid ic type for i2c/smbus

On Wed, Sep 23, 2015 at 09:26:23AM +0800, duson wrote: > Signed-of-by: Duson Lin Applied, thank you. > --- > drivers/input/mouse/elan_i2c_core.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/mouse/elan_i2c_core.c >

Re: [patch] Input: ff-core - silence an underflow warning

On Tue, Sep 22, 2015 at 04:26:43PM +0300, Dan Carpenter wrote: > My static checker complains that "value" comes from the user in > evdev_do_ioctl() and we check that it's not too large here but we don't > check that it's negative. It's harmless because the ->set_gain() and > ->set_autocenter()

Re: PROBLEM: Missing events on thinkpad trackpoint buttons

On 9/28/15, Dmitry Torokhov wrote: > On Sun, Sep 27, 2015 at 5:14 AM, Benjamin Tissoires > wrote: >> I believe the fix is worse than the original situation given that this >> also removes all gestures support we can have in libinput. >

Re: PROBLEM: Missing events on thinkpad trackpoint buttons

On Mon, Sep 28, 2015 at 08:22:02PM -0400, Nick Bowler wrote: > On 9/28/15, Dmitry Torokhov wrote: > > On Sun, Sep 27, 2015 at 5:14 AM, Benjamin Tissoires > > wrote: > >> I believe the fix is worse than the original situation given that

Re: [RFC PATCH] PM / Runtime: runtime: Add sysfs option for forcing runtime suspend

On Sunday, September 27, 2015 10:27:25 AM Alan Stern wrote: > On Sun, 27 Sep 2015, Rafael J. Wysocki wrote: > > > On Saturday, September 26, 2015 11:20:50 AM Alan Stern wrote: > > > On Sat, 26 Sep 2015, Rafael J. Wysocki wrote: > > > > > > > > > So something like: > > > > > > > > > > > >

Re: [RFC PATCH] PM / Runtime: runtime: Add sysfs option for forcing runtime suspend

On Sunday, September 27, 2015 07:02:17 PM Pavel Machek wrote: > Hi! Hi, > > > > > That, or there may be an additional value, say "aggressive", to write > > > > > to the > > > > > control file in which case it becomes just > > > > > > > > > > echo aggressive >/sys/.../power/control > > > > > >

Re: [PATCH] Input: serio - fix blocking of parport

On Sun, Sep 27, 2015 at 05:18:08PM -0700, Dmitry Torokhov wrote: > On Sat, Sep 26, 2015 at 06:53:21PM +0530, Sudip Mukherjee wrote: > > If parkbd_allocate_serio() fails to allocate memory we are releasing the > > parport but we missed unregistering the device. As a result this device > > with