Re: [RESEND PATCH v3 1/1] Add Corsair Vengeance K90 driver

On Wed, 30 Sep 2015, Clément Vuchener wrote: > This patch implements a HID driver for the Corsair Vengeance K90 keyboard. > > It fixes the behaviour of the keys using incorrect HID usage codes and > exposes the macro playback mode and current profile to the user space > through sysfs

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

> What shall I do... play with lockdep (print_irqtrace_events) in > del_timer_sync()? I recalled that when Jiri was thinking towards a "compiler bug" that the part in del_timer_sync() emebedded in the "ifdef CONFIG_LOCKDEP" is somehow "mis-compiled". Furthermore, I see that

Re: [PATCH v2] HID: hid-input: allow input_configured callback return errors

On Tue, 29 Sep 2015, Dmitry Torokhov wrote: > When configuring input device via input_configured callback we may > encounter errors (for example input_mt_init_slots() may fail). Instead > of continuing with half-initialized input device let's allow driver > indicate failures. Applied to

Re: [PATCH v5 1/3] ARM: dts: vf500-colibri: Add device tree node for touchscreen support

On Tue, Sep 01, 2015 at 06:06:53PM +0530, Sanchayan Maity wrote: > Add device tree node for touchscreen support on Colibri VF50. The > touchscreen functionality on VF50 uses the ADC channels of Vybrid > and some GPIOs. Also add pinctrl nodes for proper pinmux. > > Signed-off-by: Sanchayan Maity

Re: [PATCH] HID: hid-multitouch.c: fix formatting warnings

On Tue, 29 Sep 2015, Brent Adam wrote: > >> Fixed the following checkpatch.pl warnings: > >> WARNING: line over 80 characters: line 163 > >> WARNING: Missing a blank line after declarations: line 359 > >> WARNING: Missing a blank line after declarations: line 572 > >> WARNING: Missing a blank

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

On Wed, 30 Sep 2015 08:41:57 +0200 Sedat Dilek wrote: > > What shall I do... play with lockdep (print_irqtrace_events) in > > del_timer_sync()? > > I recalled that when Jiri was thinking towards a "compiler bug" that > the part in del_timer_sync() emebedded in the "ifdef

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

On Wed, 30 Sep 2015, Sedat Dilek wrote: > > diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c > > index 36712e9..aaae42e 100644 > > --- a/drivers/hid/usbhid/hid-core.c > > +++ b/drivers/hid/usbhid/hid-core.c > > @@ -38,6 +38,8 @@ > > #include > > #include "usbhid.h" >

RE: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey

On 30 September 2015 00:54 Dmitry Torokhov wrote: > To: Opensource [Steve Twiss] > Cc: Lee Jones; DEVICETREE; Ian Campbell; Kumar Gala; LINUXINPUT; > LINUXKERNEL; Mark Rutland; Pawel Moll; RTCLINUX; Rob Herring; David > Dajun Chen; Samuel Ortiz; Support Opensource > Subject: Re: [PATCH V3 3/3]

Re: [PATCH] HID: multitouch: Fetch feature reports on demand for Win8 devices

On Tue, Sep 29, 2015 at 05:04:31AM -0400, Benjamin Tissoires wrote: > > +static void mt_get_feature(struct hid_device *hdev, struct hid_report > > *report) > > +{ > > + int ret, size = hid_report_len(report); > > + u8 *buf; > > + > > + /* > > +* Only fetch the feature report if initial

Re: [PATCH] HID: hiddev: fix returned errno code in hiddev_connect()

On Wed, 30 Sep 2015, Luis de Bethencourt wrote: > The driver is using -1 instead of the -ENOMEM defined macro to specify > that a buffer allocation failed. Since the error number is propagated, > the caller will get a -EPERM which is the wrong error condition. Generally I agree that the more

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

On Wed, Sep 30, 2015 at 12:13 PM, Steven Rostedt wrote: > On Wed, 30 Sep 2015 11:46:31 +0200 > Sedat Dilek wrote: > >> On Wed, Sep 30, 2015 at 10:56 AM, Steven Rostedt wrote: >> > On Wed, 30 Sep 2015 09:35:23 +0200 (CEST) >> >

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

On Wed, 30 Sep 2015 11:46:31 +0200 Sedat Dilek wrote: > On Wed, Sep 30, 2015 at 10:56 AM, Steven Rostedt wrote: > > On Wed, 30 Sep 2015 09:35:23 +0200 (CEST) > > Jiri Kosina wrote: > > > > > >> [ ... snip a lot of stuff ... ] > >> >

[PATCH] HID: hiddev: fix returned errno code in hiddev_connect()

The driver is using -1 instead of the -ENOMEM defined macro to specify that a buffer allocation failed. Since the error number is propagated, the caller will get a -EPERM which is the wrong error condition. Also, the smatch tool complains with the following warning: hiddev_connect() warn:

Re: [PATCH] HID: hiddev: fix returned errno code in hiddev_connect()

On Wed, Sep 30, 2015 at 10:56:26AM +0100, Luis de Bethencourt wrote: > On 30/09/15 10:52, Luis de Bethencourt wrote: > > The driver is using -1 instead of the -ENOMEM defined macro to specify > > that a buffer allocation failed. Since the error number is propagated, > > the caller will get a

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

On Wed, Sep 30, 2015 at 10:56 AM, Steven Rostedt wrote: > On Wed, 30 Sep 2015 09:35:23 +0200 (CEST) > Jiri Kosina wrote: > > >> [ ... snip a lot of stuff ... ] >> > What shall I do... play with lockdep (print_irqtrace_events) in >> > del_timer_sync()? > >

Re: [PATCH] HID: hiddev: fix returned errno code in hiddev_connect()

On 30/09/15 10:52, Luis de Bethencourt wrote: > The driver is using -1 instead of the -ENOMEM defined macro to specify > that a buffer allocation failed. Since the error number is propagated, > the caller will get a -EPERM which is the wrong error condition. > > Also, the smatch tool complains

Re: [PATCH] HID: hiddev: fix returned errno code in hiddev_connect()

On 30/09/15 11:04, Sudip Mukherjee wrote: > On Wed, Sep 30, 2015 at 10:56:26AM +0100, Luis de Bethencourt wrote: >> On 30/09/15 10:52, Luis de Bethencourt wrote: >>> The driver is using -1 instead of the -ENOMEM defined macro to specify >>> that a buffer allocation failed. Since the error number

Re: [PATCH v3 1/5] Input: goodix - reset device at init

On Tue, 2015-09-29 at 17:47 +, Tirdea, Irina wrote: > > > -Original Message- > > From: Bastien Nocera [mailto:had...@hadess.net] > > Sent: 29 September, 2015 5:04 > > To: Tirdea, Irina; linux-input@vger.kernel.org > > Cc: linux-ker...@vger.kernel.org; Rob Herring; Pawel Moll; Ian > >

Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey

On Tue, 29 Sep 2015, Dmitry Torokhov wrote: > On Mon, Sep 28, 2015 at 08:19:27AM +, Opensource [Steve Twiss] wrote: > > > > > Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings > > > for DA9062 OnKey > > > > > > On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

On Wed, 30 Sep 2015 09:35:23 +0200 (CEST) Jiri Kosina wrote: > [ ... snip a lot of stuff ... ] > > What shall I do... play with lockdep (print_irqtrace_events) in > > del_timer_sync()? Also, do you have PARAVIRT enabled by chance? -- Steve > > I'd suggest showing this to

[RESEND PATCH v3 0/1] Corsair Vengeance K90 driver

I have split the special functions between backlight and macro functions. This should make it easier to test new devices. I think the macro functions will only be reused with the K95. While backlight is more common feature, though I have no idea it is done with other Corsair hardware. I have

[RESEND PATCH v3 1/1] Add Corsair Vengeance K90 driver

This patch implements a HID driver for the Corsair Vengeance K90 keyboard. It fixes the behaviour of the keys using incorrect HID usage codes and exposes the macro playback mode and current profile to the user space through sysfs attributes. It also adds two LED class devices controlling the

[PATCH 2/2] Input: goodix - use "inverted_[xy]" flags instead of "rotated_screen"

The goodix touchscreen driver uses a "rotated_screen" flag for systems on which the touchscreen is mounted rotated by 180 degrees with respect to the display. With the addition of support for the dt properties "touchscreen-inverted-x" and "touchscreen-inverted-y", a separate "rotated_screen" flag

Re: [PATCH] Input: Add support for FocalTech FT6236 touchscreen controller

Hi Noralf, On Tue, Sep 29, 2015 at 06:16:47PM +0200, Noralf Trønnes wrote: > This adds support for the FT6x06 and the FT6x36 family of > capacitive touch panel controllers, in particular the FT6236. > > Signed-off-by: Noralf Trønnes > --- > > The driver is based on: >

[PATCH RFC 0/2] Input: Goodix - add axis swapping and inversion support

Hello, the goodix touchscreen driver has gained device-tree support in kernel 4.1, but doesn't currently support the touchscreen-swapped-x-y, touchscreen-inverted-x and touchscreen-inverted-y properties. On systems which combine a portrait-mode display with a landscape-mode touchscreen, such as

Re: [PATCH RFC 0/2] Input: Goodix - add axis swapping and inversion support

On Thu, 2015-10-01 at 00:29 +0200, Karsten Merker wrote: > Hello, > > the goodix touchscreen driver has gained device-tree support in > kernel > 4.1, but doesn't currently support the touchscreen-swapped-x-y, > touchscreen-inverted-x and touchscreen-inverted-y properties. Can't test for now,

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

On Thu, 1 Oct 2015 00:37:52 +0200 Sedat Dilek wrote: > No, that did not help. > > $ dmesg | grep BUG: > [ 24.491708] BUG: sleeping function called from invalid context at > kernel/workqueue.c:2678 > > $ grep -i parav /boot/config-$(uname -r) > # CONFIG_PARAVIRT is not

[PATCH 2/3] Input: alps: drop unlikely before IS_ERR_OR_NULL

IS_ERR_OR_NULL already contain an unlikely compiler flag. Drop it. Signed-off-by: Geliang Tang --- drivers/input/mouse/alps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c index 4d24686..b4f146a

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

On Thu, Oct 1, 2015 at 4:01 AM, Steven Rostedt wrote: > On Thu, 1 Oct 2015 00:37:52 +0200 > Sedat Dilek wrote: > >> No, that did not help. >> >> $ dmesg | grep BUG: >> [ 24.491708] BUG: sleeping function called from invalid context at >>

Re: [PATCH v3 1/5] Input: goodix - reset device at init

Hey, On Wed, Sep 30, 2015 at 1:15 PM, Bastien Nocera wrote: > On Tue, 2015-09-29 at 17:47 +, Tirdea, Irina wrote: >> >> > -Original Message- >> > From: Bastien Nocera [mailto:had...@hadess.net] >> > Sent: 29 September, 2015 5:04 >> > To: Tirdea, Irina;