Re: [RFC 1/5] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2015-11-08 Thread Benjamin Tissoires
Hi, - Original Message - > From: "Jiri Kosina" > To: "Simon Wood" > Cc: linux-input@vger.kernel.org, linux-ker...@vger.kernel.org, "Edwin" > , "Michal MalĂ˝" > , "elias vanderstuyft" , > "Benjamin Tissoires" > > Sent: Friday, October 30, 2015 2:51:47 PM > Subject: Re: [RFC 1/5] INPUT:

Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl

2015-11-08 Thread Benjamin Tissoires
- Original Message - > From: "Elias Vanderstuyft" > To: "Benjamin Tissoires" > Cc: "Dmitry Torokhov" , "David Herrmann" > , "Peter Hutterer" > , "open list:HID CORE LAYER" > , linux-ker...@vger.kernel.org > Sent: Sunday, November 8, 2015 11:55:04 AM > Subject: Re: [PATCH v3] Input:

[PATCH v2 2/2] Input: uinput: Sanity check on ff_effects_max and EV_FF

2015-11-08 Thread Elias Vanderstuyft
Currently the user can set ff_effects_max to zero with the EV_FF bit (and the FF_GAIN and/or FF_AUTOCENTER bits) set, in this case the uninitialized methods ff->set_gain and/or ff->set_autocenter can be dereferenced, resulting in a kernel oops. Check in uinput_create_device() and print a helpful m

Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl

2015-11-08 Thread Elias Vanderstuyft
Hi, On Tue, Aug 25, 2015 at 5:12 PM, Benjamin Tissoires wrote: > diff --git a/include/uapi/linux/uinput.h b/include/uapi/linux/uinput.h > index 013c9d8..ef6c9f5 100644 > --- a/include/uapi/linux/uinput.h > +++ b/include/uapi/linux/uinput.h > @@ -20,6 +20,11 @@ > * Author: Aristeu Sergio Rozansk

[PATCH] Input: parkbd - Drop bogus __init from parkbd_allocate_serio()

2015-11-08 Thread Geert Uytterhoeven
WARNING: vmlinux.o(.text+0x1056606): Section mismatch in reference from the function parkbd_attach() to the function .init.text:parkbd_allocate_serio() The function parkbd_attach() references the function __init parkbd_allocate_serio(). This is often because parkbd_attach lacks a __init annotation