On Tue, Aug 7, 2012 at 3:09 PM, Ferruh Yigit f...@cypress.com wrote:
From: Ferruh YIGIT f...@cypress.com
This driver is for Cypress TrueTouch(tm) Standard Product controllers,
Generation4 devices.
Driver consist of four main modules:
Bus driver: Linux bus driver implementation, binds other
On Fri, Sep 14, 2012 at 8:46 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Ferruh,
This driver is for Cypress TrueTouch(tm) Standard Product controllers,
Generation4 devices.
This is second version of driver, code re-structured to match with
existing Generation3 driver code.
To
Martinez Canillas jav...@dowhile0.org
Thanks
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
catch, thanks for fixing it
Acked-by: Javier Martinez Canillas jav...@dowhile0.org
---
drivers/input/touchscreen/cyttsp_core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/cyttsp_core.c
b/drivers/input/touchscreen/cyttsp_core.c
index
contain Cypress (or its subsidiaries)
confidential information. If it has been received in error, please advise the
sender and immediately delete this message.
Acked-by: Javier Martinez Canillas jav...@dowhile0.org
--
To unsubscribe from this list: send the line unsubscribe linux-input
-by: Matthias Kaehlcke matth...@kaehlcke.net
---
Acked-by: Javier Martinez Canillas jav...@dowhile0.org
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
devices
Input: cyttsp4 - I2C driver for Cypress TMA4XX touchscreen devices
Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices
For the whole series:
Acked-by: Javier Martinez Canillas jav...@dowhile0.org
drivers/input/touchscreen/Kconfig | 30 +
drivers/input
-by: Matthias Kaehlcke matth...@kaehlcke.net
Acked-by: Javier Martinez Canillas jav...@dowhile0.org
Acked-by: Ferruh Yigit f...@cypress.com
---
drivers/input/touchscreen/cyttsp_core.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/cyttsp_core.h
for Cypress, we may change the driver
status from Maintained to Supported.
Signed-off-by: Javier Martinez Canillas jav...@dowhile0.org
---
Ferruh, please send your ack if you are willing to take over
maintainance of this driver.
Also, please confirm that you have been working on behalf
On Tue, Jul 16, 2013 at 8:57 AM, Ferruh Yigit f...@cypress.com wrote:
On 07/15/2013 12:41 AM, Javier Martinez Canillas wrote:
I haven't had time to work on this driver for a long time and
Ferruh has been doing a great job making it more generic,
adding support for new hardware and providing
From: Doug Anderson diand...@chromium.org
If someone sends a EC_CMD_REBOOT_EC to the EC, the EC will likely be
unresponsive for quite a while. Add a delay to the end of the command
to prevent random failures of future commands.
NOTES:
* This could be optimized a bit by simply delaying the next
From: Andrew Bresticker abres...@chromium.org
Instead of having users of the ChromeOS EC call the interface-specific
cmd_xfer() callback directly, introduce a central cros_ec_cmd_xfer()
to use instead. This will allow us to put all the locking and retry
logic in one place instead of duplicating
From: Andrew Bresticker abres...@chromium.org
Now that there's a central cros_ec_cmd_xfer(), move the locking
out of the SPI and LPC drivers.
Signed-off-by: Andrew Bresticker abres...@chromium.org
Reviewed-by: Simon Glass s...@chromium.org
---
drivers/mfd/cros_ec.c | 10 +-
From: Andrew Bresticker abres...@chromium.org
When an EC command returns EC_RES_IN_PROGRESS, we need to query
the state of the EC until it indicates that it is no longer busy.
Do this in cros_ec_cmd_xfer() under the EC's mutex so that other
commands (e.g. keyboard, I2C passtru) aren't issued to
From: Derek Basehore dbaseh...@chromium.org
Since the i2c bus can get wedged on the EC sometimes, set the number of retries
to 3. Since we un-wedge the bus immediately after the wedge happens, this is the
correct fix since only one transfer will fail.
Signed-off-by: Derek Basehore
This is a second batch of cleanups patches for the mfd cros_ec
driver and its subdevices drivers. The first batch of cleanups
was posted by Doug Anderson [0] and have already been merged.
The patches were picked from the ChromeOS 3.8 kernel and after
these no cleanups patches for cros_ec are left,
From: Todd Broch tbr...@chromium.org
If the EC device tree node has sub-nodes, try to instantiate them as
MFD sub-devices. We can configure the EC features provided by the board.
Signed-off-by: Todd Broch tbr...@chromium.org
---
drivers/mfd/cros_ec.c | 40
From: Todd Broch tbr...@chromium.org
Previous algorithm was a bit conservative and complicating with
respect to identifying key ghosting. This CL uses the bitops hamming
weight function (hweight8) to count the number of matching rows for
colM colN. If that number is 1 ghosting is present.
Hello Wolfram,
On 08/01/2014 07:59 PM, Wolfram Sang wrote:
+#define I2C_MAX_RETRIES 3
I think a define for this is overkill, yet I don't really mind.
Acked-by: Wolfram Sang w...@the-dreams.de
Thanks a lot.
I assume this goes via MFD, let me know if I should take it.
Yes, if
is four entries but the driver dynamically allocates the
keymap array and does not limit the array size.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Documentation/devicetree/bindings/input/atmel,maxtouch.txt | 8 +++-
1 file changed, 7 insertions(+), 1 deletion
type
than IRQ_TYPE_NONE. The right approach is to get the IRQ flags
that was parsed by OF from the interrupt Device Tree propery.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/input/touchscreen/atmel_mxt_ts.c | 9 -
1 file changed, 8 insertions(+), 1
-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
With only this patch the touchpad is probed but interrupts are not being
generated. The following is needed to have a fully functional touchpad:
[PATCH 1/2] Input: atmel_mxt_ts - Get IRQ edge/level flags on DT booting
https
Hello Tomasz,
Thanks a lot for your feedback.
On 08/07/2014 03:14 AM, Tomasz Figa wrote:
Hi Javier,
Have you observed an actual failure due to this? I believe that
Yes, I found this issue since the driver was not taking into account the value
defined in the edge/level type cells from the
Hello Fabio,
On 08/07/2014 03:35 AM, Fabio Estevam wrote:
On Wed, Aug 6, 2014 at 10:08 PM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
+hsi2c_8 {
+ status = okay;
+ clock-frequency = 333000;
Doesn't it work at the more standard 400kHz i2c frequency
type
than IRQ_TYPE_NONE. The right approach is to get the IRQ flags
that was parsed by OF from the interrupt Device Tree propery.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
This patch was first sent as a part of a two part series along
with [PATCH 2/2] Input
Hello Dmitry,
On 08/07/2014 08:09 AM, Dmitry Torokhov wrote:
irq_of_parse_and_map() already sets up IRQ trigger type based on DT
data, by calling irq_create_of_mapping() which in turn calls
irq_set_irq_type().
Right but somehow when the IRQ is actually requested the type is
Hello,
On 08/07/2014 06:47 PM, Dmitry Torokhov wrote:
Actually, I take this back. In mainline everything as it should: if
pdata does not specify particular trigger the flags requested end up
being IRQF_ONESHOT, which should preserve trigger bits previously set up
by the board or OF code. In
+Thomas Gleixner, Jason Cooper, Benjamin Herrenschmidt and Thomas Abraham
Hello Dmitry,
On 08/08/2014 06:21 PM, Dmitry Torokhov wrote:
On Fri, Aug 08, 2014 at 03:07:33PM +0100, Nick Dyer wrote:
On 07/08/14 08:44, Javier Martinez Canillas wrote:
The Atmel maXTouch driver assumed that the IRQ
Hello,
On 08/08/2014 06:38 PM, Javier Martinez Canillas wrote:
It seems as if the first call to exynos_irq_set_type() that is made by OF is a
no-op while the second call is the one that actually setups the hw correctly.
Does this make any sense? Maybe is related to the pin not being muxed
Hello Doug,
On 08/08/2014 10:54 PM, Doug Anderson wrote:
Hi,
To fix the issue a variation of patch [0] will be posted that moves the IRQ
pinmux setup from .irq_set_type to the .irq_request_resources function
handler.
That way the pin will be setup as IRQ regardless of the the trigger type
Hello Nick,
On 08/08/2014 04:52 PM, Javier Martinez Canillas wrote:
On 08/07/2014 02:38 PM, Nick Dyer wrote:
I'm afraid you have misunderstood the impact of this change to the way that
the GPIOs coming in to the touch controller are mapped to key codes. Look
Unfortunately
to the EC while
it is working on the in-progress command.
Signed-off-by: Andrew Bresticker abres...@chromium.org
Reviewed-by: Simon Glass s...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/cros_ec.c | 35 ++-
1 file
Hello Lee,
This is a resend of a patch series originally sent [0] almost a
month ago (July, 28). The series add a batch of cleanups patches
for the mfd cros_ec driver and its subdevices drivers. The first
batch of cleanups was posted by Doug Anderson [1] and have already
been merged. The patches
it across the different
drivers.
Signed-off-by: Andrew Bresticker abres...@chromium.org
Reviewed-by: Simon Glass s...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/i2c/busses/i2c-cros-ec-tunnel.c | 2 +-
drivers/input/keyboard/cros_ec_keyb.c
From: Andrew Bresticker abres...@chromium.org
Now that there's a central cros_ec_cmd_xfer(), move the locking
out of the SPI and LPC drivers.
Signed-off-by: Andrew Bresticker abres...@chromium.org
Reviewed-by: Simon Glass s...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti
From: Todd Broch tbr...@chromium.org
If the EC device tree node has sub-nodes, try to instantiate them as
MFD sub-devices. We can configure the EC features provided by the board.
Signed-off-by: Todd Broch tbr...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti
Hello Lee,
Thanks a lot for your feedback.
On 08/21/2014 04:21 PM, Lee Jones wrote:
On Wed, 20 Aug 2014, Javier Martinez Canillas wrote:
From: Andrew Bresticker abres...@chromium.org
When an EC command returns EC_RES_IN_PROGRESS, we need to query
the state of the EC until it indicates
Hello Lee,
On 08/21/2014 04:25 PM, Lee Jones wrote:
static const struct mfd_cell cros_devs[] = {
-{
-.name = cros-ec-keyb,
-.id = 1,
-.of_compatible = google,cros-ec-keyb,
-},
-{
-.name = cros-ec-i2c-tunnel,
-.id
it across the different
drivers.
Signed-off-by: Andrew Bresticker abres...@chromium.org
Reviewed-by: Simon Glass s...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Doug Anderson diand...@chromium.org
Acked-by: Lee Jones lee.jo...@linaro.org
long term.
* This same logic probably needs to be applied to the i2c driver.
Signed-off-by: Doug Anderson diand...@chromium.org
Reviewed-by: Randall Spangler rspang...@chromium.org
Reviewed-by: Vadim Bendebury vben...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti
Hello Dmitry,
On 08/25/2014 07:05 PM, Dmitry Torokhov wrote:
Patches #1, #2, #6 and #7 do not depend of others so they can be
merged independently but patches #3, #4 and #5 have to be merged
in that specific order since they depend on the previous one.
#7 does not apply to my tree (I
Hello Dmitry,
On 08/25/2014 08:01 PM, Dmitry Torokhov wrote:
On Mon, Aug 25, 2014 at 07:28:01PM +0200, Javier Martinez Canillas wrote:
#7 does not apply to my tree (I guess it depends on the 1st batch which I
expect will go through MFD tree?). Maybe you could rebase it on top of my
Hello Lee,
Sorry for the delay but had been on holidays last week.
On 09/04/2014 10:25 AM, Lee Jones wrote:
-static const struct mfd_cell cros_devs[] = {
-{
-.name = cros-ec-keyb,
-.id = 1,
-.of_compatible = google,cros-ec-keyb,
-},
-{
-
[adding Lee Jones to cc list since I'm referring on a series he posted]
Hello Sjoerd,
On 09/09/2014 09:52 AM, Sjoerd Simons wrote:
For i2c devices in OF the modalias exposed to userspace is i2c:node
type, for the Maxtouch driver this is i2c:maxtouch.
Add maxtouch to the i2c id table such
Hello Lee,
On 09/11/2014 10:00 AM, Sjoerd Simons wrote:
-static const struct of_device_id mxt_of_match[] = {
-{ .compatible = atmel,maxtouch, },
-{},
-};
-MODULE_DEVICE_TABLE(of, mxt_of_match);
-
static const struct i2c_device_id mxt_id[] = {
Hello Nick,
On 09/11/2014 11:19 AM, Nick Dyer wrote:
Thanks for the clear explanation.
The i2c aliases are a bit confusing. The original device the driver was
written for was called qt602240, which was renamed by Atmel to mXT224 when
the chip series was called maXTouch. The driver now
Hello Wolfram,
On 09/11/2014 01:08 PM, Wolfram Sang wrote:
Funny timing. I am just reviewing the series from Lee and also stumbled
over modaliases, too...
On Thu, Sep 11, 2014 at 10:19:54AM +0100, Nick Dyer wrote:
On 11/09/14 09:38, Javier Martinez Canillas wrote:
To expand on what
Hello Wolfram,
On 09/11/2014 01:35 PM, Wolfram Sang wrote:
This is a workaround. It would make sense, however, to add it because we
want to support i2c_board_info structures.
I think it really depends if an IP block can be used on non-DT platforms
(which I think is true for this
Hello,
This is a second batch of cleanups patches for the mfd cros_ec
driver and its subdevices drivers. The first batch of cleanups
was posted by Doug Anderson [0] and have already been merged.
The patches were picked from the ChromeOS 3.8 kernel and after
these no cleanups patches for cros_ec
long term.
* This same logic probably needs to be applied to the i2c driver.
Signed-off-by: Doug Anderson diand...@chromium.org
Reviewed-by: Randall Spangler rspang...@chromium.org
Reviewed-by: Vadim Bendebury vben...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti
...@chromium.org
Reviewed-by: Doug Anderson diand...@chromium.org
Acked-by: Wolfram Sang w...@the-dreams.de
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/i2c/busses/i2c-cros-ec-tunnel.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/i2c/busses/i2c-cros
-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v3:
- Fix us time and use raw values instead of a define. Suggested by Lee Jones.
Changes since v2:
- Explain in the commit message from where the delay and retry values come
from.
Commented by Andrew Bresticker.
- Move
it across the different
drivers.
Signed-off-by: Andrew Bresticker abres...@chromium.org
Reviewed-by: Simon Glass s...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Doug Anderson diand...@chromium.org
Acked-by: Lee Jones lee.jo...@linaro.org
From: Andrew Bresticker abres...@chromium.org
Now that there's a central cros_ec_cmd_xfer(), move the locking
out of the SPI driver.
Signed-off-by: Andrew Bresticker abres...@chromium.org
Reviewed-by: Simon Glass s...@chromium.org
Signed-off-by: Javier Martinez Canillas javier.marti
as the Cros EC MFD driver registers
the MFD subdevices with an of_compatibility string.
Signed-off-by: Sjoerd Simons sjoerd.sim...@collabora.co.uk
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Applied to for-next, thanks!
However, since you are working
Hello Dmitry,
There are different multi-touch protocols used by Atmel maXTouch touchscreen
chips. Old chips use the T9 multi-touch object type while newer chips use the
T100 multi-touch object type. The Atmel touch driver currently only supports
the former so this series add support for the
.
Signed-off-by: Nick Dyer nick.d...@itdev.co.uk
Acked-by: Yufeng Shen mile...@chromium.org
[javier: Factor out T9 and T100 routines to have a common init function]
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/input/touchscreen/atmel_mxt_ts.c | 258
function to simplify the former.
Signed-off-by: Sjoerd Simons sjoerd.sim...@collabora.co.uk
[javier: Adapt to latest driver changes and modify commit message accordingly]
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/input/touchscreen/atmel_mxt_ts.c | 48
Hello Nick,
On 12/16/2014 05:39 PM, Nick Dyer wrote:
On 16/12/14 16:34, Javier Martinez Canillas wrote:
On 12/16/2014 05:16 PM, Nick Dyer wrote:
Nick Dyer (1):
Input: atmel_mxt_ts - Implement support for T100 touch object
I posted an updated version of this patch on 9th December and would
Hello Nick,
On 12/16/2014 06:07 PM, Nick Dyer wrote:
On 16/12/14 16:49, Javier Martinez Canillas wrote:
Awesome, what do you think about the change to have a common input device
initialization function that I squashed in your original patch?
mxt_initialize_t100_input_device
Hello Nick,
On 12/19/2014 15:04 PM, Nick Dyer wrote:
Hi Benson-
On 18/12/14 18:49, Benson Leung wrote:
Dmitry and Chung-Yih have had some discussion about how to handle
hovering fingers, and I think the direction they wanted to go was to
use ABS_MT_DISTANCE instead.
Hello Dmitry,
This is a resend of the T100 muli-touch object type support for the Atmel
maXTouch touchscreen driver. Old chips use the T9 multi-touch object type
while newer chips use this T100 multi-touch object type which is currenty
not supported by the driver.
Nick Dyer posted his patch to
support]
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/input/touchscreen/atmel_mxt_ts.c | 323 +--
1 file changed, 302 insertions(+), 21 deletions(-)
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c
b/drivers/input/touchscreen
function to simplify the former.
Signed-off-by: Sjoerd Simons sjoerd.sim...@collabora.co.uk
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/input/touchscreen/atmel_mxt_ts.c | 48 +++-
1 file changed, 28 insertions(+), 20 deletions(-)
diff
.
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Dmitry,
On 03/17/2015 03:00 PM, Javier Martinez Canillas wrote:
This is a resend of the T100 muli-touch object type support for the Atmel
maXTouch touchscreen driver. Old chips use the T9 multi-touch object type
while newer chips use this T100 multi-touch object type which is currenty
),
+ .acpi_match_table = ACPI_PTR(mxt_acpi_id),
.pm = mxt_pm_ops,
},
.probe = mxt_probe,
Patch looks good to me and I've tested it in a Pixel2 Chromebook using
evtest:
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Tested-by: Javier Martinez
their
configurations will surely differ.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
--
To unsubscribe from this list: send the line
Hello Dmitry,
On Wednesday, April 15, 2015 18:35 BST, Dmitry Torokhov
dmitry.torok...@gmail.com wrote:
On Wed, Apr 15, 2015 at 05:58:04PM +0200, Javier Martinez Canillas wrote:
This is an unrelated cleanup so probably should had been a separate patch?
Fair enough.
--
Dmitry
Hello Benjamin,
On 04/15/2015 11:20 PM, Benjamin Tissoires wrote:
Hi guys,
On Wed, Apr 15, 2015 at 11:58 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
Hello Dmitry,
On 04/08/2015 02:26 AM, Dmitry Torokhov wrote:
This change allows atmel_mxt_ts to bind to ACPI
by the ChromeOS EC mfd driver, KEYBOARD_CROS_EC really
should depend on MFD_CROS_EC. And because this config option selects
CROS_EC_PROTO, that dependency is met as well. So make the driver
to depend on MFD_CROS_EC instead of CROS_EC_PROTO.
Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com
and Bartolomiej for the feedback and suggestions.
Best regards,
Javier
Javier Martinez Canillas (6):
mfd: Add MFD_CROS_EC dependencies
Revert platform/chrome: Don't make CHROME_PLATFORMS depends on X86 ||
ARM
platform/chrome: Make depends on MFD_CROS_EC instead CROS_EC_PROTO
mfd
instead so the module can be auto-loaded and also
report the correct alias using sysfs:
$ cat /sys/class/i2c-adapter/i2c-8/8-004b/modalias
of:NtrackpadTNULLCatmel,maxtouch
Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com
---
drivers/i2c/i2c-core.c | 8
1 file changed, 8
Hello Dmitry,
Thanks a lot for your feedback.
On 07/30/2015 06:37 PM, Dmitry Torokhov wrote:
On Thu, Jul 30, 2015 at 09:35:17AM -0700, Dmitry Torokhov wrote:
Hi Javier,
On Thu, Jul 30, 2015 at 06:18:25PM +0200, Javier Martinez Canillas wrote:
Hello,
Short version:
This series add
if that happens.
Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com
---
drivers/input/touchscreen/egalax_ts.c | 1 +
drivers/input/touchscreen/mms114.c| 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/input/touchscreen/egalax_ts.c
b/drivers/input/touchscreen/egalax_ts.c
with OF but that don't have a of_match_table.
Although arguably, those drivers were relying on the assumption that a
MODALIAS=i2c:foo would always be reported even for the OF case which
is not the true on other subsystems.
[0]: https://lkml.org/lkml/2014/8/28/283
Best regards,
Javier
Javier Martinez
module when the device is added.
Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com
---
drivers/input/misc/gp2ap002a00f.c | 1 +
drivers/input/touchscreen/goodix.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/input/misc/gp2ap002a00f.c
b/drivers/input/misc
Hello,
On 08/06/2015 01:11 PM, Sjoerd Simons wrote:
+ Corrected Javiers e-mail address.
On Thu, 2015-08-06 at 12:51 +0200, Dirk Behme wrote:
On 17.03.2015 15:00, Javier Martinez Canillas wrote:
Having this patch in mainline as commit
b23157dc74272ac8ebffd1a566e3e822dbc3e65f [1] breaks our
thanks for reporting it but I've already mentioned in this
thread that I posted a fix for it and is already in Dmitry tree:
https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/?h=next=5b21e3c740b770fb2548a5a8ea66e544d114d0a8
Best regards,
--
Javier Martinez Canillas
Open Source Group
Sam
roduced by my "cleanup" patch, sorry for the mess :(
I double checked when posting the patch but got confused and used the old
error logic. Following is a fixup patch [0].
I don't know if Dmitry prefers to squash with the other patch since it
didn't hit mainline yet or if not I can post it
Hello Dmitry,
On 10/07/2015 12:49 AM, Dmitry Torokhov wrote:
> On Tue, Oct 06, 2015 at 11:49:41PM +0200, Javier Martinez Canillas wrote:
>> Hello Stephen,
>>
>> On 10/06/2015 11:01 PM, Stephen Kitt wrote:
>>> On Tue, 6 Oct 2015 22:57:26 +0200, Stephen Kitt <st.
_from_user() failed.
This is of course wrong since if memdup_user() fails, no memory was
allocated and the error in the error-valued pointer should be returned.
Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Fixes
Hello Dmitry,
On 09/11/2015 03:35 AM, Javier Martinez Canillas wrote:
> Remove the unneded semicolon since it is clearly a typo error.
>
> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
>
> ---
>
> drivers/input/keyboard/snvs_pwrkey.c | 2 +-
>
-by: Javier Martinez Canillas jav...@osg.samsung.com
---
drivers/input/misc/max8997_haptic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/input/misc/max8997_haptic.c
b/drivers/input/misc/max8997_haptic.c
index d0f687281339..a806ba3818f7 100644
--- a/drivers/input/misc
Remove the unneded semicolon since it is clearly a typo error.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/input/keyboard/snvs_pwrkey.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/snvs_pwrkey.c
b/drivers
They aren't needed and are just creating null statements so remove it.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/input/touchscreen/mms114.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/mms114.c
b/d
It's not needed and is just creating a null statement so remove it.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/input/misc/pm8941-pwrkey.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/pm8941-pwrkey.c
b/drivers
Hello Dmitry,
On 10/02/2015 08:25 PM, Dmitry Torokhov wrote:
> Hi Javier,
>
> On Fri, Oct 02, 2015 at 03:40:11PM +0200, Javier Martinez Canillas wrote:
>> Hello Dmitry,
>>
>> This series contains trivial patches with fixes to different warnings
>> reported
-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/input/mouse/synaptics_i2c.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/input/mouse/synaptics_i2c.c
b/drivers/input/mouse/synaptics_i2c.c
index aa7c5da60800..9f69ce3de2f3 100644
--- a/drivers
-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/input/mouse/elan_i2c_smbus.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/input/mouse/elan_i2c_smbus.c
b/drivers/input/mouse/elan_i2c_smbus.c
index cb6aecbc1dc2..e5b0adfac3d0 100644
--- a/drivers
/touchscreen/ads7846.c:532:1-3: WARNING: PTR_ERR_OR_ZERO can be
used
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/input/touchscreen/ads7846.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/touchscreen/ads7846.c
b/drivers
/touchscreen/cyttsp4_i2c.c:53:1-3: WARNING: PTR_ERR_OR_ZERO can be
used
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/input/touchscreen/cyttsp4_i2c.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/input/touchscreen/cyttsp4_i2
-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/input/keyboard/goldfish_events.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/input/keyboard/goldfish_events.c
b/drivers/input/keyboard/goldfish_events.c
index 907e4e278fce..6dfdb574bd01
-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/input/touchscreen/jornada720_ts.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/input/touchscreen/jornada720_ts.c
b/drivers/input/touchscreen/jornada720_ts.c
index ea3b6a5b83e6..177a1e92da03
and declaration on line 1485 can be dropped
end returns can be simplified and declaration on line 515 can be dropped
end returns can be simplified
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/input/touchscreen/atmel_mxt_ts.c | 30 +--
-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/input/touchscreen/intel-mid-touch.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/input/touchscreen/intel-mid-touch.c
b/drivers/input/touchscreen/intel-mid-touch.c
index b4f0725a1c3d..4c3ef2
The invoked function already returns zero on success or a negative
errno code so there is no need to open code the logic in the caller.
This also fixes the following make coccicheck warning:
end returns can be simplified and declaration on line 304 can be dropped
Signed-off-by: Javier Martinez
Martinez Canillas <jav...@osg.samsung.com>
---
drivers/input/keyboard/cap11xx.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c
index 378db10001df..7240316ddfe3 100644
--- a/drivers/input/ke
The invoked function already returns zero on success or a negative
errno code so there is no need to open code the logic in the caller.
This also fixes the following make coccicheck warnings:
end returns can be simplified and declaration on line 402 can be dropped
Signed-off-by: Javier Martinez
-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/input/misc/retu-pwrbutton.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/input/misc/retu-pwrbutton.c
b/drivers/input/misc/retu-pwrbutton.c
index 30b459b6b344..55ce68a6dcbf 100644
--- a/drivers/inpu
1 - 100 of 114 matches
Mail list logo
