Re: [RFT/PATCH] Input: bfin_rotary - introduce open and close methods

2015-02-12 Thread Sonic Zhang
Acked-by: Sonic Zhang sonic.zh...@analog.com On Thu, Feb 12, 2015 at 3:54 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Sonic, On Fri, Feb 06, 2015 at 05:37:29PM +0800, Sonic Zhang wrote: Hi Dmitry, After apply your patch manually to my blackfin kernel tree, I got kernel panic

Re: [PATCH] Input: bfin_rotary - mark suspend and resume code as __maybe_unused

2015-02-09 Thread Sonic Zhang
Hi Dmitry, Since the line I mentioned was removed in v3.19-rc1, I am fine with this patch. Acked-by: Sonic Zhang sonic.zh...@analog.com On Fri, Feb 6, 2015 at 2:09 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Instead of using #ifdef to guard potentially unused suspend and resume code

Re: [PATCH] Input: bfin_rotary - mark suspend and resume code as __maybe_unused

2015-02-06 Thread Sonic Zhang
Hi Dmitry, On Fri, Feb 6, 2015 at 2:09 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Instead of using #ifdef to guard potentially unused suspend and resume code let's mark them as __maybe_unused so they still get discarded if they are not used but we do not get warning. This allows for

Re: [RFT/PATCH] Input: bfin_rotary - introduce open and close methods

2015-02-06 Thread Sonic Zhang
Hi Dmitry, On Fri, Feb 6, 2015 at 2:56 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Introduce open and close methods for the input device to postpone enabling the device until it is needed. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- Hi Sonic, Could you please

Re: [RFT/PATCH] Input: bfin_rotary - introduce open and close methods

2015-02-06 Thread Sonic Zhang
: 0x00100100 { _device_add + 0x3b4 } address : 0x0001bcde { _parse_args + 0x12e } address : 0xffa00014 { _ret_from_fork + 0x14 } Modules linked in: Kernel panic - not syncing: Kernel exception ---[ end Kernel panic - not syncing: Kernel exception Regards, Sonic Zhang -- To unsubscribe from

[PATCH] blackfin: convert pinmux request API into empty static inline functions for bf609 and bf548

2015-02-06 Thread Sonic Zhang
From: Sonic Zhang sonic.zh...@analog.com Signed-off-by: Sonic Zhang sonic.zh...@analog.com --- arch/blackfin/include/asm/portmux.h | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/arch/blackfin/include/asm/portmux.h b/arch/blackfin/include/asm/portmux.h

[PATCH v2] bfin_rotary: convert to use managed resources

2015-02-05 Thread Sonic Zhang
From: Sonic Zhang sonic.zh...@analog.com - remap rotary register physical address into kernel space in probe - replace kzalloc with devm_kzalloc - replace request_irq with devm_request_irq - remove memory free and irq free from the device remove function - use devm_input_allocate_device v2

[PATCH] bfin_rotary: convert to use managed resources

2015-02-04 Thread Sonic Zhang
From: Sonic Zhang sonic.zh...@analog.com - remap rotary register physical address into kernel space in probe - replace kzalloc with devm_kzalloc - replace request_irq with devm_request_irq - remove memory free and irq free from the device remove function - use devm_input_allocate_device Signed

[PATCH v3 2/3] bfin_rotary: Move peripheral pinmux definition into platform data of bf527

2015-02-04 Thread Sonic Zhang
From: Sonic Zhang sonic.zh...@analog.com v3-changes: - Pinctrl API is used to set up counter pinmux on bf548 and bf609. Pinmux list is use less on bf548 and bf609. Signed-off-by: Sonic Zhang sonic.zh...@analog.com --- arch/blackfin/mach-bf527/boards/ad7160eval.c |8 arch/blackfin

[PATCH v4 3/3] bfin_rotary: replace bfin specific MMR function with generic IO function

2015-02-04 Thread Sonic Zhang
From: Sonic Zhang sonic.zh...@analog.com - use readw and writew to access rotary MMRs - remap rotary register physical address into kernel space in probe v2-changes: - replace kzalloc with devm_kzalloc - replace request_irq with devm_request_irq - remove memory free and irq free from the device

Re: [PATCH v3 2/3] bfin_rotary: Move peripheral pinmux definition into platform data of bf527

2015-02-04 Thread Sonic Zhang
Hi Dmitry, On Thu, Feb 5, 2015 at 3:44 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Sonic, On Wed, Feb 04, 2015 at 03:58:04PM +0800, Sonic Zhang wrote: @@ -102,7 +95,7 @@ static int bfin_rotary_probe(struct platform_device *pdev) return -EINVAL

Re: [PATCH v3 2/3] bfin_rotary: Move peripheral pinmux definition into platform data of bf527

2015-02-04 Thread Sonic Zhang
Hi Dmitry, On Thu, Feb 5, 2015 at 3:44 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Sonic, On Wed, Feb 04, 2015 at 03:58:04PM +0800, Sonic Zhang wrote: @@ -102,7 +95,7 @@ static int bfin_rotary_probe(struct platform_device *pdev) return -EINVAL

Re: [PATCH v2 3/3] bfin_rotary: replace bfin specific MMR function with generic IO function

2015-02-03 Thread Sonic Zhang
Hi Dmitry, On Wed, Feb 4, 2015 at 9:24 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Jan 14, 2015 at 04:54:14PM +0800, Sonic Zhang wrote: From: Sonic Zhang sonic.zh...@analog.com - use readw and writew to access rotary MMRs - remap rotary register physical address into kernel

Re: [PATCH v2 2/3] bfin_rotary: Move peripheral pinmux definition into platform data

2015-02-03 Thread Sonic Zhang
Hi Dmitry, On Wed, Feb 4, 2015 at 9:22 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Jan 14, 2015 at 04:54:13PM +0800, Sonic Zhang wrote: From: Sonic Zhang sonic.zh...@analog.com Please tell me why this is needed. Also, should not this be converted to pinctrl infrastructure

Re: [PATCH v2 3/3] bfin_rotary: replace bfin specific MMR function with generic IO function

2015-02-03 Thread Sonic Zhang
Hi Dmitry, On Wed, Feb 4, 2015 at 9:24 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Jan 14, 2015 at 04:54:14PM +0800, Sonic Zhang wrote: From: Sonic Zhang sonic.zh...@analog.com - use readw and writew to access rotary MMRs - remap rotary register physical address into kernel

Re: [PATCH v2 1/3] bfin_rotary: move rotary platform header definition to linux platform_data head path

2015-02-01 Thread Sonic Zhang
Hi Dmitry, Could you review and merge these 3 patches for bfin_rotary? Thanks, Sonic -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/3] bfin_rotary: replace bfin specific MMR function with generic IO function

2015-01-29 Thread Sonic Zhang
Ping again. On Wed, Jan 14, 2015 at 4:54 PM, Sonic Zhang sonic@gmail.com wrote: From: Sonic Zhang sonic.zh...@analog.com - use readw and writew to access rotary MMRs - remap rotary register physical address into kernel space in probe v2-changes: - replace kzalloc with devm_kzalloc

Re: [PATCH v2 1/3] bfin_rotary: move rotary platform header definition to linux platform_data head path

2015-01-29 Thread Sonic Zhang
Ping again On Wed, Jan 14, 2015 at 4:54 PM, Sonic Zhang sonic@gmail.com wrote: From: Sonic Zhang sonic.zh...@analog.com The platform data definition of the rotary driver should be generic for all architectures. Signed-off-by: Sonic Zhang sonic.zh...@analog.com --- arch/blackfin/mach

Re: [PATCH v2 1/3] bfin_rotary: move rotary platform header definition to linux platform_data head path

2015-01-21 Thread Sonic Zhang
PING On Wed, Jan 14, 2015 at 4:54 PM, Sonic Zhang sonic@gmail.com wrote: From: Sonic Zhang sonic.zh...@analog.com The platform data definition of the rotary driver should be generic for all architectures. Signed-off-by: Sonic Zhang sonic.zh...@analog.com --- arch/blackfin/mach-bf527

Re: [PATCH v2 3/3] bfin_rotary: replace bfin specific MMR function with generic IO function

2015-01-21 Thread Sonic Zhang
PING On Wed, Jan 14, 2015 at 4:54 PM, Sonic Zhang sonic@gmail.com wrote: From: Sonic Zhang sonic.zh...@analog.com - use readw and writew to access rotary MMRs - remap rotary register physical address into kernel space in probe v2-changes: - replace kzalloc with devm_kzalloc - replace

[PATCH 1/3] bfin_rotary: move rotary platform header definition to linux platform_data head path

2015-01-14 Thread Sonic Zhang
From: Sonic Zhang sonic.zh...@analog.com The platform data definition of the rotary driver should be generic for all architectures. Signed-off-by: Sonic Zhang sonic.zh...@analog.com --- arch/blackfin/mach-bf527/boards/ad7160eval.c |2 +- arch/blackfin/mach-bf527/boards/ezkit.c

[PATCH 3/3] bfin_rotary: replace bfin specific MMR function with generic IO function

2015-01-14 Thread Sonic Zhang
From: Sonic Zhang sonic.zh...@analog.com - use readw and writew to access rotary MMRs - remap rotary register physical address into kernel space in probe Signed-off-by: Sonic Zhang sonic.zh...@analog.com --- arch/blackfin/mach-bf527/boards/ad7160eval.c |5 +++ arch/blackfin/mach-bf527

[PATCH 2/3] bfin_rotary: Move peripheral pinmux definition into platform data

2015-01-14 Thread Sonic Zhang
From: Sonic Zhang sonic.zh...@analog.com Signed-off-by: Sonic Zhang sonic.zh...@analog.com --- arch/blackfin/mach-bf527/boards/ad7160eval.c |8 arch/blackfin/mach-bf527/boards/ezkit.c |8 arch/blackfin/mach-bf548/boards/ezkit.c |8 arch/blackfin

[PATCH v2 3/3] bfin_rotary: replace bfin specific MMR function with generic IO function

2015-01-14 Thread Sonic Zhang
From: Sonic Zhang sonic.zh...@analog.com - use readw and writew to access rotary MMRs - remap rotary register physical address into kernel space in probe v2-changes: - replace kzalloc with devm_kzalloc - replace request_irq with devm_request_irq - remove memory free and irq free from the device

[PATCH v2 2/3] bfin_rotary: Move peripheral pinmux definition into platform data

2015-01-14 Thread Sonic Zhang
From: Sonic Zhang sonic.zh...@analog.com Signed-off-by: Sonic Zhang sonic.zh...@analog.com --- arch/blackfin/mach-bf527/boards/ad7160eval.c |8 arch/blackfin/mach-bf527/boards/ezkit.c |8 arch/blackfin/mach-bf548/boards/ezkit.c |8 arch/blackfin

[PATCH v2 1/3] bfin_rotary: move rotary platform header definition to linux platform_data head path

2015-01-14 Thread Sonic Zhang
From: Sonic Zhang sonic.zh...@analog.com The platform data definition of the rotary driver should be generic for all architectures. Signed-off-by: Sonic Zhang sonic.zh...@analog.com --- arch/blackfin/mach-bf527/boards/ad7160eval.c |2 +- arch/blackfin/mach-bf527/boards/ezkit.c