Re: [PATCH] HID: sony: Fix work queue issues.

2014-02-20 Thread Jiri Kosina
On Wed, 19 Feb 2014, Frank Praznik wrote: > Don't initialize force-feedback for devices that don't support it to avoid > calls > to schedule_work() with an uninitialized work_struct. > > Move the cancel_work_sync() call out of sony_destroy_ff() since the state > worker > is used for the LEDs ev

Re: [PATCH] HID: sony: Fix work queue issues.

2014-02-19 Thread David Herrmann
Hi On Wed, Feb 19, 2014 at 8:21 PM, Frank Praznik wrote: > On Wed, Feb 19, 2014 at 1:41 PM, David Herrmann wrote: >> Hi Frank >> >> On Wed, Feb 19, 2014 at 7:09 PM, Frank Praznik >> wrote: >>> Don't initialize force-feedback for devices that don't support it to avoid >>> calls >>> to schedule

Re: [PATCH] HID: sony: Fix work queue issues.

2014-02-19 Thread Frank Praznik
On Wed, Feb 19, 2014 at 1:41 PM, David Herrmann wrote: > Hi Frank > > On Wed, Feb 19, 2014 at 7:09 PM, Frank Praznik > wrote: >> Don't initialize force-feedback for devices that don't support it to avoid >> calls >> to schedule_work() with an uninitialized work_struct. >> >> Move the cancel_wor

Re: [PATCH] HID: sony: Fix work queue issues.

2014-02-19 Thread David Herrmann
Hi Frank On Wed, Feb 19, 2014 at 7:09 PM, Frank Praznik wrote: > Don't initialize force-feedback for devices that don't support it to avoid > calls > to schedule_work() with an uninitialized work_struct. > > Move the cancel_work_sync() call out of sony_destroy_ff() since the state > worker > is

Re: [PATCH] HID: sony: Fix work queue issues.

2014-02-19 Thread Greg KH
On Wed, Feb 19, 2014 at 01:09:22PM -0500, Frank Praznik wrote: > Don't initialize force-feedback for devices that don't support it to avoid > calls > to schedule_work() with an uninitialized work_struct. > > Move the cancel_work_sync() call out of sony_destroy_ff() since the state > worker > is

[PATCH] HID: sony: Fix work queue issues.

2014-02-19 Thread Frank Praznik
Don't initialize force-feedback for devices that don't support it to avoid calls to schedule_work() with an uninitialized work_struct. Move the cancel_work_sync() call out of sony_destroy_ff() since the state worker is used for the LEDs even when force-feedback is disabled. Remove sony_destroy_ff