From: S Twiss
This patch set adds RTC support for the Dialog DA9062 Power Management IC.
Changes are made to the existing DA9063 RTC component so that functionality
in this device driver can be re-used to support the DA9062 RTC.
This following patch set is the proposed method for re-using existi
From: S Twiss
Add DA9062 RTC support into the existing DA9063 RTC driver component by
using generic access tables for common register and bit mask definitions.
The following change will add generic register and bit mask support to the
DA9063 RTC. The changes are slightly complicated by requiring
From: S Twiss
Add MFD core driver support for a RTC component
- MFD core adds the RTC resources da9062_rtc_resources[] for the RTC
alarm and tick timer IRQ
- An appropriate mfd_cell has been added into da9062_devs[] to support
a component .name = "da9062-rtc" and .of_compatible = "dlg,da906
From: S Twiss
Add device tree bindings for the DA9062 RTC driver component
Signed-off-by: Steve Twiss
---
Checks performed with linux-next/next-20150708/scripts/checkpatch.pl
da9062.txttotal: 0 errors, 0 warnings, 88 lines checked
This patch applies against linux-next and next
Hi Steve,
On Thu, Jul 9, 2015 at 9:45 AM, S Twiss wrote:
> From: S Twiss
>
> This patch set adds RTC support for the Dialog DA9062 Power Management IC.
> Changes are made to the existing DA9063 RTC component so that functionality
> in this device driver can be re-used to support the DA9062 RTC.
This one deserves some extra review because it introduces a call to:
WARN_ON(extra_checks);
in gpiod_free(). That may or may not matter...
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.
Dmitry,
On 08/07/15 18:08, Dmitry Torokhov wrote:
> On Wed, Jul 08, 2015 at 10:59:04AM +0300, Roger Quadros wrote:
>> Dmitry,
>>
>> On 07/07/15 19:25, Dmitry Torokhov wrote:
>>> Hi Roger,
>>>
>>> On Tue, Jul 07, 2015 at 12:37:31PM +0300, Roger Quadros wrote:
Hi Dmitry,
On 07/07/15 0
On 09 July 2015 09:02, Geert Uytterhoeven wrote:
> Subject: Re: [PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the
> existing DA9063 RTC driver
>
> Hi Steve,
>
> On Thu, Jul 9, 2015 at 9:45 AM, S Twiss
> wrote:
> > From: S Twiss
> >
> > This patch set adds RTC support for the Dialog D
On Thu, Jul 9, 2015 at 10:42 AM, Opensource [Steve Twiss]
wrote:
>> > S Twiss (3):
>> > mfd: da9062: Support for the DA9063 RTC in the DA9062 core
>>
>> "DA9062 RTC"?
>>
>
> Hi Geert,
>
> It's the support for the "DA9063 RTC *driver* in the DA9062 MFD driver core".
Ah, I read "core" as in "hard
On Wed, 8 Jul 2015, Ellen Wang wrote:
> cp2112_i2c_xfer() only reads up to 61 bytes, returning EIO
> on longers reads. The fix is to wrap a loop around
> cp2112_read() to pick up all the returned data.
>
> Signed-off-by: Ellen Wang
> ---
> This is the updated patch with a check for 0 return fro
On Wed, 8 Jul 2015, Ellen Wang wrote:
> > > No need for int; u8 is enough (value is copyed from buf[2] that is u8).
> > > Put the new u8 field few lines below, together with the other u8, to
> > > avoid extra padding.
> > >
> > > No need to send immediately a new version. Let's see if there is an
On Mon, 6 Jul 2015, Andrew Duggan wrote:
> Some touchpads are configured with firmware which continues to scan for
> fingers at a minimal scan rate even after receiving the HID power sleep
> command. This allows a finger touching the touchpad to genrate a wake
> event. This patch ensures that scan
On Thu, 9 Jul 2015, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Thu, 9 Jul 2015 08:00:10 +0200
>
> The input_free_device() function tests whether its argument is NULL and
> then returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using th
On Wed, 8 Jul 2015, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Wed, 8 Jul 2015 22:12:25 +0200
>
> The gpiod_put() function performs also input parameter validation
> by forwarding its single input pointer to the gpiod_free() function.
> Thus the test around the calls is not needed.
Use for_each_set_bit to check for set bits in bitmap
as it is more efficient and compact.
Also use bitwise and instead of expensive %
operation while fetching next event.
Signed-off-by: Anshul Garg
---
drivers/input/misc/uinput.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-
Signed-off-by: HungNien Chen
---
drivers/input/touchscreen/wdt87xx_i2c.c | 68 -
1 file changed, 66 insertions(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/wdt87xx_i2c.c
b/drivers/input/touchscreen/wdt87xx_i2c.c
index fb92ae1..b97cb4f 100644
--- a/dr
On Thu, Jul 09, 2015 at 06:41:01AM -0700, Anshul Garg wrote:
> Use for_each_set_bit to check for set bits in bitmap
> as it is more efficient and compact.
> Also use bitwise and instead of expensive %
> operation while fetching next event.
It is not expensive if we are using a constant that is car
Hello Mr. Dmitry ,
On Thu, Jul 9, 2015 at 10:56 PM, Dmitry Torokhov
wrote:
> On Thu, Jul 09, 2015 at 06:41:01AM -0700, Anshul Garg wrote:
>> Use for_each_set_bit to check for set bits in bitmap
>> as it is more efficient and compact.
>> Also use bitwise and instead of expensive %
>> operation w
Hi Hn,
On Thu, Jul 09, 2015 at 11:00:43PM +0800, HungNien Chen wrote:
> Signed-off-by: HungNien Chen
> ---
> drivers/input/touchscreen/wdt87xx_i2c.c | 68
> -
> 1 file changed, 66 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/wdt87xx_i
As mentioned in the comment in the code, both the pen and touch data
come from the interface tagged as BAMBOO_PAD. The driver re-routes the
events for the Pen to the generic HID interface and keeps the ones for
the touch through this current interface.
Clearing the WACOM_DEVICETYPE_PEN bit removes
On Thu, Jul 09, 2015 at 11:05:57PM +0530, Anshul Garg wrote:
> Hello Mr. Dmitry ,
>
>
>
> On Thu, Jul 9, 2015 at 10:56 PM, Dmitry Torokhov
> wrote:
> > On Thu, Jul 09, 2015 at 06:41:01AM -0700, Anshul Garg wrote:
> >> Use for_each_set_bit to check for set bits in bitmap
> >> as it is more effic
On Thu, Jul 09, 2015 at 11:32:11AM +0300, Roger Quadros wrote:
> Dmitry,
>
> On 08/07/15 18:08, Dmitry Torokhov wrote:
> > On Wed, Jul 08, 2015 at 10:59:04AM +0300, Roger Quadros wrote:
> >> Dmitry,
> >>
> >> On 07/07/15 19:25, Dmitry Torokhov wrote:
> >>> Hi Roger,
> >>>
> >>> On Tue, Jul 07, 201
Hello Mr. Dmitry ,
udev->tail change i have not tested.
i have suggested this change for sole optimization purpose.
Yes this "udev->tail = (udev->tail + 1) & (UINPUT_BUFFER_SIZE - 1);"
should be code.
On Thu, Jul 9, 2015 at 11:44 PM, Dmitry Torokhov
wrote:
> On Thu, Jul 09, 2015 at 11:05:57PM
On Thu, Jul 9, 2015 at 8:34 AM, Jiri Kosina wrote:
> On Wed, 8 Jul 2015, SF Markus Elfring wrote:
>
>> From: Markus Elfring
>> Date: Wed, 8 Jul 2015 22:12:25 +0200
>>
>> The gpiod_put() function performs also input parameter validation
>> by forwarding its single input pointer to the gpiod_free()
>>> The gpiod_put() function performs also input parameter validation
>>> by forwarding its single input pointer to the gpiod_free() function.
>>> Thus the test around the calls is not needed.
>>>
>>> This issue was detected by using the Coccinelle software.
>>>
>>> Signed-off-by: Markus Elfring
>
On Thu, Jul 9, 2015 at 4:49 PM, SF Markus Elfring
wrote:
The gpiod_put() function performs also input parameter validation
by forwarding its single input pointer to the gpiod_free() function.
Thus the test around the calls is not needed.
This issue was detected by using th
On Thu, Jul 09, 2015 at 11:06:03AM -0700, Dmitry Torokhov wrote:
> Hi Hn,
>
> On Thu, Jul 09, 2015 at 11:00:43PM +0800, HungNien Chen wrote:
> > @@ -165,6 +170,8 @@ struct wdt87xx_sys_param {
> > u16 scaling_factor;
> > u32 max_x;
> > u32 max_y;
> > + u16 vendor_id;
>
>> The proposed update candidates are contained in the source
>> file "drivers/hid/i2c-hid/i2c-hid.c" from Linux next-20150708.
>>
>> * i2c_hid_remove() function:
>> Can it be tolerated here that the pointer "ihid->desc" might be eventually
>> null?
>>
>> * i2c_hid_probe() function:
>> Is this
On Thu, Jul 9, 2015 at 5:10 PM, SF Markus Elfring
wrote:
>>> The proposed update candidates are contained in the source
>>> file "drivers/hid/i2c-hid/i2c-hid.c" from Linux next-20150708.
>>>
>>> * i2c_hid_remove() function:
>>> Can it be tolerated here that the pointer "ihid->desc" might be
>>>
We need to emit EV_SYN/SYN_REPORT between key press and release, otherwise
userspace is allowed to "swallow" the event.
Signed-off-by: Dmitry Torokhov
---
Observed this with Plantronics headsets...
drivers/hid/hid-input.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/
When a device is reset the values of control registers will be reset to
the defaults. This patch reapplies the control register values set for F11
by the driver.
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-rmi.c | 41 ++---
1 file changed, 34 insertions(+
On Thursday 09 July 2015 15:14:17 Andrew Duggan wrote:
> When a device is reset the values of control registers will be reset to
> the defaults. This patch reapplies the control register values set for F11
> by the driver.
Hi,
thanks for this, it works as intended. I just added a couple of
commen
On 07/09/2015 03:40 PM, Gabriele Mazzotta wrote:
On Thursday 09 July 2015 15:14:17 Andrew Duggan wrote:
When a device is reset the values of control registers will be reset to
the defaults. This patch reapplies the control register values set for F11
by the driver.
Hi,
thanks for this, it work
All Elantech touchpads pre-v4 with dynamic resolution queries have a fixed
resolution of 800dpi -> 31.49 units/mm. Set this statically, so userspace does
not have to guess.
Cc: Duson Lin
Signed-off-by: Peter Hutterer
---
drivers/input/mouse/elantech.c | 13 -
1 file changed, 8 inser
cp2112_i2c_xfer() only supports a single i2c_msg. More than
one message at a time just returns EIO. This breaks certain
important cases. For example, the at24 eeprom driver generates
paired write and read messages (for eeprom address and data).
Since the device doesn't support i2c repeated star
Change all occurrences of be16 to le16 in cp2112_xfer(),
because SMBUS words are little endian, not big endian.
Signed-off-by: Ellen Wang
---
drivers/hid/hid-cp2112.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c
i
When doing an I2C_SMBUS_BYTE write (one byte write, no address),
the data to be written is in "command" not "data->byte".
---
drivers/hid/hid-cp2112.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c
index a3703b8..7afc3fc 1006
i2c_driver does not need to set an owner because i2c_register_driver()
will set it.
Signed-off-by: Krzysztof Kozlowski
---
The coccinelle script which generated the patch was sent here:
http://www.spinics.net/lists/kernel/msg2029903.html
---
drivers/hid/i2c-hid/i2c-hid.c | 1 -
1 file changed,
i2c_driver does not need to set an owner because i2c_register_driver()
will set it.
Signed-off-by: Krzysztof Kozlowski
---
The coccinelle script which generated the patch was sent here:
http://www.spinics.net/lists/kernel/msg2029903.html
---
drivers/input/keyboard/adp5589-keys.c | 1 -
d
Patch HID report descriptor to add joystick axis for the L1 button (previously
missing).
Signed-off-by: Simon Wood
---
drivers/hid/hid-sony.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index ed2f008..69586b3 100644
Hi,
On 10-07-15 02:32, Peter Hutterer wrote:
All Elantech touchpads pre-v4 with dynamic resolution queries have a fixed
resolution of 800dpi -> 31.49 units/mm. Set this statically, so userspace does
not have to guess.
Cc: Duson Lin
Signed-off-by: Peter Hutterer
Ah I was planning on writing
41 matches
Mail list logo
