Re: [PATCH v2] HID: multitouch: Fetch feature reports on demand for Win8 devices

On Wed, Oct 07, 2015 at 06:12:42PM -0700, Andrew Duggan wrote: > I can confirm that it is working on the Dell XPS 13 and the buttonpad > property is set correctly. However, I also tried it on an older non > production precision touchpad and it didn't work. It reports that it fails > to fetch

[2/2] Input: input.h - Add and extend KEY_* usage detail comments

The KEY_* definitions in input.h had no formal functional definitions when they were first introduced. This led to a situation where some keys were used inconsistently across different drivers. For example, KEY_POWER was used both in some very low-level situations (where pressing the key

[1/2] Input: input.h - Add and extend KEY_* usage detail comments

The KEY_* definitions in input.h had no formal functional definitions when they were first introduced. This led to a situation where some keys were used very inconsistently across different drivers. For example, KEY_SETUP was used both in some very low-level situations (like resetting the

Re: [PATCH v7 2/9] Input: goodix - reset device at init

On Thursday 08 October 2015 13:19:28 Irina Tirdea wrote: > After power on, it is recommended that the driver resets the device. > The reset procedure timing is described in the datasheet and is used > at device init (before writing device configuration) and > for power management. It is a sequence

Re: [PATCH v7 2/9] Input: goodix - reset device at init

On Thu, 2015-10-08 at 12:54 +0200, Arnd Bergmann wrote: > I think lists like this in drivers should be avoided if at all > possible, > it just leads to other people adding their platform in the lists as > opposed to fixing their boot loaders. Instructions on fixing UEFI firmwares without the

[PATCH v7 7/9] Input: goodix - add sysfs interface to dump config

Goodix devices have a configuration information register area that specify various parameters for the device. The configuration information has a specific format described in the Goodix datasheet. It includes X/Y resolution, maximum supported touch points, interrupt flags, various sesitivity

[PATCH v7 4/9] Input: goodix - add power management support

Implement suspend/resume for goodix driver. The suspend and resume process uses the gpio pins. If the device ACPI/DT information does not declare gpio pins, suspend/resume will not be available for these devices. This is based on Goodix datasheets for GT911 and GT9271 and on Goodix driver

[PATCH v7 5/9] Input: goodix - use goodix_i2c_write_u8 instead of i2c_master_send

Use goodix_i2c_write_u8 instead of i2c_master_send to simplify code. Signed-off-by: Irina Tirdea --- drivers/input/touchscreen/goodix.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/input/touchscreen/goodix.c

RE: [PATCH v7 2/9] Input: goodix - reset device at init

> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: 08 October, 2015 13:54 > To: Tirdea, Irina > Cc: Dmitry Torokhov; Bastien Nocera; Aleksei Mamlin; > linux-input@vger.kernel.org; Mark Rutland; Purdila, Octavian; linux- > ker...@vger.kernel.org;

RE: [PATCH v7 0/9] Goodix touchscreen enhancements

> -Original Message- > From: linux-input-ow...@vger.kernel.org > [mailto:linux-input-ow...@vger.kernel.org] On Behalf Of Arnd Bergmann > Sent: 08 October, 2015 14:10 > To: Tirdea, Irina > Cc: Dmitry Torokhov; Bastien Nocera; Aleksei Mamlin; > linux-input@vger.kernel.org; Mark Rutland;

[2/2 v2] Input: input.h - Add and extend KEY_* usage detail comments

The KEY_* definitions in input.h had no formal functional definitions when they were first introduced. This led to a situation where some keys were used inconsistently across different drivers. For example, KEY_POWER was used both in some very low-level situations (where pressing the key

Re: [PATCH v7 0/9] Goodix touchscreen enhancements

On Thursday 08 October 2015 13:19:26 Irina Tirdea wrote: > Add several enhancements to the Goodix touchscreen driver. > > Bastien, the functionality from this patches should be now skipped > for your devices (Onda v975w, WinBook TW100 and WinBook TW700). > > Aleksei, I have removed your

[1/2 v2] Input: input.h - Add and extend KEY_* usage detail comments

The KEY_* definitions in input.h had no formal functional definitions when they were first introduced. This led to a situation where some keys were used very inconsistently across different drivers. For example, KEY_SETUP was used both in some very low-level situations (like resetting the

[PATCH v7 2/9] Input: goodix - reset device at init

After power on, it is recommended that the driver resets the device. The reset procedure timing is described in the datasheet and is used at device init (before writing device configuration) and for power management. It is a sequence of setting the interrupt and reset pins high/low at specific

[PATCH v7 0/9] Goodix touchscreen enhancements

Add several enhancements to the Goodix touchscreen driver. Bastien, the functionality from this patches should be now skipped for your devices (Onda v975w, WinBook TW100 and WinBook TW700). Aleksei, I have removed your Tested-by tag since I have done some non-trivial changes to the "reset device

[PATCH v7 3/9] Input: goodix - write configuration data to device

Goodix devices can be configured by writing custom data to the device at init. The configuration data is read with request_firmware from "goodix__cfg.bin", where is the product id read from the device (e.g.: goodix_911_cfg.bin for Goodix GT911, goodix_9271_cfg.bin for GT9271). The configuration

[PATCH v7 1/9] Input: goodix - use actual config length for each device type

Each of the Goodix devices supported by this driver has a fixed size for the configuration information registers. The size varies depending on the device and is specified in the datasheet. Use the proper configuration length as specified in the datasheet for each device model, so we do not read

[PATCH v7 9/9] Input: goodix - sort includes using inverse Xmas tree order

Signed-off-by: Irina Tirdea --- drivers/input/touchscreen/goodix.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c index 7f0da7e..1f0625a 100644 ---

[PATCH v7 8/9] Input: goodix - add runtime power management support

Add support for runtime power management so that the device is turned off when not used (when the userspace holds no open handles of the input device). The device uses autosuspend with a default delay of 2 seconds, so the device will suspend if no handles to it are open for 2 seconds. The runtime

RE: [PATCH v5 1/9] Input: goodix - sort includes alphabetically

> -Original Message- > From: Pavel Machek [mailto:pa...@ucw.cz] > Sent: 05 October, 2015 23:58 > To: Tirdea, Irina > Cc: Dmitry Torokhov; Bastien Nocera; Aleksei Mamlin; > linux-input@vger.kernel.org; Mark Rutland; Purdila, Octavian; linux- > ker...@vger.kernel.org;

Re: [PATCH v7 2/9] Input: goodix - reset device at init

On Thursday 08 October 2015 12:18:37 Tirdea, Irina wrote: > > From: Arnd Bergmann [mailto:a...@arndb.de] > > Sent: 08 October, 2015 13:54 > > To: Tirdea, Irina > > Cc: Dmitry Torokhov; Bastien Nocera; Aleksei Mamlin; > > linux-input@vger.kernel.org; Mark Rutland; Purdila, Octavian; linux- > >

Re: [PATCH v8 0/9] Goodix touchscreen enhancements

On Thursday 08 October 2015 17:23:42 Irina Tirdea wrote: > Add several enhancements to the Goodix touchscreen driver. > > The new functionality is only available for devices that > declare named gpio pins for interrupt and reset in their > ACPI/DT configuration. > > Thanks, > Irina > > Changes

Re: [PATCH 3/3] Input: adp5589-keys: fix event count mask

On 5 October 2015 at 21:29, Dmitry Torokhov wrote: > Hi Ezequiel, > > On Fri, Oct 2, 2015 at 2:28 PM, Ezequiel Garcia > wrote: >> On 6 May 2015 at 20:36, Dmitry Torokhov wrote: >>> On Tue, Apr 21, 2015 at

[PATCH v8 3/9] Input: goodix - write configuration data to device

Goodix devices can be configured by writing custom data to the device at init. The configuration data is read with request_firmware from "goodix__cfg.bin", where is the product id read from the device (e.g.: goodix_911_cfg.bin for Goodix GT911, goodix_9271_cfg.bin for GT9271). The configuration

[PATCH v8 2/9] Input: goodix - reset device at init

After power on, it is recommended that the driver resets the device. The reset procedure timing is described in the datasheet and is used at device init (before writing device configuration) and for power management. It is a sequence of setting the interrupt and reset pins high/low at specific

RE: [PATCH v7 2/9] Input: goodix - reset device at init

> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: 08 October, 2015 16:01 > To: Tirdea, Irina > Cc: Dmitry Torokhov; Bastien Nocera; Aleksei Mamlin; > linux-input@vger.kernel.org; Mark Rutland; Purdila, Octavian; linux- > ker...@vger.kernel.org;

[PATCH v8 9/9] Input: goodix - sort includes using inverse Xmas tree order

Signed-off-by: Irina Tirdea --- drivers/input/touchscreen/goodix.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c index b958b37..22bfc4b 100644 ---

[PATCH v8 8/9] Input: goodix - add runtime power management support

Add support for runtime power management so that the device is turned off when not used (when the userspace holds no open handles of the input device). The device uses autosuspend with a default delay of 2 seconds, so the device will suspend if no handles to it are open for 2 seconds. The runtime

[PATCH v8 5/9] Input: goodix - use goodix_i2c_write_u8 instead of i2c_master_send

Use goodix_i2c_write_u8 instead of i2c_master_send to simplify code. Signed-off-by: Irina Tirdea --- drivers/input/touchscreen/goodix.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/input/touchscreen/goodix.c

[PATCH v8 6/9] Input: goodix - add support for ESD

Add ESD (Electrostatic Discharge) protection mechanism. The driver enables ESD protection in HW and checks a register to determine if ESD occurred. If ESD is signalled by the HW, the driver will reset the device. The ESD poll time (in ms) can be set through the sysfs property esd_timeout. If it

[PATCH v8 4/9] Input: goodix - add power management support

Implement suspend/resume for goodix driver. The suspend and resume process uses the gpio pins. If the device ACPI/DT information does not declare gpio pins, suspend/resume will not be available for these devices. This is based on Goodix datasheets for GT911 and GT9271 and on Goodix driver

[PATCH v8 7/9] Input: goodix - add sysfs interface to dump config

Goodix devices have a configuration information register area that specify various parameters for the device. The configuration information has a specific format described in the Goodix datasheet. It includes X/Y resolution, maximum supported touch points, interrupt flags, various sesitivity

Re: [PATCH] Input: evdev - add event-mask API

Hey On Thu, Sep 3, 2015 at 6:14 PM, David Herrmann wrote: > Hardware manufacturers group keys in the weirdest way possible. This may > cause a power-key to be grouped together with normal keyboard keys and > thus be reported on the same kernel interface. > > However,

Re: [PATCH] HID: hid-logitech-hidpp: driver for m545/m546 mouse

Ping, Benjamin, Nestor, do you have any comments ? BR G.Baroncelli On 2015-09-29 20:20, Goffredo Baroncelli wrote: > From: Goffredo Baroncelli > > Add support for the Logitech m545/m546 mouse. This mouse is designed > for windows 8. So when the side buttons are pressed,

Re: [PATCH] HID: hid-logitech-hidpp: driver for m545/m546 mouse

Hi Goffredo, On Thu, Oct 8, 2015 at 1:07 PM, Goffredo Baroncelli wrote: > Ping, > > > Benjamin, Nestor, > > do you have any comments ? Sorry for not going back to you earlier. I do not see any obvious problems in the patch (few comments though), but I think we can do better

Re: [PATCH v2] HID: multitouch: Fetch feature reports on demand for Win8 devices

On 10/08/2015 02:40 AM, Mika Westerberg wrote: On Wed, Oct 07, 2015 at 06:12:42PM -0700, Andrew Duggan wrote: I can confirm that it is working on the Dell XPS 13 and the buttonpad property is set correctly. However, I also tried it on an older non production precision touchpad and it didn't

RE: [PATCH] input:gpio-key: set IRQF_NO_SUSPEND for wake capable key

On Friday, October 09, 2015 10:14 AM, Zheng, Qi wrote: > > Hi, > > "enable_irq_wake" is to enable/disable power-management wake-on of an > IRQ. > It is wake-on control not interrupt enable control. > In my opinion, to make sure the keys press working when system suspend, both > wake-on and

RE: [PATCH] input:gpio-key: set IRQF_NO_SUSPEND for wake capable key

Hi, "enable_irq_wake" is to enable/disable power-management wake-on of an IRQ. It is wake-on control not interrupt enable control. In my opinion, to make sure the keys press working when system suspend, both wake-on and interrupt should be enabled. Besides, for many platforms, the gpio irq chip

[PATCH] input:keyboard: add Cypress button driver for Intel Platform

This driver is to support Cypress CY8CMBR3XXX family controller, which is used as button input for Intel platforms. Signed-off-by: Qipeng Zha --- drivers/input/keyboard/Kconfig| 7 + drivers/input/keyboard/Makefile | 1 +

Re: [PATCH] HID: hid-logitech-hidpp: driver for m545/m546 mouse

This is duplicated mail in plain text for content policy of mail list. Hi all, I use `solaar show` in https://github.com/pwr/Solaar to detect features. My m546 support 0x1B00(REPROG CONTROLS) and 0x1B03(REPROG CONTROLS V3), but doesn't have 0x1B04(REPROG CONTROLS V4). Rgd, VRan On Fri, Oct 9,

RE: [PATCH] input:gpio-key: set IRQF_NO_SUSPEND for wake capable key

Thanks help from Aubrey. We can fix this bug in platform gpio driver instead of modifying general gpio_keys.c. BRs Zheng Qi PEG->IPG->EIG SH IO/LPSS team -Original Message- From: Li, Aubrey Sent: Friday, October 9, 2015 10:48 AM To: Zheng, Qi ; Dmitry Torokhov

[PATCH v2] HID: wacom: Add support for Cintiq Companion 2

Adds support for the EMR (pen+pad) and touchscreen devices used by the Wacom Cintiq Companion 2. This applies both to using the device as a standalone system, as well as when operating in "Cintiq mode" (where the EMR/touchscreen are simply exposed as USB devices to the system its connected to).