Hi Cedric,
I'm a little bit lost there. You still have the same problems than the
one described in the thread in xorg-devel? I don't get the though the
touchpoints are correctly recognized...
Can you send us your dmesg output and the trace from evtest?
I also would like to know which kernel
Hi Simon,
well, it's a known bug. This panel is now fixed in 3.6-rc0, and I
submitted the fix for stable. I'm still waiting for the stable
approval.
BTW, Zytronic 0005 is a multitouch device and not only a single touch
one. So I think we should handle it through hid-multitouch. I know
that
Hi Scott,
we are getting closer. Just a few nitpicks:
On Thu, Aug 9, 2012 at 11:22 AM, Scott Liu scott@emc.com.tw wrote:
Some of ELAN's production need to with set_idle commmand when reusme.
reusme - resume
Signed-off-by: Scott Liu scott@emc.com.tw
---
drivers/hid/hid-ids.h
Hi Jiri,
On Wed, Aug 29, 2012 at 12:25 AM, Jiri Kosina jkos...@suse.cz wrote:
On Wed, 22 Aug 2012, Henrik Rydberg wrote:
With the input_mt_sync_frame() function in place, there is no longer
any need to keep the full touch state in the driver. This patch
removes the slot state and replaces
with the input-mt
equivalent. The initialization code is moved to mt_input_configured(),
to make sure the full HID report has been seen.
Cc: Benjamin Tissoires benjamin.tissoi...@enac.fr
Signed-off-by: Henrik Rydberg rydb...@euromail.se
---
drivers/hid/hid-multitouch.c | 133
regression on 3M and similar panels.
Cc: Benjamin Tissoires benjamin.tissoi...@enac.fr
Signed-off-by: Henrik Rydberg rydb...@euromail.se
---
Since this patch looks like it could be backported as-is: In 3.6,
maxcontacts may be modified after the slots have been initialized,
leaving the patch
Hi Dmitry,
thanks for the review.
On Wed, Oct 3, 2012 at 6:43 PM, Dmitry Torokhov
dmitry.torok...@gmail.com wrote:
Hi Benjamin,
A few random comments...
On Fri, Sep 14, 2012 at 03:41:43PM +0200, benjamin.tissoires wrote:
From: Benjamin Tissoires benjamin.tissoi...@enac.fr
Microsoft
Hi Jean,
Thanks for the comments, the tests and the review. I'm going to try to
answer most of the remarks, so here is the first:
On Sat, Oct 6, 2012 at 10:04 PM, Jean Delvare kh...@linux-fr.org wrote:
Hi Benjamin,
[...]
a
ERROR: hiddev_report_event [drivers/i2c/i2c-hid.ko] undefined!
ERROR:
On Sat, Oct 6, 2012 at 11:39 PM, Stéphane Chatty cha...@enac.fr wrote:
Le 6 oct. 2012 à 23:28, Jiri Kosina a écrit :
On Sat, 6 Oct 2012, Jiri Kosina wrote:
My vote is a clear 3. It took me a few years to kick all users (as
opposed to implementers) of i2c from drivers/i2c and finding them a
,
On Fri, 14 Sep 2012 15:41:43 +0200, benjamin.tissoires wrote:
From: Benjamin Tissoires benjamin.tissoi...@enac.fr
Microsoft published the protocol specification of HID over i2c:
http://msdn.microsoft.com/en-us/library/windows/hardware/hh852380.aspx
This patch introduces an implementation
devices will be available.
Once the ACPI part is done, OEM will not have to declare HID over I2C
devices in their platform specific driver.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
Hi Guys,
here is the v2 of the HID over I2C driver.
Changes since v1:
* s/i2chid/i2c_hid
On Sun, Oct 7, 2012 at 9:03 PM, Jean Delvare kh...@linux-fr.org wrote:
On Sun, 7 Oct 2012 18:57:36 +0200, Benjamin Tissoires wrote:
On Sun, Oct 7, 2012 at 4:28 PM, Jean Delvare kh...@linux-fr.org wrote:
On Fri, 14 Sep 2012 15:41:43 +0200, benjamin.tissoires wrote:
+ u16 readRegister
is for invalid argument.
So ENODEV is the right return value.
Anyway, thanks for the review.
Cheers,
Benjamin
Benjamin Tissoires benjamin.tissoi...@gmail.com writes:
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
new file mode 100644
index 000..8b6c31a
--- /dev/null
On Mon, Oct 22, 2012 at 6:07 PM, Dmitry Torokhov
dmitry.torok...@gmail.com wrote:
On Mon, Oct 22, 2012 at 11:47:42AM +0800, Jian-Jhong Ding wrote:
Scott Liu scott@emc.com.tw writes:
+
+struct mt_device {
+ struct mt_slot curdata; /* placeholder of incoming data */
+ __u8
Hi Alan,
Yes, I saw that too.
Acked-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
On Thu, Oct 25, 2012 at 4:35 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote:
From: Alan Cox a...@linux.intel.com
Signed-off-by: Alan Cox a...@linux.intel.com
---
drivers/hid/hid-multitouch.c |2
Adding Jiri to the recipient list of the patch, otherwise, the thread
may fall in the depth of his mailbox :)
Cheers,
Benjamin
On Thu, Oct 25, 2012 at 7:08 PM, Benjamin Tissoires
benjamin.tissoi...@gmail.com wrote:
Hi Alan,
Yes, I saw that too.
Acked-by: Benjamin Tissoires benjamin.tissoi
Hi Chris,
On Sat, Oct 27, 2012 at 2:27 AM, Chris MacDonald
ch...@fourthandvine.com wrote:
Hi All -
Firstly, apologies if this is the wrong forum for this type of
problem, (maybe linux-usb?) if this is the case please let me know.
I've got an Ubuntu 12.04 install and updated the kernel to
to calculate the resolution in third
party drivers like hid-multitouch.
This patch also complete the function with additional valid axes.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
Nice, but please see comment below.
drivers/hid/hid-input.c | 11
Hi Henrik,
On Mon, Oct 29, 2012 at 8:05 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
HID spec details special values for the HID field unit exponent.
Basically, the range [0x8..0xf] correspond to [-8..-1].
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
On Mon, Oct 29, 2012 at 8:25 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
Currently, there is no way to know the index of the current field
in the .input_mapping and .event callbacks when this field is inside
an array of HID fields.
This patch forwards this index to the
on the last element
in this array.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@enac.fr
---
drivers/hid/hid-multitouch.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 725d155..95562d8
for this
distinction in hid-multitouch.
We recognize Win8 certified devices from their vendor feature 0xffc5
where Microsoft put a signed blob in the report to check if the device
passed the certification.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/hid
that the quirk ALWAYS_VALID is taken into account and
also ensures its precedence over the other VALID* quirks.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/hid-multitouch.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
Since we seem to never actually
Hi Henrik,
On Mon, Oct 29, 2012 at 11:19 PM, Henrik Rydberg rydb...@euromail.se wrote:
On Fri, Oct 26, 2012 at 10:44:24AM +0200, Benjamin Tissoires wrote:
Win 8 specification is much more precise than the Win 7 one.
Moreover devices that need to take certification must be submitted
by the
multitouch protocol.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/hid-multitouch.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
I suppose the idea here is to send position and distance values even
when there is no touch
Slaby jirisl...@gmail.com
I'm not sure we should keep these copyrights. Actually, nearly all the
code is new except the skeleton.
+ * Copyright (c) 2012 Bastien Nocera had...@hadess.net
+ * Copyright (c) 2012 Benjamin Tissoires benjamin.tissoi...@gmail.com
+ */
+
+/*
+ * This program is free
Hi Bastien,
this v2 is good for me:
Reviewed-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
Cheers,
Benjamin
On Wed, Oct 31, 2012 at 12:10 PM, Bastien Nocera had...@hadess.net wrote:
Add a driver for the ION iCade mini arcade cabinet [1]. The device
generates a key press and release
Hi Henrik,
On Wed, Oct 31, 2012 at 7:53 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
On Mon, Oct 29, 2012 at 11:19 PM, Henrik Rydberg rydb...@euromail.se wrote:
On Fri, Oct 26, 2012 at 10:44:24AM +0200, Benjamin Tissoires wrote:
Win 8 specification is much more precise than
On Sun, Nov 4, 2012 at 9:54 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
The goal of this patch is to implement in a reliable way Win 8
multitouch protocol (to avoid quirking many devices). Thanks to the
precision they made in the specification, I think it is feasible:
they add
can't remove the 2 usb related headers because the
function mt_resume has a specific patch for usb devices.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/hid-multitouch.c | 63
++--
1 file changed, 37 insertions
Hi Henrik,
grrr damn new gmail interface, I clicked on the wrong button.
sorry for the noise.
On Mon, Nov 5, 2012 at 2:28 PM, Benjamin Tissoires
benjamin.tissoi...@gmail.com wrote:
Hi Henrik,
On Mon, Nov 5, 2012 at 1:57 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin
Hi Jiri,
On Fri, Nov 9, 2012 at 4:49 AM, Jiri Kosina jkos...@suse.cz wrote:
On Tue, 16 Oct 2012, Benjamin Tissoires wrote:
--- /dev/null
+++ b/drivers/hid/i2c-hid/i2c-hid.c
...
+static int i2c_hid_alloc_buffers(struct i2c_hid *ihid)
+{
+ /* the worst case is computed from
Hi Jiri,
On Tue, Nov 13, 2012 at 8:47 AM, Jiri Kosina jkos...@suse.cz wrote:
On Wed, 7 Nov 2012, Benjamin Tissoires wrote:
Hi Guys,
here is the third version of this patchset.
I think I included most of Henrik's comments.
Happy reviewing :)
Cheers,
Benjamin
v1 introduction:
So
Hi Henrik,
thanks for the review of the patchset. I'll do my best for the next version :)
On Tue, Nov 13, 2012 at 5:42 PM, Henrik Rydberg rydb...@euromail.se wrote:
On Wed, Nov 07, 2012 at 05:37:34PM +0100, Benjamin Tissoires wrote:
Win8 devices supporting hovering must provides InRange HID
Hi Henrik,
On Tue, Nov 13, 2012 at 6:27 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
From: Benjamin Tissoires benjamin.tissoi...@gmail.com
Date: Tue, 13 Nov 2012 15:12:17 +0100
Subject: [PATCH v4] HID: hid-multitouch: forwards MSC_TIMESTAMP
Computes the device timestamp
Hi Henrik,
On Tue, Nov 13, 2012 at 6:33 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
here is the third version of this patchset.
I think I included most of Henrik's comments.
Happy reviewing :)
thanks for the changes :-)
and thanks for the review.
Jiri,
I am fine
On Tue, Nov 13, 2012 at 7:04 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
Why [-1,1] here?
At first, I only used [0,1]. However, it's still the same problem with
the information being kept between the touches:
if you start an application after having touched your device, you
Without this, the device is blocked in dmesg at:
hid-multitouch 0003:25AA:8883.000X: usb_submit_urb(ctrl) failed: -1
hid-multitouch 0003:25AA:8883.000X: timeout initializing reports
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
Hi guys,
Even if Chris did not answered, I had
Hi Henrik,
On 11/14/2012 08:58 PM, Henrik Rydberg wrote:
Hi Benjamin,
Computes the device timestamp according to the specification.
It also ensures that if the time between two events is greater
than MAX_TIMESTAMP_INTERVAL, the timestamp will be reset.
Signed-off-by: Benjamin Tissoires
On Thu, Nov 15, 2012 at 10:33 AM, Jiri Kosina jkos...@suse.cz wrote:
On Wed, 14 Nov 2012, Henrik Rydberg wrote:
* patches 1-9 has already been reviewed and are ready for inclusion I
would say.
* Jiri, I kept your ack on patch 4 even if I changed the place of the
comment in hid.h
*
On Thu, Nov 15, 2012 at 3:04 PM, Benjamin Tissoires
benjamin.tissoi...@gmail.com wrote:
On Thu, Nov 15, 2012 at 2:51 PM, Jiri Kosina jkos...@suse.cz wrote:
On Mon, 12 Nov 2012, Benjamin Tissoires wrote:
Microsoft published the protocol specification of HID over i2c:
http://msdn.microsoft.com
Hi Henrik,
On Fri, Nov 16, 2012 at 9:09 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
This was not what I envisioned from the discussion yesterday, I was
probably too vague. Firstly, the absolute time interval checked seems
to be 500 ms, which is arbitrary. Second, the wrap
Hi Bastien,
(adding the input and HID maintainers to the recipient list).
On Thu, Nov 15, 2012 at 7:13 PM, Bastien Nocera had...@hadess.net wrote:
This driver was originally written by James McKenzie, updated by
Greg Kroah-Hartman, further updated by myself, with suspend support
added.
On Mon, Nov 19, 2012 at 4:44 PM, Bastien Nocera had...@hadess.net wrote:
On Mon, 2012-11-19 at 16:32 +0100, Benjamin Tissoires wrote:
Hi Bastien,
(adding the input and HID maintainers to the recipient list).
On Thu, Nov 15, 2012 at 7:13 PM, Bastien Nocera had...@hadess.net wrote
Hi Jan-Matthias,
On Mon, Nov 19, 2012 at 12:58 PM, Jan-Matthias Braun jan_br...@gmx.net wrote:
Dear List,
using the current (Linux v2.6.7) hid-multitouch driver I have the problem,
that the touchscreen works fine after a fresh boot, but after a suspend the
touchscreen does not come back to
this one :)
Reviewed-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
Signed-off-by: Jiri Kosina jkos...@suse.cz
---
drivers/hid/i2c-hid/i2c-hid.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
index
to send it to other devices too.
Tested on 3M, Stantum, Cypress, Zytronic, eGalax, and Elan panels.
Suggested by Benjamin Tissoires benjamin.tissoi...@enac.fr
Signed-off-by: Scott Liu scott@emc.com.tw
Signed-off-by: Jiri Kosina jkos...@suse.cz
---
drivers/hid/hid-multitouch.c | 27
Hi Guys,
well, I'm not very satisfied with this patch. I first thought it was a
good idea but I can see now several cons:
1. Henrik would like to partially base the time spent between two
events when the device wraps on the *event* time. This is a great idea
for consistency, but I'm afraid I
helpful to debug hid devices, that's why I share
it there... and also because I work for an open-source company :)
Happy reviewing.
Cheers,
Benjamin
Benjamin Tissoires (11):
HID: hid-input factorize hid_input allocation
HID: hid-input: simplify hid_input allocation and registration
HID
2012, 20:00:25 schrieb Jan-Matthias Braun:
Hi Benjamin,
Am Mittwoch, 21. November 2012, 14:36:33 schrieb Benjamin Tissoires:
On 11/21/2012 10:33 AM, Jan-Matthias Braun wrote:
Am Dienstag, 20. November 2012, 13:47:23 schrieben Sie:
On Mon, Nov 19, 2012 at 12:58 PM, Jan-Matthias Braun
On Fri, Nov 23, 2012 at 4:31 PM, Benjamin Tissoires
benjamin.tissoi...@gmail.com wrote:
This device is the worst device I saw. It keeps TipSwitch and InRange
at 1 for fingers that are not touching the panel.
The solution is to rely on the field ContactCount, which is accurate
as the correct
Hi Bruno,
On Mon, Nov 26, 2012 at 6:56 PM, Bruno Prémont
bonb...@linux-vserver.org wrote:
Hi Andrew,
[CCing David Herrmann]
On Sun, 25 November 2012 Andrew de los Reyes wrote:
Benjamin Tissoires and Nestor Lopez Casado have been helping me to add
Linux support for new Logitech Touch Mice
On Mon, Nov 26, 2012 at 11:54 PM, Christopher Heiny
che...@synaptics.com wrote:
On 11/26/2012 10:41 AM, Benjamin Tissoires wrote:
Hi Christopher,
On Sat, Nov 17, 2012 at 4:58 AM, Christopher Heiny che...@synaptics.com
wrote:
rmi_bus.c implements the basic functionality of the RMI bus
Hi Christopher,
I did not made a full review, but at least, there is a problem in your
rmi_f11_finger_handler function:
On Sat, Nov 17, 2012 at 4:58 AM, Christopher Heiny che...@synaptics.com wrote:
rmi_f11.c is a driver for 2D touch sensors using the RMI4 protocol. It
supports
both
.
I'll try to address all of your comments.
I have a few answers to some of your remarks (I fully agree with all
of the others):
On Mon, 12 Nov 2012 15:42:59 +0100, Benjamin Tissoires wrote:
Microsoft published the protocol specification of HID over i2c:
http://msdn.microsoft.com/en-us/library
On Mon, Dec 3, 2012 at 2:02 PM, Jean Delvare kh...@linux-fr.org wrote:
Hi Benjamin,
On Mon, 3 Dec 2012 12:32:03 +0100, Benjamin Tissoires wrote:
Hi Jean,
On Fri, Nov 30, 2012 at 3:56 PM, Jean Delvare kh...@linux-fr.org wrote:
Hi Benjamin, Jiri,
Sorry for the late review. But better
On Tue, Dec 4, 2012 at 11:31 AM, Jiri Kosina jkos...@suse.cz wrote:
On Mon, 3 Dec 2012, Benjamin Tissoires wrote:
I know that it already have been used by one Nvidia team and by Elan
for internal tests. So I don't know if it's possible to change it now
(though it's not a big deal).
Yes
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/i2c-hid/i2c-hid.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
index d6fdb3e..da04948 100644
--- a/drivers/hid/i2c-hid
On Tue, Dec 4, 2012 at 10:42 PM, Jean Delvare kh...@linux-fr.org wrote:
On Tue, 4 Dec 2012 16:27:43 +0100, Benjamin Tissoires wrote:
HID descriptors contains 4 bytes of reserved field.
The previous implementation was overriding the next fields in struct i2c_hid.
Signed-off-by: Benjamin
On Thu, Dec 6, 2012 at 11:01 AM, Jiri Kosina jkos...@suse.cz wrote:
- count = ihid-inbuf[0] | (ihid-inbuf[1] 8);
+ ret_count = ihid-inbuf[0] | (ihid-inbuf[1] 8);
+ if (!ret_count)
I'd make this (ret_count = 2), as this would let you call memcpy with a
null or even negative
On Wed, Dec 12, 2012 at 5:34 PM, Jean Delvare kh...@linux-fr.org wrote:
Hi Benjamin,
On Wed, 12 Dec 2012 17:12:16 +0100, Benjamin Tissoires wrote:
We should not enter close function while someone else is in open.
This mutex prevents this race.
There is also no need to override the ret value
We should not enter close function while someone else is in open.
This mutex prevents this race.
There is also no need to override the ret value with -EIO in case of
a failure of i2c_hid_set_power.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
Reviewed-by: Jean Delvare kh
On Thu, Jan 3, 2013 at 10:50 AM, Jiri Kosina jkos...@suse.cz wrote:
On Fri, 23 Nov 2012, Benjamin Tissoires wrote:
Last week, I received two new interesting devices report:
- N-trig win 8 certified pen/touch panel
- Samsung Nexio 42
Bejmanin, Henrik, what are the plans with this patchset
Hi Mika,
On Tue, Jan 8, 2013 at 2:05 PM, Mika Westerberg
mika.westerb...@linux.intel.com wrote:
The HID over I2C protocol specification states that when the device is
enumerated from ACPI the HID descriptor address can be obtained by
executing _DSM for the device with function 1. Enable this.
On Wed, Jan 9, 2013 at 10:28 AM, Mika Westerberg
mika.westerb...@linux.intel.com wrote:
On Tue, Jan 08, 2013 at 10:55:59PM +0100, Benjamin Tissoires wrote:
On Tue, Jan 8, 2013 at 7:09 PM, Mika Westerberg
mika.westerb...@linux.intel.com wrote:
On Tue, Jan 08, 2013 at 02:51:53PM +0100, Benjamin
this.
Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com
I'm eager to test it (hopefully next week).
Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Thanks,
Benjamin
---
Changes to previous version:
* platform data is embedded into struct i2c_hid
On Wed, Jan 9, 2013 at 9:52 AM, Jiri Kosina jkos...@suse.cz wrote:
On Wed, 9 Jan 2013, Benjamin Tissoires wrote:
mika.westerb...@linux.intel.com wrote:
The HID over I2C protocol specification states that when the device is
enumerated from ACPI the HID descriptor address can be obtained
On Fri, Jan 18, 2013 at 5:56 PM, Hartmut Knaack knaac...@gmx.de wrote:
Hi,
I've built myself a joystick adapter (project website:
http://www.hexagons.de/index.php/USB_Joystickadapter), which has the purpose
of connecting up to 2 Atari style joysticks (the ones with db9 connectors,
found on
Hi Jason,
On Wed, Jan 23, 2013 at 6:41 AM, Jason Flatt jfl...@cox.net wrote:
I am trying to add the newer Sony Google TV remote, and am looking for some
advice on how to get this implemented. This is my first experience with hid
drivers and multitouch.
Some base info:
Bluetooth only
information are packed at the begining of the frame.
Unfortunately, CountactCount is most of the time at the end of the report.
The solution is to pick it when we have the whole report in raw_event.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/hid-ids.h
Hi Henrik,
On Mon, Jan 28, 2013 at 4:23 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
finally, I managed to send a new bunch of patches. Sorry for the delay from
the
previous version, but meanwhile, I implemented an automatic regressions tests
for hid device [1].
So this
On Thu, Jan 31, 2013 at 5:58 PM, Jiri Kosina jkos...@suse.cz wrote:
On Thu, 31 Jan 2013, Benjamin Tissoires wrote:
i2c_hid_output_raw_report is used by hidraw to forward set_report requests.
The current implementation of i2c_hid_set_report needs to take the
report_id as an argument
Hi Henrik,
On Sun, Feb 3, 2013 at 2:07 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
so, this is the v2 of the support of win7/8 devices.
Looks like it is getting there, thanks.
Thanks for the review. However, before sending a new patch series, I'd
like to have your answers to
on the values stored in
the different fields.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/hid-core.c | 4
include/linux/hid.h| 2 ++
2 files changed, 6 insertions(+)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index
On Mon, Feb 4, 2013 at 12:42 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
Why not an index here?
Just because an index is not sufficient. You need two things: an index
within the field, and the actual field (a pointer to a struct
hid_field). Each .value is local to a field,
On Tue, Feb 5, 2013 at 12:13 PM, Jiri Kosina jkos...@suse.cz wrote:
On Mon, 4 Feb 2013, Henrik Rydberg wrote:
Thanks for the review. However, before sending a new patch series, I'd
like to have your answers to my comments as I mostly disagree on
everything :)
With good reason,
Do you mind if I send the usbhid dependency and the pen+multitouch
series this week, or we are too close to the 3.9 opening window?
Please just send the patches, and let's see whether they will make it for
3.8 or I'll queue (some of) them for 3.9.
Well, I didn't wanted to push them into 3.8
...@linux.intel.com
Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Cheers,
Benjamin
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
, Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Cheers,
Benjamin
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
is HID_GROUP_SENSOR_HUB.
Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com
Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Thanks Mika for this series!
Cheers,
Benjamin
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord
On Mon, Feb 11, 2013 at 4:53 PM, Pandruvada, Srinivas
srinivas.pandruv...@intel.com wrote:
This was added to load sensor hub driver on USB plug in without explicit
modprobe.
But with last few changes to remove vendor and product id, we need to do
modprobe this driver.
So removal is OK.
I
Hi Henrik,
On Wed, Feb 20, 2013 at 9:25 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/hid-multitouch.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Since removing the transport layer
.
Finally, few drivers still depends on USB_HID. Many of them
are requiring the io wait callback. They are found in the next patch.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
Reviewed-by: Mika Westerberg mika.westerb...@linux.intel.com
For the sensor-hub part:
Tested-by: Mika
Hi David,
On Mon, Feb 25, 2013 at 2:41 PM, David Herrmann dh.herrm...@gmail.com wrote:
Hi guys
On Mon, Feb 25, 2013 at 1:29 PM, Jiri Kosina jkos...@suse.cz wrote:
On Mon, 25 Feb 2013, Benjamin Tissoires wrote:
Hi guys,
this is the v2 of the hid transport cleanup.
Changes since v1
Hi Nuno,
On Mon, Feb 25, 2013 at 4:00 PM, Nuno Santos nsan...@displax.com wrote:
Hi,
I have been experiencing an issue with a Linux driver for multitouch input
that i'm responsible for maintaining.
Side note. Your driver does not seems to be upstreamed (or I missed
it). You should really
,
Benjamin
Benjamin Tissoires (7):
HID: input: don't register unmapped input devices
HID: multitouch: breaks out touch handling in specific functions
HID: multitouch: do not map usage from non used reports
HID: multitouch: add handling for pen in dual-sensors device
HID: multitouch
This is not just cosmetics, it can help to write udev and X.org
rules.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-multitouch.c | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-multitouch.c b
This will allow easier integration of hybrid pen and touch devices.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-multitouch.c | 75 +++-
1 file changed, 54 insertions(+), 21 deletions(-)
diff --git a/drivers/hid/hid
Hi Dan,
On Tue, Mar 5, 2013 at 2:06 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
We can't trust dj_report-device_index because it comes from the
user and hasn't been range checked. It is used as an offset into
the djrcv_dev-paired_dj_devices[] array which has 7 elements.
There is one
://bugzilla.kernel.org/show_bug.cgi?id=49781
Reported-and-tested-by: Bob Bowles bobjohnbow...@gmail.com
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
Hi guys,
this bug has taken too long to be solved. I managed to figure out the root cause
recently thanks to the work of Jelle
Hi Randy,
On Wed, Mar 6, 2013 at 8:26 PM, Randy Dunlap rdun...@infradead.org wrote:
On 03/05/13 16:50, Stephen Rothwell wrote:
Hi all,
Changes since 20130305:
on i386 and x86_64:
Sorry, it looks like my patches went not very smoothly.
ERROR: usb_control_msg
In the HID drivers tranport cleanup series, I removed the dependency
between hid-holtek and usbhid. This was wrong as hid-holtek.c relies
extensively on usb calls.
This fixes compilation error when CONFIG_USB_SUPPORT is not enabled.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
On Thu, Mar 7, 2013 at 11:09 AM, Jiri Kosina jkos...@suse.cz wrote:
On Thu, 7 Mar 2013, Benjamin Tissoires wrote:
on i386 and x86_64:
Sorry, it looks like my patches went not very smoothly.
ERROR: usb_control_msg [drivers/hid/hid-multitouch.ko] undefined!
I've submitted a new patch
On Thu, Mar 7, 2013 at 11:33 AM, Jiri Kosina jkos...@suse.cz wrote:
On Thu, 7 Mar 2013, Benjamin Tissoires wrote:
You should have at least one other patch for hid-mt:
https://patchwork.kernel.org/patch/2193641/
Ah, right, that one is in my queue as well, sorry for not mentioning it in
my
On Thu, Mar 7, 2013 at 3:26 PM, Jiri Kosina jkos...@suse.cz wrote:
On Wed, 27 Feb 2013, Benjamin Tissoires wrote:
Some drivers send the idle command directly to underlying device,
creating an unwanted dependency on the underlying transport layer.
This patch adds hid_hw_idle() to the interface
On Thu, Mar 7, 2013 at 4:07 PM, Jiri Kosina jkos...@suse.cz wrote:
On Tue, 5 Mar 2013, Benjamin Tissoires wrote:
hid_output_raw_report() makes a direct call to usb_control_msg(). However,
some USB3 boards have shown that the usb device is not ready during the
.probe(). This blocks the entire
On Tue, Mar 12, 2013 at 2:36 AM, Peter Hutterer
peter.hutte...@who-t.net wrote:
On Mon, Mar 11, 2013 at 04:34:27PM -0400, Yufeng Shen wrote:
I have ran into cases where I want to make a touch end event to have a
touch cancel indication.
This comes from trying to solve the problem of :
If
On Tue, Mar 12, 2013 at 7:18 PM, Yufeng Shen mile...@google.com wrote:
On Tue, Mar 12, 2013 at 4:59 AM, Benjamin Tissoires
benjamin.tissoi...@gmail.com wrote:
On Tue, Mar 12, 2013 at 2:36 AM, Peter Hutterer
peter.hutte...@who-t.net wrote:
On Mon, Mar 11, 2013 at 04:34:27PM -0400, Yufeng Shen
.
For backward compatibility, we need to add a quirk to request
this behavior.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-input.c | 77
+
include/linux/hid.h | 1 +
2 files changed, 78 insertions(+)
diff
On 03/19/2013 10:38 PM, Henrik Rydberg wrote:
Hi Benjamin,
This is not just cosmetics, it can help to write udev and X.org
rules.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-multitouch.c | 24 +++-
1 file changed, 23 insertions
1 - 100 of 977 matches
Mail list logo
