Re: Add support(re-using) for Cypress CY8CTMA884 part in exiting cypress touch controller driver(drivers/input/touchscreen/cyttsp4_core.c)

2016-01-06 Thread rajeev kumar
Hello Ferruh

On Mon, Jan 4, 2016 at 12:46 PM, rajeev kumar
 wrote:
> Hello Ferruh,
>
>   I was going through exiting cypress touch screen  driver
> (drivers/input/touchscreen/cyttsp4_core.c). Driver copy write suggest
> that it supports TMA4XX and TMA1036 cypress touch part. Is there any
> planning to extend the support for tma884 part ?
> In fact , support for tma884 part exit in android version of the code
> for v3.0.31 Linux kernel. I've gone ahead and tried to review the
> current version of the `cyttsp4*` sources in v4.3 relative to the
> version present in
> Android(https://android.googlesource.com/kernel/omap) and there are a
> lot of similarities between these two versions of the drivers. It
> looks to me that the version in v4.3 is a cleaned up fork of the older
> version contained in Android. I understand that these two versions of
> the driver may have both been targeted at different Cypress touch
> screen controller part numbers. But based on what I've been reading,
> both of these parts appear to be more closely related/in the same
> product family than not and so should use a common driver.
> So my question is:
> 1. Is there any planning to extend support for cypress tma884 part in
> existing cypress touch screen driver i.e in
> drivers/input/touchscreen/cyttsp4_core.c ? or
> 2. may be with minor changes, can I re-use the same driver for tma884
> part ? Please suggest.

Continuation to the last mail, doing more post-mortem analysis for the
code base,  drivers/input/touchscreen/cyttsp4_core.c ( v4.3 kernel:
support TMA4XX and TMA1036 cypress touch part) and android
code base, https://android.googlesource.com/kernel/omap ( Supports
CY8CTMA398 and CY8CTMA884 cypress touch part). I don't have the
specification for TMA4XX device families but by looking/comparing
code, my analysis suggest that I can use
drivers/input/touchscreen/cyttsp4_core.c (v4.3 kernel) also for
cypress touch part CY8CTMA884 as it is.
Could you please strengthen my understanding ?

TIA
Best Regards
Rajeev

>
> TIA
>
> Best Regards
> Rajeev
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Add support(re-using) for Cypress CY8CTMA884 part in exiting cypress touch controller driver(drivers/input/touchscreen/cyttsp4_core.c)

2016-01-03 Thread rajeev kumar
Hello Ferruh,

  I was going through exiting cypress touch screen  driver
(drivers/input/touchscreen/cyttsp4_core.c). Driver copy write suggest
that it supports TMA4XX and TMA1036 cypress touch part. Is there any
planning to extend the support for tma884 part ?
In fact , support for tma884 part exit in android version of the code
for v3.0.31 Linux kernel. I've gone ahead and tried to review the
current version of the `cyttsp4*` sources in v4.3 relative to the
version present in
Android(https://android.googlesource.com/kernel/omap) and there are a
lot of similarities between these two versions of the drivers. It
looks to me that the version in v4.3 is a cleaned up fork of the older
version contained in Android. I understand that these two versions of
the driver may have both been targeted at different Cypress touch
screen controller part numbers. But based on what I've been reading,
both of these parts appear to be more closely related/in the same
product family than not and so should use a common driver.
So my question is:
1. Is there any planning to extend support for cypress tma884 part in
existing cypress touch screen driver i.e in
drivers/input/touchscreen/cyttsp4_core.c ? or
2. may be with minor changes, can I re-use the same driver for tma884
part ? Please suggest.

TIA

Best Regards
Rajeev
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html