Re: [PATCH 0/4] HID: Improve handling of multimode Logitech handling wheels

2015-02-13 Thread Simon Wood
Hi all,
I tested this with a DFP, G27 and WiiWheell was looking good, but then
I found a small bug.

It seems that the requested mode is case sensitive. 'G25' works, but
'g25' is seen as a request for a 'DF-GT' and causes and error.

Sorry I didn't see this earlier. I'd be happy to apply and fix later,
but I suspect Jiri will say fix it first.
Simon

PS. Resent via Gmail as my hosting is having issues.

On Fri, 6 Feb 2015 10:27:21 -0700, si...@mungewell.org wrote:
  This patch series improves handling of various Logitech gaming wheels and
  allows switching between various compatibility modes which might be useful
  to improve compatibility with very old games and testing purposes.

 Hi all,
 We should note that part 1 performs a very important function of identify
 the wheels as per Logitech's schema.

 At present our (old detection) uses USB Revision to identify 'fancy'
 wheels which can be placed into native mode. This means when Logitech
 updates the hardware we are playing catch-up (this has happened 3 times
 with the DF-GT wheel so far).

 This newer code should automatically cope with new wheels in the future.


 Thanks to Michal for undertaking this work. I have been testing the code
 over the past weeks and believe it to be working, I will confirm mid-next
 week when I can gain access to my wheels.

 Simon

Got this while testing
--
Feb 12 19:52:00 bigbox kernel: [  966.044022] usb 8-2: new full-speed USB 
device number 16 using uhci_hcd
Feb 12 19:52:00 bigbox kernel: [  966.215031] usb 8-2: New USB device found, 
idVendor=046d, idProduct=c298
Feb 12 19:52:00 bigbox kernel: [  966.215035] usb 8-2: New USB device strings: 
Mfr=0, Product=2, SerialNumber=0
Feb 12 19:52:00 bigbox kernel: [  966.215038] usb 8-2: Product: G27 Racing Wheel
Feb 12 19:52:00 bigbox kernel: [  966.218081] drivers/hid/usbhid/hid-core.c: 
HID probe called for ifnum 0
Feb 12 19:52:00 bigbox kernel: [  966.225084] logitech 0003:046D:C298.0012: 
fixing up Logitech Driving Force Pro report descri
ptor
Feb 12 19:52:00 bigbox kernel: [  966.225545] input: G27 Racing Wheel as 
/devices/pci:00/:00:1d.3/usb8/8-2/8-2:1.0/000
3:046D:C298.0012/input/input24
Feb 12 19:52:00 bigbox mtp-probe: checking bus 8, device 16: 
/sys/devices/pci:00/:00:1d.3/usb8/8-2
Feb 12 19:52:00 bigbox mtp-probe: bus: 8, device: 16 was not an MTP device
Feb 12 19:52:00 bigbox kernel: [  966.280150] logitech 0003:046D:C298.0012: 
input,hidraw2: USB HID v1.00 Joystick [G27 Racing 
Wheel] on usb-:00:1d.3-2/input0
Feb 12 19:52:00 bigbox kernel: [  966.280155] drivers/hid/hid-lg4ff.c: Found 
wheel with real PID C29B whose reported PID is C2
98
Feb 12 19:52:00 bigbox kernel: [  966.280158] drivers/hid/hid-lg4ff.c: Found 
compatible device, product ID C298
Feb 12 19:52:00 bigbox kernel: [  966.280166] drivers/hid/usbhid/hid-core.c: 
submitting out urb
Feb 12 19:52:00 bigbox kernel: [  966.280174] drivers/hid/hid-lg4ff.c: sysfs 
interface created
Feb 12 19:52:00 bigbox kernel: [  966.280176] drivers/hid/hid-lg4ff.c: Driving 
Force Pro: setting range to 900
Feb 12 19:52:00 bigbox kernel: [  966.280179] logitech 0003:046D:C298.0012: 
Force feedback support for Logitech Gaming Wheels
Feb 12 19:52:00 bigbox kernel: [  966.286030] drivers/hid/usbhid/hid-core.c: 
submitting out urb
Feb 12 19:52:00 bigbox kernel: [  966.294030] drivers/hid/usbhid/hid-core.c: 
submitting out urb
Feb 12 19:52:26 bigbox kernel: [  992.162555] drivers/hid/hid-lg4ff.c: 
Alternate mode DFGT not supported by the device
--

Note I don't have a DFGT, and didn't ask for a fake one


Unplug and replug
--
Feb 12 20:05:15 bigbox kernel: [ 1761.104019] usb 8-2: new full-speed USB 
device number 23 using uhci_hcd
Feb 12 20:05:15 bigbox kernel: [ 1761.275032] usb 8-2: New USB device found, 
idVendor=046d, idProduct=c294
Feb 12 20:05:15 bigbox kernel: [ 1761.275037] usb 8-2: New USB device strings: 
Mfr=0, Product=2, SerialNumber=0
Feb 12 20:05:15 bigbox kernel: [ 1761.275040] usb 8-2: Product: G27 Racing Wheel
Feb 12 20:05:15 bigbox kernel: [ 1761.278091] drivers/hid/usbhid/hid-core.c: 
HID probe called for ifnum 0
Feb 12 20:05:15 bigbox kernel: [ 1761.286543] input: G27 Racing Wheel as 
/devices/pci:00/:00:1d.3/usb8/8-2/8-2:1.0/0003:046D:C294.0019/input/input31
Feb 12 20:05:15 bigbox mtp-probe: checking bus 8, device 23: 
/sys/devices/pci:00/:00:1d.3/usb8/8-2
Feb 12 20:05:15 bigbox mtp-probe: bus: 8, device: 23 was not an MTP device
Feb 12 20:05:15 bigbox kernel: [ 1761.340180] logitech 0003:046D:C294.0019: 
input,hidraw2: USB HID v1.00 Joystick [G27 Racing Wheel] on 
usb-:00:1d.3-2/input0
Feb 12 20:05:15 bigbox kernel: [ 1761.340186] drivers/hid/hid-lg4ff.c: Found 
wheel with real PID C29B whose reported PID is C294
Feb 12 20:05:15 bigbox kernel: [ 1761.340188] drivers/hid/hid-lg4ff.c: Found 
compatible device, product ID C294
Feb 12 20:05:15 bigbox kernel: [ 1761.340197] drivers/hid/usbhid/hid-core.c: 
submitting out urb
Feb 12 20:05:15 bigbox kernel: [ 

Re: [PATCH 0/4] HID: Improve handling of multimode Logitech handling wheels

2015-02-09 Thread Elias Vanderstuyft
On Fri, Feb 6, 2015 at 5:34 PM, Michal Malý
madcatxs...@devoid-pointer.net wrote:
 This patch series improves handling of various Logitech gaming wheels and
 allows switching between various compatibility modes which might be useful
 to improve compatibility with very old games and testing purposes.

 Signed-off-by: Michal Malý madcatxs...@devoid-pointer.net

 Michal Malý (4):
   Identify Logitech gaming wheels in compatibility modes accordingly to
Logitech specifications
   Display the real wheel model and supported alternate modes through
 sysfs. This applies only to multimode wheels.
   Introduce a module parameter to disable automatic switch of Logitech
   gaming wheels from compatibility to native mode. This only applies
 to multimode wheels.
   Allow switching of Logitech gaming wheels between available
 compatibility modes through sysfs. This only applies to multimode
 wheels.

  .../ABI/testing/sysfs-driver-hid-logitech-lg4ff|  45 ++
  drivers/hid/hid-lg.c   |   6 +
  drivers/hid/hid-lg4ff.c| 608 
 ++---
  3 files changed, 583 insertions(+), 76 deletions(-)

 --
 2.2.2


Applied cleanly on kernel 3.17.8, and tested with:
- Logitech Formula Vibration Wheel
- Logitech MOMO (Black) Wheel
Everything keeps working like it was before, which is correct because
these wheels are no multimode wheels.

Tested-by: Elias Vanderstuyft elias@gmail.com

Thanks,
Elias
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/4] HID: Improve handling of multimode Logitech handling wheels

2015-02-06 Thread simon
 This patch series improves handling of various Logitech gaming wheels and
 allows switching between various compatibility modes which might be useful
 to improve compatibility with very old games and testing purposes.

Hi all,
We should note that part 1 performs a very important function of identify
the wheels as per Logitech's schema.

At present our (old detection) uses USB Revision to identify 'fancy'
wheels which can be placed into native mode. This means when Logitech
updates the hardware we are playing catch-up (this has happened 3 times
with the DF-GT wheel so far).

This newer code should automatically cope with new wheels in the future.


Thanks to Michal for undertaking this work. I have been testing the code
over the past weeks and believe it to be working, I will confirm mid-next
week when I can gain access to my wheels.

Simon

--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html