Re: [PATCH v2] rbd: Remove VLA usage

2018-03-16 Thread kbuild test robot
Hi Kyle, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc5 next-20180316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v2] staging: typec: rt1711h typec chip driver

2018-03-16 Thread 李書帆
Hi Guenter, 2018-03-17 10:16 GMT+08:00 Guenter Roeck : > On 03/16/2018 10:40 AM, ShuFan Lee wrote: >> >> From: ShuFan Lee >> >> Richtek RT1711H Type-C chip driver that works with >> Type-C Port Controller Manager to provide USB PD and >> USB Type-C

Re: [PATCH v2 6/6] platform/chrome: mfd/cros_ec_dev: Add sysfs entry to set keyboard wake lid angle

2018-03-16 Thread Gwendal Grignou
On Wed, Mar 7, 2018 at 8:28 AM Lee Jones wrote: > On Wed, 21 Feb 2018, Enric Balletbo i Serra wrote: > > From: Gwendal Grignou > > > > This adds a sysfs attribute (/sys/class/chromeos/cros_ec/kb_wake_angle) > > used to set and get the keyboard wake

[PATCH] Input: atmel_mxt_ts: Add hook for Chromebooks with upstream coreboot

2018-03-16 Thread Jean Lucas
Chromebooks use coreboot for system initialization. coreboot has always had the default mainboard vendor string for Google machines set to "Google". Google engineers set this string to "GOOGLE" in the coreboot copies of the Chromium OS tree. The atmel_mxt_ts driver in it's current state is set to

Re: [PATCH 03/14] mm/hmm: HMM should have a callback before MM is destroyed v2

2018-03-16 Thread John Hubbard
On 03/16/2018 08:47 PM, John Hubbard wrote: > On 03/16/2018 07:36 PM, John Hubbard wrote: >> On 03/16/2018 12:14 PM, jgli...@redhat.com wrote: >>> From: Ralph Campbell >>> >> >> >> >>> +static void hmm_release(struct mmu_notifier *mn, struct mm_struct *mm) >>> +{ >>> +

Re: [PATCH] phy: core: Allow phy_pm_runtime_xxx API calls with NULL phy

2018-03-16 Thread kbuild test robot
Hi Manu, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v4.16-rc4] [also build test WARNING on next-20180316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH 08/14] mm/hmm: cleanup special vma handling (VM_SPECIAL)

2018-03-16 Thread John Hubbard
On 03/16/2018 12:14 PM, jgli...@redhat.com wrote: > From: Jérôme Glisse > > Special vma (one with any of the VM_SPECIAL flags) can not be access by > device because there is no consistent model accross device drivers on > those vma and their backing memory. > > This patch

Re: [PATCH v4] EDAC, sb_edac: Remove VLA usage

2018-03-16 Thread Borislav Petkov
On Wed, Mar 14, 2018 at 01:21:32PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wvla, remove VLA and replace it > with a fixed-length array instead. > > Fixed as part of the directive to remove all VLAs from > the kernel: https://lkml.org/lkml/2018/3/7/621 > > Also, remove

Re: [PATCH v3 18/18] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-16 Thread Timur Tabi
On Fri, Mar 16, 2018 at 11:25 PM, Sinan Kaya wrote: > @@ -477,15 +477,16 @@ static inline void t4_ring_sq_db(struct t4_wq *wq, u16 > inc, union t4_wr *wqe) > (u64 *)wqe); > } else { > pr_debug("DB

Re: [PATCH v3 18/18] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-16 Thread Sinan Kaya
On 3/17/2018 12:03 AM, Sinan Kaya wrote: > On 3/16/2018 11:40 PM, Sinan Kaya wrote: >> I'll change writel_relaxed() with __raw_writel() in the series like you >> suggested >> and also look at your other comments. > > I spoke too soon. > > Now that I realized, code needs to follow one of the

Re: [PATCH v3 18/18] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-16 Thread Timur Tabi
On 3/16/18 6:04 PM, Steve Wise wrote: Anybody understand why the PPC implementation of writeX_relaxed() isn't relaxed? You probably should ask that on the linuxppc-...@lists.ozlabs.org mailing list. I've always wondered why PowerPC has non-standard I/O accessors. -- Qualcomm Datacenter

Re: [PATCH v3 18/18] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-16 Thread Sinan Kaya
On 3/16/2018 11:40 PM, Sinan Kaya wrote: > I'll change writel_relaxed() with __raw_writel() in the series like you > suggested > and also look at your other comments. I spoke too soon. Now that I realized, code needs to follow one of the following patterns for correctness 1) wmb()

Re: [PATCH v4.16-rc5 1/1] x86/vdso: VDSO should handle clock_gettime(CLOCK_MONOTONIC_RAW) without syscall

2018-03-16 Thread kbuild test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [also build test ERROR on next-20180316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/jason-vas

Re: [PATCH 07/14] mm/hmm: use uint64_t for HMM pfn instead of defining hmm_pfn_t to ulong

2018-03-16 Thread John Hubbard
On 03/16/2018 12:14 PM, jgli...@redhat.com wrote: > From: Jérôme Glisse > Hi Jerome, This one looks great. A couple of trivial typo fixes are listed below. You can add: Reviewed-by: John Hubbard > All device driver we care about are using 64bits

Re: [PATCH 03/14] mm/hmm: HMM should have a callback before MM is destroyed v2

2018-03-16 Thread John Hubbard
On 03/16/2018 07:36 PM, John Hubbard wrote: > On 03/16/2018 12:14 PM, jgli...@redhat.com wrote: >> From: Ralph Campbell >> > > > >> +static void hmm_release(struct mmu_notifier *mn, struct mm_struct *mm) >> +{ >> +struct hmm *hmm = mm->hmm; >> +struct hmm_mirror

[PATCH i2c/slave-mqueue v1] i2c: slave-mqueue: add a slave backend to receive and queue messages

2018-03-16 Thread Haiyue Wang
Some protocols over I2C are designed for bi-directional transferring messages by using I2C Master Write protocol. Like the MCTP (Management Component Transport Protocol) and IPMB (Intelligent Platform Management Bus), they both require that the userspace can receive messages from I2C dirvers under

Re: [PATCH v3 18/18] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-16 Thread Sinan Kaya
On 3/16/2018 7:05 PM, Steve Wise wrote: >> >> On 3/16/2018 5:05 PM, Steve Wise wrote: Code includes wmb() followed by writel(). writel() already has a barrier >>> on some architectures like arm64. This ends up CPU observing two barriers back to back before executing >> the

Re: [PATCH 06/14] mm/hmm: remove HMM_PFN_READ flag and ignore peculiar architecture

2018-03-16 Thread John Hubbard
On 03/16/2018 12:14 PM, jgli...@redhat.com wrote: > From: Jérôme Glisse > > Only peculiar architecture allow write without read thus assume that > any valid pfn do allow for read. Note we do not care for write only > because it does make sense with thing like atomic compare

Re: [PATCH 05/14] mm/hmm: use struct for hmm_vma_fault(), hmm_vma_get_pfns() parameters

2018-03-16 Thread John Hubbard
On 03/16/2018 12:14 PM, jgli...@redhat.com wrote: > From: Jérôme Glisse > Hi Jerome, I failed to find any problems in this patch, so: Reviewed-by: John Hubbard There are a couple of documentation recommended typo fixes listed below, which are very

Re: [PATCH 2/2] kprobe: fix: Add ftrace_ops_assist_func to kprobe blacklist

2018-03-16 Thread Steven Rostedt
On Sat, 17 Mar 2018 10:22:11 +0900 Masami Hiramatsu wrote: > Or, we can check it by ftrace_location_range() as below patch. Cute ;-) > > Note that as a side-effect, we can not trace functions in trace_kprobe.c > anymore, and this means it is hard to me to make a testcase

Re: [PATCH 03/14] mm/hmm: HMM should have a callback before MM is destroyed v2

2018-03-16 Thread John Hubbard
On 03/16/2018 12:14 PM, jgli...@redhat.com wrote: > From: Ralph Campbell > > +static void hmm_release(struct mmu_notifier *mn, struct mm_struct *mm) > +{ > + struct hmm *hmm = mm->hmm; > + struct hmm_mirror *mirror; > + struct hmm_mirror *mirror_next; > + > +

Re: [PATCH v2] staging: typec: rt1711h typec chip driver

2018-03-16 Thread Guenter Roeck
On 03/16/2018 10:40 AM, ShuFan Lee wrote: From: ShuFan Lee Richtek RT1711H Type-C chip driver that works with Type-C Port Controller Manager to provide USB PD and USB Type-C functionalities. Add definition of TCPC_CC_STATUS_TOGGLING. Signed-off-by: ShuFan Lee

Re: [PATCH 04/14] mm/hmm: hmm_pfns_bad() was accessing wrong struct

2018-03-16 Thread John Hubbard
On 03/16/2018 12:14 PM, jgli...@redhat.com wrote: > From: Jérôme Glisse > > The private field of mm_walk struct point to an hmm_vma_walk struct and > not to the hmm_range struct desired. Fix to get proper struct pointer. > > Signed-off-by: Jérôme Glisse

Re: [PATCH v3 1/7] watchdog: sama5d4: make use of timeout-secs provided in devicetree

2018-03-16 Thread Guenter Roeck
On 03/16/2018 06:37 AM, Marcus Folkesson wrote: Hi, Am I supposed to do something more to make this patchset picked up? Did you check linux-next ? Guenter Thanks, Marcus Folkesson On Sun, Feb 11, 2018 at 09:08:41PM +0100, Marcus Folkesson wrote: watchdog_init_timeout() will allways pick

Re: [PATCH v7 0/2] hwmon: (ucd9000) Add gpio and debugfs interfaces

2018-03-16 Thread Guenter Roeck
On 03/16/2018 02:22 PM, Eddie James wrote: The ucd9000 series chips have gpio pins. Add a gpio chip interface to the ucd device so that users can query and set the state of the gpio pins. Add a debugfs interface using the existing pmbus debugfs directory to provide MFR_STATUS and the status of

Re: [PATCH v5 0/2] Remove false-positive VLAs when using max()

2018-03-16 Thread Miguel Ojeda
On Fri, Mar 16, 2018 at 9:14 PM, Linus Torvalds wrote: > On Fri, Mar 16, 2018 at 1:03 PM, Miguel Ojeda > wrote: >>> >>> Kees - is there some online "gcc-4.4 checker" somewhere? This does >>> seem to work with my gcc. I actually

Re: [v6] watchdog: add SPDX identifiers for watchdog subsystem

2018-03-16 Thread Guenter Roeck
On Fri, Mar 16, 2018 at 04:14:11PM +0100, Marcus Folkesson wrote: > - Add SPDX identifier > - Remove boiler plate license text > - If MODULE_LICENSE and boiler plate does not match, go for boiler plate > license > > Signed-off-by: Marcus Folkesson > Acked-by: Adam

Re: [PATCH] net: ethernet: arc: Fix a potential memory leak if an optional regulator is deferred

2018-03-16 Thread kbuild test robot
Hi Christophe, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [also build test ERROR on next-20180316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH v3] vsprintf: Prevent crash when dereferencing invalid pointers

2018-03-16 Thread Sergey Senozhatsky
On (03/16/18 09:55), Petr Mladek wrote: [..] > I am not sure if it is worth it. I think that we would catch 99% of > problems by checking the first byte. > > This patch was motivated by a code clean up rather than bug reports. OK. Then I think we really need this "the patch is just good enough"

Re: [PATCH 2/2] kprobe: fix: Add ftrace_ops_assist_func to kprobe blacklist

2018-03-16 Thread Masami Hiramatsu
On Sat, 17 Mar 2018 09:13:34 +0900 Masami Hiramatsu wrote: > On Fri, 16 Mar 2018 13:53:01 -0400 (EDT) > Mathieu Desnoyers wrote: > > > - On Mar 16, 2018, at 12:48 PM, rostedt rost...@goodmis.org wrote: > > > > > On Fri, 16 Mar 2018

[PATCH 02/14] mm/hmm: fix header file if/else/endif maze v2

2018-03-16 Thread jglisse
From: Jérôme Glisse The #if/#else/#endif for IS_ENABLED(CONFIG_HMM) were wrong. Because of this after multiple include there was multiple definition of both hmm_mm_init() and hmm_mm_destroy() leading to build failure if HMM was enabled (CONFIG_HMM set). Changed since v1: -

Re: [PATCH v3 1/5] tpm: fix intermittent failure with self tests

2018-03-16 Thread James Bottomley
On Mon, 2018-03-05 at 18:56 +0200, Jarkko Sakkinen wrote: > index 9e80a953d693..1adb976a2e37 100644 > --- a/drivers/char/tpm/tpm-interface.c > +++ b/drivers/char/tpm/tpm-interface.c > @@ -537,14 +537,26 @@ ssize_t tpm_transmit_cmd(struct tpm_chip *chip, > struct tpm_space *space, >  

Re: [PATCH] acpi, numa: fix pxm to online numa node associations

2018-03-16 Thread Dan Williams
[ adding Toshi's correct address ] On Thu, Mar 15, 2018 at 8:08 PM, Dan Williams wrote: > Commit 99759869faf1 "acpi: Add acpi_map_pxm_to_online_node()" added > support for mapping a given proximity to its nearest, by SLIT distance, > online node. However, it sometimes

Re: [PATCH v5 1/9] sysctl: Add flags to support min/max range clamping

2018-03-16 Thread Luis R. Rodriguez
On Fri, Mar 16, 2018 at 02:13:42PM -0400, Waiman Long wrote: > When the CTL_FLAGS_CLAMP_RANGE flag is set in the ctl_table > entry, any update from the userspace will be clamped to the given > range without error if either the proc_dointvec_minmax() or the > proc_douintvec_minmax() handlers is

[PATCH 1/2] regulator: add QCOM RPMh regulator driver

2018-03-16 Thread David Collins
Add the QCOM RPMh regulator driver to manage PMIC regulators which are controlled via RPMh on some Qualcomm Technologies, Inc. SoCs. RPMh is a hardware block which contains several accelerators which are used to manage various hardware resources that are shared between the processors of the SoC.

[PATCH 0/2] regulator: add QCOM RPMh regulator driver

2018-03-16 Thread David Collins
Hello, This patch series adds a driver and device tree binding documentation for PMIC regulator control via Resource Power Manager-hardened (RPMh) on some Qualcomm Technologies, Inc. SoCs such as SDM845. RPMh is a hardware block which contains several accelerators which are used to manage

[PATCH 2/2] dt-bindings: regulator: add QCOM RPMh regulator bindings

2018-03-16 Thread David Collins
Introduce bindings for RPMh regulator devices found on some Qualcomm Technlogies, Inc. SoCs. These devices allow a given processor within the SoC to make PMIC regulator requests which are aggregated within the RPMh hardware block along with requests from other processors in the SoC to determine

Re: [linux-sunxi] [PATCH v4 7/9] clk: sunxi-ng: add support for the Allwinner H6 CCU

2018-03-16 Thread Jernej Škrabec
Hi, Dne petek, 16. marec 2018 ob 15:02:13 CET je Icenowy Zheng napisal(a): > The Allwinner H6 SoC has a CCU which has been largely rearranged. > > Add support for it in the sunxi-ng CCU framework. > > Signed-off-by: Icenowy Zheng > Acked-by: Maxime Ripard

Re: New -Werror=restrict error with incremental gcc

2018-03-16 Thread Laura Abbott
On 03/15/2018 08:11 PM, Josh Poimboeuf wrote: On Thu, Mar 15, 2018 at 08:06:26AM -0700, Laura Abbott wrote: This only showed up with the very latest rawhide snapshot, .17 worked and .18 started failing. I had to download .18 manually to test locally

Re: [PATCH v5 2/9] proc/sysctl: Provide additional ctl_table.flags checks

2018-03-16 Thread Luis R. Rodriguez
On Fri, Mar 16, 2018 at 02:13:43PM -0400, Waiman Long wrote: > Checking code is added to provide the following additional > ctl_table.flags checks: > > 1) No unknown flag is allowed. > 2) Minimum of a range cannot be larger than the maximum value. > 3) The signed and unsigned flags are

Re: [PATCH v4 1/5] PCI: endpoint: BAR width should not depend on sizeof dma_addr_t

2018-03-16 Thread Niklas Cassel
On Fri, Mar 16, 2018 at 06:02:20PM +, Lorenzo Pieralisi wrote: > On Thu, Mar 08, 2018 at 02:33:26PM +0100, Niklas Cassel wrote: > > If a BAR supports 64-bit width or not depends on the hardware, > > and should thus not depend on sizeof(dma_addr_t). > > > > Since this driver is generic,

Re: [PATCH 2/4] mm/hmm: fix header file if/else/endif maze

2018-03-16 Thread kbuild test robot
Hi Jérôme, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc5 next-20180316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v5 0/2] Remove false-positive VLAs when using max()

2018-03-16 Thread Miguel Ojeda
On Fri, Mar 16, 2018 at 9:14 PM, Linus Torvalds wrote: > On Fri, Mar 16, 2018 at 1:03 PM, Miguel Ojeda > wrote: >>> >>> Kees - is there some online "gcc-4.4 checker" somewhere? This does >>> seem to work with my gcc. I actually

Re: [PATCH v4 09/10] drivers: qcom: rpmh: add support for batch RPMH request

2018-03-16 Thread Evan Green
On Fri, Mar 9, 2018 at 3:26 PM Lina Iyer wrote: > Platform drivers need make a lot of resource state requests at the same > time, say, at the start or end of an usecase. It can be quite > inefficient to send each request separately. Instead they can give the > RPMH library

Re: [PATCH v4 07/10] drivers: qcom: rpmh: cache sleep/wake state requests

2018-03-16 Thread Evan Green
On Fri, Mar 9, 2018 at 3:27 PM Lina Iyer wrote: > Active state requests are sent immediately to the mailbox controller, > while sleep and wake state requests are cached in this driver to avoid > taxing the mailbox controller repeatedly. The cached values will be sent > to

Re: [PATCH v4 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

2018-03-16 Thread Evan Green
On Fri, Mar 9, 2018 at 3:27 PM Lina Iyer wrote: > Sleep and wake requests are sent when the application processor > subsystem of the SoC is entering deep sleep states like in suspend. > These requests help lower the system power requirements when the > resources are not in

Re: [PATCH] dcache: remove trailing whitespace

2018-03-16 Thread Niklas Cassel
TW, happens in *all* branches. If you do that kind > of stuff, at least do it against something in the public trees > and _tell_ _what_ _it_ _is_ _against_. Hello Al, I always base my patches on linux-next, which is usually correct, and if it isn't, the maintainer usually say

[PATCH] drm/i915: Disable some extra clang warnings

2018-03-16 Thread Matthias Kaehlcke
Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set warnings to full") enabled extra warnings for i915 to spot possible bugs in new code, and then disabled a subset of these warnings to keep the current code building without warnings (with gcc). Enabling the extra warnings also

Re: general protection fault in ucma_connect

2018-03-16 Thread Al Viro
On Fri, Mar 16, 2018 at 04:59:02PM -0700, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > e2c15aff5f353ba80bd3bb49840837f65fa5cc43 (Thu Mar 15 18:07:35 2018 +) > Merge tag 'sound-4.16-rc6' of > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound > > So

Re: [PATCH 2/2] kprobe: fix: Add ftrace_ops_assist_func to kprobe blacklist

2018-03-16 Thread Masami Hiramatsu
On Fri, 16 Mar 2018 13:53:01 -0400 (EDT) Mathieu Desnoyers wrote: > - On Mar 16, 2018, at 12:48 PM, rostedt rost...@goodmis.org wrote: > > > On Fri, 16 Mar 2018 12:41:34 -0400 > > Steven Rostedt wrote: > > > >> Yes, kprobes are

Re: [PATCH 2/2] kprobe: fix: Add ftrace_ops_assist_func to kprobe blacklist

2018-03-16 Thread Masami Hiramatsu
On Fri, 16 Mar 2018 12:28:59 -0400 (EDT) Mathieu Desnoyers wrote: > - On Mar 16, 2018, at 11:25 AM, rostedt rost...@goodmis.org wrote: > > > On Fri, 16 Mar 2018 11:18:25 -0400 > > Francis Deslauriers wrote: > > > >> Hi

Re: [PATCH] net: ethernet: arc: Fix a potential memory leak if an optional regulator is deferred

2018-03-16 Thread kbuild test robot
Hi Christophe, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [also build test ERROR on next-20180316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[PATCH] staging: lustre: o2iblnd: Stop MLX5 triggering a dump_cqe

2018-03-16 Thread Doug Oucharek
We have found that MLX5 will trigger a dump_cqe if we don't invalidate the rkey on a newly alloated MR for FastReg usage. This fix just tags the MR as invalid on its creation if we are using FastReg and that will force it to do an invalidate of the rkey on first usage. Signed-off-by: Doug

Re: [RFC 3/4] sh: ecovec24: convert backlight to use device properties

2018-03-16 Thread Dmitry Torokhov
On Fri, Mar 16, 2018 at 09:50:21AM +0100, Geert Uytterhoeven wrote: > Hi Dmitry, > > On Thu, Mar 15, 2018 at 11:42 PM, Dmitry Torokhov > wrote: > > Instead of backlight legacy platform data, let's switch to using device > > properties and GPIO lookup tables. > > > >

Re: [RFC 2/4] sh: ecovec24: conditionally register backlight device

2018-03-16 Thread Dmitry Torokhov
Hi Jacopo, On Fri, Mar 16, 2018 at 11:07:48AM +0100, jacopo mondi wrote: > Hello Dmitry > > FYI I am brushing the ecovec board these days as well > https://www.spinics.net/lists/linux-sh/msg52536.html > What is the ecovec board BTW? Is it some devkit or what? It seems quite old to me. > And I

Re: [PATCH -mm] proc: fixup test for read

2018-03-16 Thread Andrew Morton
On Sat, 17 Mar 2018 02:21:47 +0300 Alexey Dobriyan wrote: > /proc/kmsg can and will block if read under root. > This fixes proc-shotgun-test-read-readdir-readlink-a-little-write.patch. It helps to point that out, so that reviewers won't be scrambling around asking wtf.

Re: [PATCH V3] ZBOOT: fix stack protector in compressed boot phase

2018-03-16 Thread Rich Felker
On Fri, Mar 16, 2018 at 03:13:37PM -0700, Andrew Morton wrote: > On Fri, 16 Mar 2018 15:55:16 +0800 Huacai Chen wrote: > > > Call __stack_chk_guard_setup() in decompress_kernel() is too late that > > stack checking always fails for decompress_kernel() itself. So remove > >

[PATCH -mm] proc: fixup test for read

2018-03-16 Thread Alexey Dobriyan
/proc/kmsg can and will block if read under root. Signed-off-by: Alexey Dobriyan --- tools/testing/selftests/proc/read.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/tools/testing/selftests/proc/read.c +++ b/tools/testing/selftests/proc/read.c @@ -54,7

RE: [PATCH v3 18/18] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-16 Thread Steve Wise
> > On 3/16/2018 5:05 PM, Steve Wise wrote: > >> Code includes wmb() followed by writel(). writel() already has a barrier > > on > >> some architectures like arm64. > >> > >> This ends up CPU observing two barriers back to back before executing > the > >> register write. > >> > >> Since code

Re: [PATCH] drm/vc4_validate: Remove VLA usage

2018-03-16 Thread Eric Anholt
"Gustavo A. R. Silva" writes: > In preparation to enabling -Wvla, remove VLA. In this particular > case use macro ARRAY_SIZE so the length of array _bo_ can be > computed at preprocessing time. > > The use of stack Variable Length Arrays needs to be avoided, as they > can

RE: [PATCH v3 18/18] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-16 Thread Steve Wise
> > On Fri, Mar 16, 2018 at 04:05:10PM -0500, Steve Wise wrote: > > > Code includes wmb() followed by writel(). writel() already has a barrier > > on > > > some architectures like arm64. > > > > > > This ends up CPU observing two barriers back to back before executing > the > > > register write.

Re: [PATCH] memory-failure: fix section mismatch

2018-03-16 Thread Matthias Kaehlcke
El Sat, Mar 03, 2018 at 11:16:11PM -0800 Nick Desaulniers ha dit: > Clang complains when a variable is declared extern twice, but with two > different sections. num_poisoned_pages is marked extern and __read_mostly > in include/linux/swapops.h, but only extern in include/linux/mm.h. Some > c

Re: [PATCH v6 16/20] clk: add support for clocks provided by SCMI

2018-03-16 Thread Stephen Boyd
Quoting Sudeep Holla (2018-02-23 08:23:46) > diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c > new file mode 100644 > index ..1e4d7a57779b > --- /dev/null > +++ b/drivers/clk/clk-scmi.c > + hws[idx] = >hw; > + } > + } > + > +

Re: [PATCH v2] rslib: Remove VLAs by setting upper bound on nroots

2018-03-16 Thread Andrew Morton
On Thu, 15 Mar 2018 15:59:19 -0700 Kees Cook wrote: > Avoid stack VLAs[1] by always allocating the upper bound of stack space > needed. The existing users of rslib appear to max out at 24 roots[2], > so use that as the upper bound until we have a reason to change it. > >

Re: [PATCH] clk: hisilicon: mark wdt_mux_p[] as const

2018-03-16 Thread Stephen Boyd
Quoting Arnd Bergmann (2018-02-20 07:15:21) > The symbol is in the __initconst section but not marked init, which > caused a warning when building with LTO. > > This makes it 'const' as was obviously intended. > > Signed-off-by: Arnd Bergmann > --- Applied to clk-next

Re: [PATCH] bpf: whitelist syscalls for error injection

2018-03-16 Thread Howard McLauchlan
On 03/13/2018 04:56 PM, Andy Lutomirski wrote: > On Tue, Mar 13, 2018 at 11:16 PM, Howard McLauchlan > wrote: >> Error injection is a useful mechanism to fail arbitrary kernel >> functions. However, it is often hard to guarantee an error propagates >> appropriately to user

Re: [PATCH 4.4 29/63] watchdog: hpwdt: fix unused variable warning

2018-03-16 Thread Jerry Hoemann
Greg, Sorry, if I'm missing something, but I see 3 patches for hpwdt queued up for 4.4: queue-4.4/watchdog-hpwdt-fix-unused-variable-warning.patch queue-4.4/watchdog-hpwdt-smbios-check.patch queue-4.4/watchdog-hpwdt-check-source-of-nmi.patch Shouldn't there also be a

Re: [PATCH] clk: fix false-positive Wmaybe-uninitialized warning

2018-03-16 Thread Stephen Boyd
Quoting Arnd Bergmann (2018-02-16 07:27:47) > When we build this driver with on x86-32, gcc produces a false-positive > warning: > > drivers/clk/renesas/clk-sh73a0.c: In function 'sh73a0_cpg_clocks_init': > drivers/clk/renesas/clk-sh73a0.c:155:10: error: 'parent_name' may be used >

Re: [PATCH 2/2] clk: sprd: add RTC gate for SC9860

2018-03-16 Thread Stephen Boyd
Quoting Chunyan Zhang (2018-02-09 01:55:09) > From: Chunyan Zhang > > Add a few gate clocks which are used for gating RTC for some > devices on AON area of SC9860. > > This patch has been tested on SC9860, with this patch and proper DT > configurations, the

Re: [PATCH 1/2] dt-bindings: clocks: add APB RTC gate for SC9860

2018-03-16 Thread Stephen Boyd
Quoting Chunyan Zhang (2018-02-09 01:48:10) > From: Chunyan Zhang > > Added index of RTC gate clocks which are used by some devices on aon > area of SC9860, for example the Watchdog timer. > > Signed-off-by: Chunyan Zhang > ---

Re: [PATCH] clk: qcom: smd-rpm: Migrate to devm_of_clk_add_hw_provider()

2018-03-16 Thread Stephen Boyd
Quoting Stephen Boyd (2018-02-01 16:33:26) > Signed-off-by: Stephen Boyd > --- Applied to clk-next

[PATCH v2 8/8] staging:iio:ade7854: Remove read_reg_* duplications

2018-03-16 Thread Rodrigo Siqueira
The original code had a read function per data size; after updates, all read functions tasks were centralized in a single function, but the old signature was kept to maintain the module working without problems. This patch removes a set of duplications associated with read_reg_*, and update the

[PATCH v2 6/8] staging:iio:ade7854: Rework I2C read function

2018-03-16 Thread Rodrigo Siqueira
The read operation for the I2C function has many duplications that can be generalized into a single function. This patch reworks the read operation for I2C to centralizes all similar code in a single function. Part of the rework includes a proper error handling and a fix on the i2c_master_recv for

[PATCH v2 7/8] staging:iio:ade7854: Rework SPI read function

2018-03-16 Thread Rodrigo Siqueira
Rework read SPI function to reduce the code duplication and centralizes all the task in a single function. Signed-off-by: Rodrigo Siqueira --- drivers/staging/iio/meter/ade7854-spi.c | 140 +--- 1 file changed, 37 insertions(+), 103

[PATCH v2 4/8] staging:iio:ade7854: Rework SPI write function

2018-03-16 Thread Rodrigo Siqueira
The write operation using SPI has a many code duplications (similar to I2C) and four different interfaces per data size. This patch introduces a single function that centralizes the main task related to SPI. Signed-off-by: Rodrigo Siqueira ---

[PATCH v2 5/8] staging:iio:ade7854: Replace many functions for one function

2018-03-16 Thread Rodrigo Siqueira
This patch removes code duplications related to the write_reg_* functions and centralizes them in a single function. Also, it eliminates the legacy functions and replaces them by a unique signature that is used by SPI and I2C. Signed-off-by: Rodrigo Siqueira ---

[PATCH v2 2/8] staging:iio:ade7854: Fix the wrong number of bits to read

2018-03-16 Thread Rodrigo Siqueira
The function ade7854_i2c_read_reg_32() have to invoke the i2c_master_recv() for read 32 bits values, however, the counter is set to 3 which means 24 bits. This patch fixes the wrong size of 24 bits, to 32 bits. Finally, this patch is based on John Syne patches. Signed-off-by: Rodrigo Siqueira

[PATCH v2 3/8] staging:iio:ade7854: Rework I2C write function

2018-03-16 Thread Rodrigo Siqueira
The write operation using I2C has many code duplications and four different interfaces per data size. This patch introduces a single function that centralizes the main tasks. The central function inserted by this patch can easily replace all the four functions related to the data size. However,

[PATCH v2 0/8] staging:iio:ade7854: Cleanup on I2C/SPI code

2018-03-16 Thread Rodrigo Siqueira
This patchset reworks the I2C/SPI code from meter module. The set of patches try to reduce the code duplication and make the communication reliable. The current version of the module had many code duplications, which make the code more error-prone and hard to read. Jonh Syne identified some wrong

[PATCH v2 1/8] staging:iio:ade7854: Fix error handling on read/write

2018-03-16 Thread Rodrigo Siqueira
The original code does not correctly handle the error related to I2C read and write. This patch fixes the error handling related to all read/write functions for I2C. This patch is an adaptation of the John Syne patches. Signed-off-by: Rodrigo Siqueira

Re: [PATCH 1/1] clk: add more __must_check for bulk APIs

2018-03-16 Thread Stephen Boyd
Quoting Dong Aisheng (2018-01-23 04:24:45) > we need it even when !CONFIG_HAVE_CLK because it allows > us to catch missing checking return values in the non-clk > compile configurations too. More test coverage. > > Cc: Stephen Boyd > Suggested-by: Stephen Boyd

Re: [PATCH 1/1] Documentation: clk: enable lock is not held for clk_is_enabled API

2018-03-16 Thread Stephen Boyd
Quoting Dong Aisheng (2018-01-19 05:37:15) > The core does not need to hold enable lock for clk_is_enabled API. > Update the doc to reflect it. > > Cc: Jonathan Corbet > Cc: Stephen Boyd > Suggested-by: Stephen Boyd > Signed-off-by:

Re: [PATCH v2] rslib: Remove VLAs by setting upper bound on nroots

2018-03-16 Thread Andrew Morton
On Thu, 15 Mar 2018 15:59:19 -0700 Kees Cook wrote: > Avoid stack VLAs[1] by always allocating the upper bound of stack space > needed. The existing users of rslib appear to max out at 24 roots[2], > so use that as the upper bound until we have a reason to change it. > >

Re: [PATCH] clk: qcom: gcc-msm8996: Mark aggre0 noc clks as critical

2018-03-16 Thread Stephen Boyd
Quoting srinivas.kandaga...@linaro.org (2017-12-07 02:59:22) > From: Srinivas Kandagatla > > aggre0 bus clks are not associated with any of the drivers, so its > important that these clks are always on to get peripherals on this > bus working. So mark them as

Re: [PATCH v12 22/22] selftests/vm: Fix deadlock in protection_keys.c

2018-03-16 Thread Dave Hansen
On 02/21/2018 05:55 PM, Ram Pai wrote: > From: Thiago Jung Bauermann > > The sig_chld() handler calls dprintf2() taking care of setting > dprint_in_signal so that sigsafe_printf() won't call printf(). > Unfortunately, this precaution is is negated by dprintf_level(),

Re: [PATCH v12 21/22] selftests/vm: sub-page allocator

2018-03-16 Thread Dave Hansen
On 02/21/2018 05:55 PM, Ram Pai wrote: ... > @@ -888,6 +917,7 @@ void setup_hugetlbfs(void) > void *(*pkey_malloc[])(long size, int prot, u16 pkey) = { > > malloc_pkey_with_mprotect, > + malloc_pkey_with_mprotect_subpage, > malloc_pkey_anon_huge, > malloc_pkey_hugetlb >

Re: [PATCH v12 20/22] selftests/vm: testcases must restore pkey-permissions

2018-03-16 Thread Dave Hansen
On 02/21/2018 05:55 PM, Ram Pai wrote: > Generally the signal handler restores the state of the pkey register > before returning. However there are times when the read/write operation > can legitamely fail without invoking the signal handler. Eg: A > sys_read() operaton to a write-protected page

Re: [PATCH] clk: versatile: Remove WARNs in ->round_rate()

2018-03-16 Thread Stephen Boyd
Quoting Brian Starkey (2017-11-13 07:27:51) > clk_round_rate() is intended to be used to round a given clock rate to > the closest one achievable by the actual clock. This implies that the > input to clk_round_rate() is expected to be unachievable - and such > cases shouldn't be treated as

Re: [PATCH v12 18/22] selftests/vm: associate key on a mapped page and detect write violation

2018-03-16 Thread Dave Hansen
On 02/21/2018 05:55 PM, Ram Pai wrote: > detect write-violation on a page to which write-disabled > key is associated much after the page is mapped. The more tests the merrier. Acked-by: Dave Hansen

Re: [PATCH v12 19/22] selftests/vm: detect write violation on a mapped access-denied-key page

2018-03-16 Thread Dave Hansen
On 02/21/2018 05:55 PM, Ram Pai wrote: > detect write-violation on a page to which access-disabled > key is associated much after the page is mapped. Acked-by: Dave Hansen

Re: [PATCH] clk: versatile: add min/max rate boundaries for vexpress osc clock

2018-03-16 Thread Stephen Boyd
Quoting Sudeep Holla (2017-11-10 08:06:57) > Clock framework has a provider API(clk_hw_set_rate_range) to set the > min/max rate of a clock. Use the same to set the boundaries for the > vexpress osc clock. > > Cc: Michael Turquette > Cc: Stephen Boyd

Re: [PATCH] clk: versatile: add min/max rate boundaries for vexpress osc clock

2018-03-16 Thread Stephen Boyd
Quoting Sudeep Holla (2018-02-19 07:55:37) > On Fri, Nov 10, 2017 at 4:06 PM, Sudeep Holla wrote: > > Clock framework has a provider API(clk_hw_set_rate_range) to set the > > min/max rate of a clock. Use the same to set the boundaries for the > > vexpress osc clock. > > > >

Re: [PATCH v12 17/22] selftests/vm: associate key on a mapped page and detect access violation

2018-03-16 Thread Dave Hansen
On 02/21/2018 05:55 PM, Ram Pai wrote: > detect access-violation on a page to which access-disabled > key is associated much after the page is mapped. Looks fine to me. Did this actually find a bug for you? Acked-by: Dave Hansen

Re: [PATCH 0/7] clk: add helper functions for managing clk_onecell_data

2018-03-16 Thread Stephen Boyd
Quoting David Lechner (2018-01-04 16:38:05) > I am writing some clock drivers that use struct clk_onecell_data a few > times, so I decided to write a helper function to allocate the memory > since it is a two step process and can be tedious. Then I noticed that > mediatek already had such a helper

Re: [PATCH v12 16/22] selftests/vm: fix an assertion in test_pkey_alloc_exhaust()

2018-03-16 Thread Dave Hansen
On 02/21/2018 05:55 PM, Ram Pai wrote: > +static inline int arch_reserved_keys(void) > +{ > +#if defined(__i386__) || defined(__x86_64__) /* arch */ > + return NR_RESERVED_PKEYS; > +#elif __powerpc64__ /* arch */ > + if (sysconf(_SC_PAGESIZE) == 4096) > + return

Re: [PATCH v12 15/22] selftests/vm: powerpc implementation to check support for pkey

2018-03-16 Thread Dave Hansen
On 02/21/2018 05:55 PM, Ram Pai wrote: > #define PAGE_SIZE (0x1UL << 16) > -static inline int cpu_has_pku(void) > +static inline bool is_pkey_supported(void) > { > - return 1; > + /* > + * No simple way to determine this. > + * lets try allocating a key and see if it succeeds.

Re: [PATCH 2/2] watchdog: aspeed: Allow configuring for alternate boot

2018-03-16 Thread Guenter Roeck
On Wed, Mar 14, 2018 at 02:53:13PM -0500, Eddie James wrote: > > > On 03/09/2018 04:06 PM, Guenter Roeck wrote: > >On Fri, Mar 09, 2018 at 03:58:20PM -0600, Eddie James wrote: > >>From: Milton Miller > >> > >>Allow the device tree to specify a watchdog to fallover to > >>the

Re: [PATCH v12 14/22] selftests/vm: clear the bits in shadow reg when a pkey is freed.

2018-03-16 Thread Dave Hansen
On 02/21/2018 05:55 PM, Ram Pai wrote: > diff --git a/tools/testing/selftests/vm/protection_keys.c > b/tools/testing/selftests/vm/protection_keys.c > index c4c73e6..e82bd88 100644 > --- a/tools/testing/selftests/vm/protection_keys.c > +++ b/tools/testing/selftests/vm/protection_keys.c > @@ -586,7

Re: [PATCH] fs: don't flush pagecache when expanding block device

2018-03-16 Thread Andrew Morton
On Fri, 16 Mar 2018 15:55:53 +0900 shunki-fujita wrote: > When changing the size of a block device, its all caches are freed. > It's necessary on shrinking to prevent spurious I/Os to the disappeared > region. > However, on expanding, such kind of I/Os doesn't

Re: [PATCH v12 13/22] selftests/vm: powerpc implementation for generic abstraction

2018-03-16 Thread Dave Hansen
On 02/21/2018 05:55 PM, Ram Pai wrote: > static inline u32 pkey_to_shift(int pkey) > { > +#if defined(__i386__) || defined(__x86_64__) /* arch */ > return pkey * PKEY_BITS_PER_PKEY; > +#elif __powerpc64__ /* arch */ > + return (NR_PKEYS - pkey - 1) * PKEY_BITS_PER_PKEY; > +#endif /*

  1   2   3   4   5   6   7   8   9   10   >