Re: [PATCH] ARM: dts: sunxi: Fix PMU compatible strings

2018-12-07 Thread Maxime Ripard
On Thu, Dec 06, 2018 at 01:11:42PM -0600, Rob Herring wrote: > "arm,cortex-a15-pmu" is not a valid fallback compatible string for an > Cortex-A7 PMU, so drop it. > > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Signed-off-by: Rob Herring Applied, thanks! Maxime -- Max

[PATCH v3 07/10] drm/bridge: cdns: Separate DSI and D-PHY configuration

2018-12-07 Thread Maxime Ripard
The current configuration of the DSI bridge and its associated D-PHY is intertwined. In order to ease the future conversion to the phy framework for the D-PHY part, let's split the configuration in two. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/cdns-dsi.c | 96

Re: [PATCH v2 2/3] arm64: dts: allwinner: a64: Add A64 CSI controller

2018-12-06 Thread Maxime Ripard
On Thu, Dec 06, 2018 at 06:07:59PM +0100, Michael Nazzareno Trimarchi wrote: > On Thu, Dec 6, 2018 at 4:34 PM Maxime Ripard > wrote: > > On Thu, Dec 06, 2018 at 06:53:05PM +0530, Jagan Teki wrote: > > > Allwinner A64 CSI controller has similar features as like in > > &

Re: [PATCH v2 3/3] arm64: dts: allwinner: a64: Add pinmux setting for CSI MCLK on PE1

2018-12-06 Thread Maxime Ripard
8,6 +538,11 @@ > function = "csi0"; > }; > > + csi_mclk_pin: csi-mclk { > + pins = "PE1"; > + function = "csi0"; > + }; > + We're

Re: [PATCH v2 2/3] arm64: dts: allwinner: a64: Add A64 CSI controller

2018-12-06 Thread Maxime Ripard
< CLK_CSI_SCLK>, > + < CLK_DRAM_CSI>; > + clock-names = "bus", "mod", "ram"; > + resets = < RST_BUS_CSI>; > + pinctrl-names = "default"; > + pinctrl-0 = <_pins>; > + assigned-clocks = < CLK_CSI_SCLK>; > + assigned-clock-rates = <3>; That should be enforced in the driver. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH v4 07/22] drm/sun4i: frontend: Configure and enable YUV to RGB CSC when needed

2018-12-05 Thread Maxime Ripard
are copied over from the backend > code. Because of module inter-dependency, we can't have the frontend use > these coefficients from the backend directly. > > Signed-off-by: Paul Kocialkowski Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engi

Re: [PATCH v4 04/22] drm/sun4i: frontend: Pass DRM format info to input format helpers

2018-12-05 Thread Maxime Ripard
t; Pass the DRM format info structure directly instead to all helpers > related to configuring the input format, since it's available to the > caller. Also rename the input format in the caller function to keep > things consistent. > > Signed-off-by: Paul Kocialkowski Acked-by: Maxi

Re: [PATCH v3 09/21] drm/sun4i: frontend: Add support for planar YUV input formats

2018-12-04 Thread Maxime Ripard
For the input > sequence part, no configuration is required for planar YUV formats so > zero is returned in that case. > > Signed-off-by: Paul Kocialkowski Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH 0/2] pinctrl: sunxi: a64: Drop numeral from csi0/ts0

2018-12-03 Thread Maxime Ripard
sn't make sense. > > I'd like to do the rename now while we don't have users nor support for > these two controllers. I planned to send this together with CSI support > for the A64, but Jagan beat me to it, so here it is. Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Bootli

Re: [PATCH 14/15] ARM: dts: sun8i: r40: Add RTC device node

2018-11-28 Thread Maxime Ripard
ces to the LOSC. > > Signed-off-by: Chen-Yu Tsai Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH 15/15] arm64: dts: allwinner: a64: Fix up RTC device node and clock references

2018-11-28 Thread Maxime Ripard
OSC and LOSC are also fixed. > > Signed-off-by: Chen-Yu Tsai Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH 09/14] regulator: dts: add full voltage range to LDO4 on the Lime2

2018-11-28 Thread Maxime Ripard
On Tue, Nov 27, 2018 at 10:38:52AM +0100, Maxime Ripard wrote: > On Mon, Nov 26, 2018 at 05:27:50PM +0200, Priit Laes wrote: > > From: Olliver Schinagl > > > > With commit b43776d65a33b46092 ("ARM: dts: sunxi: Use axp209.dtsi for > > Olinuxino Lime2")

Re: [PATCH 2/2] clk: core: link consumer with clock driver

2018-11-27 Thread Maxime Ripard
t fine. However, if you have clocks providers chained, for example with one oscillator, a clock controller, and a device, the link will be created between the device and the controller, but there will be no link between the controller and the oscillator. Adding a link in __clk_init_parent looks like it would address that case. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [linux-sunxi] Re: [PATCH v4 08/26] drm/sun4i: sun6i_mipi_dsi: Fix VBP size calculation

2018-11-27 Thread Maxime Ripard
'd rather focus on one thing for now. When your A64 DSI series will be in, then you can focus on the burst mode. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH v4 08/26] drm/sun4i: sun6i_mipi_dsi: Fix VBP size calculation

2018-11-27 Thread Maxime Ripard
On Tue, Nov 20, 2018 at 09:55:42PM +0530, Jagan Teki wrote: > On Tue, Nov 20, 2018 at 9:27 PM Maxime Ripard > wrote: > > > > On Thu, Nov 15, 2018 at 11:19:53PM +0530, Jagan Teki wrote: > > > On Thu, Nov 15, 2018 at 3:26 PM Maxime Ripard > > > wrote: > &

Re: [PATCH v2 03/12] drm/sun4i: sun6i_mipi_dsi: Setup burst mode timings

2018-11-27 Thread Maxime Ripard
On Tue, Nov 20, 2018 at 09:52:23PM +0530, Jagan Teki wrote: > On Tue, Nov 20, 2018 at 9:15 PM Maxime Ripard > wrote: > > > > On Mon, Nov 19, 2018 at 04:30:37PM +0530, Jagan Teki wrote: > > > On Mon, Nov 19, 2018 at 2:00 PM Maxime Ripard > > > wrote: > &

Re: [PATCH 10/14] regulator: dts: set proper lradc vref on OLinuXino Lime2

2018-11-27 Thread Maxime Ripard
On Tue, Nov 27, 2018 at 05:41:10PM +0800, Chen-Yu Tsai wrote: > On Tue, Nov 27, 2018 at 5:37 PM Maxime Ripard > wrote: > > > > On Mon, Nov 26, 2018 at 05:27:51PM +0200, Priit Laes wrote: > > > From: Olliver Schinagl > > > > > > The lradc'

Re: [PATCH 09/14] regulator: dts: add full voltage range to LDO4 on the Lime2

2018-11-27 Thread Maxime Ripard
ator-always-on; > + regulator-min-microvolt = <125>; > + regulator-max-microvolt = <330>; > + regulator-name = "vdd-io-pg"; As we discussed on the U-Boot ML already, this shouldn't be made always-on but tied to the consumer device (the pinctrl one) instead. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH 10/14] regulator: dts: set proper lradc vref on OLinuXino Lime2

2018-11-27 Thread Maxime Ripard
renced properly. > > Signed-off-by: Olliver Schinagl > Signed-off-by: Priit Laes I'm not sure why that patch is part of this series, but I applied it. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH 06/14] regulator: axp20x: add software based soft_start for AXP209 LDO3

2018-11-27 Thread Maxime Ripard
equest. > + */ > + usleep_range(1000, 5000); > + ret |= regulator_enable_regmap(rdev); > + ret |= regulator_set_voltage_sel_regmap(rdev, v_out); > + > + return ret; > +

Re: [PATCH v2 32/43] drm/sun4i: Pass modifier to backend and frontend format support helpers

2018-11-27 Thread Maxime Ripard
gt; each helper. > > Signed-off-by: Paul Kocialkowski Applied, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH v2 10/43] drm/fourcc: Add format helpers for checking YUV planes disposition

2018-11-27 Thread Maxime Ripard
; iterated from the list. > > Signed-off-by: Paul Kocialkowski Reviewed-by: Maxime Ripard Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH v2 03/43] drm/sun4i: Add TODO comment about supporting scaling with the backend

2018-11-27 Thread Maxime Ripard
> Signed-off-by: Paul Kocialkowski Applied, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH] soc: sunxi: Change to use DEFINE_SHOW_ATTRIBUTE macro

2018-11-22 Thread Maxime Ripard
On Thu, Nov 22, 2018 at 07:59:41AM -0500, Yangtao Li wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li Applied, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Descrip

Re: [PATCH v2 8/9] phy: Add Cadence D-PHY support

2018-11-21 Thread Maxime Ripard
Hi Sakari, On Mon, Nov 19, 2018 at 11:24:20PM +0200, Sakari Ailus wrote: > Hi Maxime, > > On Tue, Nov 06, 2018 at 03:54:20PM +0100, Maxime Ripard wrote: > > Cadence has designed a D-PHY that can be used by the, currently in tree, > > DSI bridge (DRM), CSI Transceiver a

Re: [PATCH v4 03/26] clk: sunxi-ng: Add check for maximum rate to NKM PLLs

2018-11-20 Thread Maxime Ripard
haven't really tested? Why are you sending them then? > Apart from this, any idea about this issue where SUN4I_TCON0_DCLK_REG > will only work with div upto 6 on A64 DSI panels[1], did you find the > same issue on A33? IIRC my panel was falling into the case where the divider was 4, s

Re: [PATCH 5/6] ARM: dts: sunxi: Add all CPUs in cooling maps

2018-11-19 Thread Maxime Ripard
ly one CPU in the > cooling maps, as the hardware doesn't have any such limitations. > > Update cooling maps to include all devices affected by individual trip > points. > > Signed-off-by: Viresh Kumar Applied, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel en

Re: [PATCH v2 0/2] media: cedrus: Add H264 decoding support

2018-11-19 Thread Maxime Ripard
. Your driver would > always use the lists in v4l2_ctrl_h264_slice_param, while the Rockchip > VPU would ignore them, use the ones in v4l2_ctrl_h264_decode_param and > perform the per-slice modifications on its own. I guess that would work, yep Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH] drm/fb-helper: Blacklist writeback when adding connectors to fbdev

2018-11-19 Thread Maxime Ripard
to solve this. > > Signed-off-by: Paul Kocialkowski Reviewed-by: Maxime Ripard Tested-by: Maxime Ripard Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH v2 06/12] drm/sun4i: sun6i_mipi_dsi: Probe tcon0 during dsi_bind

2018-11-19 Thread Maxime Ripard
anel) > @@ -1014,6 +1016,11 @@ static int sun6i_dsi_bind(struct device *dev, struct > device *master, > > dsi->drv = drv; > > + if (!tcon0) > + return -EPROBE_DEFER; You can't fall in that condition. The component framework won't call bind unless

Re: [PATCH v2 05/12] drm/sun4i: tcon: Export get tcon0 routine

2018-11-19 Thread Maxime Ripard
on explictly, better export the existing > sun5i_get_tcon0 so-that the relevant interface can reuse. That's not the name of the function you export. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH v2 04/12] drm/sun4i: sun6i_mipi_dsi: Simplify drq set to support all modes

2018-11-19 Thread Maxime Ripard
6I_DSI_TCON_DRQ_REG, val); > + regmap_write(dsi->regs, SUN6I_DSI_TCON_DRQ_REG, > + SUN6I_DSI_TCON_DRQ_ENABLE_MODE | > + SUN6I_DSI_TCON_DRQ_SET(sun6i_dsi_get_drq(dsi, mode))); On top of that, you now enable the DRQ stuff all the time, while it was conditional before. -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH v2 03/12] drm/sun4i: sun6i_mipi_dsi: Setup burst mode timings

2018-11-19 Thread Maxime Ripard
n50iw1/de_dsi.c) > > dsi_hsa = 0; > dsi_hbp = 0; > dsi_hact = x*dsi_pixel_bits[format]/8; > dsi_hblk = dsi_hact; > dsi_hfp = 0; > dsi_vblk = 0; > > Signed-off-by: Jagan Teki How is that matching the code you have in the rest of your patch? Maxime -- Maxime

Re: [PATCH v2 01/12] drm/sun4i: sun6i_mipi_dsi: Compute burst mode loop N1 instruction delay

2018-11-19 Thread Maxime Ripard
; > Signed-off-by: Jagan Teki *why* are you doing this? What is it fixing? on which devices? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH v0 0/2] Initial Allwinner T3 support.

2018-11-15 Thread Maxime Ripard
e Allwinner R40 for In-Car > Entertainment usage. That series looks good, thanks! The only thing that would need to be reworked is your Signed-off-by name, which (I guess?) should be written the same way than in your Copyright info. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and

Re: [PATCH v4 08/26] drm/sun4i: sun6i_mipi_dsi: Fix VBP size calculation

2018-11-15 Thread Maxime Ripard
tion is quite sparse, and a MIPI-DSI analyzer is way too expensive, I'd really like to have at least what each of these commits are actually fixing, and what symptoms each of these were causing, and not just "the BSP does it". Having some datasheet for the panels you had working would help too. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH] arm64: sunxi: Enable REGMAP_MMIO to fix linker error

2018-11-14 Thread Maxime Ripard
> select GENERIC_IRQ_CHIP > select PINCTRL > + select REGMAP_MMIO > select RESET_CONTROLLER > help > This enables support for Allwinner sunxi based SoCs like the A64. The sunxi_sram driver has a Kconfig symbol of its own now, it would make more

Re: [PATCH v6 4/4] arm64: defconfig: Enable PWM_SUN4I

2018-11-13 Thread Maxime Ripard
On Tue, Nov 13, 2018 at 05:45:35PM +0530, Jagan Teki wrote: > Allwinner PWM support need for ARM64 Allwinner SoC's > which used pwms, builds it as module. > > Signed-off-by: Jagan Teki Applied all 4 patches, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engin

Re: [PATCH] arm64: dts: allwinner: a64: Add mali node

2018-11-13 Thread Maxime Ripard
"arm,mali-400"; You should document that new compatible string. The patch looks good otherwise, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

[PATCH 5/5] DO NOT MERGE: ARM: dts: bananapi: Add Camera support

2018-11-13 Thread Maxime Ripard
Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/sun7i-a20-bananapi.dts | 98 +- 1 file changed, 98 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts index 70dfc4ac0bb5..18dbff9f1ce9 100644 --- a/arch/arm

[PATCH 4/5] ARM: dts: sun7i: Add CSI0 controller

2018-11-13 Thread Maxime Ripard
The CSI controller embedded in the A20 can be supported by our new driver. Let's add it to our DT. Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/sun7i-a20.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20

Re: [PATCH 15/15] arm64: dts: allwinner: a64: bananapi-m64: Add Bluetooth device node

2018-11-08 Thread Maxime Ripard
dds the missing > LPO clock on the WiFi side. There is also a PCM connection for Bluetooth, > but this is not covered here. > > Signed-off-by: Chen-Yu Tsai Acked-by: Maxime Ripard Thanks for figuring this out! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://

[PATCH v2 9/9] drm/bridge: cdns: Convert to phy framework

2018-11-06 Thread Maxime Ripard
Now that we have everything we need in the phy framework to allow to tune the phy parameters, let's convert the Cadence DSI bridge to that API instead of creating a ad-hoc driver for its phy. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/cdns-dsi.c | 485

Re: [PATCH 01/10] drm/sun4i: sun6i_mipi_dsi: Compute burst mode loop N1 instruction delay

2018-11-05 Thread Maxime Ripard
((mode->clock / 1000) * 8)) - 50; > + else > + delay = 50 - 1; Apart from the other comments, I'd really prefer to have a function here that would take the mipi_dsi_device and compute the delay. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCHv2] ARM: dts: sun8i-h3: Add dts for the Mapleboard MP130

2018-11-05 Thread Maxime Ripard
pins = "PL10"; > + function = "gpio_out"; > + }; > + > + sw_r_pio: key_pins { > + pins = "PL3", "PL4"; > + function = "gpio_in"; > + }; > +}; You don't need these nodes at all.

Re: [PATCH] dts: sun8i-h3: Add DTS for Mapleboard MP130

2018-10-29 Thread Maxime Ripard
uot;PL10"; > + function = "gpio_out"; > + }; > + > + sw_r_pio: key_pins { > + pins = "PL3", "PL4"; > + function = "gpio_in"; > + }; > +}; > + > + { > + pinctrl-names = "

Re: [PATCH v3 06/25] drm/sun4i: sun6i_mipi_dsi: Add DSI Generic short write 2 param transfer

2018-10-29 Thread Maxime Ripard
lar transfer type may process properly. > > Signed-off-by: Jagan Teki > Tested-by: Jagan Teki I'm not sure why you have a Tested-by tag here. Of course we're expecting you to test your patches before sending them. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineerin

Re: [PATCH v2 14/15] arm64: dts: allwinner: a64: Add DSI pipeline

2018-10-29 Thread Maxime Ripard
On Thu, Oct 25, 2018 at 06:51:14PM +0530, Jagan Teki wrote: > On Wed, Oct 24, 2018 at 11:40 PM Maxime Ripard > wrote: > > > > On Tue, Oct 23, 2018 at 09:20:34PM +0530, Jagan Teki wrote: > > > The A64 has a MIPI-DSI block which is similar to A31 > > > withou

Re: [PATCH v2 13/15] dt-bindings: sun6i-dsi: Add compatible for A64 DPHY

2018-10-29 Thread Maxime Ripard
On Thu, Oct 25, 2018 at 06:22:51PM +0530, Jagan Teki wrote: > On Wed, Oct 24, 2018 at 11:39 PM Maxime Ripard > wrote: > > > > On Tue, Oct 23, 2018 at 09:20:33PM +0530, Jagan Teki wrote: > > > The MIPI DSI PHY HDMI controller on Allwinner A64 is similar > > > on

Re: [PATCH] ARM: dts: sun8i-a83t-tbs-a711: Change MMC0 bus-width to 4

2018-10-24 Thread Maxime Ripard
On Mon, Oct 22, 2018 at 06:43:51PM +0200, meg...@megous.com wrote: > From: Ondrej Jirman > > The actual hardware has 4 data lines. Use them. > > Signed-off-by: Ondrej Jirman Queued for 4.21, thanks Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v5 0/2] Neutis N5 support

2018-10-16 Thread Maxime Ripard
e full license text > - compatible: "emlid,neutis-n5" instead of "emlid,emlid-neutis-n5" > > Changes from v4 (15 oct 2018): > - fix dt-bindings commit prefix > - update license header for dts files > - make interfaces be alphabetically in devboard dts file

Re: [PATCH] pinctrl: sunxi: Fix a memory leak in 'sunxi_pinctrl_build_state()'

2018-10-16 Thread Maxime Ripard
he JAILLET Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v4 1/2] arm64: dts: allwinner: new board - Emlid Neutis N5

2018-10-12 Thread Maxime Ripard
on/devicetree/bindings/arm/sunxi.txt > +++ b/Documentation/devicetree/bindings/arm/sunxi.txt > @@ -19,3 +19,5 @@ using one of the following compatible strings: >allwinner,sun9i-a80 >allwinner,sun50i-a64 >nextthing,gr8 > + emlid,neutis-n5 > + emlid,neutis-n5-devboard > > Is this right place for the neutis compatibles? No, those are for SoCs compatible. I'm not sure we ever created a board compatible files. -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 2/2] ASoC: max98927: Add reset-gpio support

2018-10-12 Thread Maxime Ripard
le to cover all the cases anyhow, at least without breaking the compatibility (again). But I also see your point, and you're right that converting everyone to a gpio-reset node will not happen (even though I'd still really like to have that binding). What about having a function that would be

Re: [PATCH v3] arm64: new board - Emlid Neutis N5

2018-10-12 Thread Maxime Ripard
child node within uart1 for a serdev driver. > > Is there no such driver yet for your Bluetooth chipset, or did you not > > yet check? > > Got it. I haven't checked a serdev driver. > > Maxim, the SoM can't be run without a motherboard. According to your last > mess

Re: [PATCH v3] arm64: new board - Emlid Neutis N5

2018-10-11 Thread Maxime Ripard
d in the big dts Makefile refactoring? :) I don't really know what is that big dts Makefile refactoring you're mentionning, but I don't think we can merge dtso before having the DT connectors in place. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 2/4] drm/panel: simple: Add support for the Lemaker BL035 3.5" LCD

2018-10-10 Thread Maxime Ripard
, { > .compatible = "kyo,tcg121xglp", > .data = _tcg121xglp, > + }, { > + .compatible = "lemaker,bl035", > + .data = _bl035, You should document that new compatible. Also, where is this name coming from? Is it the name it's sold under? something you came up with? Thanks, Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v3] arm64: new board - Emlid Neutis N5

2018-10-10 Thread Maxime Ripard
> + regulator-max-microvolt = <330>; > + }; > + > + wifi_pwrseq: wifi_pwrseq { > + compatible = "mmc-pwrseq-simple"; > + pinctrl-names = "default"; > + reset-gpios = < 2 7 GPIO_ACTIVE_LOW>; /* PC7 */ > + post-power-on-delay-ms = <200>; > + }; > +}; > + > + { > + vmmc-supply = <_vcc3v3>; > + vqmmc-supply = <_vcc3v3>; > + mmc-pwrseq = <_pwrseq>; > + bus-width = <4>; > + non-removable; > + status = "okay"; > + > + brcmf: wifi@1 { > + reg = <1>; > + compatible = "brcm,bcm4329-fmac"; > + interrupt-parent = <_pio>; > + interrupts = <0 5 IRQ_TYPE_LEVEL_LOW>; /* PL5 */ > + interrupt-names = "host-wake"; > + }; > +}; > + > + { > + pinctrl-names = "default"; > + pinctrl-0 = <_8bit_pins>; > + vmmc-supply = <_vcc3v3>; > + bus-width = <8>; > + non-removable; > + cap-mmc-hw-reset; > + status = "okay"; > +}; > + > + { > + pinctrl-names = "default"; > + pinctrl-0 = <_pins>, <_rts_cts_pins>; > + status = "okay"; > +}; I guess this is for bluetooth? Have you tested serdev drivers? Also, I have a general comments, and it really depends on what your intention about the board ecosystem is. Do you expect the SOM to be swappable in multiple boards, or do you expect to send it as something that is just fixed into a daughter board? In the former case, you probably want to use overlays instead. In the latter, you're fine. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v2 10/29] drm/sun4i: Rename DE2 registers related macros

2018-10-09 Thread Maxime Ripard
On Mon, Oct 08, 2018 at 04:28:41PM +0200, Jernej Škrabec wrote: > Dne ponedeljek, 08. oktober 2018 ob 12:18:28 CEST je Maxime Ripard napisal(a): > > Hi, > > > > On Sun, Oct 07, 2018 at 11:38:46AM +0200, Jernej Skrabec wrote: > > > In preparation to introduce D

Re: [PATCH 1/2] arm64: dts: allwinner: Olimex A64-OLinuXino: enable eMMC.

2018-10-05 Thread Maxime Ripard
variant was created > > way after the original LIME2, with a separate name. > > What about the idea of keeping the current dt for the most featureful > variant and creating new dts for the other two? > > That would make it so that no one's device stops working and would > have

Re: [PATCH v3] arm64: new board - Emlid Neutis N5

2018-10-05 Thread Maxime Ripard
target to dtb makefile > - new vendor prefix - emlid > > Signed-off-by: Aleksandr Aleksandrov > Cc: Maxime Ripard It's still not the correct recipient list, and I have no idea where the v2 went, or what did you change between v1, v2 and v3. Maxime -- Maxime Ripard, Bootlin Embedded

Re: linux-next: Signed-off-by missing for commits in the arm-soc tree

2018-10-04 Thread Maxime Ripard
i: h3-h5: ir register size should be the whole > memory block") > > are missing a Signed-off-by from their committer. I just sent a new PR with the SoB this time (and I just learnt that git rebase rewrites the committer...) Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [linux-sunxi] Re: [PATCH 08/12] drm/sun4i: sun6i_mipi_dsi: Refactor vertical video start delay

2018-10-02 Thread Maxime Ripard
On Mon, Oct 01, 2018 at 01:25:59PM +0530, Jagan Teki wrote: > On Saturday 29 September 2018 08:57 PM, Maxime Ripard wrote: > > On Thu, Sep 27, 2018 at 11:03:19PM +0530, Jagan Teki wrote: > > > On Thu, Sep 27, 2018 at 10:44 PM Maxime Ripard > > > wrote: > > > &

Re: [PATCH 1/2] arm64: dts: allwinner: Olimex A64-OLinuXino: enable eMMC.

2018-10-02 Thread Maxime Ripard
On Sat, Sep 29, 2018 at 01:51:02PM -0300, Rodrigo Exterckötter Tjäder wrote: > On Sat, Sep 29, 2018 at 12:47 PM Maxime Ripard > wrote: > > > > On Thu, Sep 27, 2018 at 11:49:20AM -0300, Rodrigo Exterckötter Tjäder wrote: > > > On Thu, Sep 27, 2018 at 5:17 AM

Re: [PATCH 1/2] arm64: dts: allwinner: Olimex A64-OLinuXino: enable eMMC.

2018-09-29 Thread Maxime Ripard
On Thu, Sep 27, 2018 at 11:49:20AM -0300, Rodrigo Exterckötter Tjäder wrote: > On Thu, Sep 27, 2018 at 5:17 AM Maxime Ripard > wrote: > > > > On Tue, Sep 25, 2018 at 02:47:59PM -0300, Rodrigo Exterckötter Tjäder wrote: > > > On Tue, Sep 25, 2018 at 6:01 AM Maxime Ripar

Re: [PATCH] ARM: dts: sunxi: h3-h5: Add Bananapi M2+ v1.2 device trees

2018-09-27 Thread Maxime Ripard
ed as well. > > Signed-off-by: Chen-Yu Tsai Acked-by: Maxime Ripard Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 05/12] drm/sun4i: sun6i_mipi_dsi: Add DSI Generic short write 2 param transfer

2018-09-27 Thread Maxime Ripard
them by alphabetical order. > ret = sun6i_dsi_dcs_write_short(dsi, msg); > @@ -885,6 +886,8 @@ static ssize_t sun6i_dsi_transfer(struct mipi_dsi_host > *host, > } > > default: > + dev_err(dsi->dev, "unsupported message

Re: [PATCH 12/12] arm64: dts: allwinner: bananapi-m64: Bananapi S070WV20-CT16 DSI panel

2018-09-27 Thread Maxime Ripard
ble-active-high; > + }; > + > + backlight_dsi: backlight-dsi { > + compatible = "pwm-backlight"; > + pwms = <_pwm 0 5 PWM_POLARITY_INVERTED>; > + brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>; The brightness levels should be increasing linearly from a user point of view. Usually, with a PWM backlight, a quadratic rule works much better. MMaxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 11/12] arm64: dts: allwinner: a64: Add DSI pipeline

2018-09-27 Thread Maxime Ripard
lls = <1>; > + #size-cells = <0>; > + reg = <0>; > + > + dsi_in_tcon0: endpoint { > + remote-endpoint = > <_out_dsi>; > + }; > + }; > + }; > + }; > + > + dphy: d-phy@1ca1000 { > + compatible = "allwinner,sun6i-a31-mipi-dphy"; You should add an A64 compatible there. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 08/12] drm/sun4i: sun6i_mipi_dsi: Refactor vertical video start delay

2018-09-27 Thread Maxime Ripard
> + u32 start_delay; > + > + start_delay = mode->vtotal - vfp + 1; > + if (start_delay > mode->vtotal) > + start_delay -= mode->vtotal; > + > + if (!start_delay) > + start_delay = 1; > + I guess that it's actuall

Re: [PATCH 07/12] drm/sun4i: sun6i_mipi_dsi: Fix TCON DRQ set bits

2018-09-27 Thread Maxime Ripard
for just the front porch, unlike what your commit log is saying, and unlike what allwinner's code is saying. So this deserves some explanation. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 06/12] drm/sun4i: sun6i_mipi_dsi: Fix VBP size calculation

2018-09-27 Thread Maxime Ripard
SUN6I_DSI_BASIC_SIZE0_VBP(mode->vtotal - > +mode->vsync_end)); Is it purely theoretical, or did you find some source that back that? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 1/2] arm64: dts: allwinner: Olimex A64-OLinuXino: enable eMMC.

2018-09-27 Thread Maxime Ripard
On Tue, Sep 25, 2018 at 02:47:59PM -0300, Rodrigo Exterckötter Tjäder wrote: > On Tue, Sep 25, 2018 at 6:01 AM Maxime Ripard > wrote: > > We can't really do that, unfortunately. If the device tree name was to > > change for a given board, we'd break all the build systems

Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

2018-09-27 Thread Maxime Ripard
at is the status of adding this driver to say staging? IIRC, we tried to get it into staging, and we got told that it was too nice for staging at this point. So we're basically stuck somewhere between staging and !staging, with the driver being too nice for the former, and not nice enough for the latter :) Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 2/2] arm64: dts: allwinner: Olimex A64-OLinuXino: fix ethernet

2018-09-26 Thread Maxime Ripard
On Wed, Sep 26, 2018 at 12:14:15PM -0300, Rodrigo Exterckötter Tjäder wrote: > On Wed, Sep 26, 2018 at 6:46 AM Maxime Ripard > wrote: > > There's no need to be so specific though :) > > > > Something like that would work: > > > > arm64: dts: allwinner:

Re: [PATCH 2/2] arm64: dts: allwinner: Olimex A64-OLinuXino: fix ethernet

2018-09-26 Thread Maxime Ripard
Hi! On Fri, Sep 21, 2018 at 12:25:53PM -0300, Rodrigo Exterckötter Tjäder wrote: > On Fri, Sep 21, 2018 at 11:30 AM Maxime Ripard > wrote: > > On Wed, Sep 19, 2018 at 11:19:36AM -0300, Rodrigo Exterckötter Tjäder wrote: > > > Without "allwinner,tx-delay-ps = <600

Re: [PATCH 1/2] arm64: dts: allwinner: Olimex A64-OLinuXino: enable eMMC.

2018-09-25 Thread Maxime Ripard
On Fri, Sep 21, 2018 at 11:54:07AM -0300, Rodrigo Exterckötter Tjäder wrote: > On Fri, Sep 21, 2018 at 11:28 AM Maxime Ripard > wrote: > > Expanding a bit more that commit log would be helpful. What is the > > eMMC connected to that board? Do all versions have it? Which mode

Re: [PATCH 2/2] arm64: dts: allwinner: Olimex A64-OLinuXino: fix ethernet

2018-09-21 Thread Maxime Ripard
as a bit more explicit. What is a DTP? How did you come up with that value? What is the value used by Allwinner/Olimex, and why did you use another one if you did? Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH 1/2] arm64: dts: allwinner: Olimex A64-OLinuXino: enable eMMC.

2018-09-21 Thread Maxime Ripard
it? Which modes are supposed to be supported, and which one have been tested? Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH] drm: sun4i: Fix a uninitialized variable warning.

2018-09-21 Thread Maxime Ripard
On Wed, Sep 19, 2018 at 05:01:32PM +0800, zhong jiang wrote: > On 2018/9/19 16:47, Maxime Ripard wrote: > > On Tue, Sep 18, 2018 at 03:25:20PM +0800, zhong jiang wrote: > >> Fix the following compile warning: > >> > >> drivers/gpu/drm/sun4i/sun4i_tcon

Re: [PATCH -next] pinctrl: sunxi: fix 'pctrl->functions' allocation in sunxi_pinctrl_build_state

2018-09-21 Thread Maxime Ripard
0e37f88d9ad8 ("ARM: sunxi: Add pinctrl driver for Allwinner SoCs") > Signed-off-by: YueHaibing Acked-by: Maxime Ripard Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH] drm: sun4i: Fix a uninitialized variable warning.

2018-09-19 Thread Maxime Ripard
> > Signed-off-by: zhong jiang I can't see any code path that would lead to an uninitialized usage of that variable. Which compiler produced that warning? I tried building it today with gcc 8.1.1, and I don't see that warning either. Maxime -- Maxime Ripard, Bootlin Embedded Linux a

[PATCH 09/10] phy: Add Cadence D-PHY support

2018-09-05 Thread Maxime Ripard
support available to all these drivers, without having to duplicate that code three times, let's create a generic phy framework driver. Signed-off-by: Maxime Ripard --- drivers/phy/Kconfig | 1 +- drivers/phy/Makefile| 1 +- drivers/phy/cadence/Kconfig | 13

[PATCH 10/10] drm/bridge: cdns: Convert to phy framework

2018-09-05 Thread Maxime Ripard
Now that we have everything we need in the phy framework to allow to tune the phy parameters, let's convert the Cadence DSI bridge to that API instead of creating a ad-hoc driver for its phy. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/cdns-dsi.c | 466

Re: [PATCH v4 03/11] dt-bindings: display: Add compatible for A64 DE2 display pipeline

2018-09-05 Thread Maxime Ripard
or A64 DE2 display pipeline. > > Signed-off-by: Jagan Teki > Reviewed-by: Rob Herring > [Icenowy: Refactor and also cover TCON1] > Signed-off-by: Icenowy Zheng Applied, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH v4 4/4] drm/sun4i: Enable DesignWare HDMI for SUN50I

2018-09-05 Thread Maxime Ripard
oading since arm32 DRM built as static. Uh? Why? We should fix this instead of working around it. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH v3 21/30] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor

2018-09-03 Thread Maxime Ripard
dressing. > > Maxime, should I drop the LE2BE conversion in SID driver? (I doubt > whether it will break compatibility.) This is exposed to the userspace, so no. Maxime > -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH v7 2/8] dt-bindings: Introduce interconnect provider bindings

2018-08-30 Thread Maxime Ripard
Hi, On Wed, Aug 29, 2018 at 03:33:29PM +0300, Georgi Djakov wrote: > On 08/27/2018 06:11 PM, Maxime Ripard wrote: > > On Fri, Aug 24, 2018 at 10:35:23AM -0500, Rob Herring wrote: > >> On Fri, Aug 24, 2018 at 9:51 AM Georgi Djakov > >> wrote: > >>> > &

Re: [PATCH 1/7] dt-bindings: Add DT bindings documentation for Allwinner Thermal Sensor Controller

2018-08-29 Thread Maxime Ripard
On Fri, Aug 24, 2018 at 09:59:21PM +0200, Emmanuel Vadot wrote: > > Hi, > > On Fri, 24 Aug 2018 16:58:40 +0200 > Maxime Ripard wrote: > > > Hi, > > > > On Mon, Aug 20, 2018 at 04:27:15PM +0200, Emmanuel Vadot wrote: > > > On Mon, 20 Aug 2

Re: [PATCH 1/7] dt-bindings: Add DT bindings documentation for Allwinner Thermal Sensor Controller

2018-08-29 Thread Maxime Ripard
On Sat, Aug 25, 2018 at 05:43:52PM +0200, Emmanuel Vadot wrote: > > Hi, > > On Fri, 24 Aug 2018 16:03:40 -0700 > Eduardo Valentin wrote: > > > On Fri, Aug 24, 2018 at 09:59:21PM +0200, Emmanuel Vadot wrote: > > > > > > Hi, > > > > >

Re: [PATCH v8 6/8] ARM: dts: sun7i-a20: Add Video Engine and reserved memory nodes

2018-08-28 Thread Maxime Ripard
y > pool has to be located in that area. Following Allwinner's decision in > downstream software, the last 96 MiB of the first 256 MiB of RAM are > reserved for this purpose. > > Signed-off-by: Paul Kocialkowski Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Bootlin Embedded L

Re: [PATCH v7 2/8] dt-bindings: Introduce interconnect provider bindings

2018-08-27 Thread Maxime Ripard
On Fri, Aug 24, 2018 at 10:35:23AM -0500, Rob Herring wrote: > On Fri, Aug 24, 2018 at 9:51 AM Georgi Djakov > wrote: > > > > Hi Maxime, > > > > On 08/20/2018 06:32 PM, Maxime Ripard wrote: > > > Hi Georgi, > > > > > > On T

Re: [PATCH v7 2/8] dt-bindings: Introduce interconnect provider bindings

2018-08-27 Thread Maxime Ripard
Hi! On Fri, Aug 24, 2018 at 05:51:37PM +0300, Georgi Djakov wrote: > Hi Maxime, > > On 08/20/2018 06:32 PM, Maxime Ripard wrote: > > Hi Georgi, > > > > On Tue, Aug 07, 2018 at 05:54:38PM +0300, Georgi Djakov wrote: > >>> There is also a patch seri

Re: [PATCH 1/7] dt-bindings: Add DT bindings documentation for Allwinner Thermal Sensor Controller

2018-08-24 Thread Maxime Ripard
Hi, On Mon, Aug 20, 2018 at 04:27:15PM +0200, Emmanuel Vadot wrote: > On Mon, 20 Aug 2018 16:07:37 +0200 > Maxime Ripard wrote: > > > On Mon, Aug 20, 2018 at 07:41:22AM -0600, Rob Herring wrote: > > > On Mon, Aug 20, 2018 at 5:17 AM Maxime Ripard > > > wrot

Re: [PATCH v7 2/8] dt-bindings: Introduce interconnect provider bindings

2018-08-20 Thread Maxime Ripard
Hi Georgi, On Tue, Aug 07, 2018 at 05:54:38PM +0300, Georgi Djakov wrote: > > There is also a patch series from Maxime Ripard that's addressing the > > same general area. See "dt-bindings: Add a dma-parent property". We > > don't need multiple ways to address des

Re: [PATCH 1/7] dt-bindings: Add DT bindings documentation for Allwinner Thermal Sensor Controller

2018-08-20 Thread Maxime Ripard
On Mon, Aug 20, 2018 at 07:41:22AM -0600, Rob Herring wrote: > On Mon, Aug 20, 2018 at 5:17 AM Maxime Ripard > wrote: > > > > On Sat, Aug 04, 2018 at 09:03:49AM +0200, Emmanuel Vadot wrote: > > > This patch adds documentation for Device-Tree bindings for the All

Re: [PATCH 1/2] ARM: dts: sunxi: Don't use cd-inverted in sun8i-r40-bananapi-m2-ultra

2018-08-20 Thread Maxime Ripard
On Wed, Aug 08, 2018 at 02:25:53AM +0300, Tuomas Tynkkynen wrote: > Another user of cd-inverted seems to have crept in. Switch it away from > cd-inverted to be consistent with other sunxi boards. > > Signed-off-by: Tuomas Tynkkynen Queued for 4.20, thanks! Maxime -- Maxime Rip

Re: [PATCH 2/2] arm64: dts: sunxi: Don't use cd-inverted in sun50i-a64-pinebook

2018-08-20 Thread Maxime Ripard
On Wed, Aug 08, 2018 at 02:25:54AM +0300, Tuomas Tynkkynen wrote: > Another user of cd-inverted seems to have crept in. Switch it away from > cd-inverted to be consistent with other sunxi boards. > > Signed-off-by: Tuomas Tynkkynen Queued for 4.20, thanks! Maxime -- Maxime Rip

Re: [PATCH 1/7] dt-bindings: Add DT bindings documentation for Allwinner Thermal Sensor Controller

2018-08-20 Thread Maxime Ripard
that doesn't have any driver implemented at the moment in Linux. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH v3 1/4] arm64: dts: allwinner: a64: Add SID node

2018-07-30 Thread Maxime Ripard
On Fri, Jul 27, 2018 at 01:52:02PM +0200, Emmanuel Vadot wrote: > The A64 have a SID controller which consist of EFUSE (starting at 0x200) > and three registers to read/write some of the protected efuses. > > Signed-off-by: Emmanuel Vadot Queued all 4 for 4.20, thanks! Maxime -- M

  1   2   3   4   5   6   7   8   9   10   >