Hi,
On Fri, 25 Mar 2005 17:29:56 -0500 (EST), linux-os
<[EMAIL PROTECTED]> wrote:
> Isn't it expensive of CPU time to call kfree() even though the
> pointer may have already been freed? I suggest that the check
> for a NULL before the call is much less expensive than calling
> kfree() and doing
On Fri, 25 Mar 2005, James Bottomley wrote:
> On Fri, 2005-03-25 at 14:38 +0900, Tejun Heo wrote:
> > We have users of scsi_do_req() other than scsi_wait_req() and they
> > use different done() functions to do different things. I've checked
> > other done functions and none uses contents inside
On Fri, Mar 25, 2005 at 11:12:39PM -0500, Len Brown wrote:
> I realize now I didn't answer your original question.
> The reason ACPI now depends on PM is that
> it makes it easier for us to do a more orderly shutdown --
> acpi registers as a device so it can do some stuff
> upon the PM device
Hi,
Here goes the second release candidate for v2.4.30.
It contains a bunch of security updates (ext2 mkdir leak, af_bluetooth range
checking, isofs corrupt media, load_elf_library DoS), an ia64 update, another
round of networking fixes, amongst others.
If nothing terrible shows up, this will
Hello, Jeff.
This is the updated version of mod15write workaround. Changes are
* sg list restoration on completion
* debug code to verify sg list doesn't get changed
* updated against the latest libata-dev-2.6
* more comments
I think the code is okay, but I left the debug code there
On Fri, 2005-03-25 at 23:39 +0100, Ingo Molnar wrote:
> * Lee Revell <[EMAIL PROTECTED]> wrote:
>
> > On Fri, 2005-03-25 at 15:59 +0100, Ingo Molnar wrote:
> > > i have released the -V0.7.41-10 Real-Time Preemption patch, which can be
> > > downloaded from the usual place:
> > >
> > >
On Fri, Mar 25, 2005 at 04:03:09PM -0800, Greg KH wrote:
>
> Oh, looks like pci express now has problems too, I'll go hit that one
> next...
Here's a fix for pci express. For some reason I don't think they are
using the driver model properly here, but I could be wrong...
thanks,
greg k-h
Hi Artem:
On Fri, Mar 25, 2005 at 04:08:20PM +, Artem B. Bityuckiy wrote:
>
> I'm working on cleaning-up the JFFS3 compression stuff. JFFS3 contains a
> number of compressors which actually shouldn't be there as they are
> platform-independent and generic. So we want to move them to the
On Fri, 25 Mar 2005 20:50:35 +0100, Jean Delvare <[EMAIL PROTECTED]> wrote:
> > > [EMAIL PROTECTED]:/sys/class/i2c-adapter/i2c-1# ls
> > > ./ ../ device@
> > > [EMAIL PROTECTED]:/sys/class/i2c-adapter/i2c-1# ls -l
> > > Segmentation fault
> >
> > What device is that, and which driver is handling
Something funky going on with ACPI on nForce2? NFS is no go either.
Linux version 2.6.12-rc1-mm3 ([EMAIL PROTECTED]) (gcc version 3.3.4) #2
PREEMPT Fri Mar 25 14:30:56 EST 2005
[snip ...]
ACPI: Subsystem revision 20050309
ACPI: Interpreter enabled
ACPI: Using IOAPIC for interrupt routing
ACPI:
On Fri, 2005-03-25 at 21:57, Jason Uhlenkott wrote:
> On Fri, Mar 25, 2005 at 09:24:21PM -0500, Len Brown wrote:
> > What bad things happen if you define CONFIG_PM on SN2?
>
> None, other than slightly enlarging the kernel with some
> suspend/resume stuff we don't care about. It's always been
>
* Hua Zhong ([EMAIL PROTECTED]) wrote:
> > int bt_sock_unregister(int proto)
> > {
> > - if (proto >= BT_MAX_PROTO)
> > + if (proto < 0 || proto >= BT_MAX_PROTO)
> > return -EINVAL;
>
> Just curious: would it be better to say
>
> if ((unsigned int)proto >= BT_MAX_PTORO)
the
H. Peter Anvin wrote:
Phil Lougher wrote:
Making readdir return '.' and '..' is trivially easy, as all the
required information to fake '.' and '..' entries are present.
The lack of '.' and '..' entries hasn't caused any problems despite
cramfs/squashfs being used for a large number of years. I'm
On Mar 25, 2005, at 22:47, Hua Zhong wrote:
int bt_sock_unregister(int proto)
{
- if (proto >= BT_MAX_PROTO)
+ if (proto < 0 || proto >= BT_MAX_PROTO)
return -EINVAL;
Just curious: would it be better to say
if ((unsigned int)proto >= BT_MAX_PTORO)
Erm, it _would_
On Fri, Mar 25, 2005 at 06:24:58PM -0800, Patrick Mochel wrote:
> On Fri, 25 Mar 2005, Greg KH wrote:
> > Oh, looks like pci express now has problems too, I'll go hit that one
> > next...
>
> Bah, sorry about that. What config are you using to test, 'allmodconfig'?
Yup. Looks like pci express
Phil Lougher wrote:
Making readdir return '.' and '..' is trivially easy, as all the
required information to fake '.' and '..' entries are present.
The lack of '.' and '..' entries hasn't caused any problems despite
cramfs/squashfs being used for a large number of years. I'm inclined
to believe
On Thu, 2005-03-24 at 16:57 -0700, Moore, Eric Dean wrote:
> +static struct device_attribute mptscsih_queue_depth_attr = {
> + .attr = {
> + .name = "queue_depth",
> + .mode = S_IWUSR,
> + },
> + .store = mpt_core_store_queue_depth,
>
On Thu, 24 Mar 2005 15:13:08 -0500, Kyle Moffett <[EMAIL PROTECTED]> wrote:
> I would add ".." and "." to squashfs, just so that it acts like the rest
> of the filesystems on the planet,
Cramfs also doesn't store '.' and '..', which is where I got the idea
from in the first place when originally
> int bt_sock_unregister(int proto)
> {
> - if (proto >= BT_MAX_PROTO)
> + if (proto < 0 || proto >= BT_MAX_PROTO)
> return -EINVAL;
Just curious: would it be better to say
if ((unsigned int)proto >= BT_MAX_PTORO)
?
Is it faster too?
Hua
-
To unsubscribe from this
On Friday, March 25, 2005 6:57 pm, Jason Uhlenkott wrote:
> On Fri, Mar 25, 2005 at 09:24:21PM -0500, Len Brown wrote:
> > What bad things happen if you define CONFIG_PM on SN2?
>
> None, other than slightly enlarging the kernel with some
> suspend/resume stuff we don't care about. It's always
diff -Nru a/Makefile b/Makefile
--- a/Makefile 2005-03-25 18:26:00 -08:00
+++ b/Makefile 2005-03-25 18:26:00 -08:00
@@ -1,7 +1,7 @@
VERSION = 2
PATCHLEVEL = 6
SUBLEVEL = 11
-EXTRAVERSION = .5
+EXTRAVERSION = .6
NAME=Woozy Numbat
# *DOCUMENTATION*
diff -Nru a/fs/binfmt_elf.c
With some pending security fixes it's time to for a -stable update. So,
here's 2.6.11.6, in the normal kernel.org places. This includes some
security fixes, esp. one which closes a local root exploit in bluetooth.
The diffstat and short summary of the fixes are below.
I'll also be replying to
On Thu, 2005-03-24 at 16:56 -0700, Moore, Eric Dean wrote:
> +
> config FUSION_FC
> - tristate "Fusion MPT (base + ScsiHost) drivers for FC"
> - depends on PCI && SCSI
> + tristate "Fusion MPT (ScsiHost) drivers for FC"
This rejects completely in Kconfig. Could you check your
Jesper Juhl wrote:
Fix spelling in init/Kconfig
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
--- linux-2.6.12-rc1-mm3-orig/init/Kconfig 2005-03-25 15:29:08.0
+0100
+++ linux-2.6.12-rc1-mm3/init/Kconfig 2005-03-26 02:24:33.0 +0100
@@ -83,7 +83,7 @@
default y
Hi everybody,
I have a stock 2.6.11.5 kernel configured for SATA (libata), which sees
my SATA hard drive but not my SATA DVD burner. My system is a dual
Opteron 244 running an SMP kernel. The motherboard is MSI K8T Master2 FAR.
I have only been successful in getting the SATA DVD burner to
Dave Hansen wrote:
With sparsemem and memory hotplug there are quite a few options that
we kept adding identically in several different architectures. This
new file allows some of these to be consolidated.
Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]>
Signed-off-by: Dave Hansen <[EMAIL
On Fri, Mar 25, 2005 at 09:24:21PM -0500, Len Brown wrote:
> What bad things happen if you define CONFIG_PM on SN2?
None, other than slightly enlarging the kernel with some
suspend/resume stuff we don't care about. It's always been
unavailable for SN2 builds:
depends on IA64_GENERIC || IA64_DIG
Hi Steve,
Just a small patch on top of the other ones I sent you earlier for
cifsfs.c, I overlooked this trivial bit.
We can get rid of the else clause in a if statement. Doesn't change
anything code-wise, but shortens the file a bit and seems a bit cleaner
(at least to me) - apply or not as
> Yep, check `-noleaf' in find(1).
No.
At least the copy of find that I just looked at now, in
findutils-4.1.20, makes no such assumption that "." and ".." are the
first two directory entries.
Rather what it does is allow you to suppress an optimization, on file
systems that don't manage their
Vojtech Pavlik <[EMAIL PROTECTED]> writes:
> I'm still thinking about what to do with it.
You still thinking?.
--
Esben Stien is [EMAIL PROTECTED]
http://www.esben-stien.name
irc://irc.esben-stien.name/%23contact
[sip|iax]:esben-stien.name
-
To unsubscribe from this list: send the line
Though it looks a lot better; no more streams of messages.
Now when I resume, I get:
PCI: Enabling device :00:1d.7 ( -> 0002)
<1>Unable to handle kernel NULL pointer dereference
a second or so after resume. It is completely locked up at this point;
magic-sysreq gets no response.
lspci
On Fri, 2005-03-25 at 21:02, Jason Uhlenkott wrote:
> On Fri, Mar 25, 2005 at 08:56:58PM -0500, Len Brown wrote:
> > Please send me the .config you'd like to build.
>
> arch/ia64/configs/sn2_defconfig
> > I believe that what we want to do is include CONFIG_PM.
>
> At first glance, it looks
On Fri, 25 Mar 2005, Greg KH wrote:
> On Fri, Mar 25, 2005 at 03:39:52PM -0800, Greg KH wrote:
> > But can you take a look at drivers/scsi/scsi_transport_spi.c, line 265?
> > That is also going to need fixing up somehow. Gotta love that FIXME
> > comment...
Heh, funky.
> Ok, the patch below
Fix a typo in scdrv_init() which was breaking the build for SGI sn2.
Signed-off-by: Jason Uhlenkott <[EMAIL PROTECTED]>
Index: linux/drivers/char/snsc.c
===
--- linux.orig/drivers/char/snsc.c 2005-03-25 16:53:13.426753917 -0800
Russell King wrote:
On Wed, Mar 23, 2005 at 05:10:15PM +, Hugh Dickins wrote:
Here's the recut of those patches, including David Miller's vital fixes.
I'm addressing these to Nick rather than Andrew, because they're perhaps
not fit for -mm until more testing done and the x86_64 32-bit vdso
On Fri, Mar 25, 2005 at 08:56:58PM -0500, Len Brown wrote:
> Please send me the .config you'd like to build.
arch/ia64/configs/sn2_defconfig
> I believe that what we want to do is include CONFIG_PM.
At first glance, it looks like that will enable suspend/resume
functionality (which I don't
On Fri, 2005-03-25 at 20:43, Jason Uhlenkott wrote:
> On Fri, Mar 25, 2005 at 12:21:54AM -0800, Andrew Morton wrote:
> > bk-acpi.patch
>
> This doesn't build for SGI sn2:
>
> arch/ia64/kernel/mca.c: In function `ia64_mca_init':
> arch/ia64/kernel/mca.c:1394: error: `ACPI_INTERRUPT_CPEI'
On Fri, Mar 25, 2005 at 12:21:54AM -0800, Andrew Morton wrote:
> bk-acpi.patch
This doesn't build for SGI sn2:
arch/ia64/kernel/mca.c: In function `ia64_mca_init':
arch/ia64/kernel/mca.c:1394: error: `ACPI_INTERRUPT_CPEI' undeclared (first use
in this function)
arch/ia64/kernel/mca.c:1394:
Fix spelling in init/Kconfig
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
--- linux-2.6.12-rc1-mm3-orig/init/Kconfig 2005-03-25 15:29:08.0
+0100
+++ linux-2.6.12-rc1-mm3/init/Kconfig 2005-03-26 02:24:33.0 +0100
@@ -83,7 +83,7 @@
default y
help
David S. Miller <[EMAIL PROTECTED]> wrote:
> On Fri, 25 Mar 2005 15:34:41 +0100
> Ingo Molnar <[EMAIL PROTECTED]> wrote:
>
>> the patch below fixes a bug that i encountered while running a
>> PREEMPT_RT kernel, but i believe it should be fixed in the generic
>> kernel too. xfrm_policy_kill()
On Sat, 2005-03-26 at 01:38 +0100, Julien Wajsberg wrote:
> On Fri, 25 Mar 2005 18:14:22 -0500, Lee Revell <[EMAIL PROTECTED]> wrote:
> > On Fri, 2005-03-25 at 23:59 +0100, Julien Wajsberg wrote:
> > > - audio works too. The only problem is that two applications can't
> > > open /dev/dsp in the
While building 2.6.12-rc1-bk1 with attached config I get "Inconsistent
kallsyms data".
Setting CONFIG_KALLSYMS_EXTRA_PASS or CONFIG_KALLSYMS_ALL fixes the problem.
Noted differences:
--- System.map
+++ .tmp_System.map
-c03cf83c D kallsyms_markers
-c03cf8d4 D kallsyms_token_table
-c03cfce4 D
On Fri, 25 Mar 2005 18:14:22 -0500, Lee Revell <[EMAIL PROTECTED]> wrote:
> On Fri, 2005-03-25 at 23:59 +0100, Julien Wajsberg wrote:
> > - audio works too. The only problem is that two applications can't
> > open /dev/dsp in the same time.
>
> Not a problem. ALSA does software mixing for
On Sat, Mar 26, 2005 at 03:47:33AM +0300, Evgeniy Polyakov wrote:
>
> It looks like we all misunderstand each other -
> why do you think that if there will be kernel <-> kernel
> RNG dataflow, then system will continuously spent all
> it's time to produce that data?
It doesn't matter whether
On Tue, Mar 22, 2005 at 12:24:37PM +1100, Greg Banks wrote:
> G'day,
>
> The attached patch fixes a bug in the VFS code which causes
> "Busy inodes after unmount" and a subsequent oops.
Applied, thanks.
>
> Greg.
> --
> Greg Banks, R Software Engineer, SGI Australian Software Group.
> I don't
On Fri, 25 Mar 2005 09:23:12 -0800
"David S. Miller" <[EMAIL PROTECTED]> wrote:
> On Fri, 25 Mar 2005 16:32:07 +1100
> Nick Piggin <[EMAIL PROTECTED]> wrote:
>
> > So, to make the question more concrete: if a pgd_t is freed due
> > to freeing the single pmd_t contained within it (which was the
>
On Fri, 2005-03-25 at 16:17, Dave Jones wrote:
> On Wed, Mar 23, 2005 at 11:53:04AM -0800, Mingming Cao wrote:
>
> > The fsx command is:
> >
> > ./fsx -c 10 -n -r 4096 -w 4096 /mnt/test/foo1 &
> >
> > I also see fsx tests start to generating report about read bad data
> > about the tests
On Sat, 26 Mar 2005 10:47:45 +1100
Herbert Xu <[EMAIL PROTECTED]> wrote:
> On Fri, Mar 25, 2005 at 06:43:49PM -0500, Jeff Garzik wrote:
> >
> > In any case, it is the wrong solution to simply "turn on the tap" and
> > let the RNG spew data. There needs to be a limiting factor... typically
> >
On Fri, 25 Mar 2005 18:20:54 -0500, Lee Revell <[EMAIL PROTECTED]> wrote:
> On Fri, 2005-03-25 at 23:59 +0100, Julien Wajsberg wrote:
> > I also experiment sometimes a complete hang of the system. But I
> > didn't find how to reproduce the bug yet, especially because it seems
> > to happen when I
On Wed, Mar 23, 2005 at 11:53:04AM -0800, Mingming Cao wrote:
> The fsx command is:
>
> ./fsx -c 10 -n -r 4096 -w 4096 /mnt/test/foo1 &
>
> I also see fsx tests start to generating report about read bad data
> about the tests have run for about 9 hours(one hour before of the OOM
>
> I was hopeing that it could be added as a selectable DRM module in the
> kernel such as the ati rage and such are. This is a tested driver,
> proven working for most, making it selectable in the kernel would be
> very much appreciated and a great advancment for all savage users. The
> savage
On Fri, Mar 25, 2005 at 03:39:52PM -0800, Greg KH wrote:
> But can you take a look at drivers/scsi/scsi_transport_spi.c, line 265?
> That is also going to need fixing up somehow. Gotta love that FIXME
> comment...
Ok, the patch below seems to fix it, but I would like some validation I
did the
On Fri, Mar 25, 2005 at 06:43:49PM -0500, Jeff Garzik wrote:
>
> In any case, it is the wrong solution to simply "turn on the tap" and
> let the RNG spew data. There needs to be a limiting factor... typically
> rngd should figure out when /dev/random needs more entropy, or simply
> delay a
On Fri, Mar 25, 2005 at 04:50:16PM -0600, Kim Phillips wrote:
> I did some tests and found that the udelay(200) call in hw_random.c is
> not good for extreme RNG consumption. Whether or not such extremes
> occur in real life, on the mpc8541, /dev/hwrandom is an order of
> magnitude slower than
On Fri, 25 Mar 2005 18:21:42 -0500, Lee Revell <[EMAIL PROTECTED]> wrote:
> On Fri, 2005-03-25 at 23:59 +0100, Julien Wajsberg wrote:
> > Mar 25 22:42:55 evenflow kernel: hda: dma_timer_expiry: dma status == 0x60
> > Mar 25 22:42:55 evenflow kernel: hda: DMA timeout retry
> > Mar 25 22:42:55
On Fri, Mar 25, 2005 at 11:20:24AM -0800, Greg KH wrote:
> On Thu, Mar 24, 2005 at 09:54:24PM -0800, Patrick Mochel wrote:
> >
> > Here is the next round of driver model locking changes. These build off of
> > the previous set of changes, including the klist patch. They eradicate all
> > of the
On Fri, 2005-03-25 at 23:59 +0100, Julien Wajsberg wrote:
> Mar 25 22:42:55 evenflow kernel: hda: dma_timer_expiry: dma status == 0x60
> Mar 25 22:42:55 evenflow kernel: hda: DMA timeout retry
> Mar 25 22:42:55 evenflow kernel: hda: timeout waiting for DMA
> Mar 25 22:42:55 evenflow kernel: hda:
On Fri, 2005-03-25 at 23:59 +0100, Julien Wajsberg wrote:
> I also experiment sometimes a complete hang of the system. But I
> didn't find how to reproduce the bug yet, especially because it seems
> to happen when I do nothing (when I'm sleeping or am at work ;), and I
> can't get a Oops because I
Jeff,
I'm seeing single drives getting stuck in ata_busy_sleep() with these
log messages on boot:
<4>ata2 is slow to respond, please be patient
<3>ata2 failed to respond (30 secs)
One thing I found was the bug fixed below, where the COMRESET wasn't
getting flushed properly. This may or may not
On Fri, 2005-03-25 at 23:59 +0100, Julien Wajsberg wrote:
> - audio works too. The only problem is that two applications can't
> open /dev/dsp in the same time.
Not a problem. ALSA does software mixing for chipsets that can't do it
in hardware. Google for dmix.
However this doesn't (and can't
On Fri, 25 Mar 2005, linux-os wrote:
> On Fri, 25 Mar 2005, Jesper Juhl wrote:
>
> > (please keep me on CC)
> >
> >
> > checking for NULL before calling kfree() is redundant and needlessly
> > enlarges the kernel image, let's get rid of those checks.
> >
>
> Hardly. ORing a value with itself
Hi
Just to answer some questions :
- USB works ok since 2.6.11
- audio works too. The only problem is that two applications can't
open /dev/dsp in the same time.
- network works
I own an Asus A8N-Sli motherboard with the Nforce4-Sli chipset, and I
experiment the following problem :
Mar 25
On Freedag 25 März 2005 20:14, Arjan van de Ven wrote:
> the randomisation patches came in a series of 8 patches (where several
> were general infrastructure); could you try to disable the individual
> randomisations one at a time to see which one causes this effect?
It's caused by
"Jason Munro" <[EMAIL PROTECTED]> wrote:
>
> This fixes it here.
>
Steven Cole <[EMAIL PROTECTED]> wrote:
>
> The patch fixed it for me. Wheee.
>
OK, thanks guys. You're the best.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL
On Fri, 25 Mar 2005, Jesper Juhl wrote:
(please keep me on CC)
checking for NULL before calling kfree() is redundant and needlessly
enlarges the kernel image, let's get rid of those checks.
Hardly. ORing a value with itself and jumping on condition is
real cheap compared with pushing a value into
On 4:23:36 pm 03/25/05 Andrew Morton <[EMAIL PROTECTED]> wrote:
> Andrew Morton <[EMAIL PROTECTED]> wrote:
> >
> > It's the new rock-ridge bounds checking.
>
> Try this, please?
>
> diff -puN fs/isofs/rock.c~rock-handle-directory-overflows-fix
> fs/isofs/rock.c ---
On Sat, 2005-03-26 at 06:43 +0900, Tejun Heo wrote:
> 1. Allocate scsi_request and request (two are linked)
This can't be done because the scsi_cmnd's are allocated specially (slab
with reserve pool).
James
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body
On Fri, 25 Mar 2005, Guillaume Thouvenin wrote:
...
> The lmbench shows that the overhead (the construction and the sending
> of the message) in the fork() routine is around 7%.
...
> + /*
> + * size of data is the number of characters
> + * printed plus
Andrew Morton wrote:
Andrew Morton <[EMAIL PROTECTED]> wrote:
It's the new rock-ridge bounds checking.
Try this, please?
OK, you caught me just as I was headed out the door. ;)
The patch fixed it for me. Wheee.
[EMAIL PROTECTED] steven]# uname -r
2.6.12-rc1-mm3-GX110
[EMAIL PROTECTED] steven]#
On Fri, 25 Mar 2005, linux-os wrote:
>
> Isn't it expensive of CPU time to call kfree() even though the
> pointer may have already been freed? I suggest that the check
> for a NULL before the call is much less expensive than calling
> kfree() and doing the check there. The resulting "double
On Fri, 2005-03-25 at 15:59 +0100, Ingo Molnar wrote:
> i have released the -V0.7.41-10 Real-Time Preemption patch, which can be
> downloaded from the usual place:
>
>http://redhat.com/~mingo/realtime-preempt/
I get zillions of "return type defaults to int" warnings trying to
compile this
* Lee Revell <[EMAIL PROTECTED]> wrote:
> On Fri, 2005-03-25 at 15:59 +0100, Ingo Molnar wrote:
> > i have released the -V0.7.41-10 Real-Time Preemption patch, which can be
> > downloaded from the usual place:
> >
> >http://redhat.com/~mingo/realtime-preempt/
>
> I get zillions of "return
On Thu, 2005-03-24 at 19:20 +0100, Segher Boessenkool wrote:
> > While experimenting with framebuffer access performances, we noticed a
> > very significant improvement in write access to it when not setting
> > the "guarded" bit on the MMU mappings. This bit basically says that
> > reads and
Andrew Morton wrote:
Steven Cole <[EMAIL PROTECTED]> wrote:
I found a few more minutes to test two more kernels. The problem
first occured with 2.6.12-rc1-mm2:
2.6.12-rc1 reads the cd-rom OK as reported earlier
2.6.12-rc1-mm1 also reads the cd-rom OK
2.6.12-rc1-mm2 broken same as -mm3
On Thu, 2005-03-24 at 08:54 -0800, Jesse Barnes wrote:
> On Wednesday, March 23, 2005 10:24 pm, Benjamin Herrenschmidt wrote:
> > While experimenting with framebuffer access performances, we noticed a
> > very significant improvement in write access to it when not setting
> > the "guarded" bit on
Isn't it expensive of CPU time to call kfree() even though the
pointer may have already been freed? I suggest that the check
for a NULL before the call is much less expensive than calling
kfree() and doing the check there. The resulting "double check"
is cheap, compared to the call.
On Fri, 25 Mar
* Andrew Morton ([EMAIL PROTECTED]) wrote:
>
> (Please dont' edit the cc line. Just do reply-to-all)
>
> "Jason Munro" <[EMAIL PROTECTED]> wrote:
> >
> > > [ 146.301026] rock: directory entry would overflow storage
> > > [ 146.301044] rock: sig=0x5245, size=8, remaining=0
> > > [ 158.388397]
On 4:27:49 pm 03/25/05 "Jason Munro" <[EMAIL PROTECTED]> wrote:
> On 4:06:54 pm 03/25/05 Andrew Morton <[EMAIL PROTECTED]> wrote:
> >
> > (Please dont' edit the cc line. Just do reply-to-all)
>
> Oops, reply-to-all it is.
>
> > "Jason Munro" <[EMAIL PROTECTED]> wrote:
> > >
> > > > [
On 4:06:54 pm 03/25/05 Andrew Morton <[EMAIL PROTECTED]> wrote:
>
> (Please dont' edit the cc line. Just do reply-to-all)
Oops, reply-to-all it is.
> "Jason Munro" <[EMAIL PROTECTED]> wrote:
> >
> > > [ 146.301026] rock: directory entry would overflow storage
> > > [ 146.301044] rock:
(please keep me on CC)
There's no need to check a pointer for NULL before calling kfree() on it -
kfree() handles NULL pointers just fine on its own.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
--- linux-2.6.12-rc1-mm3-orig/fs/ntfs/dir.c 2005-03-25 15:28:59.0
+0100
+++
Andrew Morton <[EMAIL PROTECTED]> wrote:
>
> It's the new rock-ridge bounds checking.
Try this, please?
diff -puN fs/isofs/rock.c~rock-handle-directory-overflows-fix fs/isofs/rock.c
--- 25/fs/isofs/rock.c~rock-handle-directory-overflows-fix Fri Mar 25
14:21:32 2005
+++
(please keep me on CC)
checking for NULL before calling kfree() is redundant and needlessly
enlarges the kernel image, let's get rid of those checks.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
--- linux-2.6.12-rc1-mm3-orig/fs/nfsd/export.c 2005-03-21 23:12:41.0
+0100
+++
On Fri, 2005-03-25 at 13:56, Andrew Morton wrote:
> Mingming Cao <[EMAIL PROTECTED]> wrote:
> >
> > I run into OOM problem again on 2.6.12-rc1. I run some(20) fsx tests on
> > 2.6.12-rc1 kernel(and 2.6.11-mm4) on ext3 filesystem, after about 10
> > hours the system hit OOM, and OOM keep killing
There's no need to check for NULL before calling kfree().
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
--- linux-2.6.12-rc1-mm3-orig/fs/jffs/intrep.c 2005-03-21 23:12:41.0
+0100
+++ linux-2.6.12-rc1-mm3/fs/jffs/intrep.c 2005-03-25 22:47:29.0
+0100
@@ -1693,9 +1693,7
On Fri, Mar 25, 2005 at 09:03:57PM +, Russell King wrote:
> > It would be trivial to treat them both as foobar0 and have the
> > registration succeed for whoever gets it first, but I could see that this
> > would be problematic in the serial8250 case. On the other hand, this is
> > then
There's no need to check for NULL before calling kfree().
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
--- linux-2.6.12-rc1-mm3-orig/fs/hpfs/dnode.c 2005-03-21 23:12:40.0
+0100
+++ linux-2.6.12-rc1-mm3/fs/hpfs/dnode.c2005-03-25 22:44:39.0
+0100
@@ -244,12 +244,12
kfree() handles NULL pointers fine - checking is redundant.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
--- linux-2.6.12-rc1-mm3-orig/fs/ext3/acl.c 2005-03-02 08:37:55.0
+0100
+++ linux-2.6.12-rc1-mm3/fs/ext3/acl.c 2005-03-25 22:41:41.0 +0100
@@ -197,8 +197,7 @@
(Please dont' edit the cc line. Just do reply-to-all)
"Jason Munro" <[EMAIL PROTECTED]> wrote:
>
> > [ 146.301026] rock: directory entry would overflow storage
> > [ 146.301044] rock: sig=0x5245, size=8, remaining=0
> > [ 158.388397] rock: directory entry would overflow storage
> > [
Available at http://ep09.pld-linux.org/~mmazur/linux-libc-headers/
Changes:
- small (but important) fix in netfilter
- added cleaned up mtd/* userland headers
- massive change to use types from linux/types.h and not to pollute the
namespace
- use gcc emitted __mips64 instead of CONFIG_MIPS{32,64}
(please keep me on CC)
kfree() handles NULL fine, to check is redundant.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
--- linux-2.6.12-rc1-mm3-orig/fs/ext2/acl.c 2005-03-02 08:38:18.0
+0100
+++ linux-2.6.12-rc1-mm3/fs/ext2/acl.c 2005-03-25 22:41:07.0 +0100
@@ -194,8
With sparsemem and memory hotplug there are quite a few options that
we kept adding identically in several different architectures. This
new file allows some of these to be consolidated.
Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]>
Signed-off-by: Dave Hansen <[EMAIL PROTECTED]>
---
Mingming Cao <[EMAIL PROTECTED]> wrote:
>
> I run into OOM problem again on 2.6.12-rc1. I run some(20) fsx tests on
> 2.6.12-rc1 kernel(and 2.6.11-mm4) on ext3 filesystem, after about 10
> hours the system hit OOM, and OOM keep killing processes one by one. I
> could reproduce this problem very
With sparsemem being introduced, we need a central place for new
memory-related .config options: mm/Kconfig.
For all architectures, this just means that you'll see a
"Memory Model" choice in your architecture menu. For those that
implement DISCONTIGMEM, you may eventually want to make your
On Fri, 2005-03-25 at 21:52 +, Russell King wrote:
> On Fri, Mar 25, 2005 at 04:45:32PM -0500, Lee Revell wrote:
> > On Fri, 2005-03-25 at 21:07 +, Russell King wrote:
> > > On Fri, Mar 25, 2005 at 03:53:42PM -0500, Lee Revell wrote:
> > > > On Fri, 2005-03-25 at 07:38 +, Russell King
There is some confusion that arose when working on SPARSEMEM patch
between what is needed for DISCONTIG vs. NUMA.
Multiple pg_data_t's are needed for DISCONTIGMEM or NUMA,
independently. All of the current NUMA implementations require an
implementation of DISCONTIG. Because of this, quite a
This will at least suppress one prompt that users would have
received the first time they compile with the new DISCONTIG
arch option. They'll still get the "Memory Model" prompt,
but 99% of them will have the default work there.
Signed-off-by: Dave Hansen <[EMAIL PROTECTED]>
---
On Fri, Mar 25, 2005 at 04:45:32PM -0500, Lee Revell wrote:
> On Fri, 2005-03-25 at 21:07 +, Russell King wrote:
> > On Fri, Mar 25, 2005 at 03:53:42PM -0500, Lee Revell wrote:
> > > On Fri, 2005-03-25 at 07:38 +, Russell King wrote:
> > > > Users need to be re-educated _not_ to use
On 3:22:52 pm 03/25/05 Steven Cole <[EMAIL PROTECTED]> wrote:
> Same results, -mm2 broken, and -mm1 reads the disk. I even tried
> other CD's just to make sure I didn't have something weird. Same
> results.
> [EMAIL PROTECTED] steven]# dmesg | tail
> [ 51.205871] EXT3 FS on hda6, internal
Steven Cole <[EMAIL PROTECTED]> wrote:
>
> >>
> >> I found a few more minutes to test two more kernels. The problem
> >> first occured with 2.6.12-rc1-mm2:
> >>
> >> 2.6.12-rc1 reads the cd-rom OK as reported earlier
> >> 2.6.12-rc1-mm1 also reads the cd-rom OK
> >> 2.6.12-rc1-mm2 broken same
On Fri, 2005-03-25 at 21:07 +, Russell King wrote:
> On Fri, Mar 25, 2005 at 03:53:42PM -0500, Lee Revell wrote:
> > On Fri, 2005-03-25 at 07:38 +, Russell King wrote:
> > > Users need to be re-educated _not_ to use ksymoops.
> >
> > How about changing the fscking docs to not tell users
1 - 100 of 457 matches
Mail list logo
