[2.6.12-rc1] suspend to Disk success - T42 laptop

2005-03-27 Thread Shawn Starr
Hello Pavel, I can now suspend to disk on the laptop with 2.6.12-rc1. There is no failures anymore. It resumes perfectly. Thank you. Shawn. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 0/6] freepgt: free_pgtables shakeup

2005-03-27 Thread Russell King
On Sun, Mar 27, 2005 at 10:17:39AM -0800, David S. Miller wrote: > On Sun, 27 Mar 2005 08:57:25 +0100 > Russell King <[EMAIL PROTECTED]> wrote: > > > Unfortunately not - free_pgd_slow doesn't have any knowledge about the > > mm_struct that the pgd was associated with. > > You could store the mm

[2.6.12-rc1][ACPI][suspend] /proc/acpi/sleep vs /sys/power/state issue - 'standby' on a laptop

2005-03-27 Thread Shawn Starr
Hello, I've noticed something strange with issuing 'standby' to the system: when echoing "standby" to /sys/power/state, nothing happens, not even a log or system activity to attempt standby mode. However, trying echo "1" to /proc/acpi/sleep the system attempts to (standby) and aborts:

Re: 2.6.12-rc1-mm3: class_simple API

2005-03-27 Thread Jim Crilly
On 03/27/05 01:39:27PM -0500, Nick Orlov wrote: > On Sun, Mar 27, 2005 at 10:17:17AM -0800, Greg KH wrote: > > On Sun, Mar 27, 2005 at 01:04:31PM -0500, Nick Orlov wrote: > > > > > > - Whether the changes like the one above are "the right thing to do" ? > > > > Yes. > > Questionable. > > > >

[PATCH] nommu.c build error fix

2005-03-27 Thread Yoshinori Sato
- Argument addition of security_file_mmap. - Because in_gate_area_no_task undefined with CONFIG_KALLSYM=y, add it. Signed-off-by: Yoshinori Sato <[EMAIL PROTECTED]> = mm/nommu.c 1.32 vs edited = --- 1.32/mm/nommu.c 2005-03-10 00:12:40 +09:00 +++ edited/mm/nommu.c 2005-03-28

Re: Linux 2.4.30-rc3

2005-03-27 Thread Ville Herva
On Sat, Mar 26, 2005 at 01:28:01PM -0300, you [Marcelo Tosatti] wrote: > > Hi, > > Here goes -rc3. > > A nasty typo happened while merging v2.6 load_elf_library() DoS fix, > which could leap to oopses. > > Summary of changes from v2.4.30-rc2 to v2.4.30-rc3 >

$BBp5^JX!JBh0l9f!K(B

2005-03-27 Thread info
$BEv%5%$%H$N$4MxMQ$OA4$FL5NA!JCK=w6&!o(B0$B1_!K(B $B$d$C$Q$j=P0)$&$J$i$46a=j$G5$7Z$KOC$79g$($k%a!<%k!&%(!{%A%U%l%s%I$,$G$9$h(B $B$M!#Ev%5%$%H$OA49qCO0hJL$N;TD.Bhttp://loves.qsv20.com/ [EMAIL PROTECTED]"[EMAIL PROTECTED]&$K%W%i%$%P%7!pJs$rBgNL8x3+$7$F$*$j$^$9!#(B - To unsubscribe from

[PATCH 2.6.12-rc1] cpusets GFP_ATOMIC fix: tonedown panic comment

2005-03-27 Thread Paul Jackson
This patch applies on top of my patch of March 26, entitled "cpusets special case GFP_ATOMIC allocs". It tones down my panic'y commentary. My commentary shouldn't imply that failed GFP_ATOMICs should lead to, or normally lead to, panics. Even though there are a few panic() calls following

Re: Can't use SYSFS for "Proprietry" driver modules !!!.

2005-03-27 Thread Horst von Brand
Kyle Moffett <[EMAIL PROTECTED]> said: > On Mar 27, 2005, at 14:16, Aaron Gyes wrote: > > So what? Sure, GPL'd drivers are easier for an end-user in that case. > > What does that have to do with law? > Well, under most interpretations of the GPL, you are *NOT* allowed to > even _link_ non-GPL

Re: [PATCH] no need to check for NULL before calling kfree() -fs/ext2/

2005-03-27 Thread Horst von Brand
Dave Jones <[EMAIL PROTECTED]> said: > On Sun, Mar 27, 2005 at 05:12:58PM +0200, Jan Engelhardt wrote: > > > Well, kfree inlined was already mentioned but forgotten again. > > What if this was used: > > > > inline static void kfree_WRAP(void *addr) { > > if(likely(addr != NULL)) { > >

Re: ]PATCH] cpuset: make function decl. ANSI

2005-03-27 Thread Paul Jackson
Randy wrote: > kernel/cpuset.c:1428:41: warning: non-ANSI function declaration Acked-by: Paul Jackson <[EMAIL PROTECTED]> Thanks, Randy. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <[EMAIL PROTECTED]>

[PATCH] isdn: hfc4s8s_ll sparse cleanups

2005-03-27 Thread Randy.Dunlap
drivers/isdn/hisax/hfc4s8s_l1.c:1661:7: warning: obsolete struct initializer, us e C99 syntax drivers/isdn/hisax/hfc4s8s_l1.c:1662:7: warning: obsolete struct initializer, us e C99 syntax drivers/isdn/hisax/hfc4s8s_l1.c:1663:7: warning: obsolete struct initializer, us e C99 syntax

[PATCH] isdn: hfc_usb: use NULL instead of 0

2005-03-27 Thread Randy.Dunlap
17 of these (all different line numbers): drivers/isdn/hisax/hfc_usb.c:139:9: warning: Using plain integer as NULL pointer Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> diffstat:= drivers/isdn/hisax/hfc_usb.c |2 +- drivers/isdn/hisax/hfc_usb.h |2 +- 2 files changed, 2

[PATCH] x86_64/lib: find_first_zero_bit not extern

2005-03-27 Thread Randy.Dunlap
Exported function was marked inline: arch/x86_64/lib/bitops.c:18: warning: `find_first_zero_bit' declared inline afte r being called Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> diffstat:= arch/x86_64/lib/bitops.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -Naurp

]PATCH] cpuset: make function decl. ANSI

2005-03-27 Thread Randy.Dunlap
kernel/cpuset.c:1428:41: warning: non-ANSI function declaration Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> diffstat:= kernel/cpuset.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -Naurp ./kernel/cpuset.c~cpuset_void ./kernel/cpuset.c --- ./kernel/cpuset.c~cpuset_void

source file unable to export function to kernel

2005-03-27 Thread linux lover
Hi, I have included this as myfile.c in /usr/src/linux-2.4.24/kernel. I included its entry in Makefile in export-objs. //sourcefile #define EXPORT_SYMTAB #include #include #include //contains prototypes for fun1 and fun2 #include char* fun1(char* str1) { } void fun2(char

Re: [PATCH] no need to check for NULL before calling kfree() -fs/ext2/

2005-03-27 Thread Paul Jackson
Jesper wrote: > What I'm trying to find out now is if there's a general consensus that > these patches are worthwile and wanted or if they are unwanted and I'm > wasting my time. Thanks for your good work so far, and your good natured tolerance of the excessively detailed discussions

[patch] oom lca -- fork bombing killer

2005-03-27 Thread Coywolf Qi Hunt
March 28, 2005 Coywolf Qi Hunt [EMAIL PROTECTED] Linux OOM LCA (Least Common Ancestor) Patch

Re: upgrading modutils may have fixed: unresolved symbols still in 2.4.30-rc2 (usbserial needs symbol tty_ldisc_ref and tty_ldisc_deref which are EXPORT_SYMBOL_GPL)

2005-03-27 Thread Willy Tarreau
On Sat, Mar 26, 2005 at 04:31:59PM -0800, David Dyck wrote: > >dd:linux# insmod usbserial > >Using /lib/modules/2.4.30-rc2/kernel/drivers/usb/serial/usbserial.o > >...: unresolved symbol tty_ldisc_ref > >...: unresolved symbol tty_ldisc_deref > > I tried again with 2.4.30-rc3, but this time I

Re: imps2 mouse driver and bug 2082

2005-03-27 Thread Dmitry Torokhov
Hi, On Sunday 27 March 2005 18:37, Mauro Mozzarelli wrote: > The mouse driver, re-developed for kernel 2.6, ever since the earliest > 2.6 release lost the ability to reset a broken link with an IMPS2 mouse > (this happens when disconnecting the mouse plug either physically or > through a "non

Re: [PATCH] no need to check for NULL before calling kfree() -fs/ext2/

2005-03-27 Thread Paul Jackson
Dave writes: > Am I the only person who is completely fascinated by the > effort being spent here micro-optimising something thats Eh .. it's well known behaviour. Bring two questions before a committee, one for millions of dollars and the other for pocket change, and watch the committee spend

Re: [PATCH] no need to check for NULL before calling kfree() -fs/ext2/

2005-03-27 Thread Paul Jackson
Jan - please don't trim the CC lists when responding on lkml. Thanks. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <[EMAIL PROTECTED]> 1.650.933.1373, 1.925.600.0401 - To unsubscribe from this list: send

Re: Can't use SYSFS for "Proprietry" driver modules !!!.

2005-03-27 Thread Clemens Schwaighofer
The fact that Nvidia and ATI get away with it? The choose to take a risk based upon a specific interpretation of the boundary of a derivative work. Since the boundary is untested in law its not certain who is right. Plus the fact, that if somebody sues them, they just remove the drivers from

How to measure time accurately.

2005-03-27 Thread krishna
Hi All, Can any one tell me how to measure time accurately for a block of C code in device drivers. For example, If I want to measure the time duration of firmware download. Regards, Krishna Chaitanya - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: Mac mini sound woes

2005-03-27 Thread Benjamin Herrenschmidt
On Mon, 2005-03-28 at 03:42 +0200, Andrea Arcangeli wrote: > On Mon, Mar 28, 2005 at 09:42:00AM +1000, Benjamin Herrenschmidt wrote: > > suggest I just don't do any control ? Or should I implement a double > > buffer scheme with software gain as well in the kernel driver ? > > I recall to have

Re: Can't use SYSFS for "Proprietry" driver modules !!!

2005-03-27 Thread Aaron Gyes
On Sun, 2005-03-27 at 14:30 -0500, Kyle Moffett wrote: > Well, under most interpretations of the GPL, you are *NOT* allowed to > even _link_ non-GPL code with GPL code. (Basically, by distributing > such a linked binary, you are certifying that you have permission to > GPL the entire source-code

Re: Can't use SYSFS for "Proprietry" driver modules !!!.

2005-03-27 Thread Steven Rostedt
On Mon, 2005-03-28 at 03:39 +0200, Adrian Bunk wrote: > > Your talking about something completely different. Yes, it is quite > > explicit if you modify the source, and distribute it in binary only > > form. I'm talking about writing a separate module that links with the > > GPL code

Kernel bug when using quagga/zebra

2005-03-27 Thread Iulian Surugiu
Hi I`m using fedora core 3 kernel (2.6.9-1.667). I would like to mention first that this is not only the first time i am encountering this error, however , for the last 3 days i had had setup routers on different distributions/kernels and quagga/zebra different packages (source/binaries) and

Re: Mac mini sound woes

2005-03-27 Thread Andrea Arcangeli
On Mon, Mar 28, 2005 at 09:42:00AM +1000, Benjamin Herrenschmidt wrote: > suggest I just don't do any control ? Or should I implement a double > buffer scheme with software gain as well in the kernel driver ? I recall to have sometime clicked on volume controls that weren't hardware related, I

Re: Can't use SYSFS for "Proprietry" driver modules !!!.

2005-03-27 Thread Adrian Bunk
On Sun, Mar 27, 2005 at 06:54:52PM -0500, Steven Rostedt wrote: > On Mon, 2005-03-28 at 00:01 +0200, Adrian Bunk wrote: > > > > How do you define "proven in court"? > > > > Decided by an US judge based on US laws? > > Decided by a German judge based on German laws? > > Decided by a Chinese judge

Re: 2.6.12-rc1-mm3: box hangs solid on resume from disk while resuming device drivers

2005-03-27 Thread Li Shaohua
On Sun, 2005-03-27 at 02:23, Rafael J. Wysocki wrote: > Hi, > > On Friday, 25 of March 2005 15:19, Rafael J. Wysocki wrote: > > On Friday, 25 of March 2005 13:54, you wrote: > > ]--snip--[ > > > >My box is still hanged solid on resume (swsusp) by the drivers: > > > > > > > >ohci_hcd > > >

Re: Can't use SYSFS for "Proprietry" driver modules !!!.

2005-03-27 Thread Albert Cahalan
greg k-h writes: > On Sat, Mar 26, 2005 at 10:30:20PM -0500, Lee Revell wrote: >> That's the problem, it's not spelled out explicitly anywhere. >> That file does not address the issue of whether a driver is >> a "derived work". This is the part he should talk to a lawyer >> about, right? > > How

Re: Can't use SYSFS for "Proprietry" driver modules !!!.

2005-03-27 Thread Chris Wedgwood
On Sun, Mar 27, 2005 at 10:10:56AM -0800, Greg KH wrote: > How about the fact that when you load a kernel module, it is linked > into the main kernel image? The GPL explicitly states what needs to > be done for code linked in. oddly, the close nv driver has like 2.4MB if text in the kernel. i

Re: Problems on Apple iBook with ALSA and snd-powermac [2.6.11.5]

2005-03-27 Thread Benjamin Herrenschmidt
On Mon, 2005-03-28 at 01:08 +0200, Martin Loschwitz wrote: > Hi folks, > > given that the alsa-user-mailinglist has some strange kind of authentication > mechanism, and admin-authorization and whatever, I'm writing this mail to the > LKML (it would have been CCed here anyway). > > The current

Re: Disc driver is module, software suspend fails

2005-03-27 Thread Jim Carter
On Fri, 25 Mar 2005, Pavel Machek wrote: > There's another feature that enables you to start resume manually with > some echo to /sys... Perhaps it needs to be documented better, I'm > looking for a patch ;-). But how can it resume from a swap device for which it has no driver? Even if you

[PATCH] radeonfb: Fix mode setting on CRT monitors

2005-03-27 Thread Benjamin Herrenschmidt
Hi ! Current radeonfb is a bit "anal" about accepting CRT modes, it basically only accepts modes that have the exact resolution, which tends to break with fbcon on console switches as it provides "approximate" modes. This patch fixes it by having the driver chose the closest possible mode instead

Re: Can't use SYSFS for "Proprietry" driver modules !!!.

2005-03-27 Thread Steven Rostedt
On Mon, 2005-03-28 at 00:01 +0200, Adrian Bunk wrote: > On Sun, Mar 27, 2005 at 01:37:11PM -0500, Steven Rostedt wrote: > >... > > Wasn't this long ago proven in court that the license of headers can't > > control the code that calls them. IIRC, it was with X Motif and making > > free libraries

Re: [RFC] Some thoughts on device drivers and sysfs

2005-03-27 Thread Arioch
Adam Belay пишет: I would like to propose that we create a new type of device that would act as the layer between physical (bus devices) and logical (class devices). why not using D-BUS to allow lowlevel drivers to expose its features to userspace? - To unsubscribe from this list: send the

Re: [RFC] spinlock_t & rwlock_t break_lock member initialization (patch seeking comments included)

2005-03-27 Thread Jesper Juhl
On Sun, 27 Mar 2005, Zwane Mwaikambo wrote: > On Sun, 27 Mar 2005, Jesper Juhl wrote: > > > I've now been running kernels (both PREEMPT, SMP, both and without both) > > with the patch below applied for a few days and I see no ill effects. I'm > > still interrested in comments about wether or

Mac mini sound woes

2005-03-27 Thread Benjamin Herrenschmidt
Hi Takashi ! I'm looking into adding proper sound support for the Mac Mini. The problem is that from what I've seen (Apple driver is only partially opensource nowadays it seems, and the latest darwin drop is both incomplete and doesn't build), that beast only has a fixed function D->A converter,

imps2 mouse driver and bug 2082

2005-03-27 Thread Mauro Mozzarelli
The mouse driver, re-developed for kernel 2.6, ever since the earliest 2.6 release lost the ability to reset a broken link with an IMPS2 mouse (this happens when disconnecting the mouse plug either physically or through a "non imps2" KVM switch). The result is that the mouse can no longer be

Re: Can't use SYSFS for "Proprietry" driver modules !!!.

2005-03-27 Thread Greg KH
On Sun, Mar 27, 2005 at 11:16:54AM -0800, Aaron Gyes wrote: > > And then the user want to upgrade the 2.0 kernel that shipped with this > > box although the company that made the hardware went bankrupt some years > > ago. > > > > If the user has the source of the driver, he can port the driver

Re: [PATCH] no need to check for NULL before calling kfree()-fs/ext2/

2005-03-27 Thread linux-os
On Sun, 27 Mar 2005, Arjan van de Ven wrote: On Sat, 2005-03-26 at 18:21 -0500, linux-os wrote: On Sat, 26 Mar 2005, Arjan van de Ven wrote: On Fri, 2005-03-25 at 17:29 -0500, linux-os wrote: Isn't it expensive of CPU time to call kfree() even though the pointer may have already been freed? nope a

Problems on Apple iBook with ALSA and snd-powermac [2.6.11.5]

2005-03-27 Thread Martin Loschwitz
Hi folks, given that the alsa-user-mailinglist has some strange kind of authentication mechanism, and admin-authorization and whatever, I'm writing this mail to the LKML (it would have been CCed here anyway). The current snd-powermac module from ALSA seems to have trouble with modern Apple iBook

Re: [PATCH] no need to check for NULL before calling kfree() -fs/ext2/

2005-03-27 Thread Jesper Juhl
On Sun, 27 Mar 2005, Dave Jones wrote: > Am I the only person who is completely fascinated by the > effort being spent here micro-optimising something thats > almost never in a path that needs optimising ? > I'd be amazed if any of this masturbation showed the tiniest > blip on a real workload,

[RFC] Driver States

2005-03-27 Thread Adam Belay
Dynamic power management may require devices and drivers to transition between various physical and logical states. I would like to start a discussion on how these might be defined at the bus, driver, and class levels. Bus Level = At the bus level, there are two state attributes, power

Re: Do not misuse Coverity please (Was: sound/oss/cs46xx.c: fix a check after use)

2005-03-27 Thread Russell King
On Mon, Mar 28, 2005 at 12:34:01AM +0200, Jean Delvare wrote: > I think that you'd be better just telling the > maintainers about the problem without providing an arbitrary patch, so > that they will actually look into the problem with their advanced > knowledge of the driver FWIW, I agree with

Re: Can't use SYSFS for "Proprietry" driver modules !!!.

2005-03-27 Thread Dave Airlie
> > How about the fact that when you load a kernel module, it is linked into > > the main kernel image? The GPL explicitly states what needs to be done > > for code linked in. > > > I've always wondered about dynamically loaded modules (and libraries for > that matter). The standard IANAL, but

Re: Do not misuse Coverity please (Was: sound/oss/cs46xx.c: fix a check after use)

2005-03-27 Thread Jean Delvare
Hi Adrian, > There are two cases: > 1. NULL is impossible, the check is superfluous > 2. this was an actual bug Agreed. > In the first case, my patch doesn't do any harm (a superfluous isn't > a real bug). The fact that it isn't a bug does not imply that the patch doesn't harm. Tricking the

Network Performance Ingo's RT-Preempt

2005-03-27 Thread Christensen Tom
I'm running 2.6.11 with Ingo's Preempt patch (realtime-preempt-2.6.11-final-V0.7.40-04). The system is SMP with a broadcom NIC (tg3 driver). I am seeing truly appalling network performance (2-4kbps on a 1gbps network). Is this a known issue? I know this patch is not production ready, what

i386/x86_64 segment register issuses (Re: PATCH: Fix x86 segment register access)

2005-03-27 Thread H. J. Lu
It turns out that 2.4 kernel has arch/i386/kernel/process.c: asm volatile("movl %%" #seg ",%0":"=m" (*(int *)&(value))) arch/i386/kernel/process.c: asm volatile("movl %%fs,%0":"=m" (*(int *)>fs)); arch/i386/kernel/process.c: asm volatile("movl %%gs,%0":"=m" (*(int *)>gs));

Re: [RFC] Some thoughts on device drivers and sysfs

2005-03-27 Thread Adam Belay
On Sun, 2005-03-27 at 23:43 +0200, Dominik Brodowski wrote: > On Sun, Mar 27, 2005 at 04:27:24PM -0500, Adam Belay wrote: > > > extern int device_create_file(struct device *device, struct > > > device_attribute > > > * entry); > > > and delete them (e.g. in ->remove) using > > > extern void

Re: SATA Promise TX4 Crash

2005-03-27 Thread Neil Whelchel
On Sat, 26 Mar 2005, quasiben wrote: > Dear Neil Whelchel, > I have been having very similar problems. However, my setup is > somewhat different. I have a LVM logical volume that spans two disks > (one PATA and one SATA). Did you upgrade your PSU as one person > suggested ? If so, did it

Re: [PATCH] no need to check for NULL before calling kfree() -fs/ext2/

2005-03-27 Thread linux-os
On Sat, 26 Mar 2005, Marcin Dalecki wrote: On 2005-03-27, at 00:21, linux-os wrote: Always, always, a call will be more expensive than a branch on condition. It's impossible to be otherwise. A call requires that the return address be written to memory (the stack), using register indirection (the

Re: [2.6 patch] drivers/usb/media/usbvideo.c: fix a check after use

2005-03-27 Thread Jean Delvare
Hi Adrian, > This patch fixes a check after use found by the Coverity checker. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- linux-2.6.12-rc1-mm1-full/drivers/usb/media/usbvideo.c.old > 2005-03-23 04:59:11.0 +0100 > +++

Re: Can't use SYSFS for "Proprietry" driver modules !!!.

2005-03-27 Thread Adrian Bunk
On Sun, Mar 27, 2005 at 01:37:11PM -0500, Steven Rostedt wrote: >... > Wasn't this long ago proven in court that the license of headers can't > control the code that calls them. IIRC, it was with X Motif and making > free libraries for that. So, actually it was for a free solution for a > non

Re: Can't use SYSFS for "Proprietry" driver modules !!!.

2005-03-27 Thread Steven Rostedt
On Sun, 2005-03-27 at 10:10 -0800, Greg KH wrote: > How about the fact that when you load a kernel module, it is linked into > the main kernel image? The GPL explicitly states what needs to be done > for code linked in. > I've always wondered about dynamically loaded modules (and libraries for

Re: [RFC] Some thoughts on device drivers and sysfs

2005-03-27 Thread Dominik Brodowski
On Sun, Mar 27, 2005 at 04:27:24PM -0500, Adam Belay wrote: > > extern int device_create_file(struct device *device, struct device_attribute > > * entry); > > and delete them (e.g. in ->remove) using > > extern void device_remove_file(struct device * dev, struct device_attribute > > * attr); > >

Re: Do not misuse Coverity please (Was: sound/oss/cs46xx.c: fix a check after use)

2005-03-27 Thread Adrian Bunk
On Sun, Mar 27, 2005 at 11:21:58PM +0200, Jean Delvare wrote: > Hi Adrian, > > > This patch fixes a check after use found by the Coverity checker. > > (...) > > static void amp_hercules(struct cs_card *card, int change) > > { > > - int old=card->amplifier; > > + int old; > > if(!card) >

Re: [RFC] Some thoughts on device drivers and sysfs

2005-03-27 Thread Jon Smirl
On Sun, 27 Mar 2005 14:24:59 -0500, Adam Belay <[EMAIL PROTECTED]> wrote: > This would allow us to represent per-device driver attributes in sysfs. > As an added benefit, driver devices would allow the tracking and control > of driver state, which may be needed for dynamic power management. I >

Re: Do not misuse Coverity please (Was: sound/oss/cs46xx.c: fix a check after use)

2005-03-27 Thread Jean Delvare
Hi Adrian, > This patch fixes a check after use found by the Coverity checker. > (...) > static void amp_hercules(struct cs_card *card, int change) > { > - int old=card->amplifier; > + int old; > if(!card) > { > CS_DBGOUT(CS_ERROR, 2, printk(KERN_INFO >

Re: Can't use SYSFS for "Proprietry" driver modules !!!.

2005-03-27 Thread Diego Calleja
El Sun, 27 Mar 2005 11:16:54 -0800, Aaron Gyes <[EMAIL PROTECTED]> escribió: > company that made the device? Should NVIDIA be forced to give up their > secrets to all their competitors because some over zealous developers > say so? Should the end-users of the current drivers be forced to lose Is

[2.6 patch] MAINTAINERS: remove obsolete HPUSBSCSI entry

2005-03-27 Thread Adrian Bunk
It seems I forgot MAINTAINERS in my patch that removed this driver... Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-mm3-full/MAINTAINERS.old 2005-03-27 23:17:59.0 +0200 +++ linux-2.6.12-rc1-mm3-full/MAINTAINERS 2005-03-27 23:18:07.0 +0200 @@

[2.6 patch] sound/oss/rme96xx.c: fix two check after use

2005-03-27 Thread Adrian Bunk
This patch fixes two check after use found by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-mm3-full/sound/oss/rme96xx.c.old 2005-03-27 23:16:02.0 +0200 +++ linux-2.6.12-rc1-mm3-full/sound/oss/rme96xx.c 2005-03-27 23:16:11.0

[2.6 patch] drivers/pci/msi.c: fix a check after use

2005-03-27 Thread Adrian Bunk
This patch fixes a check after use found by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-mm1-full/drivers/pci/msi.c.old 2005-03-23 04:46:30.0 +0100 +++ linux-2.6.12-rc1-mm1-full/drivers/pci/msi.c 2005-03-23 04:47:03.0 +0100 @@

Re: [RFC] Some thoughts on device drivers and sysfs

2005-03-27 Thread Dominik Brodowski
On Sun, Mar 27, 2005 at 02:24:59PM -0500, Adam Belay wrote: > One of the original design goals of sysfs was to provide a standardized > location to keep driver configuration attributes. Although sysfs > handles this very well for bus devices and class devices, there isn't > currently a method to

Re: BK snapshots removed from kernel.org?

2005-03-27 Thread Barry K. Nathan
On Sun, Mar 27, 2005 at 02:14:33PM -0300, Norberto Bensa wrote: [quote rewrapped to keep it within 80 columns] > Why were snapshots (-bk) removed from www.kernel.org? I can't see any > relevant post in LKML. It happens whenever the kernel.org scripts get confused. It's happened at least once

[2.6 patch] sound/oss/cs46xx.c: fix a check after use

2005-03-27 Thread Adrian Bunk
This patch fixes a check after use found by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-mm1-full/sound/oss/cs46xx.c.old2005-03-23 04:48:53.0 +0100 +++ linux-2.6.12-rc1-mm1-full/sound/oss/cs46xx.c2005-03-23 04:49:31.0

Re: Can't use SYSFS for "Proprietry" driver modules !!!.

2005-03-27 Thread James Courtier-Dutton
Mark Fortescue wrote: > Hi, > > I am writing a "Proprietry" driver module for a "Proprietry" PCI card and > I have found that I can't use SYSFS on Linux-2.6.10. > > Why ?. > > I am not modifing the Kernel/SYSFS code so I should be able, to use all > the SYSFS/internal kernel function calls

[2.6 patch] drivers/usb/media/usbvideo.c: fix a check after use

2005-03-27 Thread Adrian Bunk
This patch fixes a check after use found by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-mm1-full/drivers/usb/media/usbvideo.c.old 2005-03-23 04:59:11.0 +0100 +++ linux-2.6.12-rc1-mm1-full/drivers/usb/media/usbvideo.c 2005-03-23

[2.6 patch] fs/udf/inode.c: fix a check after use

2005-03-27 Thread Adrian Bunk
This patch fixes a check after use found by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-mm1-full/fs/udf/inode.c.old2005-03-23 05:12:25.0 +0100 +++ linux-2.6.12-rc1-mm1-full/fs/udf/inode.c2005-03-23 05:12:53.0 +0100 @@

[2.6 patch] drivers/net/pcmcia/nmclan_cs.c: fix a check after use

2005-03-27 Thread Adrian Bunk
This patch fixes a check after use found by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-mm1-full/drivers/net/pcmcia/nmclan_cs.c.old 2005-03-23 05:04:00.0 +0100 +++ linux-2.6.12-rc1-mm1-full/drivers/net/pcmcia/nmclan_cs.c2005-03-23

[2.6 patch] drivers/scsi/sg.c: fix check after use

2005-03-27 Thread Adrian Bunk
This patch fixes a check after use found by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-mm1-full/drivers/scsi/sg.c.old 2005-03-23 04:57:20.0 +0100 +++ linux-2.6.12-rc1-mm1-full/drivers/scsi/sg.c 2005-03-23 04:57:50.0 +0100 @@

[2.6 patch] drivers/video/console/fbcon.c: fix a check after use

2005-03-27 Thread Adrian Bunk
This patch fixes a check after use found by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-mm1-full/drivers/video/console/fbcon.c.old 2005-03-23 04:53:20.0 +0100 +++ linux-2.6.12-rc1-mm1-full/drivers/video/console/fbcon.c 2005-03-23

[2.6 patch] fs/udf/udftime.c: fix off by one error

2005-03-27 Thread Adrian Bunk
This patch fixes an off by one error found by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-mm1-full/fs/udf/udftime.c.old 2005-03-23 01:22:02.0 +0100 +++ linux-2.6.12-rc1-mm1-full/fs/udf/udftime.c 2005-03-23 01:22:13.0 +0100 @@

[2.6 patch] sound/oss/sonicvibes.c: fix an array overflow

2005-03-27 Thread Adrian Bunk
This patch fixes an array overflow found by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-mm1-full/sound/oss/sonicvibes.c.old2005-03-23 01:53:13.0 +0100 +++ linux-2.6.12-rc1-mm1-full/sound/oss/sonicvibes.c2005-03-23

[2.6 patch] drivers/input/joystick/spaceorb.c: fix an array overflow

2005-03-27 Thread Adrian Bunk
This patch fixes an array overflow found by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-mm1-full/drivers/input/joystick/spaceorb.c.old 2005-03-23 02:12:33.0 +0100 +++ linux-2.6.12-rc1-mm1-full/drivers/input/joystick/spaceorb.c 2005-03-23

[2.6 patch] fix NCR53C9x.c compile warning

2005-03-27 Thread Adrian Bunk
This patch fixes the following warning: CC [M] drivers/scsi/NCR53C9x.o drivers/scsi/NCR53C9x.c: In function `esp_do_data': drivers/scsi/NCR53C9x.c:1838: warning: unused variable `flags' Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 12 Aug 2004 - 20 Dec

[2.6 patch] drivers/pnp/pnpacpi/rsparser.c: fix an array overflow

2005-03-27 Thread Adrian Bunk
This patch fixes an array overflow found by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-mm1-full/drivers/pnp/pnpacpi/rsparser.c.old 2005-03-23 02:58:31.0 +0100 +++ linux-2.6.12-rc1-mm1-full/drivers/pnp/pnpacpi/rsparser.c2005-03-23

[2.6 patch] drivers/video/radeonfb.c: fix an array overflow

2005-03-27 Thread Adrian Bunk
This patch fixes an array overflow found by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-mm1-full/drivers/video/radeonfb.c.old 2005-03-23 01:50:14.0 +0100 +++ linux-2.6.12-rc1-mm1-full/drivers/video/radeonfb.c 2005-03-23

[2.6 patch] drivers/pnp/pnpbios/rsparser.c: fix an array overflow

2005-03-27 Thread Adrian Bunk
This patch fixes an array overflow found by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-mm1-full/drivers/pnp/pnpbios/rsparser.c.old 2005-03-23 03:04:17.0 +0100 +++ linux-2.6.12-rc1-mm1-full/drivers/pnp/pnpbios/rsparser.c2005-03-23

[2.6 patch] SCSI: cleanups

2005-03-27 Thread Adrian Bunk
This patch contains the following cleanups: - make needlessly global code static - remove the following unused functions: - scsi.h: print_driverbyte - scsi.h: print_hostbyte - #if 0 the following unused functions: - constants.c: scsi_print_hostbyte - constants.c: scsi_print_driverbyte -

[-mm patch] always enable regparm on i386

2005-03-27 Thread Adrian Bunk
The patch below always enables regparm on i386 (with gcc >= 3.0). With this patch, it should get a better testing coverage in -mm. This patch should help to find bugs that show up with regparm enabled. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> ---

Re: [Ext2-devel] Re: OOM problems on 2.6.12-rc1 with many fsx tests

2005-03-27 Thread Badari Pulavarty
Badari Pulavarty wrote: Mingming Cao wrote: On Sat, 2005-03-26 at 16:23 -0800, Mingming Cao wrote: On Fri, 2005-03-25 at 14:11 -0800, Badari Pulavarty wrote: On Fri, 2005-03-25 at 13:56, Andrew Morton wrote: Mingming Cao <[EMAIL PROTECTED]> wrote: I run into OOM problem again on 2.6.12-rc1. I run

Re: [Ext2-devel] Re: OOM problems on 2.6.12-rc1 with many fsx tests

2005-03-27 Thread Badari Pulavarty
Mingming Cao wrote: On Sat, 2005-03-26 at 16:23 -0800, Mingming Cao wrote: On Fri, 2005-03-25 at 14:11 -0800, Badari Pulavarty wrote: On Fri, 2005-03-25 at 13:56, Andrew Morton wrote: Mingming Cao <[EMAIL PROTECTED]> wrote: I run into OOM problem again on 2.6.12-rc1. I run some(20) fsx tests on

Re: [PATCH] typo fix in Documentation/eisa.txt

2005-03-27 Thread Jean Delvare
> > > Force the probing code to probe EISA slots even when it cannot find an > > > -EISA compliant mainboard (nothing appears on slot 0). Defaultd to 0 > > > +EISA compliant mainboard (nothing appears on slot 0). Default to 0 > > > (don't force), and set to 1 (force probing) when either > > >

Re: Linux 2.6.11.6

2005-03-27 Thread Chris Wright
* Ryan Anderson ([EMAIL PROTECTED]) wrote: > On Sat, Mar 26, 2005 at 01:27:53AM -0800, Chris Wright wrote: > > > Could you please add CAN IDs to the stable changelog for already assigned > > > vulnerabilities? > > > > That's what I did for .5 -> .6. We can't retroactively update changeset > >

Re: [PATCH] typo fix in Documentation/eisa.txt

2005-03-27 Thread Rolf Eike Beer
Typo fixes. Thanks to Randy Dunlap and Jean Delvare. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- linux-2.6.11/Documentation/eisa.txt 2005-03-02 08:38:12.0 +0100 +++ linux-2.6.12-rc1/Documentation/eisa.txt 2005-03-27 21:58:04.0 +0200 @@ -171,9 +171,9 @@

2.6.11-bk10 non-fatal oops mkdir'ing loop-mounted UDF image

2005-03-27 Thread Alessandro Suardi
Machine is a K7-800 with 256MB, 2x160GB hard disks, a Samsung TL-552 burner running FC3 plus 2.6.11-bk10 from kernel.org. While trying to understand why mkisofs -dvd-video creates an image with a VOB file that has a different MD5 sum than the original (reproducible), I wanted to give it

Re: [PATCH] typo fix in Documentation/eisa.txt

2005-03-27 Thread Randy.Dunlap
Rolf Eike Beer wrote: Jean Delvare wrote: Hi Eike, Trivial typo fix. (...) Force the probing code to probe EISA slots even when it cannot find an -EISA compliant mainboard (nothing appears on slot 0). Defaultd to 0 +EISA compliant mainboard (nothing appears on slot 0). Default to 0 (don't force),

Re: [PATCH] typo fix in Documentation/eisa.txt

2005-03-27 Thread Rolf Eike Beer
Jean Delvare wrote: > Hi Eike, > > > Trivial typo fix. > > (...) > > Force the probing code to probe EISA slots even when it cannot find an > > -EISA compliant mainboard (nothing appears on slot 0). Defaultd to 0 > > +EISA compliant mainboard (nothing appears on slot 0). Default to 0 > > (don't

Re: Can't use SYSFS for "Proprietry" driver modules !!!.

2005-03-27 Thread Adrian Bunk
On Sun, Mar 27, 2005 at 11:16:54AM -0800, Aaron Gyes wrote: > > And then the user want to upgrade the 2.0 kernel that shipped with this > > box although the company that made the hardware went bankrupt some years > > ago. > > > > If the user has the source of the driver, he can port the driver

Re: [PATCH] typo fix in Documentation/eisa.txt

2005-03-27 Thread Jean Delvare
Hi Eike, > Trivial typo fix. > (...) > Force the probing code to probe EISA slots even when it cannot find an > -EISA compliant mainboard (nothing appears on slot 0). Defaultd to 0 > +EISA compliant mainboard (nothing appears on slot 0). Default to 0 > (don't force), and set to 1 (force

Re: Can't use SYSFS for "Proprietry" driver modules !!!.

2005-03-27 Thread Kyle Moffett
On Mar 27, 2005, at 14:16, Aaron Gyes wrote: So what? Sure, GPL'd drivers are easier for an end-user in that case. What does that have to do with law? Well, under most interpretations of the GPL, you are *NOT* allowed to even _link_ non-GPL code with GPL code. (Basically, by distributing such a

[RFC] Some thoughts on device drivers and sysfs

2005-03-27 Thread Adam Belay
One of the original design goals of sysfs was to provide a standardized location to keep driver configuration attributes. Although sysfs handles this very well for bus devices and class devices, there isn't currently a method to export attributes for device drivers and their specific bound device

Re: [Ext2-devel] Re: OOM problems on 2.6.12-rc1 with many fsx tests

2005-03-27 Thread Mingming Cao
On Sat, 2005-03-26 at 16:23 -0800, Mingming Cao wrote: > On Fri, 2005-03-25 at 14:11 -0800, Badari Pulavarty wrote: > > On Fri, 2005-03-25 at 13:56, Andrew Morton wrote: > > > Mingming Cao <[EMAIL PROTECTED]> wrote: > > > > > > > > I run into OOM problem again on 2.6.12-rc1. I run some(20) fsx

Re: [PATCH] no need to check for NULL before calling kfree() -fs/ext2/

2005-03-27 Thread Pekka Enberg
On Sun, 27 Mar 2005 12:40:26 -0500, Dave Jones <[EMAIL PROTECTED]> wrote: > Am I the only person who is completely fascinated by the > effort being spent here micro-optimising something thats > almost never in a path that needs optimising ? > I'd be amazed if any of this masturbation showed the

[OOPS] 2.6.11 - NMI lockup with CFQ scheduler

2005-03-27 Thread Chris Rankin
[gcc-3.4.3, Linux-2.6.11-SMP, Dual P4 Xeon with HT enabled] Hi, My Linux 2.6.11 box oopsed when I tried to logout. I have switched to using the anticipatory scheduler instead. Cheers, Chris NMI Watchdog detected LOCKUP on CPU1, eip c0275cc7, registers: Modules linked in: snd_pcm_oss

[PATCH] typo fix in drivers/scsi/sata_svw.c

2005-03-27 Thread Rolf Eike Beer
Add missing brace. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- linux-2.6.11/drivers/scsi/sata_svw.c2005-03-21 11:41:58.0 +0100 +++ linux-2.6.12-rc1/drivers/scsi/sata_svw.c2005-03-27 15:50:38.0 +0200 @@ -395,7 +395,7 @@ /* Clear a magic bit in

Re: Can't use SYSFS for "Proprietry" driver modules !!!.

2005-03-27 Thread Aaron Gyes
> And then the user want to upgrade the 2.0 kernel that shipped with this > box although the company that made the hardware went bankrupt some years > ago. > > If the user has the source of the driver, he can port the driver or hire > someone to port the driver (this "obscure piece of

  1   2   3   4   >