Re: Development Model

2005-04-21 Thread Ralf Baechle
On Tue, Apr 19, 2005 at 03:24:00PM -0400, Rik van Riel wrote: > The current development model seems to go much smoother than > anything I've seen before. It violates conventional wisdom and that psychological thing is the lion share of why some people feel uneasy about it. Dealing with the

Re: /proc/cpuinfo format - arch dependent!

2005-04-21 Thread Ralf Baechle
On Tue, Apr 19, 2005 at 09:24:17AM -0400, Lennart Sorensen wrote: > If you change it now, how many tools would break? > > Maybe if you can list what statistics you think should be common to all > systems, that could be presented in another file that is always the same > format on each

Re: [PATCH] kill old EH constants

2005-04-21 Thread Geert Uytterhoeven
On Wed, 20 Apr 2005, Linux Kernel Mailing List wrote: > tree 932c6f9689fd08a7a9d689cfbec8682ccde8175d > parent 84011ae88da62a20b3ae7b48e2ae3b1ef0fc810a > author <[EMAIL PROTECTED]> Mon, 11 Apr 2005 08:19:25 -0500 > committer James Bottomley <[EMAIL PROTECTED]> Sun, 17 Apr 2005 06:14:52 -0500 > >

Re: Serious performance degradation on a RAID with kernel 2.6.10-bk7 and later

2005-04-21 Thread Bartlomiej ZOLNIERKIEWICZ
Hi! A small update. Patching mm/filemap.c is not necessary in order to get the improved performance! It's sufficient to remove roundup_pow_of_two from |get_init_ra_size ... So a simple one-liner changes to picture dramatically. But why ?!?!? roundup_pow_of_two() uses fls() and ia64 has buggy

COMPILE-ERROR: 'make prepare ARCH=um' fails on 2.6.11.7

2005-04-21 Thread Frank Schruefer
Hello, 'make prepare ARCH=um' spits out some serious errors. 'make ARCH=um' works though - just takes ways longer ... Here are the 3 commands to reproduce plus the errornous output: - Stone:/usr/src/linux-2.6.11.7 # uname -a Linux Stone

Re: [RFC/PATCH] unregister_node() for hotplug use

2005-04-21 Thread Keiichiro Tokunaga
On Wed, 20 Apr 2005 14:35:10 +0200 Arjan van de Ven wrote: > > > diff -puN drivers/base/node.c~numa_hp_base drivers/base/node.c > > --- linux-2.6.12-rc2-mm3/drivers/base/node.c~numa_hp_base 2005-04-14 > > 20:49:37.0 +0900 > > +++ linux-2.6.12-rc2-mm3-kei/drivers/base/node.c

Re: Linux 2.6.12-rc3

2005-04-21 Thread Geert Uytterhoeven
On Thu, 21 Apr 2005, Jan Dittmer wrote: > Linus Torvalds wrote: > > Geert Uytterhoeven: > > [PATCH] M68k: Update defconfigs for 2.6.11 > > [PATCH] M68k: Update defconfigs for 2.6.12-rc2 > > Why do I still get this error when trying to cross-compile for m68k? Because to build m68k

Re: Disk output lockup 2.6.12_rc2 2.6.11.7

2005-04-21 Thread Mikael Andersson
Mikael Andersson wrote: > During heavy io-load a lockup occurs that appears to prevent any disk > output from taking place. fs is reiserfs on two device-mapper mirrored > 200G maxtor disks. After the lockup occurs you can to things like 'ls', > but echo > test.txt will hang. fs is now ext3 > >

Re: Linux 2.6.12-rc3

2005-04-21 Thread Jan Dittmer
Linus Torvalds wrote: > Geert Uytterhoeven: > [PATCH] M68k: Update defconfigs for 2.6.11 > [PATCH] M68k: Update defconfigs for 2.6.12-rc2 Why do I still get this error when trying to cross-compile for m68k? toolchain: Reading specs from

[RFC/PATCH 20/22] W1: add w1_device_id/MODULE_DEVICE_TABLE for automatic driver loading

2005-04-21 Thread Dmitry Torokhov
W1: support for automatic family drivers loading via hotplug: - allow family drivers support list of families; - export supported families through MODULE_DEVICE_TABLE. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/w1/w1.c |6 -- drivers/w1/w1.h

Re: [PATCH] Bad rounding in timeval_to_jiffies [was: Re: Odd Timer behavior in 2.6 vs 2.4 (1 extra tick)]

2005-04-21 Thread Russell King
On Wed, Apr 20, 2005 at 11:40:16PM -0400, Steven Rostedt wrote: > Is 11 jiffies correct for 10ms? Consider the 1 jiffy case. How long does waiting one jiffy actually wait? j=01 2 +--+--+--> t A B C D If you start timing one jiffy from

Re: Linux 2.6.12-rc3

2005-04-21 Thread Jan Dittmer
> [EMAIL PROTECTED]: > [PATCH] zfcp: convert to compat_ioctl This does not seem to compile anymore with defconfig: CC drivers/s390/scsi/zfcp_aux.o /usr/src/ctest/rc/kernel/drivers/s390/scsi/zfcp_aux.c:63: warning: initialization from incompatible pointer type

Re: [patch] fix race in __block_prepare_write (again)

2005-04-21 Thread Anton Altaparmakov
On Thu, 2005-04-21 at 17:20 +1000, Nick Piggin wrote: > On Thu, 2005-04-21 at 08:10 +0100, Anton Altaparmakov wrote: > > And one more thing... > > > > On Thu, 2005-04-21 at 08:01 +0100, Anton Altaparmakov wrote: > > > On Thu, 21 Apr 2005, Nick Piggin wrote: > > > > ... I somehow didn't send it to

Re: [patch] Real-Time Preemption, -RT-2.6.12-rc3-V0.7.46-00

2005-04-21 Thread Paolo Ciarrocchi
2005/4/21, Ingo Molnar <[EMAIL PROTECTED]>: > > i have released the -V0.7.46-00 Real-Time Preemption patch, which can be > downloaded from the usual place: > > http://redhat.com/~mingo/realtime-preempt/ > > this is a merge to 2.6.12-rc3, plus the 'ping localhost' fix from > [EMAIL PROTECTED]

[RFC/PATCH 22/22] W1: expose module parameters in sysfs

2005-04-21 Thread Dmitry Torokhov
W1: allow changing w1 module parameters through sysfs, add parameter descriptions and document them in Documentation/kernel-parameters.txt Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- Documentation/kernel-parameters.txt | 19 --- drivers/w1/w1.c

Re: Serious performance degradation on a RAID with kernel 2.6.10-bk7 and later

2005-04-21 Thread Andreas Hirstius
A small update. Patching mm/filemap.c is not necessary in order to get the improved performance! It's sufficient to remove roundup_pow_of_two from |get_init_ra_size ... So a simple one-liner changes to picture dramatically. But why ?!?!? Andreas | jmerkey wrote: For 3Ware, you need to chage

[RFC/PATCH 21/22] W1: implement standard hotplug handler

2005-04-21 Thread Dmitry Torokhov
Ahem.. Kmail just refuses send this on inline... Sorry. -- Dmitry W1: implement W1 bus hotplug handler. Slave devices will define FID (family ID) end SN (serial number) environment variables. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- w1.c | 51

Re: Linux 2.6.12-rc3

2005-04-21 Thread Martin Schlemmer
On Wed, 2005-04-20 at 17:59 -0700, Linus Torvalds wrote: > And for the crazy people, the git archive on kernel.org is up and running > under /pub/scm/linux/kernel/git/torvalds/linux-2.6.git. For the > adventurous of you, the name of the 2.6.12-rc3 release is a very nice and > readable: > >

Re: [PATCH] Updated: Dynamic Tick version 050408-1 - C-state measures

2005-04-21 Thread Thomas Renninger
Tony Lindgren wrote: > * Pavel Machek <[EMAIL PROTECTED]> [050419 14:10]: >>Hi! >> >>>The machine is a Pentium M 2.00 GHz, supporting C0-C4 processor power states. >>>The machine run at 2.00 GHz all the time. >>.. >>>_passing bm_history=0x (default) to processor module:_ >>> >>>Average

[RFC/PATCH 18/22] W1: cleanup family implementation

2005-04-21 Thread Dmitry Torokhov
W1: clean-up family implementation: - get rid of w1_family_ops and template attributes in w1_slave structure and have family drivers create necessary attributes themselves. There are too many different devices using 1-Wire interface and it is impossible to fit them all into

[RFC/PATCH 14/22] W1: rename timeout to scan_interval

2005-04-21 Thread Dmitry Torokhov
W1: more master attributes changes: - rename timeout parameter/attribute to scan_interval to better reflect its purpose; - make scan_timeout be a per-device attribute and allow changing it from userspace via sysfs; - allow changing max_slave_count it from userspace as well.

[RFC/PATCH 12/22] W1: drop unneeded master attributes

2005-04-21 Thread Dmitry Torokhov
W1: get rid of unneeded master device attributes: - 'pointer' and 'attempts' are meaningless for userspace; - information provided by 'slaves' and 'slave_count' can be gathered from other sysfs bits; - w1_slave_found has to be rearranged now that slave_count field is gone.

[RFC/PATCH 17/22] W1: cleanup slave refcounting & more

2005-04-21 Thread Dmitry Torokhov
W1: clean-up slave device implementation: - get rid of separate refcount, rely on driver model to enforce lifetime rules; - pin w1 module until slave device is registered with sysfs to make sure W1 core stays loaded. - drop 'name' attribute as we already have it in bus_id.

[RFC/PATCH 15/22] W1: add slave_ttl master attribute

2005-04-21 Thread Dmitry Torokhov
W1: add slave_ttl attribute to w1 masters. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- w1.c | 24 1 files changed, 24 insertions(+) Index: dtor/drivers/w1/w1.c === ---

[RFC/PATCH 16/22] W1: cleanup masters refcounting & more

2005-04-21 Thread Dmitry Torokhov
W1: clean-up master device implementation: - get rid of separate refcount, rely on driver model to enforce lifetime rules; - use atomic to generate unique master IDs; - drop unused fields. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- w1.c | 263

[RFC/PATCH 13/22] W1: cleanup master attributes handling

2005-04-21 Thread Dmitry Torokhov
W1: clean-up master attribute implementation: - drop unnecessary "w1_master" prefix from attribute names; - do not acquire master->mutex when accessing attributes; - move attribute code "closer" to the rest of master code. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- w1.c

[RFC/PATCH 11/22] W1: move w1_search to the rest of IO code

2005-04-21 Thread Dmitry Torokhov
W1: move w1_search function to w1_io.c to be with the rest of IO code. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- w1.c| 87 -- w1.h|1 w1_io.c | 89

[RFC/PATCH 10/22] W1: drop main control thread

2005-04-21 Thread Dmitry Torokhov
W1: Drop control thread from w1 core, whatever it does can also be done in the context of w1_remove_master_device. Also, pin the module when registering new master device to make sure that w1 core is not unloaded until last device is gone. This simplifies logic a lot.

[RFC/PATCH 9/22] W1: drop custom hotplug over netlink notification

2005-04-21 Thread Dmitry Torokhov
W1: drop custom-made hotplug over netlink notification from w1 core. Standard hotplug mechanism should work just fine (patch will follow). Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/w1/w1_netlink.c | 66 ---

[RFC/PATCH 8/22] W1: merge master code into one file

2005-04-21 Thread Dmitry Torokhov
W1: fold w1_int.c into w1.c - there is no point in artificially separating code for master devices between 2 files. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/w1/w1_int.c| 181 - drivers/w1/w1_int.h| 36

[RFC/PATCH 7/22] W1: bus operations cleanup

2005-04-21 Thread Dmitry Torokhov
W1: cleanup bus operations code: - have bus operatiions accept w1_master instead of unsigned long and drop data field from w1_bus_master so the structure can be statically allocated by driver implementing it; - rename w1_bus_master to w1_bus_ops to avoid confusion with

[RFC/PATCH 5/22] W1: list handling cleanup

2005-04-21 Thread Dmitry Torokhov
W1: list handling cleanup. Most of the list_for_each_safe users don't need *_safe variant, *_entry variant is better suited in most places. Also, checking retrieved list element for null is a bit pointless... Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- w1.c | 131

[RFC/PATCH 6/22] W1: drop owner field from master and slave structures

2005-04-21 Thread Dmitry Torokhov
W1: drop owner field from w1_master and w1_slave structures. Just having it there does not magically fixes lifetime rules. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- w1.c |1 - w1.h |2 -- w1_int.c |1 - 3 files changed, 4 deletions(-) Index:

[RFC/PATCH 4/22] W1: use attribute group for slave's attributes

2005-04-21 Thread Dmitry Torokhov
W1: add 2 default attributes "family" and "serial" to slave devices, every 1-Wire slave has them. Use attribute_group to handle. The rest of slave attributes are left as is - will be dealt with later. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- w1.c | 115

[RFC/PATCH 3/22] W1: use attribute group for master's attributes

2005-04-21 Thread Dmitry Torokhov
W1: use attribute_group to create master device attributes to guarantee proper cleanup in case of failure. Also, hide most of attribute define ugliness in macros. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- w1.c | 157

[RFC/PATCH 2/22] W1: formatting fixes

2005-04-21 Thread Dmitry Torokhov
w1: some formatting changes to bring the code in line with CodingStyle guidelines. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- dscore.c |4 +--- w1.c | 21 + 2 files changed, 10 insertions(+), 15 deletions(-) Index: dtor/drivers/w1/w1.c

[RFC/PATCH 1/22] W1: whitespace fixes

2005-04-21 Thread Dmitry Torokhov
W1: whitespace fixes. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- Kconfig| 14 +++--- Makefile |2 ds_w1_bridge.c | 24 +- dscore.c | 126 - dscore.h |6 +- matrox_w1.c| 10

[RFC/PATCH 0/22] W1: sysfs, lifetime and other fixes

2005-04-21 Thread Dmitry Torokhov
Hi, I happened to take a look into drivers/w1 and found there bunch of thigs that IMO should be changed: - custom-made refcounting is racy - lifetime rules need to be better enforced - family framework is insufficient for many advanced w1 devices - custom-made hotplug notification over netlink

Re: [ Patch ]: Fix loopback communication latency bug

2005-04-21 Thread Ingo Molnar
* yangyi <[EMAIL PROTECTED]> wrote: > Hi, Ingo > > For the option PREEMPT_RT, local communication latency is very very > big, it is about 30 to 50 times as big as the option PREEMPT_NONE as > far as local ping latency is concerned. Obviously, this should be > fixed ASAP. > > This patch

2.6.12-rc3 cpufreq compile error on ppc32

2005-04-21 Thread Colin Leroy
Hi guys, One of Ben's patches ("ppc32: Fix cpufreq problems") went in 2.6.12- rc3, but it depended on another patch that's still in -mm only: add-suspend-method-to-cpufreq-core.patch In addition to this, there's a third patch in -mm that fixes warnings and line length to the previous patch, but

Re: [patch] fix race in __block_prepare_write (again)

2005-04-21 Thread Nick Piggin
On Thu, 2005-04-21 at 08:10 +0100, Anton Altaparmakov wrote: > And one more thing... > > On Thu, 2005-04-21 at 08:01 +0100, Anton Altaparmakov wrote: > > On Thu, 21 Apr 2005, Nick Piggin wrote: > > > ... I somehow didn't send it to Andrew last time. > > > > > > Fix a race where

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Bodo Eggert <[EMAIL PROTECTED]>
Ed L Cashin <[EMAIL PROTECTED]> wrote: > +++ b/Documentation/aoe/aoe.txt 2005-04-20 11:42:20.0 -0400 > + When the aoe driver is a module, use Is there any reason for this inconsistent behaviour? > + /sys/module/aoe/parameters/aoe_iflist instead of

Re: [patch] fix race in __block_prepare_write (again)

2005-04-21 Thread Nick Piggin
On Thu, 2005-04-21 at 08:01 +0100, Anton Altaparmakov wrote: > Any reason why you left the goto out? It would be IMO much cleaner to > remove the label "out" altogether and replace the single "goto out" with a > "break" (which is fine since the goto happens inside the for loop > immediately

Re: [patch] fix race in __block_prepare_write (again)

2005-04-21 Thread Anton Altaparmakov
And one more thing... On Thu, 2005-04-21 at 08:01 +0100, Anton Altaparmakov wrote: > On Thu, 21 Apr 2005, Nick Piggin wrote: > > ... I somehow didn't send it to Andrew last time. > > > > Fix a race where __block_prepare_write can leak out an in-flight > > read against a bh if get_block returns

Re: [patch] fix race in __block_prepare_write (again)

2005-04-21 Thread Anton Altaparmakov
Hi, On Thu, 21 Apr 2005, Nick Piggin wrote: > ... I somehow didn't send it to Andrew last time. > > Fix a race where __block_prepare_write can leak out an in-flight > read against a bh if get_block returns an error. This can lead to > the page becoming unlocked while the buffer is locked and the

hpfsck question

2005-04-21 Thread Colin Leroy
Hi Klaus, Yesterday I tried to mount my iPod as usual, but the hfsplus kernel module complained the following: HFS+-fs warning: Filesystem was not cleanly unmounted, running fsck.hfsplus is recommended. mounting read-only. So I installed your hfsplusutils package and ran hpfsck. After that

Re: [PATCH] remove some usesless casts

2005-04-21 Thread Jörn Engel
On Thu, 21 April 2005 09:36:18 +0300, Pekka Enberg wrote: > > I think Jörn means that if you need an opaque data type, use void > pointers (which are automatically cast to the proper type) and that > all other casts are a design smell (except for the one or two special > cases where you actually

Re: [PATCH] sparc64: Fix copy_sigingo_to_user32()

2005-04-21 Thread Matthew Wilcox
On Wed, Apr 20, 2005 at 11:08:10PM -0700, Linux Kernel Mailing List wrote: > tree 19b2c9e85dcab6df9250ba38df885d951c96e0a6 > parent dadeafdfc8da8c27e5a68e0706b9856eaac89391 > author Jurij Smakov <[EMAIL PROTECTED]> Mon, 18 Apr 2005 08:03:12 -0700 > committer Linus Torvalds <[EMAIL PROTECTED]> Mon,

Re: [PATCH] remove some usesless casts

2005-04-21 Thread Pekka Enberg
Phillip, Jörn Engel wrote: > > Your definition of _unnecessary_ casts may differ from mine. > > Basically, every cast is unnecessary, except for maybe one or two - if > > that many. On 4/20/05, Phillip Lougher <[EMAIL PROTECTED]> wrote: > Well we agree to differ then. In my experience casts are

Re: Git-commits mailing list feed.

2005-04-21 Thread David Woodhouse
On Thu, 2005-04-21 at 08:24 +0200, Jan Dittmer wrote: > What about the daily snapshots? Is there any eta when they'll be back? Those were done by Jeff, not me. I'm planning to fix up the web page which lists individual commits some time next week, and if Jeff wants me to I could start generating

Re: Git-commits mailing list feed.

2005-04-21 Thread Jan Dittmer
David Woodhouse wrote: > As of some time in the fairly near future, the [EMAIL PROTECTED] mailing > list will be carrying real commits from Linus' live git repository, instead > of just testing patches. Have fun. > What about the daily snapshots? Is there any eta when they'll be back? -- Jan

[patch] fix race in __block_prepare_write (again)

2005-04-21 Thread Nick Piggin
... I somehow didn't send it to Andrew last time. -- SUSE Labs, Novell Inc. Fix a race where __block_prepare_write can leak out an in-flight read against a bh if get_block returns an error. This can lead to the page becoming unlocked while the buffer is locked and the read still in flight.

Dell D810 Laptop Suspend/Resume

2005-04-21 Thread Davy Durham
Hi, I've been trying for the last few days to get my D810 to suspend and resume in linux. I'm doing it from klaptop in kde using Fedora Core 3, but I've now compiled my own linux-2.6.12-rc2-mm3 kernel since I've seen some ACPI changes going in. At 2.6.11 it would seem to suspend ok, but

Tired of waiting for the software to be delivered to you? Buy and download.For PC and Macintosh

2005-04-21 Thread EnislEd
www.h63dk6153ahyi2z.marvinfhlil.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[patch] fix race in __block_prepare_write

2005-04-21 Thread Nick Piggin
Questions? Comments? -- SUSE Labs, Novell Inc. Fix a race where __block_prepare_write can leak out an in-flight read against a bh if get_block returns an error. This can lead to the page becoming unlocked while the buffer is locked and the read still in flight. __mpage_writepage BUGs on this

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-21 Thread Jens Axboe
On Wed, Apr 20 2005, James Bottomley wrote: > On Wed, 2005-04-20 at 08:15 +0900, Tejun Heo wrote: > > -* Insert this command at the head of the queue for it's device. > > -* It will go before all other commands that are already in the queue. > > -* > > -* NOTE: there is magic here

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-21 Thread Jens Axboe
On Wed, Apr 20 2005, James Bottomley wrote: On Wed, 2005-04-20 at 08:15 +0900, Tejun Heo wrote: -* Insert this command at the head of the queue for it's device. -* It will go before all other commands that are already in the queue. -* -* NOTE: there is magic here about the

Tired of waiting for the software to be delivered to you? Buy and download.For PC and Macintosh

2005-04-21 Thread EnislEd
www.h63dk6153ahyi2z.marvinfhlil.com - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[patch] fix race in __block_prepare_write

2005-04-21 Thread Nick Piggin
Questions? Comments? -- SUSE Labs, Novell Inc. Fix a race where __block_prepare_write can leak out an in-flight read against a bh if get_block returns an error. This can lead to the page becoming unlocked while the buffer is locked and the read still in flight. __mpage_writepage BUGs on this

Dell D810 Laptop Suspend/Resume

2005-04-21 Thread Davy Durham
Hi, I've been trying for the last few days to get my D810 to suspend and resume in linux. I'm doing it from klaptop in kde using Fedora Core 3, but I've now compiled my own linux-2.6.12-rc2-mm3 kernel since I've seen some ACPI changes going in. At 2.6.11 it would seem to suspend ok, but

[patch] fix race in __block_prepare_write (again)

2005-04-21 Thread Nick Piggin
... I somehow didn't send it to Andrew last time. -- SUSE Labs, Novell Inc. Fix a race where __block_prepare_write can leak out an in-flight read against a bh if get_block returns an error. This can lead to the page becoming unlocked while the buffer is locked and the read still in flight.

Re: Git-commits mailing list feed.

2005-04-21 Thread David Woodhouse
On Thu, 2005-04-21 at 08:24 +0200, Jan Dittmer wrote: What about the daily snapshots? Is there any eta when they'll be back? Those were done by Jeff, not me. I'm planning to fix up the web page which lists individual commits some time next week, and if Jeff wants me to I could start generating

Re: [PATCH] remove some usesless casts

2005-04-21 Thread Pekka Enberg
Phillip, Jörn Engel wrote: Your definition of _unnecessary_ casts may differ from mine. Basically, every cast is unnecessary, except for maybe one or two - if that many. On 4/20/05, Phillip Lougher [EMAIL PROTECTED] wrote: Well we agree to differ then. In my experience casts are

Re: [PATCH] sparc64: Fix copy_sigingo_to_user32()

2005-04-21 Thread Matthew Wilcox
On Wed, Apr 20, 2005 at 11:08:10PM -0700, Linux Kernel Mailing List wrote: tree 19b2c9e85dcab6df9250ba38df885d951c96e0a6 parent dadeafdfc8da8c27e5a68e0706b9856eaac89391 author Jurij Smakov [EMAIL PROTECTED] Mon, 18 Apr 2005 08:03:12 -0700 committer Linus Torvalds [EMAIL PROTECTED] Mon, 18 Apr

Re: [PATCH] remove some usesless casts

2005-04-21 Thread Jörn Engel
On Thu, 21 April 2005 09:36:18 +0300, Pekka Enberg wrote: I think Jörn means that if you need an opaque data type, use void pointers (which are automatically cast to the proper type) and that all other casts are a design smell (except for the one or two special cases where you actually need

hpfsck question

2005-04-21 Thread Colin Leroy
Hi Klaus, Yesterday I tried to mount my iPod as usual, but the hfsplus kernel module complained the following: HFS+-fs warning: Filesystem was not cleanly unmounted, running fsck.hfsplus is recommended. mounting read-only. So I installed your hfsplusutils package and ran hpfsck. After that

Re: [patch] fix race in __block_prepare_write (again)

2005-04-21 Thread Anton Altaparmakov
Hi, On Thu, 21 Apr 2005, Nick Piggin wrote: ... I somehow didn't send it to Andrew last time. Fix a race where __block_prepare_write can leak out an in-flight read against a bh if get_block returns an error. This can lead to the page becoming unlocked while the buffer is locked and the read

Re: [patch] fix race in __block_prepare_write (again)

2005-04-21 Thread Anton Altaparmakov
And one more thing... On Thu, 2005-04-21 at 08:01 +0100, Anton Altaparmakov wrote: On Thu, 21 Apr 2005, Nick Piggin wrote: ... I somehow didn't send it to Andrew last time. Fix a race where __block_prepare_write can leak out an in-flight read against a bh if get_block returns an error.

Re: [patch] fix race in __block_prepare_write (again)

2005-04-21 Thread Nick Piggin
On Thu, 2005-04-21 at 08:01 +0100, Anton Altaparmakov wrote: Any reason why you left the goto out? It would be IMO much cleaner to remove the label out altogether and replace the single goto out with a break (which is fine since the goto happens inside the for loop immediately after which

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Bodo Eggert [EMAIL PROTECTED]
Ed L Cashin [EMAIL PROTECTED] wrote: +++ b/Documentation/aoe/aoe.txt 2005-04-20 11:42:20.0 -0400 + When the aoe driver is a module, use Is there any reason for this inconsistent behaviour? + /sys/module/aoe/parameters/aoe_iflist instead of ^^^

Re: [patch] fix race in __block_prepare_write (again)

2005-04-21 Thread Nick Piggin
On Thu, 2005-04-21 at 08:10 +0100, Anton Altaparmakov wrote: And one more thing... On Thu, 2005-04-21 at 08:01 +0100, Anton Altaparmakov wrote: On Thu, 21 Apr 2005, Nick Piggin wrote: ... I somehow didn't send it to Andrew last time. Fix a race where __block_prepare_write can leak

Re: [ Patch ]: Fix loopback communication latency bug

2005-04-21 Thread Ingo Molnar
* yangyi [EMAIL PROTECTED] wrote: Hi, Ingo For the option PREEMPT_RT, local communication latency is very very big, it is about 30 to 50 times as big as the option PREEMPT_NONE as far as local ping latency is concerned. Obviously, this should be fixed ASAP. This patch fixes this bug

[RFC/PATCH 0/22] W1: sysfs, lifetime and other fixes

2005-04-21 Thread Dmitry Torokhov
Hi, I happened to take a look into drivers/w1 and found there bunch of thigs that IMO should be changed: - custom-made refcounting is racy - lifetime rules need to be better enforced - family framework is insufficient for many advanced w1 devices - custom-made hotplug notification over netlink

2.6.12-rc3 cpufreq compile error on ppc32

2005-04-21 Thread Colin Leroy
Hi guys, One of Ben's patches (ppc32: Fix cpufreq problems) went in 2.6.12- rc3, but it depended on another patch that's still in -mm only: add-suspend-method-to-cpufreq-core.patch In addition to this, there's a third patch in -mm that fixes warnings and line length to the previous patch, but

[RFC/PATCH 1/22] W1: whitespace fixes

2005-04-21 Thread Dmitry Torokhov
W1: whitespace fixes. Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- Kconfig| 14 +++--- Makefile |2 ds_w1_bridge.c | 24 +- dscore.c | 126 - dscore.h |6 +- matrox_w1.c| 10

[RFC/PATCH 2/22] W1: formatting fixes

2005-04-21 Thread Dmitry Torokhov
w1: some formatting changes to bring the code in line with CodingStyle guidelines. Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- dscore.c |4 +--- w1.c | 21 + 2 files changed, 10 insertions(+), 15 deletions(-) Index: dtor/drivers/w1/w1.c

[RFC/PATCH 3/22] W1: use attribute group for master's attributes

2005-04-21 Thread Dmitry Torokhov
W1: use attribute_group to create master device attributes to guarantee proper cleanup in case of failure. Also, hide most of attribute define ugliness in macros. Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- w1.c | 157

[RFC/PATCH 4/22] W1: use attribute group for slave's attributes

2005-04-21 Thread Dmitry Torokhov
W1: add 2 default attributes family and serial to slave devices, every 1-Wire slave has them. Use attribute_group to handle. The rest of slave attributes are left as is - will be dealt with later. Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- w1.c | 115

[RFC/PATCH 6/22] W1: drop owner field from master and slave structures

2005-04-21 Thread Dmitry Torokhov
W1: drop owner field from w1_master and w1_slave structures. Just having it there does not magically fixes lifetime rules. Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- w1.c |1 - w1.h |2 -- w1_int.c |1 - 3 files changed, 4 deletions(-) Index:

[RFC/PATCH 5/22] W1: list handling cleanup

2005-04-21 Thread Dmitry Torokhov
W1: list handling cleanup. Most of the list_for_each_safe users don't need *_safe variant, *_entry variant is better suited in most places. Also, checking retrieved list element for null is a bit pointless... Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- w1.c | 131

[RFC/PATCH 7/22] W1: bus operations cleanup

2005-04-21 Thread Dmitry Torokhov
W1: cleanup bus operations code: - have bus operatiions accept w1_master instead of unsigned long and drop data field from w1_bus_master so the structure can be statically allocated by driver implementing it; - rename w1_bus_master to w1_bus_ops to avoid confusion with

[RFC/PATCH 8/22] W1: merge master code into one file

2005-04-21 Thread Dmitry Torokhov
W1: fold w1_int.c into w1.c - there is no point in artificially separating code for master devices between 2 files. Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/w1/w1_int.c| 181 - drivers/w1/w1_int.h| 36

[RFC/PATCH 10/22] W1: drop main control thread

2005-04-21 Thread Dmitry Torokhov
W1: Drop control thread from w1 core, whatever it does can also be done in the context of w1_remove_master_device. Also, pin the module when registering new master device to make sure that w1 core is not unloaded until last device is gone. This simplifies logic a lot.

[RFC/PATCH 9/22] W1: drop custom hotplug over netlink notification

2005-04-21 Thread Dmitry Torokhov
W1: drop custom-made hotplug over netlink notification from w1 core. Standard hotplug mechanism should work just fine (patch will follow). Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/w1/w1_netlink.c | 66 ---

[RFC/PATCH 11/22] W1: move w1_search to the rest of IO code

2005-04-21 Thread Dmitry Torokhov
W1: move w1_search function to w1_io.c to be with the rest of IO code. Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- w1.c| 87 -- w1.h|1 w1_io.c | 89

[RFC/PATCH 13/22] W1: cleanup master attributes handling

2005-04-21 Thread Dmitry Torokhov
W1: clean-up master attribute implementation: - drop unnecessary w1_master prefix from attribute names; - do not acquire master-mutex when accessing attributes; - move attribute code closer to the rest of master code. Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- w1.c | 111

[RFC/PATCH 16/22] W1: cleanup masters refcounting more

2005-04-21 Thread Dmitry Torokhov
W1: clean-up master device implementation: - get rid of separate refcount, rely on driver model to enforce lifetime rules; - use atomic to generate unique master IDs; - drop unused fields. Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- w1.c | 263

[RFC/PATCH 15/22] W1: add slave_ttl master attribute

2005-04-21 Thread Dmitry Torokhov
W1: add slave_ttl attribute to w1 masters. Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- w1.c | 24 1 files changed, 24 insertions(+) Index: dtor/drivers/w1/w1.c === --- dtor.orig/drivers/w1/w1.c

[RFC/PATCH 17/22] W1: cleanup slave refcounting more

2005-04-21 Thread Dmitry Torokhov
W1: clean-up slave device implementation: - get rid of separate refcount, rely on driver model to enforce lifetime rules; - pin w1 module until slave device is registered with sysfs to make sure W1 core stays loaded. - drop 'name' attribute as we already have it in bus_id.

[RFC/PATCH 12/22] W1: drop unneeded master attributes

2005-04-21 Thread Dmitry Torokhov
W1: get rid of unneeded master device attributes: - 'pointer' and 'attempts' are meaningless for userspace; - information provided by 'slaves' and 'slave_count' can be gathered from other sysfs bits; - w1_slave_found has to be rearranged now that slave_count field is gone.

[RFC/PATCH 14/22] W1: rename timeout to scan_interval

2005-04-21 Thread Dmitry Torokhov
W1: more master attributes changes: - rename timeout parameter/attribute to scan_interval to better reflect its purpose; - make scan_timeout be a per-device attribute and allow changing it from userspace via sysfs; - allow changing max_slave_count it from userspace as well.

[RFC/PATCH 18/22] W1: cleanup family implementation

2005-04-21 Thread Dmitry Torokhov
W1: clean-up family implementation: - get rid of w1_family_ops and template attributes in w1_slave structure and have family drivers create necessary attributes themselves. There are too many different devices using 1-Wire interface and it is impossible to fit them all into

Re: [PATCH] Updated: Dynamic Tick version 050408-1 - C-state measures

2005-04-21 Thread Thomas Renninger
Tony Lindgren wrote: * Pavel Machek [EMAIL PROTECTED] [050419 14:10]: Hi! The machine is a Pentium M 2.00 GHz, supporting C0-C4 processor power states. The machine run at 2.00 GHz all the time. .. _passing bm_history=0x (default) to processor module:_ Average current the last 470

Re: Linux 2.6.12-rc3

2005-04-21 Thread Martin Schlemmer
On Wed, 2005-04-20 at 17:59 -0700, Linus Torvalds wrote: And for the crazy people, the git archive on kernel.org is up and running under /pub/scm/linux/kernel/git/torvalds/linux-2.6.git. For the adventurous of you, the name of the 2.6.12-rc3 release is a very nice and readable:

Re: Serious performance degradation on a RAID with kernel 2.6.10-bk7 and later

2005-04-21 Thread Andreas Hirstius
A small update. Patching mm/filemap.c is not necessary in order to get the improved performance! It's sufficient to remove roundup_pow_of_two from |get_init_ra_size ... So a simple one-liner changes to picture dramatically. But why ?!?!? Andreas | jmerkey wrote: For 3Ware, you need to chage

[RFC/PATCH 21/22] W1: implement standard hotplug handler

2005-04-21 Thread Dmitry Torokhov
Ahem.. Kmail just refuses send this on inline... Sorry. -- Dmitry W1: implement W1 bus hotplug handler. Slave devices will define FID (family ID) end SN (serial number) environment variables. Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- w1.c | 51

[RFC/PATCH 22/22] W1: expose module parameters in sysfs

2005-04-21 Thread Dmitry Torokhov
W1: allow changing w1 module parameters through sysfs, add parameter descriptions and document them in Documentation/kernel-parameters.txt Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- Documentation/kernel-parameters.txt | 19 --- drivers/w1/w1.c

Re: [patch] Real-Time Preemption, -RT-2.6.12-rc3-V0.7.46-00

2005-04-21 Thread Paolo Ciarrocchi
2005/4/21, Ingo Molnar [EMAIL PROTECTED]: i have released the -V0.7.46-00 Real-Time Preemption patch, which can be downloaded from the usual place: http://redhat.com/~mingo/realtime-preempt/ this is a merge to 2.6.12-rc3, plus the 'ping localhost' fix from [EMAIL PROTECTED] there

Re: [patch] fix race in __block_prepare_write (again)

2005-04-21 Thread Anton Altaparmakov
On Thu, 2005-04-21 at 17:20 +1000, Nick Piggin wrote: On Thu, 2005-04-21 at 08:10 +0100, Anton Altaparmakov wrote: And one more thing... On Thu, 2005-04-21 at 08:01 +0100, Anton Altaparmakov wrote: On Thu, 21 Apr 2005, Nick Piggin wrote: ... I somehow didn't send it to Andrew last

Re: Linux 2.6.12-rc3

2005-04-21 Thread Jan Dittmer
[EMAIL PROTECTED]: [PATCH] zfcp: convert to compat_ioctl This does not seem to compile anymore with defconfig: CC drivers/s390/scsi/zfcp_aux.o /usr/src/ctest/rc/kernel/drivers/s390/scsi/zfcp_aux.c:63: warning: initialization from incompatible pointer type

<    1   2   3   4   5   6   >