Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function

2006-11-28 Thread Patrick McHardy
Krzysztof Halasa wrote: Patrick McHardy [EMAIL PROTECTED] writes: It might be the case that your network device has a hard_header_len LL_MAX_HEADER, which could trigger a corruption. Hmm... GRE tunnels add 24 bytes... I just noticed the following code in include/linux/netdevice.h:

Re: 2.6.19-rc6 : Spontaneous reboots, stack overflows - seems to implicate xfs, scsi, networking, SMP

2006-11-28 Thread David Chinner
On Thu, Nov 23, 2006 at 12:18:09PM +1100, David Chinner wrote: On Wed, Nov 22, 2006 at 01:58:11PM +0100, Jesper Juhl wrote: Attached are two files. The one named stack_overflows.txt.gz contains one instance of each unique stack overflow + trace that I've got. The other file named

Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function

2006-11-28 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Wed, 29 Nov 2006 03:28:25 +0100 [NETFILTER]: ipt_REJECT: fix memory corruption On devices with hard_header_len LL_MAX_HEADER ip_route_me_harder() reallocates the skb, leading to memory corruption when using the stale tcph pointer to update the

Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function

2006-11-28 Thread Herbert Xu
David Miller [EMAIL PROTECTED] wrote: diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 9264139..95e86ac 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -94,7 +94,9 @@ #endif #endif #if !defined(CONFIG_NET_IPIP) \ -

Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function

2006-11-28 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 29 Nov 2006 15:38:29 +1100 David Miller [EMAIL PROTECTED] wrote: diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 9264139..95e86ac 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -94,7

Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function

2006-11-28 Thread Herbert Xu
David Miller [EMAIL PROTECTED] wrote: Longer term this is really messy, we should handle this some other way. Definitely. I'm not sure whether 48 is enough even for recursive tunnels. This should really just be a hint. It's OK to spend a bit of time reallocating skb's if it's too small,

Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function

2006-11-28 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 29 Nov 2006 15:56:57 +1100 David Miller [EMAIL PROTECTED] wrote: Longer term this is really messy, we should handle this some other way. Definitely. I'm not sure whether 48 is enough even for recursive tunnels. This should really just be

Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function

2006-11-28 Thread Herbert Xu
On Tue, Nov 28, 2006 at 09:04:16PM -0800, David Miller wrote: Definitely. I'm not sure whether 48 is enough even for recursive tunnels. This should really just be a hint. It's OK to spend a bit of time reallocating skb's if it's too small, but it's not OK to die. The recursive

Re: [patch] genapic: default to physical mode on hotplug CPU kernels

2006-11-28 Thread Ingo Molnar
* Siddha, Suresh B [EMAIL PROTECTED] wrote: On Tue, Nov 28, 2006 at 09:23:22PM +0100, Ingo Molnar wrote: * Siddha, Suresh B [EMAIL PROTECTED] wrote: On Tue, Nov 28, 2006 at 07:33:46AM +0100, Ingo Molnar wrote: - if (clusters = 1 max_cluster = 8 cluster_cnt[0] ==

Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function

2006-11-28 Thread Jarek Poplawski
On 29-11-2006 05:25, David Miller wrote: ... commit 93e3a20d6c67a09b867431e7d5b3e7bc97154fab Author: David S. Miller [EMAIL PROTECTED] Date: Tue Nov 28 20:24:10 2006 -0800 [NET]: Fix MAX_HEADER setting. MAX_HEADER is either set to LL_MAX_HEADER or LL_MAX_HEADER + 48, and

Re: 2.6.19-rc6-mm1: drivers/net/chelsio/: unused code

2006-11-28 Thread Adrian Bunk
On Mon, Nov 27, 2006 at 10:24:55AM -0800, Stephen Hemminger wrote: On Fri, 24 Nov 2006 01:17:31 +0100 Adrian Bunk [EMAIL PROTECTED] wrote: On Thu, Nov 23, 2006 at 02:17:03AM -0800, Andrew Morton wrote: ... Changes since 2.6.19-rc5-mm2: ... +chelsio-22-driver.patch ... netdev

Re: [PATCH] lockdep: fix sk-sk_callback_lock locking

2006-11-28 Thread Herbert Xu
Peter Zijlstra [EMAIL PROTECTED] wrote: = [ INFO: possible irq lock inversion dependency detected ] 2.6.19-rc6 #4 - nc/1854 just changed the state of lock: (af_callback_keys +

Re: 2.6.19-rc6-mm1: drivers/net/chelsio/: unused code

2006-11-28 Thread Andrew Morton
On Wed, 29 Nov 2006 08:36:09 +0100 Adrian Bunk [EMAIL PROTECTED] wrote: On Mon, Nov 27, 2006 at 10:24:55AM -0800, Stephen Hemminger wrote: On Fri, 24 Nov 2006 01:17:31 +0100 Adrian Bunk [EMAIL PROTECTED] wrote: On Thu, Nov 23, 2006 at 02:17:03AM -0800, Andrew Morton wrote: ...

Help for kernel module programming

2006-11-28 Thread prajakta choudhari
Hi: I am writing a kernel module for assging an ip address to an interface. I have included linux/igmp.h but still whenever i use the function declared in igmp.h file, it says unresolved symbol for that function. I am new to this programming. i use the following command to compile it: gcc -c

<    2   3   4   5   6   7