Re: GPL only modules

2006-12-18 Thread Giacomo A. Catenazzi
Linus Torvalds wrote: > > On Mon, 18 Dec 2006, Alexandre Oliva wrote: >>> In other words, in the GPL, "Program" does NOT mean "binary". Never has. >> Agreed. So what? How does this relate with the point above? >> >> The binary is a Program, as much as the sources are a Program. Both >> forms

Re: GPL only modules

2006-12-18 Thread Giacomo A. Catenazzi
Linus Torvalds wrote: > > On Mon, 18 Dec 2006, Alexandre Oliva wrote: >>> In other words, in the GPL, "Program" does NOT mean "binary". Never has. >> Agreed. So what? How does this relate with the point above? >> >> The binary is a Program, as much as the sources are a Program. Both >> forms

[git pull] more drm patches for 2.6.20

2006-12-18 Thread Dave Airlie
Hi Linus, This is just a bunch of minor patches and fixes for the drm tree. The biggest change is to the intel driver to fix up some tearing issues, and a small update to the radeon bounds check to fix r300 issue. The rest are just cleanups and comment fixes.. Dave. drivers/char/drm/drmP.h

Re: [KORG] Re: kernel.org lies about latest -mm kernel

2006-12-18 Thread J.H.
On Tue, 2006-12-19 at 07:46 +0100, Willy Tarreau wrote: > On Sun, Dec 17, 2006 at 04:42:56PM -0800, J.H. wrote: > > On Mon, 2006-12-18 at 00:37 +0200, Matti Aarnio wrote: > > > On Sun, Dec 17, 2006 at 10:23:54AM -0800, Randy Dunlap wrote: > > > > J.H. wrote: > > > ... > > > > >The root cause boils

Re: [RFC][PATCH] Fix area->nr_free-- went (-1) issue in buddy system

2006-12-18 Thread Aubrey
On 12/19/06, Nick Piggin <[EMAIL PROTECTED]> wrote: Hi Aubery! That's right. I guess you can either align your zone sizes (must be aligned to MAX_ORDER size), or add the zone check in page_is_buddy. Adding the zone check in page_is_buddy fix the problem. Thanks again, :) -Aubrey - To

Re: 2.6.19 file content corruption on ext3

2006-12-18 Thread Peter Zijlstra
On Mon, 2006-12-18 at 11:18 -0800, Linus Torvalds wrote: > > diff --git a/mm/rmap.c b/mm/rmap.c > > index d8a842a..3f9061e 100644 > > --- a/mm/rmap.c > > +++ b/mm/rmap.c > > @@ -448,7 +448,7 @@ static int page_mkclean_one(struct page > > goto unlock; > > > > entry =

Re: [PATCH] microcode: Fix mc_cpu_notifier section warning

2006-12-18 Thread Jean Delvare
Hi Tigran, On Mon, 18 Dec 2006 10:04:39 + (GMT), Tigran Aivazian wrote: > Ok, your patch is correct, although I assume you realize that it does > nothing --- both the function and the data it operates on are inside > CONFIG_HOTPLUG_CPU and checking include/linux/init.h I see that >

Re: [PATCH] libata-scsi: ata_task_ioctl should return ATA registers from sense data

2006-12-18 Thread Tejun Heo
David Milburn wrote: > User applications using the HDIO_DRIVE_TASK ioctl through libata > expect specific ATA registers to be returned to userspace. Verified > that ata_task_ioctl correctly returns register values to the > smartctl application. > > Signed-off-by: David Milburn <[EMAIL PROTECTED]>

Re: 2.6.19 file content corruption on ext3

2006-12-18 Thread Linus Torvalds
On Tue, 19 Dec 2006, Nick Piggin wrote: > > I wouldn't have thought it becomes clean by dropping it ;) Is this a > trick question? My answer is that we clean a page by by taking some > action such that the underlying data matches the data in RAM... Sure. > We don't "drop" any data until it

Re: 2.6.19 file content corruption on ext3

2006-12-18 Thread Peter Zijlstra
On Tue, 2006-12-19 at 15:36 +1100, Nick Piggin wrote: > plain text document attachment (fs-fix.patch) > Index: linux-2.6/fs/buffer.c > === > --- linux-2.6.orig/fs/buffer.c2006-12-19 15:15:46.0 +1100 > +++

Re: [patch] lockdep: more unlock-on-error fixes

2006-12-18 Thread Jarek Poplawski
On Mon, Dec 18, 2006 at 03:39:36PM +0100, Ingo Molnar wrote: > > * Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > Hello, > > > > If any of this proposals should be omitted or separated let me know. > > thanks for the fixes, they look good to me. I have reorganized the > __lock_acquire()

Re: Aiee, killing interrupt handler!

2006-12-18 Thread Chuck Ebbert
In-Reply-To: <[EMAIL PROTECTED]> On Tue, 19 Dec 2006 12:06:20 +0800, Hawk Xu wrote: > Our server(running Oracle 10g) is having a kernel panic problem: <> > Process swapper (pid: 0, threadinfo 80582000, task 80464300) > Stack: 0296 8013f325 81007f7f54d0

Re: [linux-cifs-client] Re: 2.6.19.1 bug? tar: file changed as we read it

2006-12-18 Thread Chuck Ebbert
In-Reply-To: <[EMAIL PROTECTED]> On Mon, 18 Dec 2006 11:22:36 -0500, simo wrote: > > With cifs, a directory search shows different sizes but opening > > them by name gives identical contents: > > > > $ ll ipt_dscp* ipt_DSCP* > > -r 1 me me 1581 Jan 28 2004 ipt_dscp.c > > -r 1

Re: -mm merge plans for 2.6.20

2006-12-18 Thread Nick Piggin
Dave Jones wrote: On Tue, Dec 19, 2006 at 04:20:37PM +1100, Nick Piggin wrote: > Dave Jones wrote: > > > Eeek! page_mapcount(page) went negative! (-2) > > Hmm, probably happened once before, too. You're right. Going back further in the log, I noticed that it had happened again exactly

linus' git repo down?

2006-12-18 Thread Robert P. J. Day
for the last couple of days, i've been unable to pull from linus' 2.6 repository. i consistently get: $ git pull fatal: unexpected EOF Fetch failure: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git No changes. even after several retries. i can clone it from scratch, i

Re: [KORG] Re: kernel.org lies about latest -mm kernel

2006-12-18 Thread J.H.
On Tue, 2006-12-19 at 07:34 +0100, Willy Tarreau wrote: > On Sat, Dec 16, 2006 at 11:30:34AM -0800, J.H. wrote: > (...) > > Since it's apparent not everyone is aware of what we are doing, I'll > > mention briefly some of the bigger points. > > > > - We have contacted HP to see if we can get

Re: 2.6.19 file content corruption on ext3

2006-12-18 Thread Nick Piggin
Linus Torvalds wrote: On Tue, 19 Dec 2006, Nick Piggin wrote: We never want to drop dirty data! (ignoring the truncate case, which is handled privately by truncate anyway) Bzzt. SURE we do. We absolutely do want to drop dirty data in the writeout path. How do you think dirty data ever

Re: [KORG] Re: kernel.org lies about latest -mm kernel

2006-12-18 Thread Willy Tarreau
On Sun, Dec 17, 2006 at 04:42:56PM -0800, J.H. wrote: > On Mon, 2006-12-18 at 00:37 +0200, Matti Aarnio wrote: > > On Sun, Dec 17, 2006 at 10:23:54AM -0800, Randy Dunlap wrote: > > > J.H. wrote: > > ... > > > >The root cause boils down to with git, gitweb and the normal mirroring > > > >on the

Re: -mm merge plans for 2.6.20

2006-12-18 Thread Dave Jones
On Tue, Dec 19, 2006 at 04:20:37PM +1100, Nick Piggin wrote: > Dave Jones wrote: > > > Eeek! page_mapcount(page) went negative! (-2) > > Hmm, probably happened once before, too. You're right. Going back further in the log, I noticed that it had happened again exactly at the time that cron

Re: [PATCH] procfs: export context switch counts in /proc/*/stat

2006-12-18 Thread Benjamin LaHaise
On Mon, Dec 18, 2006 at 11:50:08PM +, David Wragg wrote: > This patch (against 2.6.19/2.6.19.1) adds the four context switch > values (voluntary context switches, involuntary context switches, and > the same values accumulated from terminated child processes) to the > end of /proc/*/stat,

Re: [PATCH] RTC classdev: Add sysfs support for wakeup alarm (r/w)

2006-12-18 Thread Paul Sokolovsky
Hello David, Tuesday, December 19, 2006, 2:59:11 AM, you wrote: > On Monday 18 December 2006 4:54 pm, David Brownell wrote: >> > http://handhelds.org/cgi-bin/cvsweb.cgi/linux/kernel26/drivers/rtc/rtc-sa1100.c.diff?r1=1.5=1.6=h >> >> That patch you applied looks right to me -- why don't you

Re: Linux disk performance.

2006-12-18 Thread Nick Piggin
Manish Regmi wrote: Nick Piggin: but they look like they might be a (HZ quantised) delay coming from block layer plugging. Sorry i didn´t understand what you mean. When you submit a request to an empty block device queue, it can get "plugged" for a number of timer ticks before any IO is

Re: [take28-resend_2->0 0/8] kevent: Generic event handling mechanism.

2006-12-18 Thread Evgeniy Polyakov
On Mon, Dec 18, 2006 at 10:21:34PM -0800, Ulrich Drepper ([EMAIL PROTECTED]) wrote: > Evgeniy Polyakov wrote: > >I've uploaded the latest changes to the homepage. > > Thanks. But could you now update the patch so that it can be compiled > with the current upstream kernel? At least has >

Re: GPL only modules

2006-12-18 Thread D. Hazelton
On Monday 18 December 2006 12:16, David Schwartz wrote: > Combined responses to save bandwidth and reduce the number of times people > have to press "d". > > > Agreed. You missed the point. > > I don't understand how you could lead with "agreed" and then proceed to > completely ignore the entire

Re: 2.6.19 file content corruption on ext3

2006-12-18 Thread Linus Torvalds
On Tue, 19 Dec 2006, Nick Piggin wrote: > > We never want to drop dirty data! (ignoring the truncate case, which is > handled privately by truncate anyway) Bzzt. SURE we do. We absolutely do want to drop dirty data in the writeout path. How do you think dirty data ever _becomes_ clean data?

Re: [KORG] Re: kernel.org lies about latest -mm kernel

2006-12-18 Thread Willy Tarreau
On Sat, Dec 16, 2006 at 11:30:34AM -0800, J.H. wrote: (...) > Since it's apparent not everyone is aware of what we are doing, I'll > mention briefly some of the bigger points. > > - We have contacted HP to see if we can get additional hardware, mind > you though this is a long term solution and

Re: [RFC][PATCH] Fix area->nr_free-- went (-1) issue in buddy system

2006-12-18 Thread Nick Piggin
Hi Aubery! Aubrey wrote: Hi Nick, Thanks for your reply again, ;-). On 12/19/06, Nick Piggin <[EMAIL PROTECTED]> wrote: This should not happen because the pages are checked to ensure they are from the same zone before merging. How? page_is_buddy() only check if the buddy has the buddy

Re: [PATCH] incorrect direct io error handling

2006-12-18 Thread Dmitriy Monakhov
"Chen, Kenneth W" <[EMAIL PROTECTED]> writes: > Dmitriy Monakhov wrote on Monday, December 18, 2006 5:23 AM >> This patch is result of discussion started week ago here: >> http://lkml.org/lkml/2006/12/11/66 >> changes from original patch: >> - Update wrong comments about i_mutex locking. >> -

Re: Linux disk performance.

2006-12-18 Thread Manish Regmi
On 12/18/06, Erik Mouw <[EMAIL PROTECTED]> wrote: <...snip...> > > But isn't O_DIRECT supposed to bypass buffering in Kernel? It is. > Doesn't it directly write to disk? Yes, but it still uses an IO scheduler. Ok. but i also tried with noop to turnoff disk scheduling effects. There was

Re: [take28-resend_2->0 0/8] kevent: Generic event handling mechanism.

2006-12-18 Thread Ulrich Drepper
Evgeniy Polyakov wrote: I've uploaded the latest changes to the homepage. Thanks. But could you now update the patch so that it can be compiled with the current upstream kernel? At least has problems because of file->st accesses. -- ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧

Re: -mm merge plans for 2.6.20

2006-12-18 Thread Nick Piggin
Dave Jones wrote: Eeek! page_mapcount(page) went negative! (-2) Hmm, probably happened once before, too. page->flags = 404 What's that? PG_referenced|PG_reserved? So I'd say it is likely that some driver has got its refcounting wrong. Unfortunately, this debugging output is almost

Re: [RFC][PATCH] Fix area->nr_free-- went (-1) issue in buddy system

2006-12-18 Thread Aubrey
Hi Nick, Thanks for your reply again, ;-). On 12/19/06, Nick Piggin <[EMAIL PROTECTED]> wrote: This should not happen because the pages are checked to ensure they are from the same zone before merging. How? page_is_buddy() only check if the buddy has the buddy flag and has the same order.

Re: RFC: PCI quirks update for 2.6.16

2006-12-18 Thread Sergio Monteiro Basto
On Mon, 2006-12-11 at 00:47 +0100, Adrian Bunk wrote: > So we have the following situation: > - 2.6.16- 2.6.16.16 : problems for Chris > (and possibly many other people) > - 2.6.16.17 - 2.6.16.35 : problems for many other people > (I remember

Re: [PATCH] incorrect direct io error handling

2006-12-18 Thread Dmitriy Monakhov
David Chinner <[EMAIL PROTECTED]> writes: > On Mon, Dec 18, 2006 at 04:22:44PM +0300, Dmitriy Monakhov wrote: >> diff --git a/mm/filemap.c b/mm/filemap.c >> index 8332c77..7c571dd 100644 >> --- a/mm/filemap.c >> +++ b/mm/filemap.c >> @@ -2044,8 +2044,9 @@ generic_file_direct_write(struct kiocb *

Re: Task watchers v2

2006-12-18 Thread Paul Jackson
Matt wrote: > - Task watchers can actually improve kernel performance slightly (up to > 2% in extremely fork-heavy workloads for instance). Nice. Could you explain why? -- I won't rest till it's the best ... Programmer, Linux Scalability

[PATCH] noinitramfs: correct initcall return type

2006-12-18 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Use expected function return type to fix warning. init/noinitramfs.c:42: warning: initialization from incompatible pointer type Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- init/noinitramfs.c |3 ++- 1 file changed, 2 insertions(+), 1

[patch] search a little harder for mkimage

2006-12-18 Thread Mike Frysinger
this small patch checks to see if `${CROSS_COMPILE}mkimage` exists and if not, fall back to the standard `mkimage` the Blackfin toolchain includes mkimage, but we dont want to namespace collide with any of the user's system setup, so we prefix it with our toolchain name -mike Check to see if the

[PATCH 4/5] Break init() in two parts to avoid MODPOST warnings

2006-12-18 Thread Vivek Goyal
o init() is a non __init function in .text section but it calls many functions which are in .init.text section. Hence MODPOST generates lots of cross reference warnings on i386 if compiled with CONFIG_RELOCATABLE=y WARNING: vmlinux - Section mismatch: reference to

[PATCH 5/5] i386: Fix memory hotplug related MODPOST generated warning

2006-12-18 Thread Vivek Goyal
o Fix modpost generated warning. WARNING: vmlinux - Section mismatch: reference to .init.text: from .text between 'add_one_highpage_hotplug' (at offset 0xc0113d3f) and 'online_page' Signed-off-by: Vivek Goyal <[EMAIL PROTECTED]> --- arch/i386/mm/init.c |4 ++-- 1 file changed, 2

[PATCH 3/5] i386: move startup_32() in text.head section

2006-12-18 Thread Vivek Goyal
o Entry startup_32 was in .text section but it was accessing some init data too and it prompts MODPOST to generate compilation warnings. WARNING: vmlinux - Section mismatch: reference to .init.data:boot_params from .text between '_text' (at offset 0xc0100029) and 'startup_32_smp' WARNING:

[PATCH 1/5] i386: cpu hotplug/smpboot misc MODPOST warning fixes

2006-12-18 Thread Vivek Goyal
o Misc smpboot/cpu hotplug path cleanups. I did those to supress the warnings generated by MODPOST. These warnings are visible only if CONFIG_RELOCATABLE=y. o CONFIG_RELOCATABLE compiles the kernel with --emit-relocs option. This option retains relocation information in vmlinux file and

[PATCH 2/5] Convert some functions to __init to avoid MODPOST warnings

2006-12-18 Thread Vivek Goyal
o Some functions which should have been in init sections as they are called only once. Put them in init sections. Otherwise MODPOST generates warning as these functions are placed in .text and they end up accessing something in init sections. WARNING: vmlinux - Section mismatch: reference

Re: 2.6.19 file content corruption on ext3

2006-12-18 Thread Nick Piggin
Linus Torvalds wrote: On Mon, 18 Dec 2006, Peter Zijlstra wrote: This should be safe; page_mkclean walks the rmap and flips the pte's under the pte lock and records the dirty state while iterating. Concurrent faults will either do set_page_dirty() before we get around to doing it or vice

Re: [take28-resend_2->0 0/8] kevent: Generic event handling mechanism.

2006-12-18 Thread Evgeniy Polyakov
On Mon, Dec 18, 2006 at 07:47:21PM -0800, Ulrich Drepper ([EMAIL PROTECTED]) wrote: > It would help if one could actually get hold of the changes. > > Neither at home nor on my gmail account did I get them all. The gmane > also only has 5 of the 9 mails or so. Your archive only has sources >

Re: xfslogd-spinlock bug?

2006-12-18 Thread David Chinner
On Tue, Dec 19, 2006 at 01:52:29PM +1100, David Chinner wrote: > On Tue, Dec 19, 2006 at 12:39:46AM +0100, Haar János wrote: > > From: "David Chinner" <[EMAIL PROTECTED]> > > > #define POISON_FREE 0x6b > > > > > > Can you confirm that you are running with CONFIG_DEBUG_SLAB=y? > > > > Yes, i build

unreapable zombies, maybe futex+ptrace+exit

2006-12-18 Thread Albert Cahalan
I have a fun little test program for people to try. It creates zombies that persist until reboot, despite being reparented to init. Sometimes it creates processes that block SIGKILL, sit around with pending SIGKILL, or both. You'll want: a. either assembly skills or the ability to run 32-bit

Re: [RFC][PATCH] Fix area->nr_free-- went (-1) issue in buddy system

2006-12-18 Thread Nick Piggin
Aubrey wrote: Hi all, When I setup two zones (NORMAL and DMA) in my system, I got the following wired result from /proc/buddyinfo. - root:~> cat /proc/buddyinfo Node 0, zone DMA 2 1 2

Re: GPL only modules

2006-12-18 Thread Daniel Barkalow
On Mon, 18 Dec 2006, Linus Torvalds wrote: > Static vs dynamic matters for whether it's an AGGREGATE work. Clearly, > static linking aggregates the library with the other program in the same > binary. There's no question about that. And that _does_ have meaning from > a copyright law angle,

Re: GPL only modules

2006-12-18 Thread D. Hazelton
On Monday 18 December 2006 20:35, David Schwartz wrote: > > For both static and dynamic linking, you might claim the output is an > > aggregate, but that doesn't matter. What matters is whether or not > > the output is a work based on the program, and whether the "mere > > aggregation" paragraph

[-mm patch] drivers/pci/quirks.c: cleanup

2006-12-18 Thread Adrian Bunk
This patch contains the following cleanups: - move all EXPORT_SYMBOL's directly below the code they are exporting - move all DECLARE_PCI_FIXUP_*'s directly below the functions they are calling Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/pci/pci.c|4

[2.6 patch] drivers/atm/fore200e.c: cleanups

2006-12-18 Thread Adrian Bunk
This patch contains the following transformations from custom functions to standard kernel version: - fore200e_kmalloc() -> kzalloc() - fore200e_kfree() -> kfree() - fore200e_swap() -> cpu_to_be32() Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/atm/fore200e.c | 166

[2.6 patch] drivers/atm/Kconfig: remove dead ATM_TNETA1570 option

2006-12-18 Thread Adrian Bunk
This patch removes the unconverted ATM_TNETA1570 option that also lacks any code in the kernel. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.20-rc1-mm1/drivers/atm/Kconfig.old2006-12-19 04:42:00.0 +0100 +++ linux-2.6.20-rc1-mm1/drivers/atm/Kconfig2006-12-19

[2.6 patch] powerpc: remove the broken Gemini support

2006-12-18 Thread Adrian Bunk
On Sat, Nov 25, 2006 at 12:49:35AM +0100, Adrian Bunk wrote: > I just saw the commit message below. > > There seems to have been some although unmerged work on APUS support by > Roman, but I didn't find any recent work on bringing the GEMINI support > back into life. > > Is this a wrong

OSS driver removal, 3nd round

2006-12-18 Thread Adrian Bunk
Now that the second round of removing options for OSS drivers where ALSA drivers without regressions exist for the same hardware got included in Linus' tree, it's time for a third round amongst the remaining drivers. Removing OSS drivers where ALSA drivers for the same hardware exists has two

Re: [take28-resend_2->0 0/8] kevent: Generic event handling mechanism.

2006-12-18 Thread Randy Dunlap
On Mon, 18 Dec 2006 19:47:21 -0800 Ulrich Drepper wrote: > It would help if one could actually get hold of the changes. > > Neither at home nor on my gmail account did I get them all. The gmane > also only has 5 of the 9 mails or so. Your archive only has sources > from a couple of versions

Aiee, killing interrupt handler!

2006-12-18 Thread Hawk Xu
Hi! Our server(running Oracle 10g) is having a kernel panic problem: Process swapper (pid: 0, threadinfo 80582000, task 80464300) Stack: 0296 8013f325 81007f7f54d0 0100 0001 000e 8053e098 8013f3a5

Re: [take28-resend_2->0 0/8] kevent: Generic event handling mechanism.

2006-12-18 Thread Ulrich Drepper
It would help if one could actually get hold of the changes. Neither at home nor on my gmail account did I get them all. The gmane also only has 5 of the 9 mails or so. Your archive only has sources from a couple of versions back. -- ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧

Re: GPL only modules

2006-12-18 Thread D. Hazelton
On Monday 18 December 2006 14:41, Alexandre Oliva wrote: > On Dec 17, 2006, Kyle Moffett <[EMAIL PROTECTED]> wrote: > > On the other hand, certain projects like OpenAFS, while not license- > > compatible, are certainly not derivative works. > > Certainly a big chunk of OpenAFS might not be, just

[RFC][PATCH] Fix area->nr_free-- went (-1) issue in buddy system

2006-12-18 Thread Aubrey
Hi all, When I setup two zones (NORMAL and DMA) in my system, I got the following wired result from /proc/buddyinfo. - root:~> cat /proc/buddyinfo Node 0, zone DMA 2 1 2 1 1

Re: xfslogd-spinlock bug?

2006-12-18 Thread David Chinner
On Tue, Dec 19, 2006 at 12:39:46AM +0100, Haar János wrote: > From: "David Chinner" <[EMAIL PROTECTED]> > > On Mon, Dec 18, 2006 at 09:17:50AM +0100, Haar János wrote: > > > From: "David Chinner" <[EMAIL PROTECTED]> > > > > Ok, I've never heard of a problem like this before and you are doing > > >

Re: schedule_timeout: wrong timeout value

2006-12-18 Thread Robert Hancock
kyle wrote: Hi, Recently my mysql servershows something like: Dec 18 18:24:05 sql kernel: schedule_timeout: wrong timeout value from c0284efd Dec 18 18:24:36 sql last message repeated 19939 times Dec 18 18:25:37 sql last message repeated 33392 times from syslog every 1 or 2 days.

Odd system lock up

2006-12-18 Thread Erik Ohrnberger
OK, got the 2.6.19 kernel installed and running OK, full libata wrapping of existing IDE controllers and hard disks. I'm experiencing some odd, random periodic system lockups without any sort of debugging information being captured in the system message log. Perhaps it's a hard disk that's

Re: 2.6.19 file content corruption on ext3

2006-12-18 Thread Andrei Popa
> > > If all of test_clear_page_dirty() has been commented out then the page > > > will > > > never become clean hence will never fall out of pagecache, so unless > > > Andrei > > > is doing a reboot before checking for corruption, perhaps the underlying > > > data on-disk is incorrect, but we

Re: 2.6.19 file content corruption on ext3

2006-12-18 Thread Andrew Morton
On Tue, 19 Dec 2006 03:44:51 +0200 Andrei Popa <[EMAIL PROTECTED]> wrote: > On Mon, 2006-12-18 at 17:21 -0800, Andrew Morton wrote: > > On Mon, 18 Dec 2006 16:57:30 -0800 (PST) > > Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > > > What happens if you only ifdef out that single thing? > > > >

Re: 2.6.19 file content corruption on ext3

2006-12-18 Thread Andrei Popa
On Mon, 2006-12-18 at 16:57 -0800, Linus Torvalds wrote: > > On Tue, 19 Dec 2006, Andrei Popa wrote: > > > > > > > > nope, no file corruption at all. > > > > > > Ok. That's interesting, but I think you actually #ifdef'ed out too > > > much: > > > > > > It was really just the _inner_ "if

Re: 2.6.19 file content corruption on ext3

2006-12-18 Thread Andrei Popa
On Mon, 2006-12-18 at 17:21 -0800, Andrew Morton wrote: > On Mon, 18 Dec 2006 16:57:30 -0800 (PST) > Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > What happens if you only ifdef out that single thing? > > > > The actual page-cleaning functions make sure to only clear the TAG_DIRTY > > bit

RE: GPL only modules

2006-12-18 Thread David Schwartz
Combined responses: > So therefore I don't think you can reasonably claim that static > vs. dynamic linking is only a technical difference. There are clearly > other differences when it comes to distribution of the resulting > binaries. We're only talking about the special case of GPL'd works.

RE: GPL only modules

2006-12-18 Thread David Schwartz
> For both static and dynamic linking, you might claim the output is an > aggregate, but that doesn't matter. What matters is whether or not > the output is a work based on the program, and whether the "mere > aggregation" paragraph kicks in. > > If the output is not an aggregate, which is quite

RE: GPL only modules

2006-12-18 Thread David Schwartz
> > It's also not clear that an aggregate work is in fact > > a single work for any legal purpose other than the aggregator's claim to > > copyright. > Not sure what you're trying to say there - what are we talking about > here other than the copyright? We are talking about two different

Re: [linux-pm] OOPS: divide error while s2dsk (2.6.20-rc1-mm1)

2006-12-18 Thread Andrew Morton
On Mon, 18 Dec 2006 17:18:12 -0800 (PST) David Rientjes <[EMAIL PROTECTED]> wrote: > On Mon, 18 Dec 2006, Andrew Morton wrote: > > > diff -puN mm/vmscan.c~shrink_all_memory-fix-lru_pages-handling mm/vmscan.c > > --- a/mm/vmscan.c~shrink_all_memory-fix-lru_pages-handling > > +++ a/mm/vmscan.c > >

Re: 2.6.19 file content corruption on ext3

2006-12-18 Thread Andrew Morton
On Mon, 18 Dec 2006 16:57:30 -0800 (PST) Linus Torvalds <[EMAIL PROTECTED]> wrote: > What happens if you only ifdef out that single thing? > > The actual page-cleaning functions make sure to only clear the TAG_DIRTY > bit _after_ the page has been marked for writeback. Is there some ordering

Re: [linux-pm] OOPS: divide error while s2dsk (2.6.20-rc1-mm1)

2006-12-18 Thread David Rientjes
On Mon, 18 Dec 2006, Andrew Morton wrote: > diff -puN mm/vmscan.c~shrink_all_memory-fix-lru_pages-handling mm/vmscan.c > --- a/mm/vmscan.c~shrink_all_memory-fix-lru_pages-handling > +++ a/mm/vmscan.c > @@ -1484,6 +1484,16 @@ static unsigned long shrink_all_zones(un > return ret; > } > >

Re: 2.6.19 file content corruption on ext3

2006-12-18 Thread Gene Heskett
On Monday 18 December 2006 18:48, Andrei Popa wrote: >On Mon, 2006-12-18 at 14:32 -0800, Linus Torvalds wrote: >> On Mon, 18 Dec 2006, Andrei Popa wrote: >> > > This should be fairly easy to test: just change every single ", 1" >> > > case in the patch to ", 0". >> > > >> > > What happens for you

Re: [PATCH, RFC] reimplement flush_workqueue()

2006-12-18 Thread Andrew Morton
On Tue, 19 Dec 2006 03:43:19 +0300 Oleg Nesterov <[EMAIL PROTECTED]> wrote: > On 12/18, Andrew Morton wrote: > > > > On Mon, 18 Dec 2006 01:34:16 +0300 > > Oleg Nesterov <[EMAIL PROTECTED]> wrote: > > > > > NOTE: I removed 'int cpu' parameter, flush_workqueue() locks/unlocks > > >

Re: [PATCH] RTC classdev: Add sysfs support for wakeup alarm (r/w)

2006-12-18 Thread David Brownell
On Monday 18 December 2006 4:54 pm, David Brownell wrote: > > http://handhelds.org/cgi-bin/cvsweb.cgi/linux/kernel26/drivers/rtc/rtc-sa1100.c.diff?r1=1.5=1.6=h > > That patch you applied looks right to me -- why don't you forward it > to Alessandro as a bugfix for 2.6.20-rc2, and save me the

Re: 2.6.19 file content corruption on ext3

2006-12-18 Thread Linus Torvalds
On Tue, 19 Dec 2006, Andrei Popa wrote: > > > > > > nope, no file corruption at all. > > > > Ok. That's interesting, but I think you actually #ifdef'ed out too > > much: > > > > It was really just the _inner_ "if (mapping_cap_account_dirty(.." > > statement that I meant you should remove. >

Re: [PATCH] RTC classdev: Add sysfs support for wakeup alarm (r/w)

2006-12-18 Thread David Brownell
Hi Paul, On Monday 18 December 2006 3:58 pm, Paul Sokolovsky wrote: > Monday, December 18, 2006, 6:28:58 AM, you wrote: > > On Sunday 17 December 2006 11:30 am, Paul Sokolovsky wrote: > > >> Small battery-powered systems, like PDAs, need a way to be > >> suspended most of the time and woken

Re: [PATCH, RFC rc1-mm1] implement flush_work()

2006-12-18 Thread Andrew Morton
On Mon, 18 Dec 2006 23:17:14 +0300 Oleg Nesterov <[EMAIL PROTECTED]> wrote: > Add ->current_work to the "struct cpu_workqueue_struct", it points to > currently running "struct queue_work". When flush_work(work) detects > ->current_work == work, it inserts a barrier at the _head_ of ->worklist >

Re: [linux-pm] OOPS: divide error while s2dsk (2.6.20-rc1-mm1)

2006-12-18 Thread Rafael J. Wysocki
On Tuesday, 19 December 2006 00:17, Andrew Morton wrote: > On Mon, 18 Dec 2006 23:38:23 +0100 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > Looks like we have a problem with slab shrinking here. > > > > > > > > Could you please use gdb to check what exactly is at shrink_slab+0x9e? >

Re: libata and sata?

2006-12-18 Thread John Richard Moser
Alan wrote: >> I no longer have two kernels to test through; I can't tell if the speed >> is back or not. Nothing in dmesg tells me if SATA is using DMA or >> 32-bit IO support though, so I don't know... lack of knowledge over here >> is killing me for troubleshooting this on my own. > > The

Re: Linux 2.6.18.6

2006-12-18 Thread Chris Wright
diff --git a/Makefile b/Makefile index 85d8009..c8b2f7e 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 18 -EXTRAVERSION = .5 +EXTRAVERSION = .6 NAME=Avast! A bilge rat! # *DOCUMENTATION* diff --git a/arch/arm/kernel/calls.S

Linux 2.6.18.6

2006-12-18 Thread Chris Wright
We (the -stable team) are announcing the release of the 2.6.18.6 kernel. An assortment of important fixes with one security related fix that is associated with less common bluetooth hardware: 1dca7c28: Bluetooth: Add packet size checks for CAPI messages (CVE-2006-6106) The diffstat and short

Re: [PATCH, RFC] reimplement flush_workqueue()

2006-12-18 Thread Oleg Nesterov
On 12/18, Andrew Morton wrote: > > On Mon, 18 Dec 2006 01:34:16 +0300 > Oleg Nesterov <[EMAIL PROTECTED]> wrote: > > > NOTE: I removed 'int cpu' parameter, flush_workqueue() locks/unlocks > > workqueue_mutex unconditionally. It may be restored, but I think it > > doesn't make much sense, we take

Re: GPL only modules

2006-12-18 Thread Paul Mackerras
Linus Torvalds writes: > > > On Tue, 19 Dec 2006, Paul Mackerras wrote: > > > > There is in fact a pretty substantial non-technical difference between > > static and dynamic linking. If I create a binary by static linking > > and I include some library, and I distribute that binary to someone >

Re: 2.6.20-rc1-mm1

2006-12-18 Thread Andrew Morton
On Mon, 18 Dec 2006 16:29:02 -0800 Randy Dunlap <[EMAIL PROTECTED]> wrote: > On Thu, 14 Dec 2006 22:59:13 -0800 Andrew Morton wrote: > > Got this on booting up on x86_64 test box. > Didn't happen on next boot. > > > BUG: scheduling while atomic: hald-addon-stor/0x2000/3300 > > Call Trace:

FYI: [patch 2.6.20-rc1 0/6] I2C driver model updates, part II

2006-12-18 Thread David Brownell
This is just a heads-up to the folk who read LKML more than more specialized Linux lists ... there's work afoot to clean up the I2C core and make it fit the driver model better. (Some would say "overdue work...".) The most interesting/useful part (IMO) is summarized in the appended message; you

Re: 2.6.19 file content corruption on ext3

2006-12-18 Thread Andrei Popa
On Mon, 2006-12-18 at 16:04 -0800, Linus Torvalds wrote: > > On Tue, 19 Dec 2006, Andrei Popa wrote: > > > > > > There's exactly two call sites that call "page_mkclean()" (an dthat is > > > the > > > only thing in turn that calls "page_mkclean_one()", which we already > > > determined will

Re: 2.6.19 file content corruption on ext3

2006-12-18 Thread Linus Torvalds
On Tue, 19 Dec 2006, Andrei Popa wrote: > > the corrupted file has a chink full with zeros > > http://193.226.119.62/corruption0.jpg > http://193.226.119.62/corruption1.jpg Thanks. Yup, filled with zeroes, and the corruption stops (but does _not_ start) at a page boundary. That _does_ look

Re: [PATCH, RFC] reimplement flush_workqueue()

2006-12-18 Thread Andrew Morton
On Mon, 18 Dec 2006 01:34:16 +0300 Oleg Nesterov <[EMAIL PROTECTED]> wrote: > Remove ->remove_sequence, ->insert_sequence, and ->work_done from > struct cpu_workqueue_struct. To implement flush_workqueue() we can > queue a barrier work on each CPU and wait for its completition. Seems sensible.

Re: 2.6.20-rc1-mm1

2006-12-18 Thread Randy Dunlap
On Thu, 14 Dec 2006 22:59:13 -0800 Andrew Morton wrote: Got this on booting up on x86_64 test box. Didn't happen on next boot. BUG: scheduling while atomic: hald-addon-stor/0x2000/3300 Call Trace: [] show_trace+0x34/0x47 [] dump_stack+0x12/0x17 [] __sched_text_start+0x5d/0x7ba []

Re: [PATCH] Fix sparsemem on Cell

2006-12-18 Thread KAMEZAWA Hiroyuki
On Mon, 18 Dec 2006 15:16:20 -0800 Dave Hansen <[EMAIL PROTECTED]> wrote: > enum context > { > EARLY, > HOTPLUG > }; I like this :) Thanks, -Kame - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: 2.6.19 file content corruption on ext3

2006-12-18 Thread Andrei Popa
On Mon, 2006-12-18 at 14:45 -0800, Linus Torvalds wrote: > > On Mon, 18 Dec 2006, Alessandro Suardi wrote: > > > > No idea whether this can be a data point or not, but > > here it goes... my P2P box is about to turn 5 days old > > while running nonstop one or both of aMule 2.1.3 and > >

Re: [solved] Yenta Cardbus allocation failure

2006-12-18 Thread Markus Rechberger
I went on with investigating that problem and found the problem, though I'm not sure if that solution is acceptable.. seems like the memory range gets preallocated in setup-bus.c, and CARDBUS_MEM_SIZE defines that size. I changed #define CARDBUS_MEM_SIZE(32*1024*1024) to #define

Re: Open letter to Linux kernel developers (was Re: Binary Drivers)

2006-12-18 Thread Jesper Juhl
On 18/12/06, Hannu Savolainen <[EMAIL PROTECTED]> wrote: Marek Wawrzyczny wrote: > Dear Linux Kernel ML, > > I am writing as a Linux-only user of over 2 years to express my concern with > the recent proposal to block out closed source modules from the kernel. > > While, I understand and share

Re: [patch 2/2] agpgart - Remove unnecessary flushes.

2006-12-18 Thread Dave Jones
On Fri, Dec 08, 2006 at 07:24:37PM +0100, Thomas Hellström wrote: > This patch is to speed up flipping of pages in and out of the AGP > aperture as needed by the new drm memory manager. > > A number of global cache flushes are removed as well as some PCI posting > flushes. > The following

Re: 2.6.19 file content corruption on ext3

2006-12-18 Thread Linus Torvalds
On Tue, 19 Dec 2006, Andrei Popa wrote: > > > > There's exactly two call sites that call "page_mkclean()" (an dthat is the > > only thing in turn that calls "page_mkclean_one()", which we already > > determined will cause the corruption). > > > > Can you just TOTALLY DISABLE that case for

[PATCH 1/1] Char: isicom, correct probing/removing

2006-12-18 Thread Jiri Slaby
isicom, correct probing/removing Don't forget to decrease card_count in fail paths and in remove function. Also null board->base in such cases to point out, that this structure is unused and thus can be reassigned. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit

Re: [patch] debugging feature: SysRq-Q to print timers

2006-12-18 Thread Andrew Morton
On Mon, 18 Dec 2006 18:45:49 -0500 Dave Jones <[EMAIL PROTECTED]> wrote: > On Mon, Dec 18, 2006 at 03:31:03PM -0800, Andrew Morton wrote: > > On Sat, 16 Dec 2006 08:56:58 +0100 > > Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > > -> > > > Subject: [patch] debugging feature:

Re: GPL only modules

2006-12-18 Thread Linus Torvalds
On Tue, 19 Dec 2006, Paul Mackerras wrote: > > There is in fact a pretty substantial non-technical difference between > static and dynamic linking. If I create a binary by static linking > and I include some library, and I distribute that binary to someone > else, the recipient doesn't need to

Re: [PATCH] RTC classdev: Add sysfs support for wakeup alarm (r/w)

2006-12-18 Thread Paul Sokolovsky
Hello David, Monday, December 18, 2006, 6:28:58 AM, you wrote: > On Sunday 17 December 2006 11:30 am, Paul Sokolovsky wrote: >> Small battery-powered systems, like PDAs, need a way to be >> suspended most of the time and woken up just from time to time to >> process pending tasks. >

  1   2   3   4   5   6   7   >